thatguygriff
9c900d6553
CI / Tests (PHP 8.1) (pull_request) Successful in 47s
CI / No Debug Code (pull_request) Successful in 2s
CI / Build Plugin Zip (pull_request) Has been skipped
CI / Coding Standards (pull_request) Successful in 52s
CI / PHPStan (pull_request) Successful in 1m1s
CI / Tests (PHP 8.2) (pull_request) Successful in 48s
CI / Tests (PHP 8.3) (pull_request) Successful in 45s
Implements #16: invite-only student self-registration through a front-end page, accepting signup-scoped policies at account creation. Policy domain: - us_policies.acceptance_scope (signup/booking/both); Policy::appliesTo(); PolicyRepository::findForScope(); scope threaded through PolicyService, the REST create, the admin controller, and the Policies form. - PolicyAcceptance::REG_ACCOUNT (registration_id = the new user's ID). Auth: - Invite value object + InviteRepository; us_invites table. - RegistrationController + Invites admin page (manage_students): invite an email, share the registration link, revoke. - RegistrationPage ([us_student_register] shortcode): validates the invite token, collects name/password, renders signup-scoped published policies with required acceptance, creates the us_student user, records account-type acceptances, marks the invite accepted, and logs the user in. - RoleManager: manage_students cap added to STUDIO_ADMIN_CAPS. Invite-only is implemented; the us_registration_mode self_approval path is a documented future seam. Docs: docs/features/account-registration.md; policies.md updated. Tests: tests/Unit/Auth/ (Invite, InviteRepository) plus Policy scope updates. composer test (104), cs, and PHPStan level 6 all pass. Refs #16 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
92 lines
3.9 KiB
PHP
92 lines
3.9 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Tests\Unit\Policy;
|
|
|
|
use Brain\Monkey\Functions;
|
|
use Mockery;
|
|
use Unsupervised\Schedular\Policy\Policy;
|
|
use Unsupervised\Schedular\Policy\PolicyRepository;
|
|
use Unsupervised\Schedular\Policy\PolicyService;
|
|
use Unsupervised\Schedular\Policy\PolicyVersion;
|
|
use Unsupervised\Schedular\Policy\PolicyVersionRepository;
|
|
use Unsupervised\Schedular\Tests\Unit\TestCase;
|
|
|
|
class PolicyServiceTest extends TestCase
|
|
{
|
|
private PolicyRepository $policies;
|
|
private PolicyVersionRepository $versions;
|
|
private PolicyService $service;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
|
|
$this->policies = Mockery::mock(PolicyRepository::class);
|
|
$this->versions = Mockery::mock(PolicyVersionRepository::class);
|
|
$this->service = new PolicyService($this->policies, $this->versions);
|
|
}
|
|
|
|
public function testCreatePolicyInsertsPolicy(): void
|
|
{
|
|
$this->policies->shouldReceive('insert')
|
|
->once()
|
|
->with(Mockery::on(static fn (Policy $p): bool => $p->title === 'Cancellation' && $p->slug === 'cancellation'))
|
|
->andReturn(7);
|
|
|
|
self::assertSame(7, $this->service->createPolicy('Cancellation', 'cancellation'));
|
|
}
|
|
|
|
public function testAddDraftVersionNumbersAfterLatest(): void
|
|
{
|
|
$this->versions->shouldReceive('maxVersionNumber')->once()->with(4)->andReturn(2);
|
|
$this->versions->shouldReceive('insert')
|
|
->once()
|
|
->with(Mockery::on(static function (PolicyVersion $v): bool {
|
|
return $v->policyId === 4
|
|
&& $v->versionNumber === 3
|
|
&& $v->status === PolicyVersion::STATUS_DRAFT;
|
|
}))
|
|
->andReturn(15);
|
|
|
|
self::assertSame(15, $this->service->addDraftVersion(4, '<p>draft</p>'));
|
|
}
|
|
|
|
public function testPublishArchivesPriorCurrentAndPointsPolicyAtNewVersion(): void
|
|
{
|
|
Functions\expect('current_time')->with('mysql')->andReturn('2026-06-01 12:00:00');
|
|
|
|
$this->policies->shouldReceive('findById')->once()->with(4)->andReturn(new Policy('T', 't', 8, id: 4));
|
|
$this->versions->shouldReceive('findById')->once()->with(9)->andReturn(new PolicyVersion(4, 2, '<p>x</p>', PolicyVersion::STATUS_DRAFT, null, 9));
|
|
|
|
$this->versions->shouldReceive('updateStatus')->once()->with(8, PolicyVersion::STATUS_ARCHIVED);
|
|
$this->versions->shouldReceive('updateStatus')->once()->with(9, PolicyVersion::STATUS_PUBLISHED, '2026-06-01 12:00:00');
|
|
$this->policies->shouldReceive('updateCurrentVersion')->once()->with(4, 9)->andReturn(true);
|
|
|
|
self::assertTrue($this->service->publishVersion(4, 9));
|
|
}
|
|
|
|
public function testPublishFirstVersionDoesNotArchive(): void
|
|
{
|
|
Functions\expect('current_time')->andReturn('2026-06-01 12:00:00');
|
|
|
|
$this->policies->shouldReceive('findById')->once()->with(4)->andReturn(new Policy('T', 't', null, id: 4));
|
|
$this->versions->shouldReceive('findById')->once()->with(9)->andReturn(new PolicyVersion(4, 1, null, PolicyVersion::STATUS_DRAFT, null, 9));
|
|
|
|
// No archive call expected (no prior current version).
|
|
$this->versions->shouldReceive('updateStatus')->once()->with(9, PolicyVersion::STATUS_PUBLISHED, '2026-06-01 12:00:00');
|
|
$this->policies->shouldReceive('updateCurrentVersion')->once()->with(4, 9)->andReturn(true);
|
|
|
|
self::assertTrue($this->service->publishVersion(4, 9));
|
|
}
|
|
|
|
public function testPublishRejectsVersionFromAnotherPolicy(): void
|
|
{
|
|
$this->policies->shouldReceive('findById')->once()->with(4)->andReturn(new Policy('T', 't', null, id: 4));
|
|
$this->versions->shouldReceive('findById')->once()->with(9)->andReturn(new PolicyVersion(99, 1, null, PolicyVersion::STATUS_DRAFT, null, 9));
|
|
|
|
// No status/current-version writes when the version belongs elsewhere.
|
|
self::assertFalse($this->service->publishVersion(4, 9));
|
|
}
|
|
}
|