thatguygriffandClaude Opus 5
8c21a3fa9d
CI / Tests (PHP 8.1) (pull_request) Successful in 6m39s
CI / Tests (PHP 8.2) (pull_request) Successful in 57s
CI / Tests (PHP 8.3) (pull_request) Successful in 2m59s
CI / Tests (PHP 8.5) (pull_request) Successful in 3m31s
CI / No Debug Code (pull_request) Successful in 3s
CI / Coding Standards & Static Analysis (pull_request) Successful in 3m28s
CI / Build Plugin Zip (pull_request) Skipped
Two related gaps, closed together because the second is created by the first. A private lesson could only be booked by the student or their guardian, so a booking taken over the phone had no way in — where group classes have had "Add students directly" all along. "Book a lesson for a student" is now a panel on Scheduler and My Lessons: student, open time, lesson type, with weekly term reservations and a no-charge option for make-up lessons. The booking core is extracted to Booking\LessonBooker and shared with POST /bookings, so the two paths cannot drift on offering rules, slot claiming, or billing. That leaves a registration with no intake answers and no policy acceptances, because nobody was at a keyboard to give them — already true of every directly added group-class student. Ticking the boxes on a student's behalf would be an audit trail that says something untrue, so instead the answers are collected another way and recorded afterwards, from a lesson's or an enrolment's detail page. Every recording must say how it was collected, which is stamped on each row along with who typed it and shown in a new "How it was given" column: a policy ticked online and one transcribed from paper must never look alike. Only staff-made registrations qualify (us_lessons.booked_by, us_group_enrollments.enrolled_by) — one the student made already holds their own answers. Only what is still missing can be recorded, re-checked at write time, so a stale or double-posted form cannot duplicate or overwrite. No IP is stored for a transcription, and accepted_by stays the student while recorded_by names the staff member. Intake is now generic over Registration\IntakeSubject, which Lesson and Enrollment both implement; LessonDetail became Registration\IntakeAudit and is shared by both detail views rather than duplicated. Closes #182 Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01QfHt6CyJHz6KkA4RuaS7WK
68 lines
2.3 KiB
PHP
68 lines
2.3 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Tests\Unit\Registration;
|
|
|
|
use Unsupervised\Schedular\Registration\Answer;
|
|
use Unsupervised\Schedular\Tests\Unit\TestCase;
|
|
|
|
class AnswerTest extends TestCase
|
|
{
|
|
public function testConstructorAndProperties(): void
|
|
{
|
|
$answer = new Answer(3, Answer::REG_LESSON, 12, 5, 'Beginner', id: 99);
|
|
|
|
self::assertSame(3, $answer->questionId);
|
|
self::assertSame(Answer::REG_LESSON, $answer->registrationType);
|
|
self::assertSame(12, $answer->registrationId);
|
|
self::assertSame(5, $answer->studentId);
|
|
self::assertSame('Beginner', $answer->answerValue);
|
|
self::assertSame(99, $answer->id);
|
|
}
|
|
|
|
public function testFromRowMapsCorrectly(): void
|
|
{
|
|
$row = (object) [
|
|
'id' => '99',
|
|
'question_id' => '3',
|
|
'registration_type' => Answer::REG_ENROLLMENT,
|
|
'registration_id' => '12',
|
|
'student_id' => '5',
|
|
'answer_value' => '1',
|
|
];
|
|
|
|
$answer = Answer::fromRow($row);
|
|
|
|
self::assertSame(99, $answer->id);
|
|
self::assertSame(3, $answer->questionId);
|
|
self::assertSame(Answer::REG_ENROLLMENT, $answer->registrationType);
|
|
self::assertSame(12, $answer->registrationId);
|
|
}
|
|
|
|
public function testToArrayContainsExpectedKeys(): void
|
|
{
|
|
$answer = new Answer(3, Answer::REG_LESSON, 12, 5);
|
|
$arr = $answer->toArray();
|
|
|
|
foreach (['id', 'question_id', 'registration_type', 'registration_id', 'student_id', 'answer_value'] as $key) {
|
|
self::assertArrayHasKey($key, $arr);
|
|
}
|
|
}
|
|
|
|
public function testValidRegistrationTypeConstants(): void
|
|
{
|
|
self::assertContains(Answer::REG_LESSON, Answer::VALID_REGISTRATION_TYPES);
|
|
self::assertContains(Answer::REG_ENROLLMENT, Answer::VALID_REGISTRATION_TYPES);
|
|
self::assertContains(Answer::REG_ACCOUNT, Answer::VALID_REGISTRATION_TYPES);
|
|
}
|
|
|
|
public function testAccountAnswerTargetsTheUser(): void
|
|
{
|
|
$answer = new Answer(3, Answer::REG_ACCOUNT, 42, 42, 'By a friend');
|
|
|
|
self::assertSame(Answer::REG_ACCOUNT, $answer->registrationType);
|
|
self::assertSame(42, $answer->registrationId);
|
|
self::assertSame(42, $answer->studentId);
|
|
}
|
|
}
|