CI / Tests (PHP 8.1) (pull_request) Successful in 47s
CI / Tests (PHP 8.2) (pull_request) Successful in 46s
CI / No Debug Code (pull_request) Successful in 3s
CI / Tests (PHP 8.3) (pull_request) Successful in 2m37s
CI / PHPStan (pull_request) Successful in 2m52s
CI / Coding Standards (pull_request) Successful in 3m6s
CI / Build Plugin Zip (pull_request) Skipped
Three registration fixes reported from live use:
- Accepting an invite now keeps the student signed in. The form was
processed inside render() during the_content, so wp_set_auth_cookie()
ran after headers were sent and the cookie never persisted — the new
student was bounced back to the logged-out registration page. The
submission is now handled on template_redirect (before output) with a
post/redirect/get, so the cookie sticks and the student lands logged in.
- The "registration is by invitation only" message is now customisable via
a new block attribute (inviteOnlyMessage / shortcode invite_only_message),
falling back to the default wording when blank.
- Account-registration questions save again. dbDelta does not reliably
relax a column from NOT NULL to NULL, so sites created before account-
scope questions kept us_questions.offering_id NOT NULL and rejected
account inserts ("Column 'offering_id' cannot be null"). A one-time,
self-healing migration (guarded by its own option, not the version gate)
re-applies the nullable definition on next load.
composer test, composer lint, composer cs all pass.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
240 lines
8.0 KiB
PHP
240 lines
8.0 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Tests\Unit\Registration;
|
|
|
|
use Brain\Monkey\Functions;
|
|
use Mockery;
|
|
use Unsupervised\Schedular\Registration\Question;
|
|
use Unsupervised\Schedular\Registration\QuestionRepository;
|
|
use Unsupervised\Schedular\Tests\Unit\TestCase;
|
|
|
|
class QuestionRepositoryTest extends TestCase
|
|
{
|
|
private \wpdb $db;
|
|
private QuestionRepository $repo;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
|
|
$this->db = Mockery::mock(\wpdb::class);
|
|
$this->db->prefix = 'wp_';
|
|
$this->repo = new QuestionRepository($this->db);
|
|
}
|
|
|
|
public function testInsertWithNullOptionsStoresNull(): void
|
|
{
|
|
Functions\expect('current_time')->with('mysql')->andReturn('2026-04-01 12:00:00');
|
|
|
|
$this->db->shouldReceive('insert')
|
|
->once()
|
|
->with(
|
|
'wp_us_questions',
|
|
Mockery::on(static function (array $data): bool {
|
|
return $data['offering_id'] === 7
|
|
&& $data['label'] === 'Your level?'
|
|
&& $data['field_type'] === Question::FIELD_TEXT
|
|
&& $data['options'] === null
|
|
&& $data['is_required'] === 0
|
|
&& $data['created_at'] === '2026-04-01 12:00:00';
|
|
}),
|
|
Mockery::type('array')
|
|
);
|
|
|
|
$this->db->insert_id = 21;
|
|
|
|
$question = new Question(7, 'Your level?');
|
|
|
|
self::assertSame(21, $this->repo->insert($question));
|
|
}
|
|
|
|
public function testInsertEncodesOptionsAsJson(): void
|
|
{
|
|
Functions\expect('current_time')->andReturn('2026-04-01 12:00:00');
|
|
Functions\expect('wp_json_encode')
|
|
->once()
|
|
->with(['Beginner', 'Advanced'])
|
|
->andReturn('["Beginner","Advanced"]');
|
|
|
|
$this->db->shouldReceive('insert')
|
|
->once()
|
|
->with(
|
|
'wp_us_questions',
|
|
Mockery::on(static fn (array $data): bool => $data['options'] === '["Beginner","Advanced"]'),
|
|
Mockery::type('array')
|
|
);
|
|
|
|
$this->db->insert_id = 22;
|
|
|
|
$question = new Question(
|
|
offeringId: 7,
|
|
label: 'Pick a level',
|
|
fieldType: Question::FIELD_SELECT,
|
|
options: ['Beginner', 'Advanced'],
|
|
);
|
|
|
|
self::assertSame(22, $this->repo->insert($question));
|
|
}
|
|
|
|
public function testUpdateReturnsTrueOnSuccess(): void
|
|
{
|
|
$this->db->shouldReceive('update')
|
|
->once()
|
|
->with(
|
|
'wp_us_questions',
|
|
Mockery::on(static fn (array $data): bool => $data['label'] === 'Renamed' && $data['is_required'] === 1),
|
|
['id' => 5],
|
|
Mockery::type('array'),
|
|
['%d']
|
|
)
|
|
->andReturn(1);
|
|
|
|
$question = new Question(7, 'Renamed', isRequired: true, id: 5);
|
|
|
|
self::assertTrue($this->repo->update(5, $question));
|
|
}
|
|
|
|
public function testFindByOfferingActiveOnlyPreparesQuery(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')
|
|
->once()
|
|
->with(
|
|
Mockery::pattern('/offering_id = %d AND is_active = %d/'),
|
|
Mockery::on(static fn (array $p): bool => $p === ['wp_us_questions', 7, 1])
|
|
)
|
|
->andReturn('SELECT ...');
|
|
|
|
$this->db->shouldReceive('get_results')->andReturn([]);
|
|
|
|
self::assertSame([], $this->repo->findByOffering(7, activeOnly: true));
|
|
}
|
|
|
|
public function testFindByOfferingReturnsQuestions(): void
|
|
{
|
|
$row = (object) [
|
|
'id' => '3',
|
|
'offering_id' => '7',
|
|
'scope' => Question::SCOPE_OFFERING,
|
|
'label' => 'Q',
|
|
'field_type' => Question::FIELD_TEXT,
|
|
'options' => null,
|
|
'is_required' => '0',
|
|
'sort_order' => '0',
|
|
'is_active' => '1',
|
|
];
|
|
|
|
$this->db->shouldReceive('prepare')->andReturn('SELECT ...');
|
|
$this->db->shouldReceive('get_results')->andReturn([$row]);
|
|
|
|
$questions = $this->repo->findByOffering(7);
|
|
|
|
self::assertCount(1, $questions);
|
|
self::assertInstanceOf(Question::class, $questions[0]);
|
|
}
|
|
|
|
public function testInsertAccountQuestionStoresScopeAndNullOffering(): void
|
|
{
|
|
Functions\expect('current_time')->andReturn('2026-04-01 12:00:00');
|
|
|
|
$this->db->shouldReceive('insert')
|
|
->once()
|
|
->with(
|
|
'wp_us_questions',
|
|
Mockery::on(static function (array $data): bool {
|
|
return $data['offering_id'] === null
|
|
&& $data['scope'] === Question::SCOPE_ACCOUNT
|
|
&& $data['label'] === 'Emergency contact';
|
|
}),
|
|
Mockery::type('array')
|
|
);
|
|
|
|
$this->db->insert_id = 30;
|
|
|
|
$question = new Question(null, 'Emergency contact', scope: Question::SCOPE_ACCOUNT);
|
|
|
|
self::assertSame(30, $this->repo->insert($question));
|
|
}
|
|
|
|
public function testFindByScopeActiveOnlyPreparesQuery(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')
|
|
->once()
|
|
->with(
|
|
Mockery::pattern('/scope = %s AND is_active = %d/'),
|
|
Mockery::on(static fn (array $p): bool => $p === ['wp_us_questions', Question::SCOPE_ACCOUNT, 1])
|
|
)
|
|
->andReturn('SELECT ...');
|
|
|
|
$this->db->shouldReceive('get_results')->andReturn([]);
|
|
|
|
self::assertSame([], $this->repo->findByScope(Question::SCOPE_ACCOUNT, activeOnly: true));
|
|
}
|
|
|
|
public function testFindByScopeReturnsQuestions(): void
|
|
{
|
|
$row = (object) [
|
|
'id' => '5',
|
|
'offering_id' => null,
|
|
'scope' => Question::SCOPE_ACCOUNT,
|
|
'label' => 'How did you hear about us?',
|
|
'field_type' => Question::FIELD_TEXT,
|
|
'options' => null,
|
|
'is_required' => '1',
|
|
'sort_order' => '0',
|
|
'is_active' => '1',
|
|
];
|
|
|
|
$this->db->shouldReceive('prepare')->andReturn('SELECT ...');
|
|
$this->db->shouldReceive('get_results')->andReturn([$row]);
|
|
|
|
$questions = $this->repo->findByScope(Question::SCOPE_ACCOUNT);
|
|
|
|
self::assertCount(1, $questions);
|
|
self::assertNull($questions[0]->offeringId);
|
|
self::assertSame(Question::SCOPE_ACCOUNT, $questions[0]->scope);
|
|
}
|
|
|
|
public function testFindByIdReturnsNullWhenNotFound(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')->andReturn('SELECT ...');
|
|
$this->db->shouldReceive('get_row')->andReturn(null);
|
|
|
|
self::assertNull($this->repo->findById(99));
|
|
}
|
|
|
|
public function testDeleteCallsWpdbDelete(): void
|
|
{
|
|
$this->db->shouldReceive('delete')
|
|
->once()
|
|
->with('wp_us_questions', ['id' => 4], ['%d'])
|
|
->andReturn(1);
|
|
|
|
self::assertTrue($this->repo->delete(4));
|
|
}
|
|
|
|
public function testEnsureOfferingNullableRunsAlterAndReportsSuccess(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')
|
|
->once()
|
|
->with(Mockery::pattern('/ALTER TABLE %i MODIFY offering_id .*NULL/'), 'wp_us_questions')
|
|
->andReturn('ALTER TABLE `wp_us_questions` MODIFY offering_id BIGINT UNSIGNED NULL DEFAULT NULL');
|
|
|
|
$this->db->shouldReceive('query')
|
|
->once()
|
|
->with('ALTER TABLE `wp_us_questions` MODIFY offering_id BIGINT UNSIGNED NULL DEFAULT NULL')
|
|
->andReturn(0);
|
|
|
|
// A successful DDL query returns 0 rows affected (not false).
|
|
self::assertTrue($this->repo->ensureOfferingNullable());
|
|
}
|
|
|
|
public function testEnsureOfferingNullableReportsFailureWhenQueryFails(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')->once()->andReturn('ALTER ...');
|
|
$this->db->shouldReceive('query')->once()->andReturn(false);
|
|
|
|
self::assertFalse($this->repo->ensureOfferingNullable());
|
|
}
|
|
}
|