thatguygriffandClaude Opus 4.8
721c4be1d6
CI / Tests (PHP 8.1) (pull_request) Successful in 49s
CI / Tests (PHP 8.2) (pull_request) Successful in 49s
CI / No Debug Code (pull_request) Successful in 2s
CI / Coding Standards (pull_request) Successful in 2m47s
CI / PHPStan (pull_request) Successful in 3m16s
CI / Tests (PHP 8.3) (pull_request) Successful in 2m41s
CI / Build Plugin Zip (pull_request) Skipped
Three bug fixes for the 1.2.1 section: - Fixed-size fields (question labels, offering titles/notes/e-transfer email, policy titles/slugs) no longer silently fail to save when the value exceeds its column length. The REST endpoints reject over-long values with a 400, the admin controllers refuse to insert them, and the form inputs carry a maxlength so the browser blocks over-long entry. Limits are MAX_* constants on the value objects, kept in lockstep with the schema columns. - Students are kept out of wp-admin entirely. New StudentAdminGuard redirects front-end-only users (no back-office capability) away from the dashboard and hides the admin bar for them, while administrators, studio admins, and instructors keep full access. - The Add/Edit Offering instructor picker now includes WordPress administrators when they act as instructors (the default single-account setup), so a solo studio owner is selectable instead of the dropdown being empty. composer test (618), composer lint, composer cs all pass. Co-Authored-By: Claude Opus 4.8 <[email protected]>
64 lines
2.0 KiB
PHP
64 lines
2.0 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Tests\Unit\Policy;
|
|
|
|
use Brain\Monkey\Functions;
|
|
use Mockery;
|
|
use Unsupervised\Schedular\Policy\Policy;
|
|
use Unsupervised\Schedular\Policy\PolicyEndpoint;
|
|
use Unsupervised\Schedular\Policy\PolicyRepository;
|
|
use Unsupervised\Schedular\Policy\PolicyService;
|
|
use Unsupervised\Schedular\Policy\PolicyVersionRepository;
|
|
use Unsupervised\Schedular\Tests\Unit\TestCase;
|
|
|
|
class PolicyEndpointTest extends TestCase
|
|
{
|
|
private PolicyRepository&Mockery\MockInterface $policies;
|
|
private PolicyService&Mockery\MockInterface $service;
|
|
private PolicyEndpoint $endpoint;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
|
|
Functions\when('sanitize_text_field')->returnArg();
|
|
Functions\when('sanitize_title')->returnArg();
|
|
|
|
$this->policies = Mockery::mock(PolicyRepository::class);
|
|
$this->service = Mockery::mock(PolicyService::class);
|
|
$this->endpoint = new PolicyEndpoint(
|
|
$this->policies,
|
|
Mockery::mock(PolicyVersionRepository::class),
|
|
$this->service,
|
|
);
|
|
}
|
|
|
|
public function testCreateRejectsTitleLongerThanColumnLimit(): void
|
|
{
|
|
$this->service->shouldNotReceive('createPolicy');
|
|
|
|
$request = new \WP_REST_Request([
|
|
'title' => str_repeat('a', Policy::MAX_TITLE_LENGTH + 1),
|
|
]);
|
|
$response = $this->endpoint->create($request);
|
|
|
|
self::assertInstanceOf(\WP_Error::class, $response);
|
|
self::assertSame(400, $response->error_data['invalid_policy']['status']);
|
|
}
|
|
|
|
public function testCreateRejectsSlugLongerThanColumnLimit(): void
|
|
{
|
|
$this->service->shouldNotReceive('createPolicy');
|
|
|
|
$request = new \WP_REST_Request([
|
|
'title' => 'Cancellation',
|
|
'slug' => str_repeat('a', Policy::MAX_SLUG_LENGTH + 1),
|
|
]);
|
|
$response = $this->endpoint->create($request);
|
|
|
|
self::assertInstanceOf(\WP_Error::class, $response);
|
|
self::assertSame(400, $response->error_data['invalid_policy']['status']);
|
|
}
|
|
}
|