thatguygriffandClaude Opus 4.8
2c4b481077
CI / Tests (PHP 8.1) (pull_request) Successful in 44s
CI / Tests (PHP 8.2) (pull_request) Successful in 59s
CI / No Debug Code (pull_request) Successful in 3s
CI / Coding Standards (pull_request) Successful in 2m53s
CI / PHPStan (pull_request) Successful in 2m55s
CI / Tests (PHP 8.3) (pull_request) Successful in 2m41s
CI / Build Plugin Zip (pull_request) Skipped
Group classes now carry an optional per-class withdrawal deadline. Up to
that day a student may withdraw themselves from the class; the withdrawal
frees the seat and voids any pending payment but never issues an account
credit. After the deadline self-withdrawal closes and a studio admin must
withdraw the student by hand (the admin path is never subject to the
deadline). A blank deadline keeps self-withdrawal open indefinitely.
Also make the Add/Edit Offering form show only the fields relevant to the
selected kind: group settings for group classes, weekly reservation for
private lessons. Progressive enhancement — without JS every field renders.
- New nullable us_offerings.withdrawal_deadline column; Offering model gains
$withdrawalDeadline + isWithdrawalOpen().
- New student endpoint POST /enrollments/{id}/withdraw, gated by the deadline
(403 withdrawal_closed), ownership-checked, idempotent.
- Front-end group-class page shows a Withdraw button while open.
- No USC_VERSION bump: 1.2.0 is unreleased and accumulates schema changes
under its section, matching the scheduled-billing and credit features.
Tests: composer test (596), composer lint, composer cs all pass.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
256 lines
12 KiB
PHP
256 lines
12 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Tests\Unit\GroupClass;
|
|
|
|
use Brain\Monkey\Functions;
|
|
use Mockery;
|
|
use Unsupervised\Schedular\GroupClass\Enrollment;
|
|
use Unsupervised\Schedular\GroupClass\EnrollmentEndpoint;
|
|
use Unsupervised\Schedular\GroupClass\EnrollmentRepository;
|
|
use Unsupervised\Schedular\GroupClass\GroupAccessRepository;
|
|
use Unsupervised\Schedular\Offering\Offering;
|
|
use Unsupervised\Schedular\Offering\OfferingRepository;
|
|
use Unsupervised\Schedular\Payment\Payment;
|
|
use Unsupervised\Schedular\Payment\PaymentService;
|
|
use Unsupervised\Schedular\Registration\RegistrationGate;
|
|
use Unsupervised\Schedular\Tests\Unit\TestCase;
|
|
|
|
class EnrollmentEndpointTest extends TestCase
|
|
{
|
|
private EnrollmentRepository $enrollments;
|
|
private OfferingRepository $offerings;
|
|
private RegistrationGate $gate;
|
|
private PaymentService $payments;
|
|
private GroupAccessRepository $access;
|
|
private EnrollmentEndpoint $endpoint;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
|
|
Functions\when('absint')->alias(static fn ($v): int => abs((int) $v));
|
|
Functions\when('wp_unslash')->returnArg();
|
|
Functions\when('sanitize_text_field')->returnArg();
|
|
Functions\when('get_current_user_id')->justReturn(5);
|
|
Functions\when('current_time')->justReturn('2026-07-24');
|
|
|
|
$this->enrollments = Mockery::mock(EnrollmentRepository::class);
|
|
$this->offerings = Mockery::mock(OfferingRepository::class);
|
|
$this->gate = Mockery::mock(RegistrationGate::class);
|
|
$this->payments = Mockery::mock(PaymentService::class);
|
|
$this->access = Mockery::mock(GroupAccessRepository::class);
|
|
|
|
$this->endpoint = new EnrollmentEndpoint(
|
|
$this->enrollments,
|
|
$this->offerings,
|
|
$this->gate,
|
|
$this->payments,
|
|
$this->access,
|
|
);
|
|
}
|
|
|
|
private function offering(float $price): Offering
|
|
{
|
|
return new Offering(instructorId: 3, kind: Offering::KIND_GROUP_CLASS, title: 'Choir', price: $price, id: 8);
|
|
}
|
|
|
|
private function inviteOnlyOffering(): Offering
|
|
{
|
|
return new Offering(instructorId: 3, kind: Offering::KIND_GROUP_CLASS, title: 'Private Choir', accessMode: Offering::ACCESS_INVITE_ONLY, id: 8);
|
|
}
|
|
|
|
private function expectSuccessfulEnrollment(): void
|
|
{
|
|
$this->enrollments->shouldReceive('hasActiveEnrollment')->with(8, 5)->andReturn(false);
|
|
$this->enrollments->shouldReceive('countActiveForOffering')->never();
|
|
$this->gate->shouldReceive('validate')->andReturn(null);
|
|
$this->enrollments->shouldReceive('insert')->once()->andReturn(44);
|
|
$this->gate->shouldReceive('record')->once();
|
|
}
|
|
|
|
public function testEnrollInFreeClassReturnsNullPayment(): void
|
|
{
|
|
$this->offerings->shouldReceive('findById')->with(8)->andReturn($this->offering(0.0));
|
|
$this->expectSuccessfulEnrollment();
|
|
$this->payments->shouldNotReceive('createForRegistration');
|
|
|
|
$result = $this->endpoint->enroll(new \WP_REST_Request(['offering_id' => 8]));
|
|
|
|
self::assertInstanceOf(\WP_REST_Response::class, $result);
|
|
self::assertSame(201, $result->get_status());
|
|
self::assertSame(44, $result->get_data()['id']);
|
|
self::assertNull($result->get_data()['payment']);
|
|
}
|
|
|
|
public function testEnrollInPricedClassReturnsPaymentSummary(): void
|
|
{
|
|
$this->offerings->shouldReceive('findById')->with(8)->andReturn($this->offering(120.0));
|
|
$this->expectSuccessfulEnrollment();
|
|
$this->payments->shouldReceive('createForRegistration')
|
|
->once()
|
|
->with(Payment::REG_ENROLLMENT, 44, 5, 3, 120.0, 'CAD', null)
|
|
->andReturn(new Payment(
|
|
studentId: 5,
|
|
instructorId: 3,
|
|
registrationType: Payment::REG_ENROLLMENT,
|
|
registrationId: 44,
|
|
amount: 120.0,
|
|
method: Payment::METHOD_ETRANSFER,
|
|
status: Payment::STATUS_PENDING,
|
|
id: 12,
|
|
));
|
|
|
|
$result = $this->endpoint->enroll(new \WP_REST_Request(['offering_id' => 8]));
|
|
|
|
self::assertInstanceOf(\WP_REST_Response::class, $result);
|
|
self::assertSame(
|
|
['id' => 12, 'method' => Payment::METHOD_ETRANSFER, 'status' => Payment::STATUS_PENDING],
|
|
$result->get_data()['payment']
|
|
);
|
|
}
|
|
|
|
public function testScheduledBillingEnrollmentDefersPayment(): void
|
|
{
|
|
// A monthly group class is billed later by the daily scan, so enrolment
|
|
// succeeds with no payment created now.
|
|
$offering = new Offering(instructorId: 3, kind: Offering::KIND_GROUP_CLASS, title: 'Choir', price: 120.0, billingMode: Offering::BILLING_MONTHLY, id: 8);
|
|
$this->offerings->shouldReceive('findById')->with(8)->andReturn($offering);
|
|
$this->expectSuccessfulEnrollment();
|
|
$this->payments->shouldNotReceive('createForRegistration');
|
|
|
|
$result = $this->endpoint->enroll(new \WP_REST_Request(['offering_id' => 8]));
|
|
|
|
self::assertInstanceOf(\WP_REST_Response::class, $result);
|
|
self::assertSame(201, $result->get_status());
|
|
self::assertNull($result->get_data()['payment']);
|
|
}
|
|
|
|
public function testRejectsEnrollmentAfterExplicitDeadline(): void
|
|
{
|
|
// current_time is stubbed to 2026-07-24, past the 2026-07-10 deadline.
|
|
$offering = new Offering(instructorId: 3, kind: Offering::KIND_GROUP_CLASS, title: 'Choir', termStart: '2026-07-01', enrollmentDeadline: '2026-07-10', id: 8);
|
|
$this->offerings->shouldReceive('findById')->with(8)->andReturn($offering);
|
|
$this->enrollments->shouldReceive('hasActiveEnrollment')->with(8, 5)->andReturn(false);
|
|
$this->enrollments->shouldReceive('insert')->never();
|
|
|
|
$result = $this->endpoint->enroll(new \WP_REST_Request(['offering_id' => 8]));
|
|
|
|
self::assertInstanceOf(\WP_Error::class, $result);
|
|
self::assertSame('enrollment_closed', $result->get_error_code());
|
|
self::assertSame(403, $result->error_data['enrollment_closed']['status']);
|
|
}
|
|
|
|
public function testRejectsEnrollmentAfterDefaultDeadlineOfFirstClassDay(): void
|
|
{
|
|
// No explicit deadline, so it defaults to term_start (the first class day),
|
|
// which is in the past relative to the stubbed 2026-07-24 "today".
|
|
$offering = new Offering(instructorId: 3, kind: Offering::KIND_GROUP_CLASS, title: 'Choir', termStart: '2026-07-20', id: 8);
|
|
$this->offerings->shouldReceive('findById')->with(8)->andReturn($offering);
|
|
$this->enrollments->shouldReceive('hasActiveEnrollment')->with(8, 5)->andReturn(false);
|
|
$this->enrollments->shouldReceive('insert')->never();
|
|
|
|
$result = $this->endpoint->enroll(new \WP_REST_Request(['offering_id' => 8]));
|
|
|
|
self::assertInstanceOf(\WP_Error::class, $result);
|
|
self::assertSame('enrollment_closed', $result->get_error_code());
|
|
}
|
|
|
|
public function testInviteOnlyClassRejectsStudentWithoutGrant(): void
|
|
{
|
|
$this->offerings->shouldReceive('findById')->with(8)->andReturn($this->inviteOnlyOffering());
|
|
$this->enrollments->shouldReceive('hasActiveEnrollment')->with(8, 5)->andReturn(false);
|
|
$this->access->shouldReceive('hasGrant')->with(8, 5)->andReturn(false);
|
|
$this->enrollments->shouldReceive('insert')->never();
|
|
|
|
$result = $this->endpoint->enroll(new \WP_REST_Request(['offering_id' => 8]));
|
|
|
|
self::assertInstanceOf(\WP_Error::class, $result);
|
|
self::assertSame('invite_required', $result->get_error_code());
|
|
self::assertSame(403, $result->error_data['invite_required']['status']);
|
|
}
|
|
|
|
public function testInviteOnlyClassAllowsGrantedStudentAndMarksEnrolled(): void
|
|
{
|
|
$this->offerings->shouldReceive('findById')->with(8)->andReturn($this->inviteOnlyOffering());
|
|
$this->access->shouldReceive('hasGrant')->with(8, 5)->andReturn(true);
|
|
$this->expectSuccessfulEnrollment();
|
|
$this->access->shouldReceive('markEnrolled')->once()->with(8, 5);
|
|
|
|
$result = $this->endpoint->enroll(new \WP_REST_Request(['offering_id' => 8]));
|
|
|
|
self::assertInstanceOf(\WP_REST_Response::class, $result);
|
|
self::assertSame(201, $result->get_status());
|
|
}
|
|
|
|
public function testWithdrawCancelsEnrolmentAndVoidsPendingWithoutCrediting(): void
|
|
{
|
|
// No withdrawal deadline set, so withdrawal is open. current_time is 2026-07-24.
|
|
$this->enrollments->shouldReceive('findById')->with(3)->andReturn(new Enrollment(8, 5, 3, Enrollment::STATUS_ACTIVE, 41, 3));
|
|
$this->offerings->shouldReceive('findById')->with(8)->andReturn($this->offering(120.0));
|
|
$this->enrollments->shouldReceive('updateStatus')->once()->with(3, Enrollment::STATUS_CANCELLED)->andReturn(true);
|
|
$this->payments->shouldReceive('voidPending')->once()->with(41);
|
|
|
|
$result = $this->endpoint->withdraw(new \WP_REST_Request(['id' => 3]));
|
|
|
|
self::assertInstanceOf(\WP_REST_Response::class, $result);
|
|
self::assertSame(200, $result->get_status());
|
|
self::assertSame(Enrollment::STATUS_CANCELLED, $result->get_data()['status']);
|
|
}
|
|
|
|
public function testWithdrawRejectedAfterDeadline(): void
|
|
{
|
|
// current_time is stubbed to 2026-07-24, past the 2026-07-10 deadline.
|
|
$offering = new Offering(instructorId: 3, kind: Offering::KIND_GROUP_CLASS, title: 'Choir', termStart: '2026-07-01', withdrawalDeadline: '2026-07-10', id: 8);
|
|
$this->enrollments->shouldReceive('findById')->with(3)->andReturn(new Enrollment(8, 5, 3, Enrollment::STATUS_ACTIVE, 41, 3));
|
|
$this->offerings->shouldReceive('findById')->with(8)->andReturn($offering);
|
|
$this->enrollments->shouldReceive('updateStatus')->never();
|
|
$this->payments->shouldReceive('voidPending')->never();
|
|
|
|
$result = $this->endpoint->withdraw(new \WP_REST_Request(['id' => 3]));
|
|
|
|
self::assertInstanceOf(\WP_Error::class, $result);
|
|
self::assertSame('withdrawal_closed', $result->get_error_code());
|
|
self::assertSame(403, $result->error_data['withdrawal_closed']['status']);
|
|
}
|
|
|
|
public function testWithdrawRejectsAnotherStudentsEnrolment(): void
|
|
{
|
|
// Enrolment belongs to student 9, but the caller is student 5.
|
|
$this->enrollments->shouldReceive('findById')->with(3)->andReturn(new Enrollment(8, 9, 3, Enrollment::STATUS_ACTIVE, 41, 3));
|
|
$this->enrollments->shouldReceive('updateStatus')->never();
|
|
|
|
$result = $this->endpoint->withdraw(new \WP_REST_Request(['id' => 3]));
|
|
|
|
self::assertInstanceOf(\WP_Error::class, $result);
|
|
self::assertSame('forbidden', $result->get_error_code());
|
|
self::assertSame(403, $result->error_data['forbidden']['status']);
|
|
}
|
|
|
|
public function testWithdrawReturnsNotFoundForUnknownEnrolment(): void
|
|
{
|
|
$this->enrollments->shouldReceive('findById')->with(3)->andReturn(null);
|
|
|
|
$result = $this->endpoint->withdraw(new \WP_REST_Request(['id' => 3]));
|
|
|
|
self::assertInstanceOf(\WP_Error::class, $result);
|
|
self::assertSame('not_found', $result->get_error_code());
|
|
self::assertSame(404, $result->error_data['not_found']['status']);
|
|
}
|
|
|
|
public function testWithdrawIsIdempotentForAlreadyCancelledEnrolment(): void
|
|
{
|
|
// Already cancelled: no status change, no deadline check, no payment void.
|
|
$this->enrollments->shouldReceive('findById')->with(3)->andReturn(new Enrollment(8, 5, 3, Enrollment::STATUS_CANCELLED, null, 3));
|
|
$this->offerings->shouldReceive('findById')->never();
|
|
$this->enrollments->shouldReceive('updateStatus')->never();
|
|
$this->payments->shouldReceive('voidPending')->never();
|
|
|
|
$result = $this->endpoint->withdraw(new \WP_REST_Request(['id' => 3]));
|
|
|
|
self::assertInstanceOf(\WP_REST_Response::class, $result);
|
|
self::assertSame(200, $result->get_status());
|
|
self::assertSame(Enrollment::STATUS_CANCELLED, $result->get_data()['status']);
|
|
}
|
|
}
|