CI / Tests (PHP 8.1) (pull_request) Successful in 6m39s
CI / Tests (PHP 8.2) (pull_request) Successful in 57s
CI / Tests (PHP 8.3) (pull_request) Successful in 2m59s
CI / Tests (PHP 8.5) (pull_request) Successful in 3m31s
CI / No Debug Code (pull_request) Successful in 3s
CI / Coding Standards & Static Analysis (pull_request) Successful in 3m28s
CI / Build Plugin Zip (pull_request) Skipped
Two related gaps, closed together because the second is created by the first. A private lesson could only be booked by the student or their guardian, so a booking taken over the phone had no way in — where group classes have had "Add students directly" all along. "Book a lesson for a student" is now a panel on Scheduler and My Lessons: student, open time, lesson type, with weekly term reservations and a no-charge option for make-up lessons. The booking core is extracted to Booking\LessonBooker and shared with POST /bookings, so the two paths cannot drift on offering rules, slot claiming, or billing. That leaves a registration with no intake answers and no policy acceptances, because nobody was at a keyboard to give them — already true of every directly added group-class student. Ticking the boxes on a student's behalf would be an audit trail that says something untrue, so instead the answers are collected another way and recorded afterwards, from a lesson's or an enrolment's detail page. Every recording must say how it was collected, which is stamped on each row along with who typed it and shown in a new "How it was given" column: a policy ticked online and one transcribed from paper must never look alike. Only staff-made registrations qualify (us_lessons.booked_by, us_group_enrollments.enrolled_by) — one the student made already holds their own answers. Only what is still missing can be recorded, re-checked at write time, so a stale or double-posted form cannot duplicate or overwrite. No IP is stored for a transcription, and accepted_by stays the student while recorded_by names the staff member. Intake is now generic over Registration\IntakeSubject, which Lesson and Enrollment both implement; LessonDetail became Registration\IntakeAudit and is shared by both detail views rather than duplicated. Closes #182 Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01QfHt6CyJHz6KkA4RuaS7WK
125 lines
4.4 KiB
PHP
125 lines
4.4 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Tests\Unit\Policy;
|
|
|
|
use Brain\Monkey\Functions;
|
|
use Mockery;
|
|
use Unsupervised\Schedular\Policy\AcceptanceRepository;
|
|
use Unsupervised\Schedular\Policy\PolicyAcceptance;
|
|
use Unsupervised\Schedular\Tests\Unit\TestCase;
|
|
|
|
class AcceptanceRepositoryTest extends TestCase
|
|
{
|
|
private \wpdb $db;
|
|
private AcceptanceRepository $repo;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
|
|
$this->db = Mockery::mock(\wpdb::class);
|
|
$this->db->prefix = 'wp_';
|
|
$this->repo = new AcceptanceRepository($this->db);
|
|
}
|
|
|
|
public function testInsertReturnsId(): void
|
|
{
|
|
Functions\expect('current_time')->with('mysql')->andReturn('2026-06-02 09:00:00');
|
|
|
|
$this->db->shouldReceive('insert')
|
|
->once()
|
|
->with(
|
|
'wp_us_policy_acceptances',
|
|
Mockery::on(static function (array $d): bool {
|
|
return $d['policy_version_id'] === 9
|
|
&& $d['student_id'] === 5
|
|
&& $d['registration_type'] === PolicyAcceptance::REG_LESSON
|
|
&& $d['registration_id'] === 12
|
|
// No explicit acceptor: the student agreed for themselves.
|
|
&& $d['accepted_by'] === 5
|
|
&& $d['ip_address'] === '203.0.113.7'
|
|
// Ticked online: no collection provenance to record.
|
|
&& null === $d['collected_via']
|
|
&& null === $d['collected_note']
|
|
&& 0 === $d['recorded_by'];
|
|
}),
|
|
['%d', '%d', '%d', '%s', '%d', '%s', '%s', '%s', '%d', '%s']
|
|
);
|
|
$this->db->insert_id = 1;
|
|
|
|
$acceptance = new PolicyAcceptance(9, 5, PolicyAcceptance::REG_LESSON, 12, ipAddress: '203.0.113.7');
|
|
|
|
self::assertSame(1, $this->repo->insert($acceptance));
|
|
}
|
|
|
|
public function testInsertManyReturnsAllIds(): void
|
|
{
|
|
Functions\when('current_time')->justReturn('2026-06-02 09:00:00');
|
|
|
|
$ids = [11, 12];
|
|
$this->db->shouldReceive('insert')
|
|
->twice()
|
|
->andReturnUsing(function () use (&$ids): void {
|
|
$this->db->insert_id = array_shift($ids);
|
|
});
|
|
|
|
$result = $this->repo->insertMany([
|
|
new PolicyAcceptance(9, 5, PolicyAcceptance::REG_LESSON, 12),
|
|
new PolicyAcceptance(10, 5, PolicyAcceptance::REG_LESSON, 12),
|
|
]);
|
|
|
|
self::assertSame([11, 12], $result);
|
|
}
|
|
|
|
public function testFindByRegistrationMapsRows(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')
|
|
->once()
|
|
->with(Mockery::pattern('/registration_type = %s AND registration_id = %d/'), 'wp_us_policy_acceptances', PolicyAcceptance::REG_LESSON, 12)
|
|
->andReturn('SELECT ...');
|
|
|
|
$this->db->shouldReceive('get_results')->andReturn([
|
|
(object) [
|
|
'id' => '1',
|
|
'policy_version_id' => '9',
|
|
'student_id' => '5',
|
|
'registration_type' => PolicyAcceptance::REG_LESSON,
|
|
'registration_id' => '12',
|
|
'accepted_at' => '2026-06-02 09:00:00',
|
|
'ip_address' => null,
|
|
],
|
|
]);
|
|
|
|
$rows = $this->repo->findByRegistration(PolicyAcceptance::REG_LESSON, 12);
|
|
|
|
self::assertCount(1, $rows);
|
|
self::assertInstanceOf(PolicyAcceptance::class, $rows[0]);
|
|
}
|
|
|
|
public function testFindByStudentMapsRowsNewestFirst(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')
|
|
->once()
|
|
->with(Mockery::pattern('/student_id = %d ORDER BY accepted_at DESC, id DESC/'), 'wp_us_policy_acceptances', 5)
|
|
->andReturn('SELECT ...');
|
|
|
|
$this->db->shouldReceive('get_results')->andReturn([
|
|
(object) [
|
|
'id' => '2',
|
|
'policy_version_id' => '9',
|
|
'student_id' => '5',
|
|
'registration_type' => PolicyAcceptance::REG_ACCOUNT,
|
|
'registration_id' => '5',
|
|
'accepted_at' => '2026-06-03 09:00:00',
|
|
'ip_address' => null,
|
|
],
|
|
]);
|
|
|
|
$rows = $this->repo->findByStudent(5);
|
|
|
|
self::assertCount(1, $rows);
|
|
self::assertSame(5, $rows[0]->studentId);
|
|
}
|
|
}
|