thatguygriffandClaude Opus 5
b772e1811e
A parent registers once and manages lessons for one or more children, who need no login of their own. A child is a real wp_users row with the student role but no usable login — so student_id keeps meaning "a WordPress user" on every table, and booking, credits, policies and enrolments work unchanged. A us_guardians link table maps guardian to child. The signup form gains a parent/guardian tick that reveals a block per child, with the account-signup questions asked per child rather than per guardian — they describe the student, not the account holder. Signup policies are recorded once per child with the guardian as the acceptor, which is the record that actually means something. A family that half-creates is rolled back entirely rather than leaving a guardian who cannot re-register. The booking and enrolment forms gain a "Who is this for?" picker listing children first, so the default selection is never the parent — booking for the wrong child is correctable, quietly billing a parent for their kid's lesson is not. POST /bookings and POST /enrollments take an optional student_id honoured only for that child's guardian; anything else is a 403. That check is the authorisation boundary of the feature. Payments and credits gain a payer: the charge names the child it was for and the guardian who owes it, so per-child reporting is unchanged while notices, receipts and the payment step reach the parent. Credit is held by the payer, so one child's cancellation can settle a sibling's charge, and the daily billing scan sends a guardian one notice covering every child. Closes #132 Co-Authored-By: Claude Opus 5 <[email protected]>
121 lines
4.1 KiB
PHP
121 lines
4.1 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Tests\Unit\Policy;
|
|
|
|
use Brain\Monkey\Functions;
|
|
use Mockery;
|
|
use Unsupervised\Schedular\Policy\AcceptanceRepository;
|
|
use Unsupervised\Schedular\Policy\PolicyAcceptance;
|
|
use Unsupervised\Schedular\Tests\Unit\TestCase;
|
|
|
|
class AcceptanceRepositoryTest extends TestCase
|
|
{
|
|
private \wpdb $db;
|
|
private AcceptanceRepository $repo;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
|
|
$this->db = Mockery::mock(\wpdb::class);
|
|
$this->db->prefix = 'wp_';
|
|
$this->repo = new AcceptanceRepository($this->db);
|
|
}
|
|
|
|
public function testInsertReturnsId(): void
|
|
{
|
|
Functions\expect('current_time')->with('mysql')->andReturn('2026-06-02 09:00:00');
|
|
|
|
$this->db->shouldReceive('insert')
|
|
->once()
|
|
->with(
|
|
'wp_us_policy_acceptances',
|
|
Mockery::on(static function (array $d): bool {
|
|
return $d['policy_version_id'] === 9
|
|
&& $d['student_id'] === 5
|
|
&& $d['registration_type'] === PolicyAcceptance::REG_LESSON
|
|
&& $d['registration_id'] === 12
|
|
// No explicit acceptor: the student agreed for themselves.
|
|
&& $d['accepted_by'] === 5
|
|
&& $d['ip_address'] === '203.0.113.7';
|
|
}),
|
|
['%d', '%d', '%d', '%s', '%d', '%s', '%s']
|
|
);
|
|
$this->db->insert_id = 1;
|
|
|
|
$acceptance = new PolicyAcceptance(9, 5, PolicyAcceptance::REG_LESSON, 12, ipAddress: '203.0.113.7');
|
|
|
|
self::assertSame(1, $this->repo->insert($acceptance));
|
|
}
|
|
|
|
public function testInsertManyReturnsAllIds(): void
|
|
{
|
|
Functions\when('current_time')->justReturn('2026-06-02 09:00:00');
|
|
|
|
$ids = [11, 12];
|
|
$this->db->shouldReceive('insert')
|
|
->twice()
|
|
->andReturnUsing(function () use (&$ids): void {
|
|
$this->db->insert_id = array_shift($ids);
|
|
});
|
|
|
|
$result = $this->repo->insertMany([
|
|
new PolicyAcceptance(9, 5, PolicyAcceptance::REG_LESSON, 12),
|
|
new PolicyAcceptance(10, 5, PolicyAcceptance::REG_LESSON, 12),
|
|
]);
|
|
|
|
self::assertSame([11, 12], $result);
|
|
}
|
|
|
|
public function testFindByRegistrationMapsRows(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')
|
|
->once()
|
|
->with(Mockery::pattern('/registration_type = %s AND registration_id = %d/'), 'wp_us_policy_acceptances', PolicyAcceptance::REG_LESSON, 12)
|
|
->andReturn('SELECT ...');
|
|
|
|
$this->db->shouldReceive('get_results')->andReturn([
|
|
(object) [
|
|
'id' => '1',
|
|
'policy_version_id' => '9',
|
|
'student_id' => '5',
|
|
'registration_type' => PolicyAcceptance::REG_LESSON,
|
|
'registration_id' => '12',
|
|
'accepted_at' => '2026-06-02 09:00:00',
|
|
'ip_address' => null,
|
|
],
|
|
]);
|
|
|
|
$rows = $this->repo->findByRegistration(PolicyAcceptance::REG_LESSON, 12);
|
|
|
|
self::assertCount(1, $rows);
|
|
self::assertInstanceOf(PolicyAcceptance::class, $rows[0]);
|
|
}
|
|
|
|
public function testFindByStudentMapsRowsNewestFirst(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')
|
|
->once()
|
|
->with(Mockery::pattern('/student_id = %d ORDER BY accepted_at DESC, id DESC/'), 'wp_us_policy_acceptances', 5)
|
|
->andReturn('SELECT ...');
|
|
|
|
$this->db->shouldReceive('get_results')->andReturn([
|
|
(object) [
|
|
'id' => '2',
|
|
'policy_version_id' => '9',
|
|
'student_id' => '5',
|
|
'registration_type' => PolicyAcceptance::REG_ACCOUNT,
|
|
'registration_id' => '5',
|
|
'accepted_at' => '2026-06-03 09:00:00',
|
|
'ip_address' => null,
|
|
],
|
|
]);
|
|
|
|
$rows = $this->repo->findByStudent(5);
|
|
|
|
self::assertCount(1, $rows);
|
|
self::assertSame(5, $rows[0]->studentId);
|
|
}
|
|
}
|