Unsupervised/unsupervised-scheduler
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 12 Wiki Activity

Skip payment step for unpriced bookings, confirm them immediately, show students their lessons #54

Merged
thatguygriff merged 1 commits from fix/unpriced-booking-flow into main 2026-07-05 20:06:46 +00:00
Conversation 0 Commits 1 Files Changed 15
+433 -25
1 Commits
Author SHA1 Message Date
thatguygriffandClaude Fable 5 5888032ed7 Skip payment step for unpriced bookings, confirm them immediately, show students their lessons
CI / No Debug Code (pull_request) Successful in 2s
Details
CI / Tests (PHP 8.2) (pull_request) Successful in 53s
Details
CI / PHPStan (pull_request) Successful in 2m46s
Details
CI / Tests (PHP 8.1) (pull_request) Successful in 42s
Details
CI / Coding Standards (pull_request) Successful in 47s
Details
CI / Tests (PHP 8.3) (pull_request) Successful in 2m35s
Details
CI / Build Plugin Zip (pull_request) Has been skipped
Details 
Booking a slot with no priced offering created the lesson but no payment,
yet the front end still called POST /payments/intent, which 400ed with
"Could not start payment for this registration" — the student saw an error
while the backend held a claimed slot and a lesson stuck at pending.

- POST /bookings and POST /enrollments now return a `payment` summary
  ({id, method, status}) or null when nothing is owed; the JS only runs
  the payment step when a payment exists.
- Bookings with nothing owed are confirmed at creation — there is no
  payment step that would ever confirm them later.
- The booking page now shows the student's upcoming lessons (GET /bookings,
  now scoped to upcoming non-cancelled lessons with slot start/end times)
  with a pending-payment/confirmed status badge.

Fixes #53

Co-Authored-By: Claude Fable 5 <[email protected]>
 2026-07-05 17:02:38 -03:00