Let a guardian enrol every child in the same group class

Conversation 0 Commits 1 Files Changed 3

+134 -45

1 Commits

Author	SHA1	Message	Date
thatguygriffandClaude Opus 5	8017dbb9ff	Let a guardian enrol every child in the same group class CI / No Debug Code (pull_request) Successful in 26s Details CI / Tests (PHP 8.2) (pull_request) Successful in 48s Details CI / Tests (PHP 8.1) (pull_request) Successful in 1m5s Details CI / PHPStan (pull_request) Successful in 2m55s Details CI / Coding Standards (pull_request) Successful in 3m49s Details CI / Tests (PHP 8.3) (pull_request) Successful in 6m9s Details CI / Build Plugin Zip (pull_request) Skipped Details The group-class page matched enrolments to the account instead of to the student: the lookup it built from GET /enrollments was keyed by offering id alone, so the first household enrolment marked the class as "yours" and took the Enrol button away from everyone else on the account. A parent could enrol one child and was then offered nothing but Withdraw. The server was never the constraint — hasActiveEnrollment() checks the (offering, student) pair and GET /enrollments deliberately returns the whole household — so the fix is to stop discarding student_id on the way in. Active enrolments are now grouped per class as a list, each student gets their own "… is enrolled in this class." line and their own named Withdraw button, and the Enrol button stays (as "Enrol another student") while anyone the account may enrol is still out. The enrolment form offers only the students not yet enrolled. When exactly one of them is left the picker collapses, and that case needed care: an omitted student_id reads as "enrol the account holder" server-side, so a hidden field carries the id rather than posting nothing and signing up the parent instead of the last child. Closes #170 Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Jy9UPhmpLUAfimsyecHN2Z	2026-08-11 17:36:01 -03:00

Author

SHA1

Message

Date

thatguygriffandClaude Opus 5

8017dbb9ff

Let a guardian enrol every child in the same group class

CI / No Debug Code (pull_request) Successful in 26s

Details

CI / Tests (PHP 8.2) (pull_request) Successful in 48s

Details

CI / Tests (PHP 8.1) (pull_request) Successful in 1m5s

Details

CI / PHPStan (pull_request) Successful in 2m55s

Details

CI / Coding Standards (pull_request) Successful in 3m49s

Details

CI / Tests (PHP 8.3) (pull_request) Successful in 6m9s

Details

CI / Build Plugin Zip (pull_request) Skipped

Details

The group-class page matched enrolments to the account instead of to the
student: the lookup it built from GET /enrollments was keyed by offering id
alone, so the first household enrolment marked the class as "yours" and took
the Enrol button away from everyone else on the account. A parent could enrol
one child and was then offered nothing but Withdraw.

The server was never the constraint — hasActiveEnrollment() checks the
(offering, student) pair and GET /enrollments deliberately returns the whole
household — so the fix is to stop discarding student_id on the way in. Active
enrolments are now grouped per class as a list, each student gets their own
"… is enrolled in this class." line and their own named Withdraw button, and
the Enrol button stays (as "Enrol another student") while anyone the account
may enrol is still out.

The enrolment form offers only the students not yet enrolled. When exactly one
of them is left the picker collapses, and that case needed care: an omitted
student_id reads as "enrol the account holder" server-side, so a hidden field
carries the id rather than posting nothing and signing up the parent instead of
the last child.

Closes #170

Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01Jy9UPhmpLUAfimsyecHN2Z

2026-08-11 17:36:01 -03:00

Let a guardian enrol every child in the same group class #171