Fix invite sign-in, add customizable invite-only text, repair account questions #109

Merged

thatguygriff merged 1 commits from fix/registration-signin-and-account-questions into main

2026-07-24 19:29:53 +00:00

Author	SHA1	Message	Date
thatguygriffandClaude Opus 4.8	242150569b	Fix invite sign-in persistence, add invite-only text option, repair account questions CI / Tests (PHP 8.1) (pull_request) Successful in 47s Details CI / Tests (PHP 8.2) (pull_request) Successful in 46s Details CI / No Debug Code (pull_request) Successful in 3s Details CI / Tests (PHP 8.3) (pull_request) Successful in 2m37s Details CI / PHPStan (pull_request) Successful in 2m52s Details CI / Coding Standards (pull_request) Successful in 3m6s Details CI / Build Plugin Zip (pull_request) Skipped Details Three registration fixes reported from live use: - Accepting an invite now keeps the student signed in. The form was processed inside render() during the_content, so wp_set_auth_cookie() ran after headers were sent and the cookie never persisted — the new student was bounced back to the logged-out registration page. The submission is now handled on template_redirect (before output) with a post/redirect/get, so the cookie sticks and the student lands logged in. - The "registration is by invitation only" message is now customisable via a new block attribute (inviteOnlyMessage / shortcode invite_only_message), falling back to the default wording when blank. - Account-registration questions save again. dbDelta does not reliably relax a column from NOT NULL to NULL, so sites created before account- scope questions kept us_questions.offering_id NOT NULL and rejected account inserts ("Column 'offering_id' cannot be null"). A one-time, self-healing migration (guarded by its own option, not the version gate) re-applies the nullable definition on next load. composer test, composer lint, composer cs all pass. Co-Authored-By: Claude Opus 4.8 <[email protected]>	2026-07-24 16:24:15 -03:00

Author

SHA1

Message

Date

thatguygriffandClaude Opus 4.8

242150569b

Fix invite sign-in persistence, add invite-only text option, repair account questions

CI / Tests (PHP 8.1) (pull_request) Successful in 47s

Details

CI / Tests (PHP 8.2) (pull_request) Successful in 46s

Details

CI / No Debug Code (pull_request) Successful in 3s

Details

CI / Tests (PHP 8.3) (pull_request) Successful in 2m37s

Details

CI / PHPStan (pull_request) Successful in 2m52s

Details

CI / Coding Standards (pull_request) Successful in 3m6s

Details

CI / Build Plugin Zip (pull_request) Skipped

Details

Three registration fixes reported from live use:

- Accepting an invite now keeps the student signed in. The form was
  processed inside render() during the_content, so wp_set_auth_cookie()
  ran after headers were sent and the cookie never persisted — the new
  student was bounced back to the logged-out registration page. The
  submission is now handled on template_redirect (before output) with a
  post/redirect/get, so the cookie sticks and the student lands logged in.

- The "registration is by invitation only" message is now customisable via
  a new block attribute (inviteOnlyMessage / shortcode invite_only_message),
  falling back to the default wording when blank.

- Account-registration questions save again. dbDelta does not reliably
  relax a column from NOT NULL to NULL, so sites created before account-
  scope questions kept us_questions.offering_id NOT NULL and rejected
  account inserts ("Column 'offering_id' cannot be null"). A one-time,
  self-healing migration (guarded by its own option, not the version gate)
  re-applies the nullable definition on next load.

composer test, composer lint, composer cs all pass.

Co-Authored-By: Claude Opus 4.8 <[email protected]>

2026-07-24 16:24:15 -03:00