12 Commits

Author SHA1 Message Date
dependabot[bot]
34f9b574a3 chore(deps-dev): Bump @eslint/js from 9.38.0 to 9.39.0
Bumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 9.38.0 to 9.39.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](https://github.com/eslint/eslint/commits/v9.39.0/packages/js)

---
updated-dependencies:
- dependency-name: "@eslint/js"
  dependency-version: 9.39.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-11-02 17:13:37 +00:00
Pascal Bourque
2ff6d00999 chore: Changed dependabot schedule from daily to weekly (#83) 2025-11-02 12:12:25 -05:00
remiolivier
da90344ffc fix: Unable to change the set point when Home Assistant is configured with Fahrenheit temperature unit (#73)
# Fix Temperature Handling in Fahrenheit Mode

## Problem

When operating in **Fahrenheit mode**, Mysa still expects temperature
values to be provided in **Celsius**.
However, Home Assistant sends integer Fahrenheit values (e.g.,
`72.02°F`), which convert to **non-aligned Celsius values** like
`22.22°C`.

Mysa’s API only accepts temperature values that are either **whole
numbers** or **increments of 0.5°C** (for example: `21.0`, `21.5`,
`22.0`).
As a result, values such as `22.22°C` or `21.72°C` are considered
invalid and are **rejected** by Mysa’s API.

---

## Root Cause

- The original code accepted **0.1°C precision** and **0.5°C step
size**.
- When Home Assistant runs in Fahrenheit, the conversion from °F to °C
produces fractional values that are not valid (e.g., 72°F → 22.22°C).
- Because Mysa enforces strict 0.5°C increments, these fractional
setpoints caused failed updates.

---

## Solution

This update ensures valid behavior when using Fahrenheit mode **while
keeping the current behavior for Celsius**:

- Adds a new environment variable:  
  **`M2M_TEMP_UNIT`** — accepts either:
  - `C` *(default)*
  - `F` *(for Fahrenheit operation)*
- When running in Fahrenheit mode (`M2M_TEMP_UNIT=F`):
  - Celsius values are **rounded and clamped to the nearest 0.5°C**.  
  - Temperature step size and precision are adjusted:
    - Precision → `1°F`
    - Step size → `1°F`
- When running in Celsius mode, existing logic remains unchanged (0.1
precision, 0.5 step).

---

## Technical Summary

| Mode | Env Variable | Precision | Step | Conversion Behavior |
|------|---------------|------------|------|----------------------|
| Celsius | `M2M_TEMP_UNIT=C` (default) | 0.1°C | 0.5°C | Direct
pass-through |
| Fahrenheit | `M2M_TEMP_UNIT=F` | 1°F | 1°F | Convert °F → °C, snap to
0.5°C |

The rounding logic ensures that when a Fahrenheit value (e.g., `72°F`)
is converted to Celsius (`21.72°C`), it is adjusted to the nearest valid
half-degree (`21.5°C` or `22.0°C`).

# Demo


https://github.com/user-attachments/assets/bbffe5fe-a3be-43cb-aed0-f63bdfacb1d4

---------

Co-authored-by: Pascal Bourque <pascal@cosmos.moi>
2025-11-02 10:00:14 -05:00
allcontributors[bot]
4069f24880 docs: add remiolivier as a contributor for code (#82)
Adds @remiolivier as a contributor for code.

This was requested by bourquep [in this
comment](https://github.com/bourquep/mysa2mqtt/pull/72#issuecomment-3476434699)

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Pascal Bourque <pascal@cosmos.moi>
2025-11-01 10:55:59 -04:00
Pascal Bourque
a47cdbb45e fix: Don't crash on undefined values returned by the Mysa API (#81) 2025-11-01 10:49:27 -04:00
Pascal Bourque
2e075cd40d fix: Better resilience towards MQTT connection loss and errors (#80) 2025-11-01 09:05:05 -04:00
dependabot[bot]
f2d35a1ca5 chore(deps-dev): Bump the dev-dependencies group across 1 directory with 6 updates (#79) 2025-10-31 20:43:34 +00:00
dependabot[bot]
122ffde2f1 chore(deps): Bump pino from 10.0.0 to 10.1.0 (#76) 2025-10-31 20:38:17 +00:00
dependabot[bot]
c259557da0 chore(deps-dev): Bump typescript-eslint from 8.45.0 to 8.46.2 (#78) 2025-10-31 20:35:35 +00:00
dependabot[bot]
57bd430c98 chore(deps-dev): Bump @eslint/js from 9.37.0 to 9.38.0 (#75) 2025-10-31 20:35:08 +00:00
dependabot[bot]
8ca80acb49 chore(deps): Bump pino-pretty from 13.1.1 to 13.1.2 (#68) 2025-10-31 20:34:55 +00:00
Pascal Bourque
3b5dafeda9 fix: Fatal error when starting realtime updates. (#64)
Via https://github.com/bourquep/mysa-js-sdk/pull/144
2025-10-05 15:08:07 -04:00
9 changed files with 1763 additions and 1255 deletions

22
.all-contributorsrc Normal file
View File

@@ -0,0 +1,22 @@
{
"files": ["README.md"],
"imageSize": 100,
"commit": false,
"commitType": "docs",
"commitConvention": "angular",
"contributors": [
{
"login": "remiolivier",
"name": "remiolivier",
"avatar_url": "https://avatars.githubusercontent.com/u/1379047?v=4",
"profile": "https://github.com/remiolivier",
"contributions": ["code"]
}
],
"contributorsPerLine": 7,
"skipCi": true,
"repoType": "github",
"repoHost": "https://github.com",
"projectName": "mysa2mqtt",
"projectOwner": "bourquep"
}

View File

@@ -8,7 +8,7 @@ updates:
- package-ecosystem: 'npm' # See documentation for possible values
directory: '/' # Location of package manifests
schedule:
interval: 'daily'
interval: 'weekly'
labels:
- 'dependencies'
commit-message:

1
.prettierignore Normal file
View File

@@ -0,0 +1 @@
README.md

View File

@@ -1,5 +1,11 @@
# mysa2mqtt
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
[![All Contributors](https://img.shields.io/badge/all_contributors-1-orange.svg?style=flat-square)](#contributors-)
<!-- ALL-CONTRIBUTORS-BADGE:END -->
[![NPM Version](https://img.shields.io/npm/v/mysa2mqtt)](https://www.npmjs.com/package/mysa2mqtt)
[![Docker Hub](https://img.shields.io/docker/pulls/bourquep/mysa2mqtt)](https://hub.docker.com/r/bourquep/mysa2mqtt)
[![CodeQL](https://github.com/bourquep/mysa2mqtt/actions/workflows/github-code-scanning/codeql/badge.svg)](https://github.com/bourquep/mysa2mqtt/actions/workflows/github-code-scanning/codeql)
@@ -118,6 +124,11 @@ For development or custom modifications:
The application can be configured using either command-line arguments or environment variables. Environment variables
take precedence over command-line defaults.
> [!IMPORTANT]
> The `M2M_TEMPERATURE_UNIT` option must match Home Assistant's unit system (Settings → General → Unit System)
> so setpoints and readings are interpreted correctly. If mismatched, climate entities will show incorrect values (e.g.
> 21°C treated as 21°F) and commands may result in unexpected temperatures.
### Required Configuration
| CLI Option | Environment Variable | Description |
@@ -145,6 +156,7 @@ take precedence over command-line defaults.
| `-l, --log-level` | `M2M_LOG_LEVEL` | `info` | Log level: `silent`, `fatal`, `error`, `warn`, `info`, `debug`, `trace` |
| `-f, --log-format` | `M2M_LOG_FORMAT` | `pretty` | Log format: `pretty`, `json` |
| `-s, --mysa-session-file` | `M2M_MYSA_SESSION_FILE` | `session.json` | Path to Mysa session file |
| `-t, --temperature-unit` | `M2M_TEMPERATURE_UNIT` | `C` | Temperature unit (`C` = Celsius, `F` = Fahrenheit) |
## Usage Examples
@@ -369,3 +381,26 @@ copyright notice and license text in any copy of the software or substantial por
- [mqtt2ha](https://github.com/bourquep/mqtt2ha) - MQTT to Home Assistant bridge library
- [Commander.js](https://github.com/tj/commander.js) - Command-line argument parsing
- [Pino](https://github.com/pinojs/pino) - Fast JSON logger
## Contributors ✨
Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/docs/en/emoji-key)):
<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
<!-- prettier-ignore-start -->
<!-- markdownlint-disable -->
<table>
<tbody>
<tr>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/remiolivier"><img src="https://avatars.githubusercontent.com/u/1379047?v=4?s=100" width="100px;" alt="remiolivier"/><br /><sub><b>remiolivier</b></sub></a><br /><a href="https://github.com/bourquep/mysa2mqtt/commits?author=remiolivier" title="Code">💻</a></td>
</tr>
</tbody>
</table>
<!-- markdownlint-restore -->
<!-- prettier-ignore-end -->
<!-- ALL-CONTRIBUTORS-LIST:END -->
This project follows the [all-contributors](https://github.com/all-contributors/all-contributors) specification.
Contributions of any kind welcome!

2881
package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@@ -49,26 +49,26 @@
"commander": "14.0.1",
"dotenv": "17.2.3",
"mqtt2ha": "4.1.2",
"mysa-js-sdk": "1.3.2",
"pino": "10.0.0",
"pino-pretty": "13.1.1"
"mysa-js-sdk": "2.0.0",
"pino": "10.1.0",
"pino-pretty": "13.1.2"
},
"devDependencies": {
"@commander-js/extra-typings": "14.0.0",
"@eslint/js": "9.37.0",
"@semantic-release/npm": "12.0.2",
"@types/node": "24.6.2",
"@eslint/js": "9.39.0",
"@semantic-release/npm": "13.1.1",
"@types/node": "24.9.2",
"conventional-changelog-conventionalcommits": "9.1.0",
"eslint": "9.37.0",
"eslint-plugin-jsdoc": "60.8.1",
"eslint": "9.39.0",
"eslint-plugin-jsdoc": "61.1.11",
"eslint-plugin-tsdoc": "0.4.0",
"prettier": "3.6.2",
"prettier-plugin-jsdoc": "1.3.3",
"prettier-plugin-jsdoc": "1.5.0",
"prettier-plugin-organize-imports": "4.3.0",
"semantic-release": "24.2.9",
"semantic-release": "25.0.1",
"tsup": "8.5.0",
"tsx": "4.20.6",
"typescript": "5.9.3",
"typescript-eslint": "8.45.0"
"typescript-eslint": "8.46.2"
}
}

View File

@@ -99,7 +99,8 @@ async function main() {
mqttSettings,
new PinoLogger(rootLogger.child({ module: 'thermostat', deviceId: device.Id })),
firmwares.Firmware[device.Id],
serialNumbers.get(device.Id)
serialNumbers.get(device.Id),
options.temperatureUnit
)
);

View File

@@ -143,5 +143,12 @@ export const options = new Command('mysa2mqtt')
.default('mysa2mqtt')
.helpGroup('MQTT')
)
.addOption(
new Option('--temperature-unit <temperatureUnit>', 'temperature unit (C or F)')
.env('M2M_TEMPERATURE_UNIT')
.choices(['C', 'F'])
.default('C')
.helpGroup('Configuration')
)
.parse()
.opts();

View File

@@ -51,8 +51,11 @@ export class Thermostat {
private readonly mqttSettings: MqttSettings,
private readonly logger: Logger,
public readonly mysaDeviceFirmware?: FirmwareDevice,
public readonly mysaDeviceSerialNumber?: string
public readonly mysaDeviceSerialNumber?: string,
public readonly temperatureUnit?: 'C' | 'F'
) {
const is_celsius = (temperatureUnit ?? 'C') === 'C';
this.mqttDevice = {
identifiers: mysaDevice.Id,
name: mysaDevice.Name,
@@ -81,9 +84,9 @@ export class Thermostat {
min_temp: mysaDevice.MinSetpoint,
max_temp: mysaDevice.MaxSetpoint,
modes: ['off', 'heat'], // TODO: AC
precision: 0.1,
temp_step: 0.5,
temperature_unit: 'C', // TODO: Confirm that Mysa always works in C
precision: is_celsius ? 0.1 : 1.0,
temp_step: is_celsius ? 0.5 : 1.0,
temperature_unit: 'C',
optimistic: true
}
},
@@ -118,7 +121,17 @@ export class Thermostat {
if (message === '') {
this.mysaApiClient.setDeviceState(this.mysaDevice.Id, undefined, undefined);
} else {
this.mysaApiClient.setDeviceState(this.mysaDevice.Id, parseFloat(message), undefined);
let temperature = parseFloat(message);
if (!is_celsius) {
const snapHalfC = (c: number) => Math.round(c * 2) / 2;
const clamp = (v: number, min: number, max: number) => Math.min(max, Math.max(min, v));
// Snap to 0.5 °C and clamp to device limits
const setC = snapHalfC(temperature);
temperature = clamp(setC, this.mysaDevice.MinSetpoint ?? 0, this.mysaDevice.MaxSetpoint ?? 100);
}
this.mysaApiClient.setDeviceState(this.mysaDevice.Id, temperature, undefined);
}
break;
}
@@ -137,7 +150,7 @@ export class Thermostat {
device_class: 'temperature',
state_class: 'measurement',
unit_of_measurement: '°C',
suggested_display_precision: 1,
suggested_display_precision: is_celsius ? 0.1 : 0.0,
force_update: true
}
});
@@ -187,18 +200,22 @@ export class Thermostat {
try {
const deviceStates = await this.mysaApiClient.getDeviceStates();
const state = deviceStates.DeviceStatesObj[this.mysaDevice.Id];
const tstatMode = state.TstatMode?.v;
this.mqttClimate.currentTemperature = state.CorrectedTemp.v;
this.mqttClimate.currentHumidity = state.Humidity.v;
this.mqttClimate.currentMode = state.TstatMode.v === 1 ? 'off' : state.TstatMode.v === 3 ? 'heat' : undefined;
this.mqttClimate.currentAction = this.computeCurrentAction(undefined, state.Duty.v);
this.mqttClimate.targetTemperature = this.mqttClimate.currentMode !== 'off' ? state.SetPoint.v : undefined;
this.mqttClimate.currentTemperature = state.CorrectedTemp?.v;
this.mqttClimate.currentHumidity = state.Humidity?.v;
this.mqttClimate.currentMode = tstatMode === 1 ? 'off' : tstatMode === 3 ? 'heat' : undefined;
this.mqttClimate.currentAction = this.computeCurrentAction(undefined, state.Duty?.v);
this.mqttClimate.targetTemperature = this.mqttClimate.currentMode !== 'off' ? state.SetPoint?.v : undefined;
await this.mqttClimate.writeConfig();
await this.mqttTemperature.setState('state_topic', state.CorrectedTemp.v.toFixed(2));
await this.mqttTemperature.setState(
'state_topic',
state.CorrectedTemp != null ? state.CorrectedTemp.v.toFixed(2) : 'None'
);
await this.mqttTemperature.writeConfig();
await this.mqttHumidity.setState('state_topic', state.Humidity.v.toFixed(2));
await this.mqttHumidity.setState('state_topic', state.Humidity != null ? state.Humidity.v.toFixed(2) : 'None');
await this.mqttHumidity.writeConfig();
// `state.Current.v` always has a non-zero value, even for thermostats that are off, so we can't use it to determine initial power state.
@@ -242,7 +259,7 @@ export class Thermostat {
this.mqttClimate.currentHumidity = status.humidity;
this.mqttClimate.targetTemperature = this.mqttClimate.currentMode !== 'off' ? status.setPoint : undefined;
if (status.current != null) {
if (this.mysaDevice.Voltage != null && status.current != null) {
const watts = this.mysaDevice.Voltage * status.current;
await this.mqttPower.setState('state_topic', watts.toFixed(2));
} else {