Always set status for check as succesfull as we were able to start a job

Which means it passed hash check and e2e tests passed, so we can update those 2 checks to 'success'
This commit is contained in:
Volodymyr Zotov
2025-10-22 11:06:48 -05:00
parent bb4f5bdcb0
commit 04edd4dbfa

View File

@@ -35,7 +35,6 @@ jobs:
- uses: actions/github-script@v6 - uses: actions/github-script@v6
env: env:
ref: ${{ github.event.client_payload.pull_request.head.sha }} ref: ${{ github.event.client_payload.pull_request.head.sha }}
conclusion: ${{ needs.run-e2e-tests.result }}
with: with:
github-token: ${{ secrets.GITHUB_TOKEN }} github-token: ${{ secrets.GITHUB_TOKEN }}
script: | script: |
@@ -45,23 +44,23 @@ jobs:
}); });
// update the 'check-external-pr' check run // update the 'check-external-pr' check run
const check = checks.check_runs.filter(c => c.name === 'check-external-pr'); const externalCheck = checks.check_runs.filter(c => c.name === 'check-external-pr');
const { data: result } = await github.rest.checks.update({ const { data: result } = await github.rest.checks.update({
...context.repo, ...context.repo,
check_run_id: check[0].id, check_run_id: externalCheck[0].id,
status: 'completed', status: 'completed',
conclusion: process.env.conclusion conclusion: 'success'
}); });
// update the 'run-e2e-tests' check run from 'test-e2e.yml' workflow // update the 'run-e2e-tests' check run from 'test-e2e.yml' workflow
const check = checks.check_runs.filter(c => c.name === 'run-e2e-tests'); const e2eTestCheck = checks.check_runs.filter(c => c.name === 'run-e2e-tests');
const { data: result } = await github.rest.checks.update({ const { data: result } = await github.rest.checks.update({
...context.repo, ...context.repo,
check_run_id: check[0].id, check_run_id: e2eTestCheck[0].id,
status: 'completed', status: 'completed',
conclusion: process.env.conclusion conclusion: 'success'
}); });
return null; return null;