From 04edd4dbfadfe7dee2f134ea0e96bffef787d324 Mon Sep 17 00:00:00 2001
From: Volodymyr Zotov <volodymyr.zotov@agilebits.com>
Date: Wed, 22 Oct 2025 11:06:48 -0500
Subject: [PATCH] Always set status for check as succesfull as we were able to
 start a job

Which means it passed hash check and e2e tests passed, so we can update those 2 checks to 'success'
---
 .github/workflows/test-e2e-fork.yml | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/test-e2e-fork.yml b/.github/workflows/test-e2e-fork.yml
index 1b3dc7c..7e8aa68 100644
--- a/.github/workflows/test-e2e-fork.yml
+++ b/.github/workflows/test-e2e-fork.yml
@@ -35,7 +35,6 @@ jobs:
       - uses: actions/github-script@v6
         env:
           ref: ${{ github.event.client_payload.pull_request.head.sha }}
-          conclusion: ${{ needs.run-e2e-tests.result }}
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
@@ -45,23 +44,23 @@ jobs:
             });
 
             // update the 'check-external-pr' check run
-            const check = checks.check_runs.filter(c => c.name === 'check-external-pr');
+            const externalCheck = checks.check_runs.filter(c => c.name === 'check-external-pr');
 
             const { data: result } = await github.rest.checks.update({
               ...context.repo,
-              check_run_id: check[0].id,
+              check_run_id: externalCheck[0].id,
               status: 'completed',
-              conclusion: process.env.conclusion
+              conclusion: 'success'
             });
 
             // update the 'run-e2e-tests' check run from 'test-e2e.yml' workflow
-            const check = checks.check_runs.filter(c => c.name === 'run-e2e-tests');
+            const e2eTestCheck = checks.check_runs.filter(c => c.name === 'run-e2e-tests');
 
             const { data: result } = await github.rest.checks.update({
               ...context.repo,
-              check_run_id: check[0].id,
+              check_run_id: e2eTestCheck[0].id,
               status: 'completed',
-              conclusion: process.env.conclusion
+              conclusion: 'success'
             });
 
             return null;