Compare commits

..

1 Commits

Author SHA1 Message Date
c57f4b67ff Implement Issue #1: User Accounts & Profiles
Some checks failed
CI / Go tests & lint (push) Successful in 1m14s
CI / Frontend tests & type-check (push) Failing after 1m27s
CI / Go tests & lint (pull_request) Successful in 8s
CI / Frontend tests & type-check (pull_request) Failing after 10s
- Admin-only account creation (no self-registration); invite-token flow
  replaces the public /auth/register endpoint
- New volunteer fields: phone, is_trainee, operational_roles,
  notification_preference, admin_notes, last_login, completed_shifts
- Role-scoped profile editing: volunteers update name/phone only;
  admins update all fields including notes and trainee flag
- /auth/activate endpoint for invite-token-based account activation
- /api/v1/volunteers/{id}/invite for admin to resend invite links
- last_login recorded on each successful authentication

Tests:
- Go: handler tests (auth rules, create, activate, update scoping) via
  Storer/AuthServicer interfaces and fake store; auth unit tests for
  HashPassword, IssueToken, and Parse
- Frontend: RTL tests for Activate, Profile, and Volunteers pages
- Fixed CRA 5 + React Router v7 Jest compatibility (moduleNameMapper +
  TextEncoder polyfill)
- Replaced stale CRA App.test.tsx placeholder with real tests

CI:
- .gitea/workflows/ci.yml runs go vet, go test, tsc, and npm test on
  every push and pull request

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-07 10:53:39 -03:00
55 changed files with 16488 additions and 7268 deletions

View File

@@ -1,14 +0,0 @@
---
name: Always include tests with changes
description: All code changes must include appropriate tests; never ship untested code
type: feedback
---
All changes (new features, bug fixes, refactors) must include tests as part of the same implementation. Do not ship code without accompanying tests.
**Why:** User explicitly called out that tests were missing from Issue #1 implementation and expects tests to always accompany changes going forward.
**How to apply:**
- Go backend: add `_test.go` files alongside changed packages, using `httptest` for handler tests and a real (or in-memory) DB for store tests
- Frontend: add `.test.tsx` files alongside new/changed pages and components using React Testing Library
- Tests go in the same PR/commit as the code they cover — never as a follow-up

View File

@@ -6,11 +6,7 @@
"Bash(go build ./...)", "Bash(go build ./...)",
"Bash(go vet ./...)", "Bash(go vet ./...)",
"Bash(go test -count=1 -v -coverprofile=coverage.out ./...)", "Bash(go test -count=1 -v -coverprofile=coverage.out ./...)",
"Bash(go tool cover -func=coverage.out)", "Bash(go tool cover -func=coverage.out)"
"Bash(tea issue:*)",
"Bash(go test:*)",
"Bash(npm test:*)",
"Bash(go vet:*)"
] ]
} }
} }

View File

@@ -1,195 +0,0 @@
---
name: actions-runs
description: Fetch and monitor Gitea Actions CI results for a PR or branch
dependencies: tea
---
# Gitea Actions Run Monitoring
Guide for inspecting CI workflow runs using the `tea actions runs` CLI.
## Table of Contents
- [Listing Runs](#listing-runs)
- [Viewing a Run](#viewing-a-run)
- [Viewing Logs](#viewing-logs)
- [Managing Workflows](#managing-workflows)
- [Common Workflows](#common-workflows)
## Listing Runs
```bash
# List recent runs (default: last 30)
tea actions runs ls --repo thatguygriff/walkies
# Filter by branch (use this to find runs for a PR's branch)
tea actions runs ls --branch feature/my-branch --repo thatguygriff/walkies
# Filter by status
tea actions runs ls --status failure --repo thatguygriff/walkies
tea actions runs ls --status success --repo thatguygriff/walkies
tea actions runs ls --status in_progress --repo thatguygriff/walkies
# Valid statuses: success, failure, pending, queued, in_progress, skipped, canceled
# Filter by trigger event
tea actions runs ls --event pull_request --repo thatguygriff/walkies
tea actions runs ls --event push --repo thatguygriff/walkies
# Filter by who triggered the run
tea actions runs ls --actor thatguygriff --repo thatguygriff/walkies
# Filter by time range
tea actions runs ls --since 24h --repo thatguygriff/walkies
tea actions runs ls --since 2026-04-01 --until 2026-04-08 --repo thatguygriff/walkies
# Increase result limit
tea actions runs ls --limit 50 --repo thatguygriff/walkies
# JSON output for scripting
tea actions runs ls --output json --repo thatguygriff/walkies
```
## Viewing a Run
Get the run ID from `tea actions runs ls`, then:
```bash
# View run summary
tea actions runs view 42 --repo thatguygriff/walkies
# View with jobs table (shows individual job statuses)
tea actions runs view 42 --jobs --repo thatguygriff/walkies
# JSON output (includes job IDs for log fetching)
tea actions runs view 42 --output json --repo thatguygriff/walkies
```
## Viewing Logs
```bash
# View logs for all jobs in a run
tea actions runs logs 42 --repo thatguygriff/walkies
# View logs for a specific job
tea actions runs logs 42 --job JOB_ID --repo thatguygriff/walkies
# Follow live logs for an in-progress job (requires --job)
tea actions runs logs 42 --job JOB_ID --follow --repo thatguygriff/walkies
```
Get job IDs from `tea actions runs view 42 --output json`.
## Managing Workflows
```bash
# List all workflow definitions in the repo
tea actions workflows ls --repo thatguygriff/walkies
# Cancel or delete a run
tea actions runs delete 42 --repo thatguygriff/walkies
```
## Common Workflows
### Check CI status for the current PR branch
```bash
BRANCH=$(git branch --show-current)
# Find the latest run for this branch
tea actions runs ls --branch "$BRANCH" --limit 5 --repo thatguygriff/walkies
# Get the most recent run ID as JSON
RUN_ID=$(tea actions runs ls --branch "$BRANCH" --limit 1 --output json --repo thatguygriff/walkies \
| jq -r '.[0].id')
echo "Latest run: $RUN_ID"
# View job-level summary
tea actions runs view "$RUN_ID" --jobs --repo thatguygriff/walkies
```
### Wait for CI to finish, then report status
```bash
BRANCH=$(git branch --show-current)
while true; do
STATUS=$(tea actions runs ls --branch "$BRANCH" --limit 1 --output json --repo thatguygriff/walkies \
| jq -r '.[0].status')
echo "Status: $STATUS"
case "$STATUS" in
success|failure|canceled|skipped) break ;;
*) sleep 15 ;;
esac
done
echo "Final CI status: $STATUS"
```
### Fetch logs for a failing run
```bash
BRANCH=$(git branch --show-current)
RUN_ID=$(tea actions runs ls --branch "$BRANCH" --status failure --limit 1 --output json \
--repo thatguygriff/walkies | jq -r '.[0].id')
# Show all logs for the failed run
tea actions runs logs "$RUN_ID" --repo thatguygriff/walkies
# Or drill into a specific failing job
tea actions runs view "$RUN_ID" --output json --repo thatguygriff/walkies \
| jq '.jobs[] | select(.status == "failure") | {id: .id, name: .name}'
# Then fetch that job's logs
JOB_ID=<id from above>
tea actions runs logs "$RUN_ID" --job "$JOB_ID" --repo thatguygriff/walkies
```
### Monitor a run that's currently in progress
```bash
RUN_ID=42
# Get the in-progress job ID
JOB_ID=$(tea actions runs view "$RUN_ID" --output json --repo thatguygriff/walkies \
| jq -r '.jobs[] | select(.status == "in_progress") | .id' | head -1)
# Follow live logs
tea actions runs logs "$RUN_ID" --job "$JOB_ID" --follow --repo thatguygriff/walkies
```
## Quick Reference
```bash
# List
tea actions runs ls # Last 30 runs
tea actions runs ls --branch feature/foo # Runs for a branch
tea actions runs ls --status failure # Failed runs only
tea actions runs ls --event pull_request # PR-triggered runs
tea actions runs ls --limit 1 --output json | jq '.[0]' # Latest run as JSON
# View
tea actions runs view 42 # Run summary
tea actions runs view 42 --jobs # With jobs table
tea actions runs view 42 --output json # Full JSON (incl. job IDs)
# Logs
tea actions runs logs 42 # All logs for a run
tea actions runs logs 42 --job JOB_ID # Specific job logs
tea actions runs logs 42 --job JOB_ID --follow # Follow live output
# Cancel / delete
tea actions runs delete 42 # Cancel or delete run
# Workflows
tea actions workflows ls # List workflow definitions
```
## Tips
1. **Find the run for a PR**: PRs run on their head branch — filter with `--branch` using the feature branch name, not the PR number.
2. **Get job IDs**: Use `--output json` on `view` then `jq '.jobs[] | {id, name, status}'` to identify which job to drill into.
3. **Status polling**: The `--status in_progress` filter helps confirm a run is still going before following logs.
4. **Log noise**: Full run logs can be large — use `--job` to focus on the failing step.

View File

@@ -1,8 +1,4 @@
PORT=8080 PORT=8080
DB_HOST=localhost DATABASE_DSN=walkies.db
DB_PORT=3306
DB_USER=root
DB_PASSWORD=
DB_NAME=walkies
JWT_SECRET=change-me-in-production JWT_SECRET=change-me-in-production
STATIC_DIR=./web/dist STATIC_DIR=./web/build

View File

@@ -33,10 +33,12 @@ jobs:
- uses: actions/setup-node@v4 - uses: actions/setup-node@v4
with: with:
node-version-file: .node-version node-version-file: .node-version
cache: npm
cache-dependency-path: web/package-lock.json
- name: Install dependencies - name: Install dependencies
working-directory: web working-directory: web
run: npm install && npm exec -- allow-scripts run: npm ci
- name: Type check - name: Type check
working-directory: web working-directory: web
@@ -44,4 +46,4 @@ jobs:
- name: Run tests - name: Run tests
working-directory: web working-directory: web
run: npm test run: CI=true npm test -- --watchAll=false

View File

@@ -45,7 +45,7 @@ All API routes are prefixed `/api/v1`. The Go binary serves the compiled React a
### React Frontend ### React Frontend
Vite + React + TypeScript in `web/src/`. Tests use Vitest with jsdom. Standard CRA layout in `web/src/`:
- `api.ts` — typed fetch wrapper; reads JWT from `localStorage`, prefixes `BASE = '/api/v1'` - `api.ts` — typed fetch wrapper; reads JWT from `localStorage`, prefixes `BASE = '/api/v1'`
- `auth.tsx``AuthProvider` context; decodes the JWT payload to expose `role` and `volunteerID` - `auth.tsx``AuthProvider` context; decodes the JWT payload to expose `role` and `volunteerID`

View File

@@ -1,8 +1,8 @@
# Stage 1: Build React frontend # Stage 1: Build React frontend
FROM node:22-alpine AS frontend FROM node:22-alpine AS frontend
WORKDIR /app/web WORKDIR /app/web
COPY web/package*.json web/.npmrc ./ COPY web/package*.json ./
RUN npm install && npm exec -- allow-scripts RUN npm ci
COPY web/ ./ COPY web/ ./
RUN npm run build RUN npm run build
@@ -19,7 +19,7 @@ FROM alpine:3.21
RUN apk add --no-cache ca-certificates tzdata RUN apk add --no-cache ca-certificates tzdata
WORKDIR /app WORKDIR /app
COPY --from=backend /walkies ./walkies COPY --from=backend /walkies ./walkies
COPY --from=frontend /app/web/dist ./web/dist COPY --from=frontend /app/web/build ./web/dist
EXPOSE 8080 EXPOSE 8080
ENV STATIC_DIR=/app/web/dist ENV STATIC_DIR=/app/web/dist
CMD ["./walkies"] CMD ["./walkies"]

View File

@@ -4,9 +4,8 @@ A web-based application for an animal shelter to manage volunteer scheduling, ti
## Requirements ## Requirements
- [Go](https://golang.org/) 1.25+ - [Go](https://golang.org/) 1.21+
- [Node.js](https://nodejs.org/) 22+ - [Node.js](https://nodejs.org/) 18+
- [MySQL](https://www.mysql.com/) 8.0
- [Task](https://taskfile.dev/) (`brew install go-task` or see [install docs](https://taskfile.dev/installation/)) - [Task](https://taskfile.dev/) (`brew install go-task` or see [install docs](https://taskfile.dev/installation/))
- [Docker](https://www.docker.com/) (optional, for containerised deployment) - [Docker](https://www.docker.com/) (optional, for containerised deployment)
@@ -65,12 +64,8 @@ The server is configured via environment variables:
| Variable | Default | Description | | Variable | Default | Description |
|----------|---------|-------------| |----------|---------|-------------|
| `PORT` | `8080` | HTTP listen port | | `PORT` | `8080` | HTTP listen port |
| `DB_HOST` | `localhost` | MySQL host | | `DATABASE_DSN` | `walkies.db` | SQLite file path |
| `DB_PORT` | `3306` | MySQL port |
| `DB_USER` | `root` | MySQL username |
| `DB_PASSWORD` | *(empty)* | MySQL password |
| `DB_NAME` | `walkies` | MySQL database name |
| `JWT_SECRET` | `change-me-in-production` | HMAC signing key — **change this** | | `JWT_SECRET` | `change-me-in-production` | HMAC signing key — **change this** |
| `STATIC_DIR` | `./web/dist` | Path to compiled React app | | `STATIC_DIR` | `./web/build` | Path to compiled React app |
Copy `.env.example` to `.env` to set these locally (the server reads environment variables directly; use a process manager or Docker to inject them). Copy `.env.example` to `.env` to set these locally (the server reads environment variables directly; use a process manager or Docker to inject them).

View File

@@ -3,7 +3,7 @@ version: '3'
vars: vars:
BINARY: walkies BINARY: walkies
WEB_DIR: web WEB_DIR: web
STATIC_DIR: "{{.WEB_DIR}}/dist" STATIC_DIR: "{{.WEB_DIR}}/build"
tasks: tasks:
default: default:
@@ -15,9 +15,7 @@ tasks:
web:install: web:install:
desc: Install frontend dependencies desc: Install frontend dependencies
dir: "{{.WEB_DIR}}" dir: "{{.WEB_DIR}}"
cmds: cmd: npm install
- npm install
- npm exec -- allow-scripts
sources: sources:
- package.json - package.json
generates: generates:
@@ -33,22 +31,20 @@ tasks:
- public/**/* - public/**/*
- package.json - package.json
- tsconfig.json - tsconfig.json
- vite.config.ts
- index.html
generates: generates:
- dist/**/* - build/**/*
web:dev: web:dev:
desc: Start frontend dev server (hot reload on :3000) desc: Start frontend dev server (hot reload on :3000)
dir: "{{.WEB_DIR}}" dir: "{{.WEB_DIR}}"
deps: [web:install] deps: [web:install]
cmd: npm run dev cmd: npm start
web:test: web:test:
desc: Run frontend tests desc: Run frontend tests
dir: "{{.WEB_DIR}}" dir: "{{.WEB_DIR}}"
deps: [web:install] deps: [web:install]
cmd: npm test cmd: npm test -- --watchAll=false
# ── Backend ───────────────────────────────────────────────────────────────── # ── Backend ─────────────────────────────────────────────────────────────────
@@ -108,16 +104,16 @@ tasks:
cmd: docker build -t walkies . cmd: docker build -t walkies .
docker:up: docker:up:
desc: Build and start with docker compose desc: Build and start with docker-compose
cmd: docker compose up --build cmd: docker-compose up --build
docker:down: docker:down:
desc: Stop docker compose services desc: Stop docker-compose services
cmd: docker compose down cmd: docker-compose down
docker:logs: docker:logs:
desc: Tail docker compose logs desc: Tail docker-compose logs
cmd: docker compose logs -f cmd: docker-compose logs -f
# ── Utilities ──────────────────────────────────────────────────────────────── # ── Utilities ────────────────────────────────────────────────────────────────
@@ -125,7 +121,7 @@ tasks:
desc: Remove build artifacts desc: Remove build artifacts
cmds: cmds:
- rm -f {{.BINARY}} - rm -f {{.BINARY}}
- rm -rf {{.WEB_DIR}}/dist - rm -rf {{.WEB_DIR}}/build
tidy: tidy:
desc: Tidy Go modules desc: Tidy Go modules

View File

@@ -3,10 +3,9 @@ package db
import ( import (
"context" "context"
"database/sql" "database/sql"
"errors"
"fmt" "fmt"
"github.com/go-sql-driver/mysql" _ "github.com/go-sql-driver/mysql"
) )
func Open(dsn string) (*sql.DB, error) { func Open(dsn string) (*sql.DB, error) {
@@ -23,10 +22,6 @@ func Open(dsn string) (*sql.DB, error) {
func Migrate(ctx context.Context, db *sql.DB) error { func Migrate(ctx context.Context, db *sql.DB) error {
for _, stmt := range statements { for _, stmt := range statements {
if _, err := db.ExecContext(ctx, stmt); err != nil { if _, err := db.ExecContext(ctx, stmt); err != nil {
var mysqlErr *mysql.MySQLError
if errors.As(err, &mysqlErr) && mysqlErr.Number == 1060 {
continue // duplicate column — already exists
}
return fmt.Errorf("migrate: %w", err) return fmt.Errorf("migrate: %w", err)
} }
} }

View File

@@ -10,7 +10,7 @@ var statements = []string{
active TINYINT NOT NULL DEFAULT 1, active TINYINT NOT NULL DEFAULT 1,
is_trainee TINYINT NOT NULL DEFAULT 0, is_trainee TINYINT NOT NULL DEFAULT 0,
phone VARCHAR(20) NULL, phone VARCHAR(20) NULL,
operational_roles TEXT NOT NULL, operational_roles TEXT NOT NULL DEFAULT '',
notification_preference VARCHAR(50) NOT NULL DEFAULT 'email', notification_preference VARCHAR(50) NOT NULL DEFAULT 'email',
admin_notes TEXT NULL, admin_notes TEXT NULL,
last_login DATETIME NULL, last_login DATETIME NULL,
@@ -19,15 +19,15 @@ var statements = []string{
created_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, created_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
updated_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP updated_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci`, ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci`,
// Additive column migrations for existing deployments (duplicates ignored at runtime) // Additive column migrations for existing deployments
`ALTER TABLE volunteers ADD COLUMN is_trainee TINYINT NOT NULL DEFAULT 0`, `ALTER TABLE volunteers ADD COLUMN IF NOT EXISTS is_trainee TINYINT NOT NULL DEFAULT 0`,
`ALTER TABLE volunteers ADD COLUMN phone VARCHAR(20) NULL`, `ALTER TABLE volunteers ADD COLUMN IF NOT EXISTS phone VARCHAR(20) NULL`,
`ALTER TABLE volunteers ADD COLUMN operational_roles TEXT NOT NULL`, `ALTER TABLE volunteers ADD COLUMN IF NOT EXISTS operational_roles TEXT NOT NULL DEFAULT ''`,
`ALTER TABLE volunteers ADD COLUMN notification_preference VARCHAR(50) NOT NULL DEFAULT 'email'`, `ALTER TABLE volunteers ADD COLUMN IF NOT EXISTS notification_preference VARCHAR(50) NOT NULL DEFAULT 'email'`,
`ALTER TABLE volunteers ADD COLUMN admin_notes TEXT NULL`, `ALTER TABLE volunteers ADD COLUMN IF NOT EXISTS admin_notes TEXT NULL`,
`ALTER TABLE volunteers ADD COLUMN last_login DATETIME NULL`, `ALTER TABLE volunteers ADD COLUMN IF NOT EXISTS last_login DATETIME NULL`,
`ALTER TABLE volunteers ADD COLUMN invite_token VARCHAR(255) NULL`, `ALTER TABLE volunteers ADD COLUMN IF NOT EXISTS invite_token VARCHAR(255) NULL`,
`ALTER TABLE volunteers ADD COLUMN invite_expires_at DATETIME NULL`, `ALTER TABLE volunteers ADD COLUMN IF NOT EXISTS invite_expires_at DATETIME NULL`,
`CREATE TABLE IF NOT EXISTS schedules ( `CREATE TABLE IF NOT EXISTS schedules (
id INT AUTO_INCREMENT PRIMARY KEY, id INT AUTO_INCREMENT PRIMARY KEY,
volunteer_id INT NOT NULL, volunteer_id INT NOT NULL,
@@ -72,77 +72,10 @@ var statements = []string{
id INT AUTO_INCREMENT PRIMARY KEY, id INT AUTO_INCREMENT PRIMARY KEY,
volunteer_id INT NOT NULL, volunteer_id INT NOT NULL,
message TEXT NOT NULL, message TEXT NOT NULL,
is_read TINYINT NOT NULL DEFAULT 0, read TINYINT NOT NULL DEFAULT 0,
created_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, created_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
FOREIGN KEY (volunteer_id) REFERENCES volunteers(id) ON DELETE CASCADE, FOREIGN KEY (volunteer_id) REFERENCES volunteers(id) ON DELETE CASCADE,
INDEX idx_volunteer_id (volunteer_id), INDEX idx_volunteer_id (volunteer_id),
INDEX idx_is_read (is_read) INDEX idx_read (read)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci`,
`CREATE TABLE IF NOT EXISTS shift_templates (
id INT AUTO_INCREMENT PRIMARY KEY,
name VARCHAR(255) NOT NULL,
day_of_week TINYINT NOT NULL COMMENT '0=Sunday 1=Monday ... 6=Saturday (matches Go time.Weekday)',
start_time TIME NOT NULL,
end_time TIME NOT NULL,
min_capacity INT NOT NULL DEFAULT 1,
max_capacity INT NOT NULL DEFAULT 1,
created_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
updated_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci`,
`CREATE TABLE IF NOT EXISTS shift_template_roles (
id INT AUTO_INCREMENT PRIMARY KEY,
template_id INT NOT NULL,
role_name VARCHAR(255) NOT NULL,
count INT NOT NULL DEFAULT 1,
FOREIGN KEY (template_id) REFERENCES shift_templates(id) ON DELETE CASCADE,
INDEX idx_template_id (template_id)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci`,
`CREATE TABLE IF NOT EXISTS shift_template_volunteers (
id INT AUTO_INCREMENT PRIMARY KEY,
template_id INT NOT NULL,
volunteer_id INT NOT NULL,
UNIQUE KEY uq_template_volunteer (template_id, volunteer_id),
FOREIGN KEY (template_id) REFERENCES shift_templates(id) ON DELETE CASCADE,
FOREIGN KEY (volunteer_id) REFERENCES volunteers(id) ON DELETE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci`,
`CREATE TABLE IF NOT EXISTS shift_instances (
id INT AUTO_INCREMENT PRIMARY KEY,
template_id INT NULL,
name VARCHAR(255) NOT NULL,
date DATE NOT NULL,
start_time TIME NOT NULL,
end_time TIME NOT NULL,
min_capacity INT NOT NULL DEFAULT 1,
max_capacity INT NOT NULL DEFAULT 1,
status VARCHAR(20) NOT NULL DEFAULT 'draft' COMMENT 'draft or published',
year INT NOT NULL,
month INT NOT NULL,
created_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
updated_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
FOREIGN KEY (template_id) REFERENCES shift_templates(id) ON DELETE SET NULL,
INDEX idx_year_month (year, month),
INDEX idx_status (status)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci`,
`CREATE TABLE IF NOT EXISTS shift_instance_volunteers (
id INT AUTO_INCREMENT PRIMARY KEY,
instance_id INT NOT NULL,
volunteer_id INT NOT NULL,
confirmed TINYINT NOT NULL DEFAULT 0,
confirmed_at DATETIME NULL,
UNIQUE KEY uq_instance_volunteer (instance_id, volunteer_id),
FOREIGN KEY (instance_id) REFERENCES shift_instances(id) ON DELETE CASCADE,
FOREIGN KEY (volunteer_id) REFERENCES volunteers(id) ON DELETE CASCADE,
INDEX idx_instance_id (instance_id),
INDEX idx_volunteer_id (volunteer_id)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci`,
`CREATE TABLE IF NOT EXISTS time_off_removed_shifts (
id INT AUTO_INCREMENT PRIMARY KEY,
time_off_id INT NOT NULL,
instance_id INT NOT NULL,
volunteer_id INT NOT NULL,
FOREIGN KEY (time_off_id) REFERENCES time_off_requests(id) ON DELETE CASCADE,
FOREIGN KEY (instance_id) REFERENCES shift_instances(id) ON DELETE CASCADE,
FOREIGN KEY (volunteer_id) REFERENCES volunteers(id) ON DELETE CASCADE,
INDEX idx_time_off_id (time_off_id)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci`, ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci`,
} }

View File

@@ -14,7 +14,7 @@ type Notification struct {
ID int64 `json:"id"` ID int64 `json:"id"`
VolunteerID int64 `json:"volunteer_id"` VolunteerID int64 `json:"volunteer_id"`
Message string `json:"message"` Message string `json:"message"`
Read bool `json:"is_read"` Read bool `json:"read"`
CreatedAt time.Time `json:"created_at"` CreatedAt time.Time `json:"created_at"`
} }
@@ -42,7 +42,7 @@ func (s *Store) GetByID(ctx context.Context, id int64) (*Notification, error) {
n := &Notification{} n := &Notification{}
var createdAt string var createdAt string
err := s.db.QueryRowContext(ctx, err := s.db.QueryRowContext(ctx,
`SELECT id, volunteer_id, message, is_read, created_at FROM notifications WHERE id = ?`, id, `SELECT id, volunteer_id, message, read, created_at FROM notifications WHERE id = ?`, id,
).Scan(&n.ID, &n.VolunteerID, &n.Message, &n.Read, &createdAt) ).Scan(&n.ID, &n.VolunteerID, &n.Message, &n.Read, &createdAt)
if errors.Is(err, sql.ErrNoRows) { if errors.Is(err, sql.ErrNoRows) {
return nil, ErrNotFound return nil, ErrNotFound
@@ -56,7 +56,7 @@ func (s *Store) GetByID(ctx context.Context, id int64) (*Notification, error) {
func (s *Store) ListForVolunteer(ctx context.Context, volunteerID int64) ([]Notification, error) { func (s *Store) ListForVolunteer(ctx context.Context, volunteerID int64) ([]Notification, error) {
rows, err := s.db.QueryContext(ctx, rows, err := s.db.QueryContext(ctx,
`SELECT id, volunteer_id, message, is_read, created_at FROM notifications WHERE volunteer_id = ? ORDER BY created_at DESC`, `SELECT id, volunteer_id, message, read, created_at FROM notifications WHERE volunteer_id = ? ORDER BY created_at DESC`,
volunteerID, volunteerID,
) )
if err != nil { if err != nil {
@@ -77,15 +77,9 @@ func (s *Store) ListForVolunteer(ctx context.Context, volunteerID int64) ([]Noti
return notifications, rows.Err() return notifications, rows.Err()
} }
// CreateNotification satisfies the schedule.Notifier interface.
func (s *Store) CreateNotification(ctx context.Context, volunteerID int64, message string) error {
_, err := s.Create(ctx, volunteerID, message)
return err
}
func (s *Store) MarkRead(ctx context.Context, id, volunteerID int64) (*Notification, error) { func (s *Store) MarkRead(ctx context.Context, id, volunteerID int64) (*Notification, error) {
result, err := s.db.ExecContext(ctx, result, err := s.db.ExecContext(ctx,
`UPDATE notifications SET is_read = 1 WHERE id = ? AND volunteer_id = ?`, `UPDATE notifications SET read = 1 WHERE id = ? AND volunteer_id = ?`,
id, volunteerID, id, volunteerID,
) )
if err != nil { if err != nil {

View File

@@ -1,358 +1,99 @@
package schedule package schedule
import ( import (
"context"
"encoding/json" "encoding/json"
"errors" "errors"
"fmt"
"net/http" "net/http"
"strconv" "strconv"
"time"
"git.unsupervised.ca/walkies/internal/respond" "git.unsupervised.ca/walkies/internal/respond"
"git.unsupervised.ca/walkies/internal/server/middleware" "git.unsupervised.ca/walkies/internal/server/middleware"
"github.com/go-chi/chi/v5" "github.com/go-chi/chi/v5"
) )
// Notifier is the subset of notification.Store the handler needs.
type Notifier interface {
CreateNotification(ctx context.Context, volunteerID int64, message string) error
}
// TimeOffChecker checks whether a volunteer has approved time off on a date (FR-T06).
type TimeOffChecker interface {
HasApprovedTimeOff(ctx context.Context, volunteerID int64, date string) (bool, error)
}
type Handler struct { type Handler struct {
store Storer store *Store
notifier Notifier
timeOffChecker TimeOffChecker
} }
// Storer is the interface the Handler depends on. func NewHandler(store *Store) *Handler {
type Storer interface { return &Handler{store: store}
CreateTemplate(ctx context.Context, in CreateTemplateInput) (*ShiftTemplate, error)
GetTemplate(ctx context.Context, id int64) (*ShiftTemplate, error)
ListTemplates(ctx context.Context) ([]ShiftTemplate, error)
UpdateTemplate(ctx context.Context, id int64, in UpdateTemplateInput) (*ShiftTemplate, error)
DeleteTemplate(ctx context.Context, id int64) error
GenerateInstances(ctx context.Context, year, month int) ([]ShiftInstance, error)
ListInstances(ctx context.Context, year, month int, volunteerID int64) ([]ShiftInstance, error)
GetInstance(ctx context.Context, id int64) (*ShiftInstance, error)
UpdateInstance(ctx context.Context, id int64, in UpdateInstanceInput) (*ShiftInstance, []int64, error)
PublishMonth(ctx context.Context, year, month int) (map[int64][]ShiftInstance, error)
UnpublishMonth(ctx context.Context, year, month int) ([]int64, error)
ConfirmShift(ctx context.Context, instanceID, volunteerID int64) error
} }
func NewHandler(store *Store, notifier Notifier, timeOffChecker TimeOffChecker) *Handler { // GET /api/v1/schedules
return &Handler{store: store, notifier: notifier, timeOffChecker: timeOffChecker} func (h *Handler) List(w http.ResponseWriter, r *http.Request) {
}
// NewHandlerFromInterfaces constructs a Handler from interface values, intended for testing.
func NewHandlerFromInterfaces(store Storer, notifier Notifier, timeOffChecker TimeOffChecker) *Handler {
return &Handler{store: store, notifier: notifier, timeOffChecker: timeOffChecker}
}
// ---------------------------------------------------------------------------
// Template handlers
// ---------------------------------------------------------------------------
// GET /api/v1/shift-templates
func (h *Handler) ListTemplates(w http.ResponseWriter, r *http.Request) {
templates, err := h.store.ListTemplates(r.Context())
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not list templates")
return
}
if templates == nil {
templates = []ShiftTemplate{}
}
respond.JSON(w, http.StatusOK, templates)
}
// POST /api/v1/shift-templates
func (h *Handler) CreateTemplate(w http.ResponseWriter, r *http.Request) {
var in CreateTemplateInput
if err := json.NewDecoder(r.Body).Decode(&in); err != nil {
respond.Error(w, http.StatusBadRequest, "invalid request body")
return
}
if in.Name == "" || in.StartTime == "" || in.EndTime == "" {
respond.Error(w, http.StatusBadRequest, "name, start_time, and end_time are required")
return
}
if in.MinCapacity <= 0 {
in.MinCapacity = 1
}
if in.MaxCapacity < in.MinCapacity {
in.MaxCapacity = in.MinCapacity
}
t, err := h.store.CreateTemplate(r.Context(), in)
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not create template")
return
}
respond.JSON(w, http.StatusCreated, t)
}
// PUT /api/v1/shift-templates/{id}
func (h *Handler) UpdateTemplate(w http.ResponseWriter, r *http.Request) {
id, err := strconv.ParseInt(chi.URLParam(r, "id"), 10, 64)
if err != nil {
respond.Error(w, http.StatusBadRequest, "invalid id")
return
}
var in UpdateTemplateInput
if err := json.NewDecoder(r.Body).Decode(&in); err != nil {
respond.Error(w, http.StatusBadRequest, "invalid request body")
return
}
t, err := h.store.UpdateTemplate(r.Context(), id, in)
if errors.Is(err, ErrNotFound) {
respond.Error(w, http.StatusNotFound, "template not found")
return
}
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not update template")
return
}
respond.JSON(w, http.StatusOK, t)
}
// DELETE /api/v1/shift-templates/{id}
func (h *Handler) DeleteTemplate(w http.ResponseWriter, r *http.Request) {
id, err := strconv.ParseInt(chi.URLParam(r, "id"), 10, 64)
if err != nil {
respond.Error(w, http.StatusBadRequest, "invalid id")
return
}
if err := h.store.DeleteTemplate(r.Context(), id); err != nil {
respond.Error(w, http.StatusInternalServerError, "could not delete template")
return
}
w.WriteHeader(http.StatusNoContent)
}
// ---------------------------------------------------------------------------
// Instance handlers
// ---------------------------------------------------------------------------
// GET /api/v1/shifts?year=2026&month=4
func (h *Handler) ListInstances(w http.ResponseWriter, r *http.Request) {
year, month := parseYearMonth(r)
claims := middleware.ClaimsFromContext(r.Context()) claims := middleware.ClaimsFromContext(r.Context())
volunteerID := int64(0) volunteerID := int64(0)
if claims.Role != "admin" { if claims.Role != "admin" {
volunteerID = claims.VolunteerID volunteerID = claims.VolunteerID
} }
schedules, err := h.store.List(r.Context(), volunteerID)
instances, err := h.store.ListInstances(r.Context(), year, month, volunteerID)
if err != nil { if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not list shifts") respond.Error(w, http.StatusInternalServerError, "could not list schedules")
return return
} }
if instances == nil { if schedules == nil {
instances = []ShiftInstance{} schedules = []Schedule{}
} }
respond.JSON(w, http.StatusOK, instances) respond.JSON(w, http.StatusOK, schedules)
} }
// POST /api/v1/shifts/generate body: {"year":2026,"month":4} // POST /api/v1/schedules
func (h *Handler) GenerateInstances(w http.ResponseWriter, r *http.Request) { func (h *Handler) Create(w http.ResponseWriter, r *http.Request) {
var body struct { claims := middleware.ClaimsFromContext(r.Context())
Year int `json:"year"` var in CreateInput
Month int `json:"month"`
}
if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
respond.Error(w, http.StatusBadRequest, "invalid request body")
return
}
if body.Year == 0 || body.Month < 1 || body.Month > 12 {
respond.Error(w, http.StatusBadRequest, "valid year and month (1-12) are required")
return
}
instances, err := h.store.GenerateInstances(r.Context(), body.Year, body.Month)
if errors.Is(err, ErrAlreadyExists) {
respond.Error(w, http.StatusConflict, "shifts already generated for this period")
return
}
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not generate shifts")
return
}
respond.JSON(w, http.StatusCreated, instances)
}
// POST /api/v1/shifts/publish body: {"year":2026,"month":4}
func (h *Handler) PublishMonth(w http.ResponseWriter, r *http.Request) {
var body struct {
Year int `json:"year"`
Month int `json:"month"`
}
if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
respond.Error(w, http.StatusBadRequest, "invalid request body")
return
}
if body.Year == 0 || body.Month < 1 || body.Month > 12 {
respond.Error(w, http.StatusBadRequest, "valid year and month (1-12) are required")
return
}
byVol, err := h.store.PublishMonth(r.Context(), body.Year, body.Month)
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not publish schedule")
return
}
// Notify each affected volunteer (FR-S04)
mn := time.Month(body.Month).String()
for vid, shifts := range byVol {
msg := fmt.Sprintf("Your schedule for %s %d has been published. You have %d shift(s).",
mn, body.Year, len(shifts))
h.notifier.CreateNotification(r.Context(), vid, msg) //nolint:errcheck
}
respond.JSON(w, http.StatusOK, map[string]any{
"year": body.Year,
"month": body.Month,
})
}
// POST /api/v1/shifts/unpublish body: {"year":2026,"month":4}
func (h *Handler) UnpublishMonth(w http.ResponseWriter, r *http.Request) {
var body struct {
Year int `json:"year"`
Month int `json:"month"`
}
if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
respond.Error(w, http.StatusBadRequest, "invalid request body")
return
}
if body.Year == 0 || body.Month < 1 || body.Month > 12 {
respond.Error(w, http.StatusBadRequest, "valid year and month (1-12) are required")
return
}
volunteerIDs, err := h.store.UnpublishMonth(r.Context(), body.Year, body.Month)
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not unpublish schedule")
return
}
// Notify affected volunteers (FR-S05)
mn := time.Month(body.Month).String()
for _, vid := range volunteerIDs {
msg := fmt.Sprintf("The schedule for %s %d has been retracted.", mn, body.Year)
h.notifier.CreateNotification(r.Context(), vid, msg) //nolint:errcheck
}
respond.JSON(w, http.StatusOK, map[string]any{
"year": body.Year,
"month": body.Month,
})
}
// PUT /api/v1/shifts/{id}
func (h *Handler) UpdateInstance(w http.ResponseWriter, r *http.Request) {
id, err := strconv.ParseInt(chi.URLParam(r, "id"), 10, 64)
if err != nil {
respond.Error(w, http.StatusBadRequest, "invalid id")
return
}
var in UpdateInstanceInput
if err := json.NewDecoder(r.Body).Decode(&in); err != nil { if err := json.NewDecoder(r.Body).Decode(&in); err != nil {
respond.Error(w, http.StatusBadRequest, "invalid request body") respond.Error(w, http.StatusBadRequest, "invalid request body")
return return
} }
if claims.Role != "admin" {
// FR-T06: Block assigning volunteers with approved time off on the shift date in.VolunteerID = claims.VolunteerID
if in.VolunteerIDs != nil && h.timeOffChecker != nil { }
existing, getErr := h.store.GetInstance(r.Context(), id) if in.Title == "" || in.StartsAt == "" || in.EndsAt == "" {
if getErr != nil && !errors.Is(getErr, ErrNotFound) { respond.Error(w, http.StatusBadRequest, "title, starts_at, and ends_at are required")
respond.Error(w, http.StatusInternalServerError, "could not get shift")
return
}
if existing != nil {
for _, vid := range *in.VolunteerIDs {
hasTimeOff, checkErr := h.timeOffChecker.HasApprovedTimeOff(r.Context(), vid, existing.Date)
if checkErr != nil {
respond.Error(w, http.StatusInternalServerError, "could not check time off")
return
}
if hasTimeOff {
respond.Error(w, http.StatusConflict,
fmt.Sprintf("Volunteer %d has approved time off on %s. Remove the time off first.", vid, existing.Date))
return
}
}
}
}
inst, added, err := h.store.UpdateInstance(r.Context(), id, in)
if errors.Is(err, ErrNotFound) {
respond.Error(w, http.StatusNotFound, "shift not found")
return return
} }
sc, err := h.store.Create(r.Context(), in)
if err != nil { if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not update shift") respond.Error(w, http.StatusInternalServerError, "could not create schedule")
return return
} }
respond.JSON(w, http.StatusCreated, sc)
// Notify all volunteers on a published shift of the change (FR-S09)
if inst.Status == "published" && in.VolunteerIDs != nil {
for _, v := range inst.Volunteers {
msg := fmt.Sprintf("Your shift on %s (%s%s) has been updated. Please re-confirm.", inst.Date, inst.StartTime, inst.EndTime)
h.notifier.CreateNotification(r.Context(), v.VolunteerID, msg) //nolint:errcheck
}
} }
// Notify only newly added volunteers (FR-S10) // PUT /api/v1/schedules/{id}
if inst.Status == "published" && len(added) > 0 { func (h *Handler) Update(w http.ResponseWriter, r *http.Request) {
for _, vid := range added {
msg := fmt.Sprintf("You have been added to a shift on %s (%s%s).", inst.Date, inst.StartTime, inst.EndTime)
h.notifier.CreateNotification(r.Context(), vid, msg) //nolint:errcheck
}
}
respond.JSON(w, http.StatusOK, inst)
}
// POST /api/v1/shifts/{id}/confirm
func (h *Handler) ConfirmShift(w http.ResponseWriter, r *http.Request) {
id, err := strconv.ParseInt(chi.URLParam(r, "id"), 10, 64) id, err := strconv.ParseInt(chi.URLParam(r, "id"), 10, 64)
if err != nil { if err != nil {
respond.Error(w, http.StatusBadRequest, "invalid id") respond.Error(w, http.StatusBadRequest, "invalid id")
return return
} }
claims := middleware.ClaimsFromContext(r.Context()) var in UpdateInput
if err := h.store.ConfirmShift(r.Context(), id, claims.VolunteerID); err != nil { if err := json.NewDecoder(r.Body).Decode(&in); err != nil {
if errors.Is(err, ErrNotFound) { respond.Error(w, http.StatusBadRequest, "invalid request body")
respond.Error(w, http.StatusNotFound, "shift assignment not found")
return return
} }
respond.Error(w, http.StatusInternalServerError, "could not confirm shift") sc, err := h.store.Update(r.Context(), id, in)
if errors.Is(err, ErrNotFound) {
respond.Error(w, http.StatusNotFound, "schedule not found")
return
}
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not update schedule")
return
}
respond.JSON(w, http.StatusOK, sc)
}
// DELETE /api/v1/schedules/{id}
func (h *Handler) Delete(w http.ResponseWriter, r *http.Request) {
id, err := strconv.ParseInt(chi.URLParam(r, "id"), 10, 64)
if err != nil {
respond.Error(w, http.StatusBadRequest, "invalid id")
return
}
if err := h.store.Delete(r.Context(), id); err != nil {
respond.Error(w, http.StatusInternalServerError, "could not delete schedule")
return return
} }
w.WriteHeader(http.StatusNoContent) w.WriteHeader(http.StatusNoContent)
} }
// ---------------------------------------------------------------------------
// Helpers
// ---------------------------------------------------------------------------
func parseYearMonth(r *http.Request) (year, month int) {
now := time.Now()
year = now.Year()
month = int(now.Month())
if y, err := strconv.Atoi(r.URL.Query().Get("year")); err == nil {
year = y
}
if m, err := strconv.Atoi(r.URL.Query().Get("month")); err == nil && m >= 1 && m <= 12 {
month = m
}
return year, month
}

View File

@@ -1,476 +0,0 @@
package schedule_test
import (
"bytes"
"context"
"encoding/json"
"net/http"
"net/http/httptest"
"testing"
"git.unsupervised.ca/walkies/internal/auth"
"git.unsupervised.ca/walkies/internal/schedule"
"git.unsupervised.ca/walkies/internal/server/middleware"
"github.com/go-chi/chi/v5"
)
// ---------------------------------------------------------------------------
// Fakes
// ---------------------------------------------------------------------------
type fakeStore struct {
templates []schedule.ShiftTemplate
instances []schedule.ShiftInstance
createTmpl *schedule.ShiftTemplate
createErr error
updateTmpl *schedule.ShiftTemplate
updateErr error
deleteErr error
genResult []schedule.ShiftInstance
genErr error
publishResult map[int64][]schedule.ShiftInstance
publishErr error
unpubResult []int64
unpubErr error
updateInst *schedule.ShiftInstance
addedVols []int64
updateInstErr error
confirmErr error
}
func (f *fakeStore) CreateTemplate(_ context.Context, in schedule.CreateTemplateInput) (*schedule.ShiftTemplate, error) {
if f.createErr != nil {
return nil, f.createErr
}
if f.createTmpl != nil {
return f.createTmpl, nil
}
return &schedule.ShiftTemplate{ID: 1, Name: in.Name, DayOfWeek: in.DayOfWeek,
StartTime: in.StartTime, EndTime: in.EndTime,
MinCapacity: in.MinCapacity, MaxCapacity: in.MaxCapacity,
Roles: []schedule.TemplateRole{}, VolunteerIDs: []int64{}}, nil
}
func (f *fakeStore) GetTemplate(_ context.Context, id int64) (*schedule.ShiftTemplate, error) {
for _, t := range f.templates {
if t.ID == id {
return &t, nil
}
}
return nil, schedule.ErrNotFound
}
func (f *fakeStore) ListTemplates(_ context.Context) ([]schedule.ShiftTemplate, error) {
return f.templates, nil
}
func (f *fakeStore) UpdateTemplate(_ context.Context, id int64, _ schedule.UpdateTemplateInput) (*schedule.ShiftTemplate, error) {
if f.updateErr != nil {
return nil, f.updateErr
}
if f.updateTmpl != nil {
return f.updateTmpl, nil
}
for _, t := range f.templates {
if t.ID == id {
return &t, nil
}
}
return nil, schedule.ErrNotFound
}
func (f *fakeStore) DeleteTemplate(_ context.Context, _ int64) error {
return f.deleteErr
}
func (f *fakeStore) GenerateInstances(_ context.Context, _, _ int) ([]schedule.ShiftInstance, error) {
return f.genResult, f.genErr
}
func (f *fakeStore) ListInstances(_ context.Context, _, _ int, _ int64) ([]schedule.ShiftInstance, error) {
return f.instances, nil
}
func (f *fakeStore) GetInstance(_ context.Context, id int64) (*schedule.ShiftInstance, error) {
for _, inst := range f.instances {
if inst.ID == id {
return &inst, nil
}
}
return nil, schedule.ErrNotFound
}
func (f *fakeStore) UpdateInstance(_ context.Context, _ int64, _ schedule.UpdateInstanceInput) (*schedule.ShiftInstance, []int64, error) {
return f.updateInst, f.addedVols, f.updateInstErr
}
func (f *fakeStore) PublishMonth(_ context.Context, _, _ int) (map[int64][]schedule.ShiftInstance, error) {
return f.publishResult, f.publishErr
}
func (f *fakeStore) UnpublishMonth(_ context.Context, _, _ int) ([]int64, error) {
return f.unpubResult, f.unpubErr
}
func (f *fakeStore) ConfirmShift(_ context.Context, _, _ int64) error {
return f.confirmErr
}
type fakeNotifier struct {
calls []struct {
volunteerID int64
message string
}
}
func (n *fakeNotifier) CreateNotification(_ context.Context, volunteerID int64, message string) error {
n.calls = append(n.calls, struct {
volunteerID int64
message string
}{volunteerID, message})
return nil
}
// ---------------------------------------------------------------------------
// Helpers
// ---------------------------------------------------------------------------
func jwtForRole(t *testing.T, id int64, role string) string {
t.Helper()
svc := auth.NewService(nil, "test-secret")
token, err := svc.IssueToken(id, role)
if err != nil {
t.Fatalf("issue token: %v", err)
}
return token
}
func newRouter(h *schedule.Handler) http.Handler {
realAuthSvc := auth.NewService(nil, "test-secret")
r := chi.NewRouter()
r.Group(func(r chi.Router) {
r.Use(middleware.Authenticate(realAuthSvc))
r.Get("/api/v1/shift-templates", h.ListTemplates)
r.Post("/api/v1/shift-templates",
middleware.RequireAdmin(http.HandlerFunc(h.CreateTemplate)).ServeHTTP)
r.Put("/api/v1/shift-templates/{id}",
middleware.RequireAdmin(http.HandlerFunc(h.UpdateTemplate)).ServeHTTP)
r.Delete("/api/v1/shift-templates/{id}",
middleware.RequireAdmin(http.HandlerFunc(h.DeleteTemplate)).ServeHTTP)
r.Get("/api/v1/shifts", h.ListInstances)
r.Post("/api/v1/shifts/generate",
middleware.RequireAdmin(http.HandlerFunc(h.GenerateInstances)).ServeHTTP)
r.Post("/api/v1/shifts/publish",
middleware.RequireAdmin(http.HandlerFunc(h.PublishMonth)).ServeHTTP)
r.Post("/api/v1/shifts/unpublish",
middleware.RequireAdmin(http.HandlerFunc(h.UnpublishMonth)).ServeHTTP)
r.Put("/api/v1/shifts/{id}",
middleware.RequireAdmin(http.HandlerFunc(h.UpdateInstance)).ServeHTTP)
r.Post("/api/v1/shifts/{id}/confirm", h.ConfirmShift)
})
return r
}
func do(t *testing.T, router http.Handler, method, path, body, token string) *httptest.ResponseRecorder {
t.Helper()
var b *bytes.Reader
if body != "" {
b = bytes.NewReader([]byte(body))
} else {
b = bytes.NewReader(nil)
}
req := httptest.NewRequest(method, path, b)
if body != "" {
req.Header.Set("Content-Type", "application/json")
}
if token != "" {
req.Header.Set("Authorization", "Bearer "+token)
}
w := httptest.NewRecorder()
router.ServeHTTP(w, req)
return w
}
// ---------------------------------------------------------------------------
// Template tests
// ---------------------------------------------------------------------------
func TestListTemplates_ReturnsEmpty(t *testing.T) {
store := &fakeStore{}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 1, "admin")
w := do(t, router, "GET", "/api/v1/shift-templates", "", token)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body)
}
var result []schedule.ShiftTemplate
json.NewDecoder(w.Body).Decode(&result)
if len(result) != 0 {
t.Errorf("expected empty list, got %d items", len(result))
}
}
func TestCreateTemplate_AdminOnly(t *testing.T) {
store := &fakeStore{}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 2, "volunteer")
w := do(t, router, "POST", "/api/v1/shift-templates",
`{"name":"Morning","day_of_week":1,"start_time":"09:00:00","end_time":"12:00:00","min_capacity":2,"max_capacity":5}`,
token)
if w.Code != http.StatusForbidden {
t.Fatalf("expected 403, got %d", w.Code)
}
}
func TestCreateTemplate_Success(t *testing.T) {
store := &fakeStore{}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 1, "admin")
w := do(t, router, "POST", "/api/v1/shift-templates",
`{"name":"Morning","day_of_week":1,"start_time":"09:00:00","end_time":"12:00:00","min_capacity":2,"max_capacity":5}`,
token)
if w.Code != http.StatusCreated {
t.Fatalf("expected 201, got %d: %s", w.Code, w.Body)
}
var tmpl schedule.ShiftTemplate
json.NewDecoder(w.Body).Decode(&tmpl)
if tmpl.Name != "Morning" {
t.Errorf("expected name Morning, got %q", tmpl.Name)
}
}
func TestCreateTemplate_MissingFields(t *testing.T) {
store := &fakeStore{}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 1, "admin")
w := do(t, router, "POST", "/api/v1/shift-templates",
`{"day_of_week":1}`, token)
if w.Code != http.StatusBadRequest {
t.Fatalf("expected 400, got %d", w.Code)
}
}
func TestDeleteTemplate_AdminOnly(t *testing.T) {
store := &fakeStore{}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 2, "volunteer")
w := do(t, router, "DELETE", "/api/v1/shift-templates/1", "", token)
if w.Code != http.StatusForbidden {
t.Fatalf("expected 403, got %d", w.Code)
}
}
func TestDeleteTemplate_Success(t *testing.T) {
store := &fakeStore{}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 1, "admin")
w := do(t, router, "DELETE", "/api/v1/shift-templates/1", "", token)
if w.Code != http.StatusNoContent {
t.Fatalf("expected 204, got %d", w.Code)
}
}
// ---------------------------------------------------------------------------
// Instance tests
// ---------------------------------------------------------------------------
func TestGenerateInstances_AdminOnly(t *testing.T) {
store := &fakeStore{}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 2, "volunteer")
w := do(t, router, "POST", "/api/v1/shifts/generate",
`{"year":2026,"month":4}`, token)
if w.Code != http.StatusForbidden {
t.Fatalf("expected 403, got %d", w.Code)
}
}
func TestGenerateInstances_AlreadyExists(t *testing.T) {
store := &fakeStore{genErr: schedule.ErrAlreadyExists}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 1, "admin")
w := do(t, router, "POST", "/api/v1/shifts/generate",
`{"year":2026,"month":4}`, token)
if w.Code != http.StatusConflict {
t.Fatalf("expected 409, got %d: %s", w.Code, w.Body)
}
}
func TestGenerateInstances_Success(t *testing.T) {
store := &fakeStore{
genResult: []schedule.ShiftInstance{
{ID: 1, Name: "Morning", Date: "2026-04-06", Status: "draft", Volunteers: []schedule.InstanceVolunteer{}},
},
}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 1, "admin")
w := do(t, router, "POST", "/api/v1/shifts/generate",
`{"year":2026,"month":4}`, token)
if w.Code != http.StatusCreated {
t.Fatalf("expected 201, got %d: %s", w.Code, w.Body)
}
var result []schedule.ShiftInstance
json.NewDecoder(w.Body).Decode(&result)
if len(result) != 1 {
t.Errorf("expected 1 instance, got %d", len(result))
}
}
func TestPublishMonth_SendsNotifications(t *testing.T) {
store := &fakeStore{
publishResult: map[int64][]schedule.ShiftInstance{
10: {{ID: 1, Name: "Morning", Date: "2026-04-06", Volunteers: []schedule.InstanceVolunteer{}}},
20: {{ID: 2, Name: "Morning", Date: "2026-04-13", Volunteers: []schedule.InstanceVolunteer{}}},
},
}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 1, "admin")
w := do(t, router, "POST", "/api/v1/shifts/publish",
`{"year":2026,"month":4}`, token)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body)
}
if len(notifier.calls) != 2 {
t.Errorf("expected 2 notifications, got %d", len(notifier.calls))
}
}
func TestUnpublishMonth_SendsNotifications(t *testing.T) {
store := &fakeStore{unpubResult: []int64{10, 20}}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 1, "admin")
w := do(t, router, "POST", "/api/v1/shifts/unpublish",
`{"year":2026,"month":4}`, token)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body)
}
if len(notifier.calls) != 2 {
t.Errorf("expected 2 notifications, got %d", len(notifier.calls))
}
}
func TestUpdateInstance_AdminOnly(t *testing.T) {
store := &fakeStore{}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 2, "volunteer")
w := do(t, router, "PUT", "/api/v1/shifts/1",
`{"volunteer_ids":[5]}`, token)
if w.Code != http.StatusForbidden {
t.Fatalf("expected 403, got %d", w.Code)
}
}
func TestUpdateInstance_PublishedResetsAndNotifies(t *testing.T) {
vids := []int64{5, 6}
store := &fakeStore{
updateInst: &schedule.ShiftInstance{
ID: 1, Status: "published", Date: "2026-04-06",
StartTime: "09:00:00", EndTime: "12:00:00",
Volunteers: []schedule.InstanceVolunteer{
{InstanceID: 1, VolunteerID: 5, Name: "Alice"},
{InstanceID: 1, VolunteerID: 6, Name: "Bob"},
},
},
addedVols: []int64{6}, // Bob is newly added
}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 1, "admin")
body, _ := json.Marshal(map[string]any{"volunteer_ids": vids})
w := do(t, router, "PUT", "/api/v1/shifts/1", string(body), token)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body)
}
// 2 notifications for existing volunteers (reset) + 1 for newly added
// Total = 3 but FR-S10 is a subset of FR-S09, so we don't double-count
// The handler sends update notices to all current volunteers (2) and
// an "added" notice only to the newly added one (1) = 3 notifications.
if len(notifier.calls) != 3 {
t.Errorf("expected 3 notifications (2 reset + 1 added), got %d", len(notifier.calls))
}
}
func TestConfirmShift_NotAssigned(t *testing.T) {
store := &fakeStore{confirmErr: schedule.ErrNotFound}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 5, "volunteer")
w := do(t, router, "POST", "/api/v1/shifts/99/confirm", "", token)
if w.Code != http.StatusNotFound {
t.Fatalf("expected 404, got %d", w.Code)
}
}
func TestConfirmShift_Success(t *testing.T) {
store := &fakeStore{}
notifier := &fakeNotifier{}
h := schedule.NewHandlerFromInterfaces(store, notifier, nil)
router := newRouter(h)
token := jwtForRole(t, 5, "volunteer")
w := do(t, router, "POST", "/api/v1/shifts/1/confirm", "", token)
if w.Code != http.StatusNoContent {
t.Fatalf("expected 204, got %d", w.Code)
}
}
// Compile-time interface check
var _ schedule.Storer = (*fakeStore)(nil)
var _ schedule.Notifier = (*fakeNotifier)(nil)

View File

@@ -8,96 +8,35 @@ import (
"time" "time"
) )
var ( var ErrNotFound = fmt.Errorf("schedule not found")
ErrNotFound = fmt.Errorf("not found")
ErrAlreadyExists = fmt.Errorf("instances already generated for this period")
)
// --------------------------------------------------------------------------- type Schedule struct {
// Models
// ---------------------------------------------------------------------------
type ShiftTemplate struct {
ID int64 `json:"id"` ID int64 `json:"id"`
Name string `json:"name"`
DayOfWeek int `json:"day_of_week"` // matches time.Weekday: 0=Sun, 6=Sat
StartTime string `json:"start_time"` // "HH:MM:SS"
EndTime string `json:"end_time"`
MinCapacity int `json:"min_capacity"`
MaxCapacity int `json:"max_capacity"`
Roles []TemplateRole `json:"roles"`
VolunteerIDs []int64 `json:"volunteer_ids"`
CreatedAt time.Time `json:"created_at"`
UpdatedAt time.Time `json:"updated_at"`
}
type TemplateRole struct {
ID int64 `json:"id"`
TemplateID int64 `json:"template_id"`
RoleName string `json:"role_name"`
Count int `json:"count"`
}
type ShiftInstance struct {
ID int64 `json:"id"`
TemplateID *int64 `json:"template_id,omitempty"`
Name string `json:"name"`
Date string `json:"date"` // "YYYY-MM-DD"
StartTime string `json:"start_time"`
EndTime string `json:"end_time"`
MinCapacity int `json:"min_capacity"`
MaxCapacity int `json:"max_capacity"`
Status string `json:"status"` // "draft" or "published"
Year int `json:"year"`
Month int `json:"month"`
Volunteers []InstanceVolunteer `json:"volunteers"`
CreatedAt time.Time `json:"created_at"`
UpdatedAt time.Time `json:"updated_at"`
}
type InstanceVolunteer struct {
InstanceID int64 `json:"instance_id"`
VolunteerID int64 `json:"volunteer_id"` VolunteerID int64 `json:"volunteer_id"`
Name string `json:"name"` Title string `json:"title"`
Confirmed bool `json:"confirmed"` StartsAt time.Time `json:"starts_at"`
ConfirmedAt *time.Time `json:"confirmed_at,omitempty"` EndsAt time.Time `json:"ends_at"`
Notes string `json:"notes,omitempty"`
CreatedAt time.Time `json:"created_at"`
UpdatedAt time.Time `json:"updated_at"`
} }
// --------------------------------------------------------------------------- type CreateInput struct {
// Input types VolunteerID int64 `json:"volunteer_id"`
// --------------------------------------------------------------------------- Title string `json:"title"`
StartsAt string `json:"starts_at"`
type CreateTemplateInput struct { EndsAt string `json:"ends_at"`
Name string `json:"name"` Notes string `json:"notes"`
DayOfWeek int `json:"day_of_week"`
StartTime string `json:"start_time"`
EndTime string `json:"end_time"`
MinCapacity int `json:"min_capacity"`
MaxCapacity int `json:"max_capacity"`
Roles []TemplateRole `json:"roles"`
VolunteerIDs []int64 `json:"volunteer_ids"`
} }
type UpdateTemplateInput struct { type UpdateInput struct {
Name *string `json:"name"` Title *string `json:"title"`
DayOfWeek *int `json:"day_of_week"` StartsAt *string `json:"starts_at"`
StartTime *string `json:"start_time"` EndsAt *string `json:"ends_at"`
EndTime *string `json:"end_time"` Notes *string `json:"notes"`
MinCapacity *int `json:"min_capacity"`
MaxCapacity *int `json:"max_capacity"`
Roles []TemplateRole `json:"roles"`
VolunteerIDs []int64 `json:"volunteer_ids"`
} }
type UpdateInstanceInput struct { const timeLayout = "2006-01-02T15:04:05Z"
VolunteerIDs *[]int64 `json:"volunteer_ids"`
MinCapacity *int `json:"min_capacity"`
MaxCapacity *int `json:"max_capacity"`
}
// ---------------------------------------------------------------------------
// Store
// ---------------------------------------------------------------------------
type Store struct { type Store struct {
db *sql.DB db *sql.DB
@@ -107,614 +46,109 @@ func NewStore(db *sql.DB) *Store {
return &Store{db: db} return &Store{db: db}
} }
// --------------------------------------------------------------------------- func (s *Store) Create(ctx context.Context, in CreateInput) (*Schedule, error) {
// Template operations res, err := s.db.ExecContext(ctx,
// --------------------------------------------------------------------------- `INSERT INTO schedules (volunteer_id, title, starts_at, ends_at, notes) VALUES (?, ?, ?, ?, ?)`,
in.VolunteerID, in.Title, in.StartsAt, in.EndsAt, in.Notes,
func (s *Store) CreateTemplate(ctx context.Context, in CreateTemplateInput) (*ShiftTemplate, error) {
tx, err := s.db.BeginTx(ctx, nil)
if err != nil {
return nil, fmt.Errorf("begin tx: %w", err)
}
defer tx.Rollback()
res, err := tx.ExecContext(ctx,
`INSERT INTO shift_templates (name, day_of_week, start_time, end_time, min_capacity, max_capacity)
VALUES (?, ?, ?, ?, ?, ?)`,
in.Name, in.DayOfWeek, in.StartTime, in.EndTime, in.MinCapacity, in.MaxCapacity,
) )
if err != nil { if err != nil {
return nil, fmt.Errorf("insert template: %w", err) return nil, fmt.Errorf("insert schedule: %w", err)
} }
id, _ := res.LastInsertId() id, _ := res.LastInsertId()
return s.GetByID(ctx, id)
if err := upsertTemplateRoles(ctx, tx, id, in.Roles); err != nil {
return nil, err
}
if err := upsertTemplateVolunteers(ctx, tx, id, in.VolunteerIDs); err != nil {
return nil, err
}
if err := tx.Commit(); err != nil {
return nil, fmt.Errorf("commit: %w", err)
}
return s.GetTemplate(ctx, id)
} }
func (s *Store) GetTemplate(ctx context.Context, id int64) (*ShiftTemplate, error) { func (s *Store) GetByID(ctx context.Context, id int64) (*Schedule, error) {
t := &ShiftTemplate{} sc := &Schedule{}
var createdAt, updatedAt string var startsAt, endsAt, createdAt, updatedAt string
var notes sql.NullString
err := s.db.QueryRowContext(ctx, err := s.db.QueryRowContext(ctx,
`SELECT id, name, day_of_week, start_time, end_time, min_capacity, max_capacity, created_at, updated_at `SELECT id, volunteer_id, title, starts_at, ends_at, notes, created_at, updated_at FROM schedules WHERE id = ?`, id,
FROM shift_templates WHERE id = ?`, id, ).Scan(&sc.ID, &sc.VolunteerID, &sc.Title, &startsAt, &endsAt, &notes, &createdAt, &updatedAt)
).Scan(&t.ID, &t.Name, &t.DayOfWeek, &t.StartTime, &t.EndTime,
&t.MinCapacity, &t.MaxCapacity, &createdAt, &updatedAt)
if errors.Is(err, sql.ErrNoRows) { if errors.Is(err, sql.ErrNoRows) {
return nil, ErrNotFound return nil, ErrNotFound
} }
if err != nil { if err != nil {
return nil, fmt.Errorf("get template: %w", err) return nil, fmt.Errorf("get schedule: %w", err)
} }
t.CreatedAt, _ = time.Parse("2006-01-02 15:04:05", createdAt) sc.StartsAt, _ = time.Parse("2006-01-02 15:04:05", startsAt)
t.UpdatedAt, _ = time.Parse("2006-01-02 15:04:05", updatedAt) sc.EndsAt, _ = time.Parse("2006-01-02 15:04:05", endsAt)
sc.CreatedAt, _ = time.Parse("2006-01-02 15:04:05", createdAt)
roles, err := s.templateRoles(ctx, id) sc.UpdatedAt, _ = time.Parse("2006-01-02 15:04:05", updatedAt)
if err != nil { if notes.Valid {
return nil, err sc.Notes = notes.String
} }
t.Roles = roles return sc, nil
vids, err := s.templateVolunteerIDs(ctx, id)
if err != nil {
return nil, err
}
t.VolunteerIDs = vids
return t, nil
} }
func (s *Store) ListTemplates(ctx context.Context) ([]ShiftTemplate, error) { func (s *Store) List(ctx context.Context, volunteerID int64) ([]Schedule, error) {
rows, err := s.db.QueryContext(ctx, query := `SELECT id, volunteer_id, title, starts_at, ends_at, notes, created_at, updated_at FROM schedules`
`SELECT id, name, day_of_week, start_time, end_time, min_capacity, max_capacity, created_at, updated_at args := []any{}
FROM shift_templates ORDER BY day_of_week, start_time`)
if err != nil {
return nil, fmt.Errorf("list templates: %w", err)
}
defer rows.Close()
var templates []ShiftTemplate
for rows.Next() {
var t ShiftTemplate
var createdAt, updatedAt string
if err := rows.Scan(&t.ID, &t.Name, &t.DayOfWeek, &t.StartTime, &t.EndTime,
&t.MinCapacity, &t.MaxCapacity, &createdAt, &updatedAt); err != nil {
return nil, err
}
t.CreatedAt, _ = time.Parse("2006-01-02 15:04:05", createdAt)
t.UpdatedAt, _ = time.Parse("2006-01-02 15:04:05", updatedAt)
templates = append(templates, t)
}
if err := rows.Err(); err != nil {
return nil, err
}
// Load roles and volunteers for each template
for i := range templates {
roles, err := s.templateRoles(ctx, templates[i].ID)
if err != nil {
return nil, err
}
templates[i].Roles = roles
vids, err := s.templateVolunteerIDs(ctx, templates[i].ID)
if err != nil {
return nil, err
}
templates[i].VolunteerIDs = vids
}
return templates, nil
}
func (s *Store) UpdateTemplate(ctx context.Context, id int64, in UpdateTemplateInput) (*ShiftTemplate, error) {
t, err := s.GetTemplate(ctx, id)
if err != nil {
return nil, err
}
name := t.Name
dow := t.DayOfWeek
startTime := t.StartTime
endTime := t.EndTime
minCap := t.MinCapacity
maxCap := t.MaxCapacity
if in.Name != nil {
name = *in.Name
}
if in.DayOfWeek != nil {
dow = *in.DayOfWeek
}
if in.StartTime != nil {
startTime = *in.StartTime
}
if in.EndTime != nil {
endTime = *in.EndTime
}
if in.MinCapacity != nil {
minCap = *in.MinCapacity
}
if in.MaxCapacity != nil {
maxCap = *in.MaxCapacity
}
tx, err := s.db.BeginTx(ctx, nil)
if err != nil {
return nil, fmt.Errorf("begin tx: %w", err)
}
defer tx.Rollback()
_, err = tx.ExecContext(ctx,
`UPDATE shift_templates SET name=?, day_of_week=?, start_time=?, end_time=?,
min_capacity=?, max_capacity=?, updated_at=NOW() WHERE id=?`,
name, dow, startTime, endTime, minCap, maxCap, id,
)
if err != nil {
return nil, fmt.Errorf("update template: %w", err)
}
if in.Roles != nil {
if _, err := tx.ExecContext(ctx, `DELETE FROM shift_template_roles WHERE template_id = ?`, id); err != nil {
return nil, fmt.Errorf("clear roles: %w", err)
}
if err := upsertTemplateRoles(ctx, tx, id, in.Roles); err != nil {
return nil, err
}
}
if in.VolunteerIDs != nil {
if _, err := tx.ExecContext(ctx, `DELETE FROM shift_template_volunteers WHERE template_id = ?`, id); err != nil {
return nil, fmt.Errorf("clear volunteers: %w", err)
}
if err := upsertTemplateVolunteers(ctx, tx, id, in.VolunteerIDs); err != nil {
return nil, err
}
}
if err := tx.Commit(); err != nil {
return nil, fmt.Errorf("commit: %w", err)
}
return s.GetTemplate(ctx, id)
}
func (s *Store) DeleteTemplate(ctx context.Context, id int64) error {
_, err := s.db.ExecContext(ctx, `DELETE FROM shift_templates WHERE id = ?`, id)
return err
}
// ---------------------------------------------------------------------------
// Instance operations
// ---------------------------------------------------------------------------
// GenerateInstances creates draft shift instances for every template × date in
// the given month. Returns ErrAlreadyExists if instances already exist for
// that month (FR-S02).
func (s *Store) GenerateInstances(ctx context.Context, year, month int) ([]ShiftInstance, error) {
var count int
if err := s.db.QueryRowContext(ctx,
`SELECT COUNT(*) FROM shift_instances WHERE year = ? AND month = ?`, year, month,
).Scan(&count); err != nil {
return nil, fmt.Errorf("check existing: %w", err)
}
if count > 0 {
return nil, ErrAlreadyExists
}
templates, err := s.ListTemplates(ctx)
if err != nil {
return nil, err
}
// Find all dates in the month for each template's day of week
first := time.Date(year, time.Month(month), 1, 0, 0, 0, 0, time.UTC)
daysInMonth := daysIn(year, month)
tx, err := s.db.BeginTx(ctx, nil)
if err != nil {
return nil, fmt.Errorf("begin tx: %w", err)
}
defer tx.Rollback()
var instanceIDs []int64
for _, tmpl := range templates {
for d := 0; d < daysInMonth; d++ {
day := first.AddDate(0, 0, d)
if int(day.Weekday()) != tmpl.DayOfWeek {
continue
}
res, err := tx.ExecContext(ctx,
`INSERT INTO shift_instances
(template_id, name, date, start_time, end_time, min_capacity, max_capacity, status, year, month)
VALUES (?, ?, ?, ?, ?, ?, ?, 'draft', ?, ?)`,
tmpl.ID, tmpl.Name, day.Format("2006-01-02"),
tmpl.StartTime, tmpl.EndTime,
tmpl.MinCapacity, tmpl.MaxCapacity,
year, month,
)
if err != nil {
return nil, fmt.Errorf("insert instance: %w", err)
}
instID, _ := res.LastInsertId()
instanceIDs = append(instanceIDs, instID)
// Copy recurring volunteer assignments from template
for _, vid := range tmpl.VolunteerIDs {
if _, err := tx.ExecContext(ctx,
`INSERT IGNORE INTO shift_instance_volunteers (instance_id, volunteer_id) VALUES (?, ?)`,
instID, vid,
); err != nil {
return nil, fmt.Errorf("copy volunteer: %w", err)
}
}
}
}
if err := tx.Commit(); err != nil {
return nil, fmt.Errorf("commit: %w", err)
}
return s.ListInstances(ctx, year, month, 0)
}
// ListInstances returns instances for a month. When volunteerID > 0, only
// returns published instances where that volunteer is assigned.
func (s *Store) ListInstances(ctx context.Context, year, month int, volunteerID int64) ([]ShiftInstance, error) {
query := `SELECT id, template_id, name, date, start_time, end_time,
min_capacity, max_capacity, status, year, month, created_at, updated_at
FROM shift_instances WHERE year = ? AND month = ?`
args := []any{year, month}
if volunteerID > 0 { if volunteerID > 0 {
query += ` AND status = 'published' query += ` WHERE volunteer_id = ?`
AND id IN (SELECT instance_id FROM shift_instance_volunteers WHERE volunteer_id = ?)`
args = append(args, volunteerID) args = append(args, volunteerID)
} }
query += ` ORDER BY date, start_time` query += ` ORDER BY starts_at`
rows, err := s.db.QueryContext(ctx, query, args...) rows, err := s.db.QueryContext(ctx, query, args...)
if err != nil { if err != nil {
return nil, fmt.Errorf("list instances: %w", err) return nil, fmt.Errorf("list schedules: %w", err)
} }
defer rows.Close() defer rows.Close()
var instances []ShiftInstance var schedules []Schedule
for rows.Next() { for rows.Next() {
inst, err := scanInstance(rows) var sc Schedule
var startsAt, endsAt, createdAt, updatedAt string
var notes sql.NullString
if err := rows.Scan(&sc.ID, &sc.VolunteerID, &sc.Title, &startsAt, &endsAt, &notes, &createdAt, &updatedAt); err != nil {
return nil, err
}
sc.StartsAt, _ = time.Parse("2006-01-02 15:04:05", startsAt)
sc.EndsAt, _ = time.Parse("2006-01-02 15:04:05", endsAt)
sc.CreatedAt, _ = time.Parse("2006-01-02 15:04:05", createdAt)
sc.UpdatedAt, _ = time.Parse("2006-01-02 15:04:05", updatedAt)
if notes.Valid {
sc.Notes = notes.String
}
schedules = append(schedules, sc)
}
return schedules, rows.Err()
}
func (s *Store) Update(ctx context.Context, id int64, in UpdateInput) (*Schedule, error) {
sc, err := s.GetByID(ctx, id)
if err != nil { if err != nil {
return nil, err return nil, err
} }
instances = append(instances, *inst) title := sc.Title
} startsAt := sc.StartsAt.Format("2006-01-02 15:04:05")
if err := rows.Err(); err != nil { endsAt := sc.EndsAt.Format("2006-01-02 15:04:05")
return nil, err notes := sc.Notes
}
for i := range instances { if in.Title != nil {
vols, err := s.instanceVolunteers(ctx, instances[i].ID) title = *in.Title
if err != nil {
return nil, err
} }
instances[i].Volunteers = vols if in.StartsAt != nil {
startsAt = *in.StartsAt
} }
return instances, nil if in.EndsAt != nil {
endsAt = *in.EndsAt
} }
if in.Notes != nil {
func (s *Store) GetInstance(ctx context.Context, id int64) (*ShiftInstance, error) { notes = *in.Notes
row := s.db.QueryRowContext(ctx,
`SELECT id, template_id, name, date, start_time, end_time,
min_capacity, max_capacity, status, year, month, created_at, updated_at
FROM shift_instances WHERE id = ?`, id)
inst, err := scanInstanceRow(row)
if errors.Is(err, sql.ErrNoRows) {
return nil, ErrNotFound
} }
if err != nil { _, err = s.db.ExecContext(ctx,
return nil, fmt.Errorf("get instance: %w", err) `UPDATE schedules SET title=?, starts_at=?, ends_at=?, notes=?, updated_at=NOW() WHERE id=?`,
} title, startsAt, endsAt, notes, id,
vols, err := s.instanceVolunteers(ctx, inst.ID)
if err != nil {
return nil, err
}
inst.Volunteers = vols
return inst, nil
}
// UpdateInstance edits volunteer assignments and/or capacity on any instance.
// For published instances, volunteer confirmation statuses are reset (FR-S09).
// Returns the previous and new volunteer ID sets so the caller can send notifications.
func (s *Store) UpdateInstance(ctx context.Context, id int64, in UpdateInstanceInput) (inst *ShiftInstance, added []int64, err error) {
inst, err = s.GetInstance(ctx, id)
if err != nil {
return nil, nil, err
}
tx, txErr := s.db.BeginTx(ctx, nil)
if txErr != nil {
return nil, nil, fmt.Errorf("begin tx: %w", txErr)
}
defer tx.Rollback()
if in.MinCapacity != nil || in.MaxCapacity != nil {
minCap := inst.MinCapacity
maxCap := inst.MaxCapacity
if in.MinCapacity != nil {
minCap = *in.MinCapacity
}
if in.MaxCapacity != nil {
maxCap = *in.MaxCapacity
}
if _, err := tx.ExecContext(ctx,
`UPDATE shift_instances SET min_capacity=?, max_capacity=?, updated_at=NOW() WHERE id=?`,
minCap, maxCap, id,
); err != nil {
return nil, nil, fmt.Errorf("update capacity: %w", err)
}
}
if in.VolunteerIDs != nil {
// Determine newly added volunteers (FR-S10)
existing := make(map[int64]bool)
for _, v := range inst.Volunteers {
existing[v.VolunteerID] = true
}
for _, vid := range *in.VolunteerIDs {
if !existing[vid] {
added = append(added, vid)
}
}
// Replace assignments
if _, err := tx.ExecContext(ctx,
`DELETE FROM shift_instance_volunteers WHERE instance_id = ?`, id,
); err != nil {
return nil, nil, fmt.Errorf("clear volunteers: %w", err)
}
for _, vid := range *in.VolunteerIDs {
if _, err := tx.ExecContext(ctx,
`INSERT INTO shift_instance_volunteers (instance_id, volunteer_id) VALUES (?, ?)`,
id, vid,
); err != nil {
return nil, nil, fmt.Errorf("insert volunteer: %w", err)
}
}
// Reset confirmation for published shifts (FR-S09)
if inst.Status == "published" {
if _, err := tx.ExecContext(ctx,
`UPDATE shift_instance_volunteers SET confirmed=0, confirmed_at=NULL WHERE instance_id=?`, id,
); err != nil {
return nil, nil, fmt.Errorf("reset confirmations: %w", err)
}
}
}
if err := tx.Commit(); err != nil {
return nil, nil, fmt.Errorf("commit: %w", err)
}
inst, err = s.GetInstance(ctx, id)
return inst, added, err
}
// PublishMonth marks all draft instances for the month as published and returns
// a map of volunteerID → []ShiftInstance for notification purposes (FR-S04).
func (s *Store) PublishMonth(ctx context.Context, year, month int) (map[int64][]ShiftInstance, error) {
if _, err := s.db.ExecContext(ctx,
`UPDATE shift_instances SET status='published', updated_at=NOW()
WHERE year=? AND month=? AND status='draft'`, year, month,
); err != nil {
return nil, fmt.Errorf("publish: %w", err)
}
instances, err := s.ListInstances(ctx, year, month, 0)
if err != nil {
return nil, err
}
byVol := make(map[int64][]ShiftInstance)
for _, inst := range instances {
for _, v := range inst.Volunteers {
byVol[v.VolunteerID] = append(byVol[v.VolunteerID], inst)
}
}
return byVol, nil
}
// UnpublishMonth marks all published instances for the month back to draft and
// returns volunteer IDs who had assignments (for notifications FR-S05).
func (s *Store) UnpublishMonth(ctx context.Context, year, month int) ([]int64, error) {
// Collect affected volunteer IDs before unpublishing
rows, err := s.db.QueryContext(ctx,
`SELECT DISTINCT siv.volunteer_id
FROM shift_instance_volunteers siv
JOIN shift_instances si ON siv.instance_id = si.id
WHERE si.year=? AND si.month=? AND si.status='published'`, year, month,
) )
if err != nil { if err != nil {
return nil, fmt.Errorf("query volunteers: %w", err) return nil, fmt.Errorf("update schedule: %w", err)
} }
defer rows.Close() return s.GetByID(ctx, id)
var volunteerIDs []int64
for rows.Next() {
var vid int64
if err := rows.Scan(&vid); err != nil {
return nil, err
}
volunteerIDs = append(volunteerIDs, vid)
}
if err := rows.Err(); err != nil {
return nil, err
} }
if _, err := s.db.ExecContext(ctx, func (s *Store) Delete(ctx context.Context, id int64) error {
`UPDATE shift_instances SET status='draft', updated_at=NOW() _, err := s.db.ExecContext(ctx, `DELETE FROM schedules WHERE id = ?`, id)
WHERE year=? AND month=? AND status='published'`, year, month, return err
); err != nil {
return nil, fmt.Errorf("unpublish: %w", err)
}
return volunteerIDs, nil
}
// ConfirmShift marks a volunteer's attendance confirmation for a shift (FR-S06).
func (s *Store) ConfirmShift(ctx context.Context, instanceID, volunteerID int64) error {
result, err := s.db.ExecContext(ctx,
`UPDATE shift_instance_volunteers SET confirmed=1, confirmed_at=NOW()
WHERE instance_id=? AND volunteer_id=?`, instanceID, volunteerID,
)
if err != nil {
return fmt.Errorf("confirm shift: %w", err)
}
affected, _ := result.RowsAffected()
if affected == 0 {
return ErrNotFound
}
return nil
}
// ---------------------------------------------------------------------------
// Helpers
// ---------------------------------------------------------------------------
func (s *Store) templateRoles(ctx context.Context, templateID int64) ([]TemplateRole, error) {
rows, err := s.db.QueryContext(ctx,
`SELECT id, template_id, role_name, count FROM shift_template_roles WHERE template_id = ?`, templateID)
if err != nil {
return nil, fmt.Errorf("get template roles: %w", err)
}
defer rows.Close()
roles := make([]TemplateRole, 0)
for rows.Next() {
var r TemplateRole
if err := rows.Scan(&r.ID, &r.TemplateID, &r.RoleName, &r.Count); err != nil {
return nil, err
}
roles = append(roles, r)
}
return roles, rows.Err()
}
func (s *Store) templateVolunteerIDs(ctx context.Context, templateID int64) ([]int64, error) {
rows, err := s.db.QueryContext(ctx,
`SELECT volunteer_id FROM shift_template_volunteers WHERE template_id = ?`, templateID)
if err != nil {
return nil, fmt.Errorf("get template volunteers: %w", err)
}
defer rows.Close()
ids := make([]int64, 0)
for rows.Next() {
var id int64
if err := rows.Scan(&id); err != nil {
return nil, err
}
ids = append(ids, id)
}
return ids, rows.Err()
}
func (s *Store) instanceVolunteers(ctx context.Context, instanceID int64) ([]InstanceVolunteer, error) {
rows, err := s.db.QueryContext(ctx,
`SELECT siv.instance_id, siv.volunteer_id, v.name, siv.confirmed, siv.confirmed_at
FROM shift_instance_volunteers siv
JOIN volunteers v ON v.id = siv.volunteer_id
WHERE siv.instance_id = ?
ORDER BY v.name`, instanceID,
)
if err != nil {
return nil, fmt.Errorf("get instance volunteers: %w", err)
}
defer rows.Close()
vols := make([]InstanceVolunteer, 0)
for rows.Next() {
var iv InstanceVolunteer
var confirmedAt sql.NullString
if err := rows.Scan(&iv.InstanceID, &iv.VolunteerID, &iv.Name, &iv.Confirmed, &confirmedAt); err != nil {
return nil, err
}
if confirmedAt.Valid {
t, _ := time.Parse("2006-01-02 15:04:05", confirmedAt.String)
iv.ConfirmedAt = &t
}
vols = append(vols, iv)
}
return vols, rows.Err()
}
func upsertTemplateRoles(ctx context.Context, tx *sql.Tx, templateID int64, roles []TemplateRole) error {
for _, r := range roles {
if _, err := tx.ExecContext(ctx,
`INSERT INTO shift_template_roles (template_id, role_name, count) VALUES (?, ?, ?)`,
templateID, r.RoleName, r.Count,
); err != nil {
return fmt.Errorf("insert role: %w", err)
}
}
return nil
}
func upsertTemplateVolunteers(ctx context.Context, tx *sql.Tx, templateID int64, volunteerIDs []int64) error {
for _, vid := range volunteerIDs {
if _, err := tx.ExecContext(ctx,
`INSERT IGNORE INTO shift_template_volunteers (template_id, volunteer_id) VALUES (?, ?)`,
templateID, vid,
); err != nil {
return fmt.Errorf("insert template volunteer: %w", err)
}
}
return nil
}
type instanceScanner interface {
Scan(dest ...any) error
}
func scanInstance(r instanceScanner) (*ShiftInstance, error) {
var inst ShiftInstance
var templateID sql.NullInt64
var createdAt, updatedAt string
if err := r.Scan(&inst.ID, &templateID, &inst.Name, &inst.Date, &inst.StartTime, &inst.EndTime,
&inst.MinCapacity, &inst.MaxCapacity, &inst.Status, &inst.Year, &inst.Month,
&createdAt, &updatedAt); err != nil {
return nil, err
}
if templateID.Valid {
inst.TemplateID = &templateID.Int64
}
inst.CreatedAt, _ = time.Parse("2006-01-02 15:04:05", createdAt)
inst.UpdatedAt, _ = time.Parse("2006-01-02 15:04:05", updatedAt)
if inst.Volunteers == nil {
inst.Volunteers = []InstanceVolunteer{}
}
return &inst, nil
}
func scanInstanceRow(row *sql.Row) (*ShiftInstance, error) {
var inst ShiftInstance
var templateID sql.NullInt64
var createdAt, updatedAt string
if err := row.Scan(&inst.ID, &templateID, &inst.Name, &inst.Date, &inst.StartTime, &inst.EndTime,
&inst.MinCapacity, &inst.MaxCapacity, &inst.Status, &inst.Year, &inst.Month,
&createdAt, &updatedAt); err != nil {
return nil, err
}
if templateID.Valid {
inst.TemplateID = &templateID.Int64
}
inst.CreatedAt, _ = time.Parse("2006-01-02 15:04:05", createdAt)
inst.UpdatedAt, _ = time.Parse("2006-01-02 15:04:05", updatedAt)
if inst.Volunteers == nil {
inst.Volunteers = []InstanceVolunteer{}
}
return &inst, nil
}
func daysIn(year, month int) int {
return time.Date(year, time.Month(month+1), 0, 0, 0, 0, 0, time.UTC).Day()
} }

View File

@@ -12,7 +12,6 @@ import (
"git.unsupervised.ca/walkies/internal/notification" "git.unsupervised.ca/walkies/internal/notification"
"git.unsupervised.ca/walkies/internal/schedule" "git.unsupervised.ca/walkies/internal/schedule"
"git.unsupervised.ca/walkies/internal/server/middleware" "git.unsupervised.ca/walkies/internal/server/middleware"
"git.unsupervised.ca/walkies/internal/setup"
"git.unsupervised.ca/walkies/internal/timeoff" "git.unsupervised.ca/walkies/internal/timeoff"
"git.unsupervised.ca/walkies/internal/volunteer" "git.unsupervised.ca/walkies/internal/volunteer"
) )
@@ -23,21 +22,17 @@ func New(db *sql.DB, jwtSecret string, staticDir string) http.Handler {
volunteerStore := volunteer.NewStore(db) volunteerStore := volunteer.NewStore(db)
volunteerHandler := volunteer.NewHandler(volunteerStore, authSvc) volunteerHandler := volunteer.NewHandler(volunteerStore, authSvc)
notificationStore := notification.NewStore(db) scheduleStore := schedule.NewStore(db)
notificationHandler := notification.NewHandler(notificationStore) scheduleHandler := schedule.NewHandler(scheduleStore)
timeoffStore := timeoff.NewStore(db) timeoffStore := timeoff.NewStore(db)
timeoffHandler := timeoff.NewHandler(timeoffStore)
scheduleStore := schedule.NewStore(db)
scheduleHandler := schedule.NewHandler(scheduleStore, notificationStore, timeoffStore)
timeoffHandler := timeoff.NewHandler(timeoffStore, notificationStore, volunteerStore)
checkinStore := checkin.NewStore(db) checkinStore := checkin.NewStore(db)
checkinHandler := checkin.NewHandler(checkinStore) checkinHandler := checkin.NewHandler(checkinStore)
setupStore := setup.NewStore(db) notificationStore := notification.NewStore(db)
setupHandler := setup.NewHandler(setupStore, authSvc) notificationHandler := notification.NewHandler(notificationStore)
r := chi.NewRouter() r := chi.NewRouter()
r.Use(chimiddleware.Logger) r.Use(chimiddleware.Logger)
@@ -50,10 +45,6 @@ func New(db *sql.DB, jwtSecret string, staticDir string) http.Handler {
r.Post("/auth/login", volunteerHandler.Login) r.Post("/auth/login", volunteerHandler.Login)
r.Post("/auth/activate", volunteerHandler.Activate) r.Post("/auth/activate", volunteerHandler.Activate)
// Public setup endpoints (self-disabling once first user exists)
r.Get("/setup/status", setupHandler.Status)
r.Post("/setup/admin", setupHandler.CreateAdmin)
// Protected routes // Protected routes
r.Group(func(r chi.Router) { r.Group(func(r chi.Router) {
r.Use(middleware.Authenticate(authSvc)) r.Use(middleware.Authenticate(authSvc))
@@ -65,27 +56,16 @@ func New(db *sql.DB, jwtSecret string, staticDir string) http.Handler {
r.Put("/volunteers/{id}", volunteerHandler.Update) r.Put("/volunteers/{id}", volunteerHandler.Update)
r.With(middleware.RequireAdmin).Post("/volunteers/{id}/invite", volunteerHandler.ResendInvite) r.With(middleware.RequireAdmin).Post("/volunteers/{id}/invite", volunteerHandler.ResendInvite)
// Shift templates (admin only) // Schedules
r.Get("/shift-templates", scheduleHandler.ListTemplates) r.Get("/schedules", scheduleHandler.List)
r.With(middleware.RequireAdmin).Post("/shift-templates", scheduleHandler.CreateTemplate) r.Post("/schedules", scheduleHandler.Create)
r.With(middleware.RequireAdmin).Put("/shift-templates/{id}", scheduleHandler.UpdateTemplate) r.With(middleware.RequireAdmin).Put("/schedules/{id}", scheduleHandler.Update)
r.With(middleware.RequireAdmin).Delete("/shift-templates/{id}", scheduleHandler.DeleteTemplate) r.With(middleware.RequireAdmin).Delete("/schedules/{id}", scheduleHandler.Delete)
// Shift instances
r.Get("/shifts", scheduleHandler.ListInstances)
r.With(middleware.RequireAdmin).Post("/shifts/generate", scheduleHandler.GenerateInstances)
r.With(middleware.RequireAdmin).Post("/shifts/publish", scheduleHandler.PublishMonth)
r.With(middleware.RequireAdmin).Post("/shifts/unpublish", scheduleHandler.UnpublishMonth)
r.With(middleware.RequireAdmin).Put("/shifts/{id}", scheduleHandler.UpdateInstance)
r.Post("/shifts/{id}/confirm", scheduleHandler.ConfirmShift)
// Time off // Time off
r.Get("/timeoff", timeoffHandler.List) r.Get("/timeoff", timeoffHandler.List)
r.Post("/timeoff", timeoffHandler.Create) r.Post("/timeoff", timeoffHandler.Create)
r.Put("/timeoff/{id}", timeoffHandler.Update)
r.Delete("/timeoff/{id}", timeoffHandler.Delete)
r.With(middleware.RequireAdmin).Put("/timeoff/{id}/review", timeoffHandler.Review) r.With(middleware.RequireAdmin).Put("/timeoff/{id}/review", timeoffHandler.Review)
r.With(middleware.RequireAdmin).Get("/timeoff/{id}/shifts", timeoffHandler.RemovedShifts)
// Check-in / check-out // Check-in / check-out
r.Post("/checkin", checkinHandler.CheckIn) r.Post("/checkin", checkinHandler.CheckIn)
@@ -98,25 +78,8 @@ func New(db *sql.DB, jwtSecret string, staticDir string) http.Handler {
}) })
}) })
// Serve static React app for all other routes, with SPA fallback // Serve static React app for all other routes
r.Handle("/*", spaHandler(staticDir)) r.Handle("/*", http.FileServer(http.Dir(staticDir)))
return r return r
} }
// spaHandler serves static files from dir, falling back to index.html for
// paths that don't match a file on disk (so client-side routing works).
func spaHandler(dir string) http.HandlerFunc {
fs := http.Dir(dir)
fileServer := http.FileServer(fs)
return func(w http.ResponseWriter, r *http.Request) {
// Try to open the requested path as a static file.
if f, err := fs.Open(r.URL.Path); err == nil {
f.Close()
fileServer.ServeHTTP(w, r)
return
}
// Not a real file — serve index.html and let React Router handle it.
http.ServeFile(w, r, dir+"/index.html")
}
}

View File

@@ -1,84 +0,0 @@
package setup
import (
"encoding/json"
"errors"
"net/http"
"git.unsupervised.ca/walkies/internal/auth"
"git.unsupervised.ca/walkies/internal/respond"
)
// TokenIssuer is the subset of auth.Service the setup handler needs.
type TokenIssuer interface {
IssueToken(volunteerID int64, role string) (string, error)
}
type Handler struct {
store Storer
authSvc TokenIssuer
}
func NewHandler(store *Store, authSvc *auth.Service) *Handler {
return &Handler{store: store, authSvc: authSvc}
}
// NewHandlerFromInterfaces constructs a Handler from interface values, intended for testing.
func NewHandlerFromInterfaces(store Storer, authSvc TokenIssuer) *Handler {
return &Handler{store: store, authSvc: authSvc}
}
// Status handles GET /api/v1/setup/status.
func (h *Handler) Status(w http.ResponseWriter, r *http.Request) {
needs, err := h.store.NeedsSetup(r.Context())
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not check setup status")
return
}
respond.JSON(w, http.StatusOK, map[string]bool{"needs_setup": needs})
}
// CreateAdmin handles POST /api/v1/setup/admin.
func (h *Handler) CreateAdmin(w http.ResponseWriter, r *http.Request) {
var body struct {
Name string `json:"name"`
Email string `json:"email"`
Password string `json:"password"`
}
if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
respond.Error(w, http.StatusBadRequest, "invalid request body")
return
}
if body.Name == "" || body.Email == "" || body.Password == "" {
respond.Error(w, http.StatusBadRequest, "name, email, and password are required")
return
}
if len(body.Password) < 8 {
respond.Error(w, http.StatusBadRequest, "password must be at least 8 characters")
return
}
hashed, err := auth.HashPassword(body.Password)
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not hash password")
return
}
id, err := h.store.CreateAdmin(r.Context(), body.Name, body.Email, hashed)
if errors.Is(err, ErrSetupAlreadyDone) {
respond.Error(w, http.StatusForbidden, "setup already completed")
return
}
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not create admin account")
return
}
token, err := h.authSvc.IssueToken(id, "admin")
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not issue token")
return
}
respond.JSON(w, http.StatusCreated, map[string]string{"token": token})
}

View File

@@ -1,168 +0,0 @@
package setup_test
import (
"bytes"
"context"
"encoding/json"
"net/http"
"net/http/httptest"
"testing"
"git.unsupervised.ca/walkies/internal/setup"
)
// ---- fakes ---------------------------------------------------------------
type fakeStore struct {
needsSetup bool
needsSetupErr error
createAdminID int64
createAdminErr error
}
func (f *fakeStore) NeedsSetup(_ context.Context) (bool, error) {
return f.needsSetup, f.needsSetupErr
}
func (f *fakeStore) CreateAdmin(_ context.Context, _, _, _ string) (int64, error) {
return f.createAdminID, f.createAdminErr
}
type fakeTokenIssuer struct {
token string
err error
}
func (f *fakeTokenIssuer) IssueToken(_ int64, _ string) (string, error) {
return f.token, f.err
}
// Compile-time interface checks.
var _ setup.Storer = (*fakeStore)(nil)
var _ setup.TokenIssuer = (*fakeTokenIssuer)(nil)
// ---- helpers -------------------------------------------------------------
func do(t *testing.T, handler http.HandlerFunc, method, path, body string) *httptest.ResponseRecorder {
t.Helper()
var b *bytes.Reader
if body != "" {
b = bytes.NewReader([]byte(body))
} else {
b = bytes.NewReader(nil)
}
req := httptest.NewRequest(method, path, b)
if body != "" {
req.Header.Set("Content-Type", "application/json")
}
w := httptest.NewRecorder()
handler.ServeHTTP(w, req)
return w
}
// ---- Status tests --------------------------------------------------------
func TestStatus_NeedsSetup(t *testing.T) {
h := setup.NewHandlerFromInterfaces(
&fakeStore{needsSetup: true},
&fakeTokenIssuer{},
)
w := do(t, h.Status, "GET", "/api/v1/setup/status", "")
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body)
}
var resp map[string]bool
json.NewDecoder(w.Body).Decode(&resp)
if !resp["needs_setup"] {
t.Error("expected needs_setup=true")
}
}
func TestStatus_SetupDone(t *testing.T) {
h := setup.NewHandlerFromInterfaces(
&fakeStore{needsSetup: false},
&fakeTokenIssuer{},
)
w := do(t, h.Status, "GET", "/api/v1/setup/status", "")
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body)
}
var resp map[string]bool
json.NewDecoder(w.Body).Decode(&resp)
if resp["needs_setup"] {
t.Error("expected needs_setup=false")
}
}
// ---- CreateAdmin tests ---------------------------------------------------
func TestCreateAdmin_Success(t *testing.T) {
h := setup.NewHandlerFromInterfaces(
&fakeStore{createAdminID: 1},
&fakeTokenIssuer{token: "jwt-token"},
)
w := do(t, h.CreateAdmin, "POST", "/api/v1/setup/admin",
`{"name":"Admin","email":"admin@example.com","password":"supersecret"}`)
if w.Code != http.StatusCreated {
t.Fatalf("expected 201, got %d: %s", w.Code, w.Body)
}
var resp map[string]string
json.NewDecoder(w.Body).Decode(&resp)
if resp["token"] != "jwt-token" {
t.Errorf("expected token jwt-token, got %q", resp["token"])
}
}
func TestCreateAdmin_AlreadyDone(t *testing.T) {
h := setup.NewHandlerFromInterfaces(
&fakeStore{createAdminErr: setup.ErrSetupAlreadyDone},
&fakeTokenIssuer{},
)
w := do(t, h.CreateAdmin, "POST", "/api/v1/setup/admin",
`{"name":"Admin","email":"admin@example.com","password":"supersecret"}`)
if w.Code != http.StatusForbidden {
t.Fatalf("expected 403, got %d: %s", w.Code, w.Body)
}
}
func TestCreateAdmin_MissingFields(t *testing.T) {
h := setup.NewHandlerFromInterfaces(
&fakeStore{},
&fakeTokenIssuer{},
)
tests := []struct {
name string
body string
}{
{"missing name", `{"email":"a@b.com","password":"supersecret"}`},
{"missing email", `{"name":"Admin","password":"supersecret"}`},
{"missing password", `{"name":"Admin","email":"a@b.com"}`},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
w := do(t, h.CreateAdmin, "POST", "/api/v1/setup/admin", tc.body)
if w.Code != http.StatusBadRequest {
t.Fatalf("expected 400, got %d: %s", w.Code, w.Body)
}
})
}
}
func TestCreateAdmin_PasswordTooShort(t *testing.T) {
h := setup.NewHandlerFromInterfaces(
&fakeStore{},
&fakeTokenIssuer{},
)
w := do(t, h.CreateAdmin, "POST", "/api/v1/setup/admin",
`{"name":"Admin","email":"admin@example.com","password":"short"}`)
if w.Code != http.StatusBadRequest {
t.Fatalf("expected 400, got %d: %s", w.Code, w.Body)
}
}

View File

@@ -1,68 +0,0 @@
package setup
import (
"context"
"database/sql"
"errors"
)
var ErrSetupAlreadyDone = errors.New("setup already completed")
// Storer is the interface for setup-related DB operations.
type Storer interface {
NeedsSetup(ctx context.Context) (bool, error)
CreateAdmin(ctx context.Context, name, email, hashedPassword string) (int64, error)
}
type Store struct {
db *sql.DB
}
func NewStore(db *sql.DB) *Store {
return &Store{db: db}
}
// NeedsSetup returns true when the volunteers table has zero rows.
func (s *Store) NeedsSetup(ctx context.Context) (bool, error) {
var count int
err := s.db.QueryRowContext(ctx, `SELECT COUNT(*) FROM volunteers`).Scan(&count)
if err != nil {
return false, err
}
return count == 0, nil
}
// CreateAdmin atomically checks that no users exist and inserts the first admin.
func (s *Store) CreateAdmin(ctx context.Context, name, email, hashedPassword string) (int64, error) {
tx, err := s.db.BeginTx(ctx, nil)
if err != nil {
return 0, err
}
defer tx.Rollback()
var count int
if err := tx.QueryRowContext(ctx, `SELECT COUNT(*) FROM volunteers`).Scan(&count); err != nil {
return 0, err
}
if count > 0 {
return 0, ErrSetupAlreadyDone
}
res, err := tx.ExecContext(ctx,
`INSERT INTO volunteers (name, email, password, role, active, operational_roles) VALUES (?, ?, ?, 'admin', 1, '')`,
name, email, hashedPassword,
)
if err != nil {
return 0, err
}
id, err := res.LastInsertId()
if err != nil {
return 0, err
}
if err := tx.Commit(); err != nil {
return 0, err
}
return id, nil
}

View File

@@ -1,56 +1,22 @@
package timeoff package timeoff
import ( import (
"context"
"encoding/json" "encoding/json"
"errors" "errors"
"fmt"
"net/http" "net/http"
"strconv" "strconv"
"time"
"git.unsupervised.ca/walkies/internal/respond" "git.unsupervised.ca/walkies/internal/respond"
"git.unsupervised.ca/walkies/internal/server/middleware" "git.unsupervised.ca/walkies/internal/server/middleware"
"github.com/go-chi/chi/v5" "github.com/go-chi/chi/v5"
) )
// Notifier is the subset of notification.Store the handler needs.
type Notifier interface {
CreateNotification(ctx context.Context, volunteerID int64, message string) error
}
// AdminLister returns admin volunteer IDs so the handler can notify them.
type AdminLister interface {
ListAdminIDs(ctx context.Context) ([]int64, error)
}
// Storer is the interface the Handler depends on.
type Storer interface {
Create(ctx context.Context, volunteerID int64, in CreateInput) (*Request, error)
GetByID(ctx context.Context, id int64) (*Request, error)
List(ctx context.Context, volunteerID int64) ([]Request, error)
Review(ctx context.Context, id, reviewerID int64, status string) (*Request, error)
Update(ctx context.Context, id int64, in UpdateInput) (*Request, error)
Delete(ctx context.Context, id int64) error
ConflictingShifts(ctx context.Context, volunteerID int64, startsAt, endsAt string) ([]ConflictingShift, error)
RemoveFromConflictingShifts(ctx context.Context, timeOffID, volunteerID int64, startsAt, endsAt string) ([]ConflictingShift, error)
RemovedShiftsForTimeOff(ctx context.Context, timeOffID int64) ([]ConflictingShift, error)
RestoreRemovedShifts(ctx context.Context, timeOffID int64) ([]ConflictingShift, error)
}
type Handler struct { type Handler struct {
store Storer store *Store
notifier Notifier
adminLister AdminLister
} }
func NewHandler(store *Store, notifier Notifier, adminLister AdminLister) *Handler { func NewHandler(store *Store) *Handler {
return &Handler{store: store, notifier: notifier, adminLister: adminLister} return &Handler{store: store}
}
// NewHandlerFromInterfaces constructs a Handler from interface values, intended for testing.
func NewHandlerFromInterfaces(store Storer, notifier Notifier, adminLister AdminLister) *Handler {
return &Handler{store: store, notifier: notifier, adminLister: adminLister}
} }
// GET /api/v1/timeoff // GET /api/v1/timeoff
@@ -72,9 +38,6 @@ func (h *Handler) List(w http.ResponseWriter, r *http.Request) {
} }
// POST /api/v1/timeoff // POST /api/v1/timeoff
// Creates time off with status "approved". If confirm_conflicts is true and the
// volunteer is assigned to shifts in the date range, they are auto-removed and
// admins are notified (FR-T03).
func (h *Handler) Create(w http.ResponseWriter, r *http.Request) { func (h *Handler) Create(w http.ResponseWriter, r *http.Request) {
claims := middleware.ClaimsFromContext(r.Context()) claims := middleware.ClaimsFromContext(r.Context())
var in CreateInput var in CreateInput
@@ -86,181 +49,14 @@ func (h *Handler) Create(w http.ResponseWriter, r *http.Request) {
respond.Error(w, http.StatusBadRequest, "starts_at and ends_at are required") respond.Error(w, http.StatusBadRequest, "starts_at and ends_at are required")
return return
} }
req, err := h.store.Create(r.Context(), claims.VolunteerID, in)
// Determine target volunteer (admin can create for others, FR-T05)
targetVolunteerID := claims.VolunteerID
if in.VolunteerID > 0 && claims.Role == "admin" {
targetVolunteerID = in.VolunteerID
}
// Check for conflicting shifts
conflicts, err := h.store.ConflictingShifts(r.Context(), targetVolunteerID, in.StartsAt, in.EndsAt)
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not check conflicts")
return
}
// If there are conflicts and the user hasn't confirmed, return them
if len(conflicts) > 0 && !in.ConfirmConflicts {
respond.JSON(w, http.StatusConflict, map[string]any{
"message": "Time off conflicts with assigned shifts. Confirm to proceed.",
"conflicts": conflicts,
})
return
}
// Create with auto-approved status
req, err := h.store.Create(r.Context(), targetVolunteerID, in)
if err != nil { if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not create time off request") respond.Error(w, http.StatusInternalServerError, "could not create time off request")
return return
} }
// Auto-approve
req, err = h.store.Review(r.Context(), req.ID, claims.VolunteerID, "approved")
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not approve time off request")
return
}
// Remove from conflicting shifts (FR-T03)
if len(conflicts) > 0 {
removed, err := h.store.RemoveFromConflictingShifts(r.Context(), req.ID, targetVolunteerID, in.StartsAt, in.EndsAt)
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not remove from conflicting shifts")
return
}
// Notify admins
h.notifyAdmins(r.Context(), targetVolunteerID, removed)
}
respond.JSON(w, http.StatusCreated, req) respond.JSON(w, http.StatusCreated, req)
} }
// PUT /api/v1/timeoff/{id}
// Volunteers can edit their own future time off (FR-T02). Admins can edit any (FR-T05).
func (h *Handler) Update(w http.ResponseWriter, r *http.Request) {
claims := middleware.ClaimsFromContext(r.Context())
id, err := strconv.ParseInt(chi.URLParam(r, "id"), 10, 64)
if err != nil {
respond.Error(w, http.StatusBadRequest, "invalid id")
return
}
existing, err := h.store.GetByID(r.Context(), id)
if errors.Is(err, ErrNotFound) {
respond.Error(w, http.StatusNotFound, "time off request not found")
return
}
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not get time off request")
return
}
// Permission: volunteers can only edit their own future time off
if claims.Role != "admin" {
if existing.VolunteerID != claims.VolunteerID {
respond.Error(w, http.StatusForbidden, "cannot edit another volunteer's time off")
return
}
if !existing.StartsAt.After(time.Now()) {
respond.Error(w, http.StatusForbidden, "cannot edit past time off")
return
}
}
var in UpdateInput
if err := json.NewDecoder(r.Body).Decode(&in); err != nil {
respond.Error(w, http.StatusBadRequest, "invalid request body")
return
}
if in.StartsAt == "" || in.EndsAt == "" {
respond.Error(w, http.StatusBadRequest, "starts_at and ends_at are required")
return
}
req, err := h.store.Update(r.Context(), id, in)
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not update time off request")
return
}
respond.JSON(w, http.StatusOK, req)
}
// DELETE /api/v1/timeoff/{id}
// Volunteers can delete their own future time off (FR-T02).
// Admin delete restores the volunteer to previously removed shifts (FR-T04).
func (h *Handler) Delete(w http.ResponseWriter, r *http.Request) {
claims := middleware.ClaimsFromContext(r.Context())
id, err := strconv.ParseInt(chi.URLParam(r, "id"), 10, 64)
if err != nil {
respond.Error(w, http.StatusBadRequest, "invalid id")
return
}
existing, err := h.store.GetByID(r.Context(), id)
if errors.Is(err, ErrNotFound) {
respond.Error(w, http.StatusNotFound, "time off request not found")
return
}
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not get time off request")
return
}
// Permission: volunteers can only delete their own future time off
if claims.Role != "admin" {
if existing.VolunteerID != claims.VolunteerID {
respond.Error(w, http.StatusForbidden, "cannot delete another volunteer's time off")
return
}
if !existing.StartsAt.After(time.Now()) {
respond.Error(w, http.StatusForbidden, "cannot delete past time off")
return
}
}
// If admin is deleting, restore volunteer to removed shifts (FR-T04)
var restored []ConflictingShift
if claims.Role == "admin" {
restored, err = h.store.RestoreRemovedShifts(r.Context(), id)
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not restore shifts")
return
}
}
if err := h.store.Delete(r.Context(), id); err != nil {
respond.Error(w, http.StatusInternalServerError, "could not delete time off request")
return
}
respond.JSON(w, http.StatusOK, map[string]any{
"deleted": true,
"restored_shifts": restored,
})
}
// GET /api/v1/timeoff/{id}/shifts
// Returns shifts that were removed due to this time-off request (preview for FR-T04).
func (h *Handler) RemovedShifts(w http.ResponseWriter, r *http.Request) {
id, err := strconv.ParseInt(chi.URLParam(r, "id"), 10, 64)
if err != nil {
respond.Error(w, http.StatusBadRequest, "invalid id")
return
}
shifts, err := h.store.RemovedShiftsForTimeOff(r.Context(), id)
if err != nil {
respond.Error(w, http.StatusInternalServerError, "could not get removed shifts")
return
}
if shifts == nil {
shifts = []ConflictingShift{}
}
respond.JSON(w, http.StatusOK, shifts)
}
// PUT /api/v1/timeoff/{id}/review // PUT /api/v1/timeoff/{id}/review
func (h *Handler) Review(w http.ResponseWriter, r *http.Request) { func (h *Handler) Review(w http.ResponseWriter, r *http.Request) {
claims := middleware.ClaimsFromContext(r.Context()) claims := middleware.ClaimsFromContext(r.Context())
@@ -289,19 +85,3 @@ func (h *Handler) Review(w http.ResponseWriter, r *http.Request) {
} }
respond.JSON(w, http.StatusOK, req) respond.JSON(w, http.StatusOK, req)
} }
// notifyAdmins sends a notification to all admin users about a volunteer's
// shift removals due to time off (FR-T03).
func (h *Handler) notifyAdmins(ctx context.Context, volunteerID int64, removed []ConflictingShift) {
if len(removed) == 0 {
return
}
adminIDs, err := h.adminLister.ListAdminIDs(ctx)
if err != nil {
return
}
msg := fmt.Sprintf("Volunteer %d has been removed from %d shift(s) due to time off.", volunteerID, len(removed))
for _, aid := range adminIDs {
h.notifier.CreateNotification(ctx, aid, msg) //nolint:errcheck
}
}

View File

@@ -1,521 +0,0 @@
package timeoff_test
import (
"bytes"
"context"
"encoding/json"
"net/http"
"net/http/httptest"
"testing"
"time"
"git.unsupervised.ca/walkies/internal/auth"
"git.unsupervised.ca/walkies/internal/server/middleware"
"git.unsupervised.ca/walkies/internal/timeoff"
"github.com/go-chi/chi/v5"
)
// ---------------------------------------------------------------------------
// Fakes
// ---------------------------------------------------------------------------
type fakeStore struct {
requests []timeoff.Request
createResult *timeoff.Request
createErr error
getResult *timeoff.Request
getErr error
updateResult *timeoff.Request
updateErr error
deleteErr error
reviewResult *timeoff.Request
reviewErr error
conflicts []timeoff.ConflictingShift
conflictsErr error
removedShifts []timeoff.ConflictingShift
removeErr error
removedForTimeOff []timeoff.ConflictingShift
removedForErr error
restoredShifts []timeoff.ConflictingShift
restoreErr error
removeCalled bool
restoreCalled bool
}
func (f *fakeStore) Create(_ context.Context, volunteerID int64, in timeoff.CreateInput) (*timeoff.Request, error) {
if f.createErr != nil {
return nil, f.createErr
}
if f.createResult != nil {
return f.createResult, nil
}
return &timeoff.Request{
ID: 1, VolunteerID: volunteerID,
StartsAt: time.Date(2026, 5, 1, 0, 0, 0, 0, time.UTC),
EndsAt: time.Date(2026, 5, 3, 0, 0, 0, 0, time.UTC),
Status: "pending",
}, nil
}
func (f *fakeStore) GetByID(_ context.Context, id int64) (*timeoff.Request, error) {
if f.getErr != nil {
return nil, f.getErr
}
if f.getResult != nil {
return f.getResult, nil
}
return nil, timeoff.ErrNotFound
}
func (f *fakeStore) List(_ context.Context, volunteerID int64) ([]timeoff.Request, error) {
if volunteerID > 0 {
var filtered []timeoff.Request
for _, r := range f.requests {
if r.VolunteerID == volunteerID {
filtered = append(filtered, r)
}
}
return filtered, nil
}
return f.requests, nil
}
func (f *fakeStore) Review(_ context.Context, id, reviewerID int64, status string) (*timeoff.Request, error) {
if f.reviewErr != nil {
return nil, f.reviewErr
}
if f.reviewResult != nil {
return f.reviewResult, nil
}
return &timeoff.Request{ID: id, Status: status}, nil
}
func (f *fakeStore) Update(_ context.Context, id int64, in timeoff.UpdateInput) (*timeoff.Request, error) {
if f.updateErr != nil {
return nil, f.updateErr
}
if f.updateResult != nil {
return f.updateResult, nil
}
return &timeoff.Request{ID: id, Status: "approved"}, nil
}
func (f *fakeStore) Delete(_ context.Context, id int64) error {
return f.deleteErr
}
func (f *fakeStore) ConflictingShifts(_ context.Context, _ int64, _, _ string) ([]timeoff.ConflictingShift, error) {
if f.conflictsErr != nil {
return nil, f.conflictsErr
}
return f.conflicts, nil
}
func (f *fakeStore) RemoveFromConflictingShifts(_ context.Context, _, _ int64, _, _ string) ([]timeoff.ConflictingShift, error) {
f.removeCalled = true
if f.removeErr != nil {
return nil, f.removeErr
}
return f.removedShifts, nil
}
func (f *fakeStore) RemovedShiftsForTimeOff(_ context.Context, _ int64) ([]timeoff.ConflictingShift, error) {
if f.removedForErr != nil {
return nil, f.removedForErr
}
return f.removedForTimeOff, nil
}
func (f *fakeStore) RestoreRemovedShifts(_ context.Context, _ int64) ([]timeoff.ConflictingShift, error) {
f.restoreCalled = true
if f.restoreErr != nil {
return nil, f.restoreErr
}
return f.restoredShifts, nil
}
type fakeNotifier struct {
notifications []struct {
VolunteerID int64
Message string
}
}
func (f *fakeNotifier) CreateNotification(_ context.Context, volunteerID int64, message string) error {
f.notifications = append(f.notifications, struct {
VolunteerID int64
Message string
}{volunteerID, message})
return nil
}
type fakeAdminLister struct {
adminIDs []int64
}
func (f *fakeAdminLister) ListAdminIDs(_ context.Context) ([]int64, error) {
return f.adminIDs, nil
}
// ---------------------------------------------------------------------------
// Helpers
// ---------------------------------------------------------------------------
func jwtForRole(t *testing.T, id int64, role string) string {
t.Helper()
svc := auth.NewService(nil, "test-secret")
token, err := svc.IssueToken(id, role)
if err != nil {
t.Fatalf("issue token: %v", err)
}
return token
}
func newRouter(h *timeoff.Handler) http.Handler {
realAuthSvc := auth.NewService(nil, "test-secret")
r := chi.NewRouter()
r.Group(func(r chi.Router) {
r.Use(middleware.Authenticate(realAuthSvc))
r.Get("/api/v1/timeoff", h.List)
r.Post("/api/v1/timeoff", h.Create)
r.Put("/api/v1/timeoff/{id}", h.Update)
r.Delete("/api/v1/timeoff/{id}", h.Delete)
r.Put("/api/v1/timeoff/{id}/review",
middleware.RequireAdmin(http.HandlerFunc(h.Review)).ServeHTTP)
r.Get("/api/v1/timeoff/{id}/shifts",
middleware.RequireAdmin(http.HandlerFunc(h.RemovedShifts)).ServeHTTP)
})
return r
}
func do(t *testing.T, router http.Handler, method, path, body, token string) *httptest.ResponseRecorder {
t.Helper()
var b *bytes.Reader
if body != "" {
b = bytes.NewReader([]byte(body))
} else {
b = bytes.NewReader(nil)
}
req := httptest.NewRequest(method, path, b)
if body != "" {
req.Header.Set("Content-Type", "application/json")
}
if token != "" {
req.Header.Set("Authorization", "Bearer "+token)
}
w := httptest.NewRecorder()
router.ServeHTTP(w, req)
return w
}
func setup(store *fakeStore) (*timeoff.Handler, http.Handler) {
notifier := &fakeNotifier{}
adminLister := &fakeAdminLister{adminIDs: []int64{1}}
h := timeoff.NewHandlerFromInterfaces(store, notifier, adminLister)
return h, newRouter(h)
}
// ---------------------------------------------------------------------------
// Tests
// ---------------------------------------------------------------------------
func TestList_VolunteerSeesOwn(t *testing.T) {
store := &fakeStore{
requests: []timeoff.Request{
{ID: 1, VolunteerID: 10, Status: "approved"},
{ID: 2, VolunteerID: 20, Status: "pending"},
},
}
_, router := setup(store)
token := jwtForRole(t, 10, "volunteer")
w := do(t, router, "GET", "/api/v1/timeoff", "", token)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body)
}
var result []timeoff.Request
json.NewDecoder(w.Body).Decode(&result)
if len(result) != 1 {
t.Fatalf("expected 1 request, got %d", len(result))
}
if result[0].VolunteerID != 10 {
t.Errorf("expected volunteer_id=10, got %d", result[0].VolunteerID)
}
}
func TestList_AdminSeesAll(t *testing.T) {
store := &fakeStore{
requests: []timeoff.Request{
{ID: 1, VolunteerID: 10, Status: "approved"},
{ID: 2, VolunteerID: 20, Status: "pending"},
},
}
_, router := setup(store)
token := jwtForRole(t, 1, "admin")
w := do(t, router, "GET", "/api/v1/timeoff", "", token)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d", w.Code)
}
var result []timeoff.Request
json.NewDecoder(w.Body).Decode(&result)
if len(result) != 2 {
t.Errorf("expected 2 requests, got %d", len(result))
}
}
func TestCreate_NoConflicts(t *testing.T) {
store := &fakeStore{}
_, router := setup(store)
token := jwtForRole(t, 10, "volunteer")
body := `{"starts_at":"2026-05-01","ends_at":"2026-05-03","reason":"vacation"}`
w := do(t, router, "POST", "/api/v1/timeoff", body, token)
if w.Code != http.StatusCreated {
t.Fatalf("expected 201, got %d: %s", w.Code, w.Body)
}
}
func TestCreate_ConflictReturns409(t *testing.T) {
store := &fakeStore{
conflicts: []timeoff.ConflictingShift{
{InstanceID: 100, Name: "Morning Walk", Date: "2026-05-01", StartTime: "08:00:00", EndTime: "12:00:00"},
},
}
_, router := setup(store)
token := jwtForRole(t, 10, "volunteer")
body := `{"starts_at":"2026-05-01","ends_at":"2026-05-03"}`
w := do(t, router, "POST", "/api/v1/timeoff", body, token)
if w.Code != http.StatusConflict {
t.Fatalf("expected 409, got %d: %s", w.Code, w.Body)
}
var result map[string]any
json.NewDecoder(w.Body).Decode(&result)
conflicts := result["conflicts"].([]any)
if len(conflicts) != 1 {
t.Errorf("expected 1 conflict, got %d", len(conflicts))
}
}
func TestCreate_ConfirmConflictsProceeds(t *testing.T) {
store := &fakeStore{
conflicts: []timeoff.ConflictingShift{
{InstanceID: 100, Name: "Morning Walk", Date: "2026-05-01"},
},
removedShifts: []timeoff.ConflictingShift{
{InstanceID: 100, Name: "Morning Walk", Date: "2026-05-01"},
},
}
_, router := setup(store)
token := jwtForRole(t, 10, "volunteer")
body := `{"starts_at":"2026-05-01","ends_at":"2026-05-03","confirm_conflicts":true}`
w := do(t, router, "POST", "/api/v1/timeoff", body, token)
if w.Code != http.StatusCreated {
t.Fatalf("expected 201, got %d: %s", w.Code, w.Body)
}
if !store.removeCalled {
t.Error("expected RemoveFromConflictingShifts to be called")
}
}
func TestCreate_AdminForOtherVolunteer(t *testing.T) {
store := &fakeStore{}
_, router := setup(store)
token := jwtForRole(t, 1, "admin")
body := `{"starts_at":"2026-05-01","ends_at":"2026-05-03","volunteer_id":20}`
w := do(t, router, "POST", "/api/v1/timeoff", body, token)
if w.Code != http.StatusCreated {
t.Fatalf("expected 201, got %d: %s", w.Code, w.Body)
}
}
func TestUpdate_VolunteerOwnFuture(t *testing.T) {
store := &fakeStore{
getResult: &timeoff.Request{
ID: 1, VolunteerID: 10, Status: "approved",
StartsAt: time.Date(2026, 5, 1, 0, 0, 0, 0, time.UTC),
EndsAt: time.Date(2026, 5, 3, 0, 0, 0, 0, time.UTC),
},
}
_, router := setup(store)
token := jwtForRole(t, 10, "volunteer")
body := `{"starts_at":"2026-05-02","ends_at":"2026-05-04","reason":"extended"}`
w := do(t, router, "PUT", "/api/v1/timeoff/1", body, token)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body)
}
}
func TestUpdate_VolunteerCannotEditOthers(t *testing.T) {
store := &fakeStore{
getResult: &timeoff.Request{
ID: 1, VolunteerID: 20, Status: "approved",
StartsAt: time.Date(2026, 5, 1, 0, 0, 0, 0, time.UTC),
},
}
_, router := setup(store)
token := jwtForRole(t, 10, "volunteer")
body := `{"starts_at":"2026-05-02","ends_at":"2026-05-04"}`
w := do(t, router, "PUT", "/api/v1/timeoff/1", body, token)
if w.Code != http.StatusForbidden {
t.Fatalf("expected 403, got %d: %s", w.Code, w.Body)
}
}
func TestUpdate_VolunteerCannotEditPast(t *testing.T) {
store := &fakeStore{
getResult: &timeoff.Request{
ID: 1, VolunteerID: 10, Status: "approved",
StartsAt: time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC),
},
}
_, router := setup(store)
token := jwtForRole(t, 10, "volunteer")
body := `{"starts_at":"2026-05-02","ends_at":"2026-05-04"}`
w := do(t, router, "PUT", "/api/v1/timeoff/1", body, token)
if w.Code != http.StatusForbidden {
t.Fatalf("expected 403, got %d: %s", w.Code, w.Body)
}
}
func TestDelete_VolunteerOwnFuture(t *testing.T) {
store := &fakeStore{
getResult: &timeoff.Request{
ID: 1, VolunteerID: 10, Status: "approved",
StartsAt: time.Date(2026, 5, 1, 0, 0, 0, 0, time.UTC),
},
}
_, router := setup(store)
token := jwtForRole(t, 10, "volunteer")
w := do(t, router, "DELETE", "/api/v1/timeoff/1", "", token)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body)
}
}
func TestDelete_VolunteerCannotDeleteOthers(t *testing.T) {
store := &fakeStore{
getResult: &timeoff.Request{
ID: 1, VolunteerID: 20, Status: "approved",
StartsAt: time.Date(2026, 5, 1, 0, 0, 0, 0, time.UTC),
},
}
_, router := setup(store)
token := jwtForRole(t, 10, "volunteer")
w := do(t, router, "DELETE", "/api/v1/timeoff/1", "", token)
if w.Code != http.StatusForbidden {
t.Fatalf("expected 403, got %d: %s", w.Code, w.Body)
}
}
func TestDelete_AdminRestoresShifts(t *testing.T) {
store := &fakeStore{
getResult: &timeoff.Request{
ID: 1, VolunteerID: 10, Status: "approved",
StartsAt: time.Date(2026, 5, 1, 0, 0, 0, 0, time.UTC),
},
restoredShifts: []timeoff.ConflictingShift{
{InstanceID: 100, Name: "Morning Walk", Date: "2026-05-01"},
},
}
_, router := setup(store)
token := jwtForRole(t, 1, "admin")
w := do(t, router, "DELETE", "/api/v1/timeoff/1", "", token)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body)
}
if !store.restoreCalled {
t.Error("expected RestoreRemovedShifts to be called")
}
var result map[string]any
json.NewDecoder(w.Body).Decode(&result)
restored := result["restored_shifts"].([]any)
if len(restored) != 1 {
t.Errorf("expected 1 restored shift, got %d", len(restored))
}
}
func TestRemovedShifts_AdminOnly(t *testing.T) {
store := &fakeStore{
removedForTimeOff: []timeoff.ConflictingShift{
{InstanceID: 100, Name: "Morning Walk", Date: "2026-05-01"},
},
}
_, router := setup(store)
// Volunteer should get 403
volToken := jwtForRole(t, 10, "volunteer")
w := do(t, router, "GET", "/api/v1/timeoff/1/shifts", "", volToken)
if w.Code != http.StatusForbidden {
t.Fatalf("expected 403 for volunteer, got %d", w.Code)
}
// Admin should get 200
adminToken := jwtForRole(t, 1, "admin")
w = do(t, router, "GET", "/api/v1/timeoff/1/shifts", "", adminToken)
if w.Code != http.StatusOK {
t.Fatalf("expected 200 for admin, got %d: %s", w.Code, w.Body)
}
var shifts []timeoff.ConflictingShift
json.NewDecoder(w.Body).Decode(&shifts)
if len(shifts) != 1 {
t.Errorf("expected 1 shift, got %d", len(shifts))
}
}
func TestReview_AdminOnly(t *testing.T) {
store := &fakeStore{}
_, router := setup(store)
volToken := jwtForRole(t, 10, "volunteer")
body := `{"status":"approved"}`
w := do(t, router, "PUT", "/api/v1/timeoff/1/review", body, volToken)
if w.Code != http.StatusForbidden {
t.Fatalf("expected 403 for volunteer, got %d", w.Code)
}
}
func TestReview_InvalidStatus(t *testing.T) {
store := &fakeStore{}
_, router := setup(store)
adminToken := jwtForRole(t, 1, "admin")
body := `{"status":"maybe"}`
w := do(t, router, "PUT", "/api/v1/timeoff/1/review", body, adminToken)
if w.Code != http.StatusBadRequest {
t.Fatalf("expected 400, got %d: %s", w.Code, w.Body)
}
}
func TestCreate_MissingDates(t *testing.T) {
store := &fakeStore{}
_, router := setup(store)
token := jwtForRole(t, 10, "volunteer")
body := `{"reason":"vacation"}`
w := do(t, router, "POST", "/api/v1/timeoff", body, token)
if w.Code != http.StatusBadRequest {
t.Fatalf("expected 400, got %d", w.Code)
}
}

View File

@@ -27,37 +27,12 @@ type CreateInput struct {
StartsAt string `json:"starts_at"` StartsAt string `json:"starts_at"`
EndsAt string `json:"ends_at"` EndsAt string `json:"ends_at"`
Reason string `json:"reason"` Reason string `json:"reason"`
VolunteerID int64 `json:"volunteer_id,omitempty"` // admin creating for another volunteer
ConfirmConflicts bool `json:"confirm_conflicts,omitempty"` // acknowledge shift conflicts
}
type UpdateInput struct {
StartsAt string `json:"starts_at"`
EndsAt string `json:"ends_at"`
Reason string `json:"reason"`
} }
type ReviewInput struct { type ReviewInput struct {
Status string `json:"status"` // "approved" | "rejected" Status string `json:"status"` // "approved" | "rejected"
} }
// ConflictingShift is a shift instance that overlaps with a time-off period.
type ConflictingShift struct {
InstanceID int64 `json:"instance_id"`
Name string `json:"name"`
Date string `json:"date"`
StartTime string `json:"start_time"`
EndTime string `json:"end_time"`
}
// RemovedShift records that a volunteer was removed from a shift due to time off.
type RemovedShift struct {
ID int64 `json:"id"`
TimeOffID int64 `json:"time_off_id"`
InstanceID int64 `json:"instance_id"`
VolunteerID int64 `json:"volunteer_id"`
}
type Store struct { type Store struct {
db *sql.DB db *sql.DB
} }
@@ -80,20 +55,25 @@ func (s *Store) Create(ctx context.Context, volunteerID int64, in CreateInput) (
func (s *Store) GetByID(ctx context.Context, id int64) (*Request, error) { func (s *Store) GetByID(ctx context.Context, id int64) (*Request, error) {
req := &Request{} req := &Request{}
var startsAt, endsAt, createdAt, updatedAt string
var reason sql.NullString var reason sql.NullString
var reviewedBy sql.NullInt64 var reviewedBy sql.NullInt64
var reviewedAt sql.NullTime var reviewedAt sql.NullString
err := s.db.QueryRowContext(ctx, err := s.db.QueryRowContext(ctx,
`SELECT id, volunteer_id, starts_at, ends_at, reason, status, reviewed_by, reviewed_at, created_at, updated_at `SELECT id, volunteer_id, starts_at, ends_at, reason, status, reviewed_by, reviewed_at, created_at, updated_at
FROM time_off_requests WHERE id = ?`, id, FROM time_off_requests WHERE id = ?`, id,
).Scan(&req.ID, &req.VolunteerID, &req.StartsAt, &req.EndsAt, &reason, &req.Status, &reviewedBy, &reviewedAt, &req.CreatedAt, &req.UpdatedAt) ).Scan(&req.ID, &req.VolunteerID, &startsAt, &endsAt, &reason, &req.Status, &reviewedBy, &reviewedAt, &createdAt, &updatedAt)
if errors.Is(err, sql.ErrNoRows) { if errors.Is(err, sql.ErrNoRows) {
return nil, ErrNotFound return nil, ErrNotFound
} }
if err != nil { if err != nil {
return nil, fmt.Errorf("get time off request: %w", err) return nil, fmt.Errorf("get time off request: %w", err)
} }
req.StartsAt, _ = time.Parse("2006-01-02 15:04:05", startsAt)
req.EndsAt, _ = time.Parse("2006-01-02 15:04:05", endsAt)
req.CreatedAt, _ = time.Parse("2006-01-02 15:04:05", createdAt)
req.UpdatedAt, _ = time.Parse("2006-01-02 15:04:05", updatedAt)
if reason.Valid { if reason.Valid {
req.Reason = reason.String req.Reason = reason.String
} }
@@ -101,7 +81,8 @@ func (s *Store) GetByID(ctx context.Context, id int64) (*Request, error) {
req.ReviewedBy = &reviewedBy.Int64 req.ReviewedBy = &reviewedBy.Int64
} }
if reviewedAt.Valid { if reviewedAt.Valid {
req.ReviewedAt = &reviewedAt.Time t, _ := time.Parse("2006-01-02 15:04:05", reviewedAt.String)
req.ReviewedAt = &t
} }
return req, nil return req, nil
} }
@@ -124,12 +105,17 @@ func (s *Store) List(ctx context.Context, volunteerID int64) ([]Request, error)
var requests []Request var requests []Request
for rows.Next() { for rows.Next() {
var req Request var req Request
var startsAt, endsAt, createdAt, updatedAt string
var reason sql.NullString var reason sql.NullString
var reviewedBy sql.NullInt64 var reviewedBy sql.NullInt64
var reviewedAt sql.NullTime var reviewedAt sql.NullString
if err := rows.Scan(&req.ID, &req.VolunteerID, &req.StartsAt, &req.EndsAt, &reason, &req.Status, &reviewedBy, &reviewedAt, &req.CreatedAt, &req.UpdatedAt); err != nil { if err := rows.Scan(&req.ID, &req.VolunteerID, &startsAt, &endsAt, &reason, &req.Status, &reviewedBy, &reviewedAt, &createdAt, &updatedAt); err != nil {
return nil, err return nil, err
} }
req.StartsAt, _ = time.Parse("2006-01-02 15:04:05", startsAt)
req.EndsAt, _ = time.Parse("2006-01-02 15:04:05", endsAt)
req.CreatedAt, _ = time.Parse("2006-01-02 15:04:05", createdAt)
req.UpdatedAt, _ = time.Parse("2006-01-02 15:04:05", updatedAt)
if reason.Valid { if reason.Valid {
req.Reason = reason.String req.Reason = reason.String
} }
@@ -137,7 +123,8 @@ func (s *Store) List(ctx context.Context, volunteerID int64) ([]Request, error)
req.ReviewedBy = &reviewedBy.Int64 req.ReviewedBy = &reviewedBy.Int64
} }
if reviewedAt.Valid { if reviewedAt.Valid {
req.ReviewedAt = &reviewedAt.Time t, _ := time.Parse("2006-01-02 15:04:05", reviewedAt.String)
req.ReviewedAt = &t
} }
requests = append(requests, req) requests = append(requests, req)
} }
@@ -154,207 +141,3 @@ func (s *Store) Review(ctx context.Context, id, reviewerID int64, status string)
} }
return s.GetByID(ctx, id) return s.GetByID(ctx, id)
} }
// Update edits a time-off request's dates and reason.
func (s *Store) Update(ctx context.Context, id int64, in UpdateInput) (*Request, error) {
_, err := s.db.ExecContext(ctx,
`UPDATE time_off_requests SET starts_at=?, ends_at=?, reason=?, updated_at=NOW() WHERE id=?`,
in.StartsAt, in.EndsAt, in.Reason, id,
)
if err != nil {
return nil, fmt.Errorf("update time off request: %w", err)
}
return s.GetByID(ctx, id)
}
// Delete removes a time-off request.
func (s *Store) Delete(ctx context.Context, id int64) error {
result, err := s.db.ExecContext(ctx, `DELETE FROM time_off_requests WHERE id = ?`, id)
if err != nil {
return fmt.Errorf("delete time off request: %w", err)
}
affected, _ := result.RowsAffected()
if affected == 0 {
return ErrNotFound
}
return nil
}
// ConflictingShifts returns published shift instances where the volunteer is assigned
// and the shift date falls within the given date range (inclusive).
func (s *Store) ConflictingShifts(ctx context.Context, volunteerID int64, startsAt, endsAt string) ([]ConflictingShift, error) {
rows, err := s.db.QueryContext(ctx,
`SELECT si.id, si.name, si.date, si.start_time, si.end_time
FROM shift_instances si
JOIN shift_instance_volunteers siv ON siv.instance_id = si.id
WHERE siv.volunteer_id = ?
AND si.date >= ?
AND si.date <= ?
ORDER BY si.date`, volunteerID, startsAt, endsAt,
)
if err != nil {
return nil, fmt.Errorf("query conflicting shifts: %w", err)
}
defer rows.Close()
var shifts []ConflictingShift
for rows.Next() {
var cs ConflictingShift
if err := rows.Scan(&cs.InstanceID, &cs.Name, &cs.Date, &cs.StartTime, &cs.EndTime); err != nil {
return nil, err
}
shifts = append(shifts, cs)
}
return shifts, rows.Err()
}
// RemoveFromConflictingShifts removes the volunteer from shifts that overlap with
// the time-off period and records the removals for later restoration.
func (s *Store) RemoveFromConflictingShifts(ctx context.Context, timeOffID, volunteerID int64, startsAt, endsAt string) ([]ConflictingShift, error) {
conflicts, err := s.ConflictingShifts(ctx, volunteerID, startsAt, endsAt)
if err != nil {
return nil, err
}
if len(conflicts) == 0 {
return nil, nil
}
tx, err := s.db.BeginTx(ctx, nil)
if err != nil {
return nil, fmt.Errorf("begin tx: %w", err)
}
defer tx.Rollback()
for _, c := range conflicts {
// Record the removal
if _, err := tx.ExecContext(ctx,
`INSERT INTO time_off_removed_shifts (time_off_id, instance_id, volunteer_id) VALUES (?, ?, ?)`,
timeOffID, c.InstanceID, volunteerID,
); err != nil {
return nil, fmt.Errorf("record removal: %w", err)
}
// Remove volunteer from shift
if _, err := tx.ExecContext(ctx,
`DELETE FROM shift_instance_volunteers WHERE instance_id = ? AND volunteer_id = ?`,
c.InstanceID, volunteerID,
); err != nil {
return nil, fmt.Errorf("remove from shift: %w", err)
}
}
if err := tx.Commit(); err != nil {
return nil, fmt.Errorf("commit: %w", err)
}
return conflicts, nil
}
// RemovedShiftsForTimeOff returns shifts from which the volunteer was removed
// due to the given time-off request (for preview before admin deletes time off).
func (s *Store) RemovedShiftsForTimeOff(ctx context.Context, timeOffID int64) ([]ConflictingShift, error) {
rows, err := s.db.QueryContext(ctx,
`SELECT si.id, si.name, si.date, si.start_time, si.end_time
FROM time_off_removed_shifts tors
JOIN shift_instances si ON si.id = tors.instance_id
WHERE tors.time_off_id = ?
ORDER BY si.date`, timeOffID,
)
if err != nil {
return nil, fmt.Errorf("query removed shifts: %w", err)
}
defer rows.Close()
var shifts []ConflictingShift
for rows.Next() {
var cs ConflictingShift
if err := rows.Scan(&cs.InstanceID, &cs.Name, &cs.Date, &cs.StartTime, &cs.EndTime); err != nil {
return nil, err
}
shifts = append(shifts, cs)
}
return shifts, rows.Err()
}
// RestoreRemovedShifts re-adds the volunteer to shifts they were removed from
// when the given time-off request is deleted (FR-T04).
func (s *Store) RestoreRemovedShifts(ctx context.Context, timeOffID int64) ([]ConflictingShift, error) {
// Get the removals first
rows, err := s.db.QueryContext(ctx,
`SELECT tors.instance_id, tors.volunteer_id, si.name, si.date, si.start_time, si.end_time
FROM time_off_removed_shifts tors
JOIN shift_instances si ON si.id = tors.instance_id
WHERE tors.time_off_id = ?`, timeOffID,
)
if err != nil {
return nil, fmt.Errorf("query removals: %w", err)
}
defer rows.Close()
type removal struct {
instanceID int64
volunteerID int64
shift ConflictingShift
}
var removals []removal
for rows.Next() {
var r removal
if err := rows.Scan(&r.instanceID, &r.volunteerID, &r.shift.Name, &r.shift.Date, &r.shift.StartTime, &r.shift.EndTime); err != nil {
return nil, err
}
r.shift.InstanceID = r.instanceID
removals = append(removals, r)
}
if err := rows.Err(); err != nil {
return nil, err
}
if len(removals) == 0 {
return nil, nil
}
tx, err := s.db.BeginTx(ctx, nil)
if err != nil {
return nil, fmt.Errorf("begin tx: %w", err)
}
defer tx.Rollback()
var restored []ConflictingShift
for _, r := range removals {
// Re-add to shift (ignore duplicate if they were re-added manually)
_, err := tx.ExecContext(ctx,
`INSERT IGNORE INTO shift_instance_volunteers (instance_id, volunteer_id) VALUES (?, ?)`,
r.instanceID, r.volunteerID,
)
if err != nil {
return nil, fmt.Errorf("restore to shift: %w", err)
}
restored = append(restored, r.shift)
}
// Clean up removal records (CASCADE will handle this on time-off delete,
// but we clean up explicitly since we're restoring)
if _, err := tx.ExecContext(ctx,
`DELETE FROM time_off_removed_shifts WHERE time_off_id = ?`, timeOffID,
); err != nil {
return nil, fmt.Errorf("clean removals: %w", err)
}
if err := tx.Commit(); err != nil {
return nil, fmt.Errorf("commit: %w", err)
}
return restored, nil
}
// HasApprovedTimeOff checks if a volunteer has approved time off covering the given date.
func (s *Store) HasApprovedTimeOff(ctx context.Context, volunteerID int64, date string) (bool, error) {
var count int
err := s.db.QueryRowContext(ctx,
`SELECT COUNT(*) FROM time_off_requests
WHERE volunteer_id = ? AND status = 'approved'
AND ? >= DATE(starts_at) AND ? <= DATE(ends_at)`,
volunteerID, date, date,
).Scan(&count)
if err != nil {
return false, fmt.Errorf("check time off: %w", err)
}
return count > 0, nil
}

View File

@@ -397,25 +397,6 @@ func (s *Store) RecordLogin(ctx context.Context, id int64) error {
return err return err
} }
// ListAdminIDs returns the IDs of all active admin users.
func (s *Store) ListAdminIDs(ctx context.Context) ([]int64, error) {
rows, err := s.db.QueryContext(ctx,
`SELECT id FROM volunteers WHERE role = 'admin' AND active = 1`)
if err != nil {
return nil, fmt.Errorf("list admin IDs: %w", err)
}
defer rows.Close()
var ids []int64
for rows.Next() {
var id int64
if err := rows.Scan(&id); err != nil {
return nil, err
}
ids = append(ids, id)
}
return ids, rows.Err()
}
func generateToken() (string, error) { func generateToken() (string, error) {
b := make([]byte, 32) b := make([]byte, 32)
if _, err := rand.Read(b); err != nil { if _, err := rand.Read(b); err != nil {

8
web/.gitignore vendored
View File

@@ -1,11 +1,15 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.
# dependencies # dependencies
/node_modules /node_modules
/.pnp
.pnp.js
# testing # testing
/coverage /coverage
# production # production
/dist /build
# misc # misc
.DS_Store .DS_Store
@@ -15,3 +19,5 @@
.env.production.local .env.production.local
npm-debug.log* npm-debug.log*
yarn-debug.log*
yarn-error.log*

View File

@@ -1 +0,0 @@
ignore-scripts=true

View File

@@ -1,21 +1,46 @@
# Walkies Frontend # Getting Started with Create React App
React + TypeScript frontend built with [Vite](https://vite.dev/). Tests run with [Vitest](https://vitest.dev/). This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app).
## Available Scripts ## Available Scripts
### `npm run dev` In the project directory, you can run:
Starts the development server on [http://localhost:3000](http://localhost:3000) with hot module replacement. API requests to `/api` are proxied to `http://localhost:8080`. ### `npm start`
Runs the app in the development mode.\
Open [http://localhost:3000](http://localhost:3000) to view it in the browser.
The page will reload if you make edits.\
You will also see any lint errors in the console.
### `npm test` ### `npm test`
Runs all tests once using Vitest with jsdom. Launches the test runner in the interactive watch mode.\
See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information.
### `npm run build` ### `npm run build`
Type-checks with `tsc` then builds the app for production into the `dist` folder. Builds the app for production to the `build` folder.\
It correctly bundles React in production mode and optimizes the build for the best performance.
### `npm run preview` The build is minified and the filenames include the hashes.\
Your app is ready to be deployed!
Serves the production build locally for previewing. See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information.
### `npm run eject`
**Note: this is a one-way operation. Once you `eject`, you cant go back!**
If you arent satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project.
Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point youre on your own.
You dont have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldnt feel obligated to use this feature. However we understand that this tool wouldnt be useful if you couldnt customize it when you are ready for it.
## Learn More
You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).
To learn React, check out the [React documentation](https://reactjs.org/).

View File

@@ -1,18 +0,0 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="icon" href="/favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#000000" />
<meta name="description" content="Walkies - Volunteer scheduling" />
<link rel="apple-touch-icon" href="/logo192.png" />
<link rel="manifest" href="/manifest.json" />
<title>Walkies</title>
</head>
<body>
<noscript>You need to enable JavaScript to run this app.</noscript>
<div id="root"></div>
<script type="module" src="/src/main.tsx"></script>
</body>
</html>

18295
web/package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@@ -2,38 +2,52 @@
"name": "web", "name": "web",
"version": "0.1.0", "version": "0.1.0",
"private": true, "private": true,
"type": "module",
"dependencies": { "dependencies": {
"@lavamoat/preinstall-always-fail": "^3.0.0",
"react": "^19.2.4",
"react-dom": "^19.2.4",
"react-router-dom": "^7.13.1"
},
"scripts": {
"dev": "vite",
"build": "tsc -b tsconfig.app.json && vite build",
"preview": "vite preview",
"test": "vitest run"
},
"devDependencies": {
"@lavamoat/allow-scripts": "^5.0.1",
"@testing-library/dom": "^10.4.1", "@testing-library/dom": "^10.4.1",
"@testing-library/jest-dom": "^6.9.1", "@testing-library/jest-dom": "^6.9.1",
"@testing-library/react": "^16.3.2", "@testing-library/react": "^16.3.2",
"@testing-library/user-event": "^14.6.1", "@testing-library/user-event": "^13.5.0",
"@types/node": "^25.5.2", "@types/jest": "^27.5.2",
"@types/node": "^16.18.126",
"@types/react": "^19.2.14", "@types/react": "^19.2.14",
"@types/react-dom": "^19.2.3", "@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.1", "@types/react-router-dom": "^5.3.3",
"@vitest/coverage-v8": "^4.1.4", "react": "^19.2.4",
"jsdom": "^29.0.2", "react-dom": "^19.2.4",
"typescript": "^6.0.2", "react-router-dom": "^7.13.1",
"vite": "^8.0.8", "react-scripts": "5.0.1",
"vitest": "^4.1.4" "typescript": "^4.9.5",
"web-vitals": "^2.1.4"
}, },
"lavamoat": { "scripts": {
"allowScripts": { "start": "react-scripts start",
"@lavamoat/preinstall-always-fail": false "build": "react-scripts build",
} "test": "react-scripts test",
"eject": "react-scripts eject"
},
"eslintConfig": {
"extends": [
"react-app",
"react-app/jest"
]
},
"jest": {
"moduleNameMapper": {
"^react-router-dom$": "<rootDir>/node_modules/react-router-dom/dist/index.js",
"^react-router$": "<rootDir>/node_modules/react-router/dist/development/index.js",
"^react-router/dom$": "<rootDir>/node_modules/react-router/dist/development/dom-export.js"
}
},
"browserslist": {
"production": [
">0.2%",
"not dead",
"not op_mini all"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
]
} }
} }

43
web/public/index.html Normal file
View File

@@ -0,0 +1,43 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#000000" />
<meta
name="description"
content="Web site created using create-react-app"
/>
<link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" />
<!--
manifest.json provides metadata used when your web app is installed on a
user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/
-->
<link rel="manifest" href="%PUBLIC_URL%/manifest.json" />
<!--
Notice the use of %PUBLIC_URL% in the tags above.
It will be replaced with the URL of the `public` folder during the build.
Only files inside the `public` folder can be referenced from the HTML.
Unlike "/favicon.ico" or "favicon.ico", "%PUBLIC_URL%/favicon.ico" will
work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
<title>React App</title>
</head>
<body>
<noscript>You need to enable JavaScript to run this app.</noscript>
<div id="root"></div>
<!--
This HTML file is a template.
If you open it directly in the browser, you will see an empty page.
You can add webfonts, meta tags, or analytics to this file.
The build step will place the bundled scripts into the <body> tag.
To begin the development, run `npm start` or `yarn start`.
To create a production bundle, use `npm run build` or `yarn build`.
-->
</body>
</html>

View File

@@ -1,43 +1,29 @@
import React from 'react'; import React from 'react';
import { render, screen } from '@testing-library/react'; import { render, screen } from '@testing-library/react';
import { vi, type Mock } from 'vitest';
import App from './App'; import App from './App';
import { api } from './api';
vi.mock('./api', () => ({ // Mock all API calls so the app renders without a backend
jest.mock('./api', () => ({
api: { api: {
getSetupStatus: vi.fn(), listVolunteers: jest.fn().mockResolvedValue([]),
createSetupAdmin: vi.fn(), listSchedules: jest.fn().mockResolvedValue([]),
listVolunteers: vi.fn().mockResolvedValue([]), listTimeOff: jest.fn().mockResolvedValue([]),
listSchedules: vi.fn().mockResolvedValue([]), listNotifications: jest.fn().mockResolvedValue([]),
listTimeOff: vi.fn().mockResolvedValue([]), getVolunteer: jest.fn().mockResolvedValue(null),
listNotifications: vi.fn().mockResolvedValue([]),
getVolunteer: vi.fn().mockResolvedValue(null),
}, },
OPERATIONAL_ROLES: [], OPERATIONAL_ROLES: [],
})); }));
const mockGetSetupStatus = api.getSetupStatus as Mock; test('renders login page when unauthenticated', () => {
beforeEach(() => {
localStorage.clear(); localStorage.clear();
mockGetSetupStatus.mockResolvedValue({ needs_setup: false }); render(<App />);
expect(screen.getByRole('heading', { name: /sign in/i })).toBeInTheDocument();
}); });
test('renders login page when unauthenticated and setup done', async () => { test('login page has email and password fields', () => {
localStorage.clear();
render(<App />); render(<App />);
expect(await screen.findByRole('heading', { name: /sign in/i })).toBeInTheDocument(); expect(screen.getByLabelText(/email/i)).toBeInTheDocument();
});
test('login page has email and password fields', async () => {
render(<App />);
expect(await screen.findByLabelText(/email/i)).toBeInTheDocument();
expect(screen.getByLabelText(/password/i)).toBeInTheDocument(); expect(screen.getByLabelText(/password/i)).toBeInTheDocument();
expect(screen.getByRole('button', { name: /sign in/i })).toBeInTheDocument(); expect(screen.getByRole('button', { name: /sign in/i })).toBeInTheDocument();
}); });
test('redirects to setup when needs_setup is true', async () => {
mockGetSetupStatus.mockResolvedValue({ needs_setup: true });
render(<App />);
expect(await screen.findByRole('heading', { name: /initial setup/i })).toBeInTheDocument();
});

View File

@@ -1,10 +1,8 @@
import React, { createContext, useContext, useState, useEffect, ReactNode } from 'react'; import React from 'react';
import { BrowserRouter, Routes, Route, NavLink, Navigate } from 'react-router-dom'; import { BrowserRouter, Routes, Route, NavLink, Navigate } from 'react-router-dom';
import { AuthProvider, useAuth } from './auth'; import { AuthProvider, useAuth } from './auth';
import { api } from './api';
import Login from './pages/Login'; import Login from './pages/Login';
import Activate from './pages/Activate'; import Activate from './pages/Activate';
import Setup from './pages/Setup';
import Dashboard from './pages/Dashboard'; import Dashboard from './pages/Dashboard';
import Schedules from './pages/Schedules'; import Schedules from './pages/Schedules';
import TimeOff from './pages/TimeOff'; import TimeOff from './pages/TimeOff';
@@ -36,7 +34,6 @@ function ProtectedLayout() {
<main> <main>
<Routes> <Routes>
<Route path="/" element={<Dashboard />} /> <Route path="/" element={<Dashboard />} />
<Route path="/schedules/templates" element={<Schedules />} />
<Route path="/schedules" element={<Schedules />} /> <Route path="/schedules" element={<Schedules />} />
<Route path="/timeoff" element={<TimeOff />} /> <Route path="/timeoff" element={<TimeOff />} />
<Route path="/profile" element={<Profile />} /> <Route path="/profile" element={<Profile />} />
@@ -53,57 +50,15 @@ function LoginRoute() {
return <Login />; return <Login />;
} }
// Setup context lets the Setup page flip needsSetup after creating the admin.
const SetupContext = createContext<{ setNeedsSetup: (v: boolean) => void }>({
setNeedsSetup: () => {},
});
export const useSetup = () => useContext(SetupContext);
function SetupGate({ children }: { children: ReactNode }) {
const [needsSetup, setNeedsSetup] = useState<boolean | null>(null);
useEffect(() => {
api.getSetupStatus()
.then(r => setNeedsSetup(r.needs_setup))
.catch(() => setNeedsSetup(false));
}, []);
if (needsSetup === null) return null;
if (needsSetup) {
return (
<SetupContext.Provider value={{ setNeedsSetup }}>
<Routes>
<Route path="/setup" element={<Setup />} />
<Route path="*" element={<Navigate to="/setup" replace />} />
</Routes>
</SetupContext.Provider>
);
}
return (
<SetupContext.Provider value={{ setNeedsSetup }}>
<Routes>
<Route path="/setup" element={<Navigate to="/login" replace />} />
<Route path="/login" element={<LoginRoute />} />
<Route path="/activate" element={<Activate />} />
<Route path="/*" element={<ProtectedLayout />} />
</Routes>
</SetupContext.Provider>
);
}
export default function App() { export default function App() {
return ( return (
<AuthProvider> <AuthProvider>
<BrowserRouter> <BrowserRouter>
<SetupGate>
<Routes> <Routes>
<Route path="/login" element={<LoginRoute />} /> <Route path="/login" element={<LoginRoute />} />
<Route path="/activate" element={<Activate />} /> <Route path="/activate" element={<Activate />} />
<Route path="/*" element={<ProtectedLayout />} /> <Route path="/*" element={<ProtectedLayout />} />
</Routes> </Routes>
</SetupGate>
</BrowserRouter> </BrowserRouter>
</AuthProvider> </AuthProvider>
); );

View File

@@ -4,16 +4,6 @@ function getToken(): string | null {
return localStorage.getItem('token'); return localStorage.getItem('token');
} }
class ApiError extends Error {
status: number;
data: any;
constructor(message: string, status: number, data: any) {
super(message);
this.status = status;
this.data = data;
}
}
async function request<T>(method: string, path: string, body?: unknown): Promise<T> { async function request<T>(method: string, path: string, body?: unknown): Promise<T> {
const headers: Record<string, string> = { 'Content-Type': 'application/json' }; const headers: Record<string, string> = { 'Content-Type': 'application/json' };
const token = getToken(); const token = getToken();
@@ -27,19 +17,11 @@ async function request<T>(method: string, path: string, body?: unknown): Promise
if (res.status === 204) return undefined as T; if (res.status === 204) return undefined as T;
const data = await res.json(); const data = await res.json();
if (!res.ok) throw new ApiError(data.error || data.message || 'Request failed', res.status, data); if (!res.ok) throw new Error(data.error || 'Request failed');
return data as T; return data as T;
} }
export { ApiError };
export const api = { export const api = {
// Setup
getSetupStatus: () =>
request<{ needs_setup: boolean }>('GET', '/setup/status'),
createSetupAdmin: (data: { name: string; email: string; password: string }) =>
request<{ token: string }>('POST', '/setup/admin', data),
// Auth // Auth
login: (email: string, password: string) => login: (email: string, password: string) =>
request<{ token: string }>('POST', '/auth/login', { email, password }), request<{ token: string }>('POST', '/auth/login', { email, password }),
@@ -56,39 +38,18 @@ export const api = {
resendInvite: (id: number) => resendInvite: (id: number) =>
request<{ invite_token: string }>('POST', `/volunteers/${id}/invite`, {}), request<{ invite_token: string }>('POST', `/volunteers/${id}/invite`, {}),
// Shift templates // Schedules
listShiftTemplates: () => request<ShiftTemplate[]>('GET', '/shift-templates'), listSchedules: () => request<Schedule[]>('GET', '/schedules'),
createShiftTemplate: (data: CreateShiftTemplateInput) => createSchedule: (data: CreateScheduleInput) => request<Schedule>('POST', '/schedules', data),
request<ShiftTemplate>('POST', '/shift-templates', data), updateSchedule: (id: number, data: Partial<CreateScheduleInput>) =>
updateShiftTemplate: (id: number, data: Partial<CreateShiftTemplateInput>) => request<Schedule>('PUT', `/schedules/${id}`, data),
request<ShiftTemplate>('PUT', `/shift-templates/${id}`, data), deleteSchedule: (id: number) => request<void>('DELETE', `/schedules/${id}`),
deleteShiftTemplate: (id: number) => request<void>('DELETE', `/shift-templates/${id}`),
// Shift instances
listShifts: (year: number, month: number) =>
request<ShiftInstance[]>('GET', `/shifts?year=${year}&month=${month}`),
generateShifts: (year: number, month: number) =>
request<ShiftInstance[]>('POST', '/shifts/generate', { year, month }),
publishShifts: (year: number, month: number) =>
request<{ year: number; month: number }>('POST', '/shifts/publish', { year, month }),
unpublishShifts: (year: number, month: number) =>
request<{ year: number; month: number }>('POST', '/shifts/unpublish', { year, month }),
updateShift: (id: number, data: UpdateShiftInput) =>
request<ShiftInstance>('PUT', `/shifts/${id}`, data),
confirmShift: (id: number) => request<void>('POST', `/shifts/${id}/confirm`, {}),
// Time off // Time off
listTimeOff: () => request<TimeOffRequest[]>('GET', '/timeoff'), listTimeOff: () => request<TimeOffRequest[]>('GET', '/timeoff'),
createTimeOff: (data: CreateTimeOffInput & { volunteer_id?: number; confirm_conflicts?: boolean }) => createTimeOff: (data: CreateTimeOffInput) => request<TimeOffRequest>('POST', '/timeoff', data),
request<TimeOffRequest | TimeOffConflictResponse>('POST', '/timeoff', data),
updateTimeOff: (id: number, data: { starts_at: string; ends_at: string; reason?: string }) =>
request<TimeOffRequest>('PUT', `/timeoff/${id}`, data),
deleteTimeOff: (id: number) =>
request<{ deleted: boolean; restored_shifts: ConflictingShift[] }>('DELETE', `/timeoff/${id}`),
reviewTimeOff: (id: number, status: 'approved' | 'rejected') => reviewTimeOff: (id: number, status: 'approved' | 'rejected') =>
request<TimeOffRequest>('PUT', `/timeoff/${id}/review`, { status }), request<TimeOffRequest>('PUT', `/timeoff/${id}/review`, { status }),
getRemovedShifts: (id: number) =>
request<ConflictingShift[]>('GET', `/timeoff/${id}/shifts`),
// Check-in / out // Check-in / out
checkIn: (schedule_id?: number, notes?: string) => checkIn: (schedule_id?: number, notes?: string) =>
@@ -143,67 +104,23 @@ export interface UpdateVolunteerInput {
admin_notes?: string; admin_notes?: string;
} }
export interface TemplateRole { export interface Schedule {
id?: number;
template_id?: number;
role_name: string;
count: number;
}
export interface ShiftTemplate {
id: number; id: number;
name: string;
day_of_week: number; // 0=Sun, 1=Mon, ..., 6=Sat
start_time: string;
end_time: string;
min_capacity: number;
max_capacity: number;
roles: TemplateRole[];
volunteer_ids: number[];
created_at: string;
updated_at: string;
}
export interface CreateShiftTemplateInput {
name: string;
day_of_week: number;
start_time: string;
end_time: string;
min_capacity: number;
max_capacity: number;
roles?: TemplateRole[];
volunteer_ids?: number[];
}
export interface InstanceVolunteer {
instance_id: number;
volunteer_id: number; volunteer_id: number;
name: string; title: string;
confirmed: boolean; starts_at: string;
confirmed_at?: string; ends_at: string;
} notes?: string;
export interface ShiftInstance {
id: number;
template_id?: number;
name: string;
date: string; // "YYYY-MM-DD"
start_time: string;
end_time: string;
min_capacity: number;
max_capacity: number;
status: 'draft' | 'published';
year: number;
month: number;
volunteers: InstanceVolunteer[];
created_at: string; created_at: string;
updated_at: string; updated_at: string;
} }
export interface UpdateShiftInput { export interface CreateScheduleInput {
volunteer_ids?: number[]; volunteer_id?: number;
min_capacity?: number; title: string;
max_capacity?: number; starts_at: string;
ends_at: string;
notes?: string;
} }
export interface TimeOffRequest { export interface TimeOffRequest {
@@ -225,19 +142,6 @@ export interface CreateTimeOffInput {
reason?: string; reason?: string;
} }
export interface ConflictingShift {
instance_id: number;
name: string;
date: string;
start_time: string;
end_time: string;
}
export interface TimeOffConflictResponse {
message: string;
conflicts: ConflictingShift[];
}
export interface CheckIn { export interface CheckIn {
id: number; id: number;
volunteer_id: number; volunteer_id: number;
@@ -251,7 +155,7 @@ export interface Notification {
id: number; id: number;
volunteer_id: number; volunteer_id: number;
message: string; message: string;
is_read: boolean; read: boolean;
created_at: string; created_at: string;
} }

19
web/src/index.tsx Normal file
View File

@@ -0,0 +1,19 @@
import React from 'react';
import ReactDOM from 'react-dom/client';
import './index.css';
import App from './App';
import reportWebVitals from './reportWebVitals';
const root = ReactDOM.createRoot(
document.getElementById('root') as HTMLElement
);
root.render(
<React.StrictMode>
<App />
</React.StrictMode>
);
// If you want to start measuring performance in your app, pass a function
// to log results (for example: reportWebVitals(console.log))
// or send to an analytics endpoint. Learn more: https://bit.ly/CRA-vitals
reportWebVitals();

1
web/src/logo.svg Normal file
View File

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 841.9 595.3"><g fill="#61DAFB"><path d="M666.3 296.5c0-32.5-40.7-63.3-103.1-82.4 14.4-63.6 8-114.2-20.2-130.4-6.5-3.8-14.1-5.6-22.4-5.6v22.3c4.6 0 8.3.9 11.4 2.6 13.6 7.8 19.5 37.5 14.9 75.7-1.1 9.4-2.9 19.3-5.1 29.4-19.6-4.8-41-8.5-63.5-10.9-13.5-18.5-27.5-35.3-41.6-50 32.6-30.3 63.2-46.9 84-46.9V78c-27.5 0-63.5 19.6-99.9 53.6-36.4-33.8-72.4-53.2-99.9-53.2v22.3c20.7 0 51.4 16.5 84 46.6-14 14.7-28 31.4-41.3 49.9-22.6 2.4-44 6.1-63.6 11-2.3-10-4-19.7-5.2-29-4.7-38.2 1.1-67.9 14.6-75.8 3-1.8 6.9-2.6 11.5-2.6V78.5c-8.4 0-16 1.8-22.6 5.6-28.1 16.2-34.4 66.7-19.9 130.1-62.2 19.2-102.7 49.9-102.7 82.3 0 32.5 40.7 63.3 103.1 82.4-14.4 63.6-8 114.2 20.2 130.4 6.5 3.8 14.1 5.6 22.5 5.6 27.5 0 63.5-19.6 99.9-53.6 36.4 33.8 72.4 53.2 99.9 53.2 8.4 0 16-1.8 22.6-5.6 28.1-16.2 34.4-66.7 19.9-130.1 62-19.1 102.5-49.9 102.5-82.3zm-130.2-66.7c-3.7 12.9-8.3 26.2-13.5 39.5-4.1-8-8.4-16-13.1-24-4.6-8-9.5-15.8-14.4-23.4 14.2 2.1 27.9 4.7 41 7.9zm-45.8 106.5c-7.8 13.5-15.8 26.3-24.1 38.2-14.9 1.3-30 2-45.2 2-15.1 0-30.2-.7-45-1.9-8.3-11.9-16.4-24.6-24.2-38-7.6-13.1-14.5-26.4-20.8-39.8 6.2-13.4 13.2-26.8 20.7-39.9 7.8-13.5 15.8-26.3 24.1-38.2 14.9-1.3 30-2 45.2-2 15.1 0 30.2.7 45 1.9 8.3 11.9 16.4 24.6 24.2 38 7.6 13.1 14.5 26.4 20.8 39.8-6.3 13.4-13.2 26.8-20.7 39.9zm32.3-13c5.4 13.4 10 26.8 13.8 39.8-13.1 3.2-26.9 5.9-41.2 8 4.9-7.7 9.8-15.6 14.4-23.7 4.6-8 8.9-16.1 13-24.1zM421.2 430c-9.3-9.6-18.6-20.3-27.8-32 9 .4 18.2.7 27.5.7 9.4 0 18.7-.2 27.8-.7-9 11.7-18.3 22.4-27.5 32zm-74.4-58.9c-14.2-2.1-27.9-4.7-41-7.9 3.7-12.9 8.3-26.2 13.5-39.5 4.1 8 8.4 16 13.1 24 4.7 8 9.5 15.8 14.4 23.4zM420.7 163c9.3 9.6 18.6 20.3 27.8 32-9-.4-18.2-.7-27.5-.7-9.4 0-18.7.2-27.8.7 9-11.7 18.3-22.4 27.5-32zm-74 58.9c-4.9 7.7-9.8 15.6-14.4 23.7-4.6 8-8.9 16-13 24-5.4-13.4-10-26.8-13.8-39.8 13.1-3.1 26.9-5.8 41.2-7.9zm-90.5 125.2c-35.4-15.1-58.3-34.9-58.3-50.6 0-15.7 22.9-35.6 58.3-50.6 8.6-3.7 18-7 27.7-10.1 5.7 19.6 13.2 40 22.5 60.9-9.2 20.8-16.6 41.1-22.2 60.6-9.9-3.1-19.3-6.5-28-10.2zM310 490c-13.6-7.8-19.5-37.5-14.9-75.7 1.1-9.4 2.9-19.3 5.1-29.4 19.6 4.8 41 8.5 63.5 10.9 13.5 18.5 27.5 35.3 41.6 50-32.6 30.3-63.2 46.9-84 46.9-4.5-.1-8.3-1-11.3-2.7zm237.2-76.2c4.7 38.2-1.1 67.9-14.6 75.8-3 1.8-6.9 2.6-11.5 2.6-20.7 0-51.4-16.5-84-46.6 14-14.7 28-31.4 41.3-49.9 22.6-2.4 44-6.1 63.6-11 2.3 10.1 4.1 19.8 5.2 29.1zm38.5-66.7c-8.6 3.7-18 7-27.7 10.1-5.7-19.6-13.2-40-22.5-60.9 9.2-20.8 16.6-41.1 22.2-60.6 9.9 3.1 19.3 6.5 28.1 10.2 35.4 15.1 58.3 34.9 58.3 50.6-.1 15.7-23 35.6-58.4 50.6zM320.8 78.4z"/><circle cx="420.9" cy="296.5" r="45.7"/><path d="M520.5 78.1z"/></g></svg>

After

Width:  |  Height:  |  Size: 2.6 KiB

View File

@@ -1,10 +0,0 @@
import React from 'react';
import ReactDOM from 'react-dom/client';
import './index.css';
import App from './App';
ReactDOM.createRoot(document.getElementById('root')!).render(
<React.StrictMode>
<App />
</React.StrictMode>
);

View File

@@ -1,18 +1,17 @@
import React from 'react'; import React from 'react';
import { render, screen, fireEvent, waitFor } from '@testing-library/react'; import { render, screen, fireEvent, waitFor } from '@testing-library/react';
import { vi, type Mock } from 'vitest';
import { MemoryRouter, Route, Routes } from 'react-router-dom'; import { MemoryRouter, Route, Routes } from 'react-router-dom';
import Activate from './Activate'; import Activate from './Activate';
import { api } from '../api'; import { api } from '../api';
import { AuthProvider } from '../auth'; import { AuthProvider } from '../auth';
vi.mock('../api', () => ({ jest.mock('../api', () => ({
api: { api: {
activate: vi.fn(), activate: jest.fn(),
}, },
})); }));
const mockActivate = api.activate as Mock; const mockActivate = api.activate as jest.Mock;
function renderActivate(token = 'valid-token') { function renderActivate(token = 'valid-token') {
return render( return render(

View File

@@ -1,25 +1,24 @@
import React, { useEffect, useState } from 'react'; import React, { useEffect, useState } from 'react';
import { api, CheckIn, Notification, ShiftInstance } from '../api'; import { api, CheckIn, Notification, Schedule } from '../api';
import { useAuth } from '../auth'; import { useAuth } from '../auth';
export default function Dashboard() { export default function Dashboard() {
const { volunteerID } = useAuth(); const { volunteerID } = useAuth();
const now = new Date(); const [schedules, setSchedules] = useState<Schedule[]>([]);
const [schedules, setSchedules] = useState<ShiftInstance[]>([]);
const [notifications, setNotifications] = useState<Notification[]>([]); const [notifications, setNotifications] = useState<Notification[]>([]);
const [activeCheckIn, setActiveCheckIn] = useState<CheckIn | null>(null); const [activeCheckIn, setActiveCheckIn] = useState<CheckIn | null>(null);
const [history, setHistory] = useState<CheckIn[]>([]); const [history, setHistory] = useState<CheckIn[]>([]);
const [error, setError] = useState(''); const [error, setError] = useState('');
useEffect(() => { useEffect(() => {
api.listShifts(now.getFullYear(), now.getMonth() + 1).then(setSchedules).catch(() => {}); api.listSchedules().then(setSchedules).catch(() => {});
api.listNotifications().then(setNotifications).catch(() => {}); api.listNotifications().then(setNotifications).catch(() => {});
api.getHistory().then(data => { api.getHistory().then(data => {
setHistory(data); setHistory(data);
const active = data.find(c => !c.checked_out_at && c.volunteer_id === volunteerID); const active = data.find(c => !c.checked_out_at && c.volunteer_id === volunteerID);
setActiveCheckIn(active ?? null); setActiveCheckIn(active ?? null);
}).catch(() => {}); }).catch(() => {});
}, [volunteerID]); // eslint-disable-line react-hooks/exhaustive-deps }, [volunteerID]);
async function handleCheckIn() { async function handleCheckIn() {
try { try {
@@ -44,15 +43,15 @@ export default function Dashboard() {
async function handleMarkRead(id: number) { async function handleMarkRead(id: number) {
try { try {
await api.markRead(id); await api.markRead(id);
setNotifications(prev => prev.map(n => n.id === id ? { ...n, is_read: true } : n)); setNotifications(prev => prev.map(n => n.id === id ? { ...n, read: true } : n));
} catch {} } catch {}
} }
const upcomingSchedules = schedules const upcomingSchedules = schedules
.filter(s => new Date(s.date) >= now) .filter(s => new Date(s.starts_at) >= new Date())
.slice(0, 5); .slice(0, 5);
const unreadNotifications = notifications.filter(n => !n.is_read); const unreadNotifications = notifications.filter(n => !n.read);
return ( return (
<div className="page"> <div className="page">
@@ -79,7 +78,7 @@ export default function Dashboard() {
<ul> <ul>
{upcomingSchedules.map(s => ( {upcomingSchedules.map(s => (
<li key={s.id}> <li key={s.id}>
<strong>{s.name}</strong> {s.date} {s.start_time.slice(0, 5)}{s.end_time.slice(0, 5)} <strong>{s.title}</strong> {new Date(s.starts_at).toLocaleString()} to {new Date(s.ends_at).toLocaleString()}
</li> </li>
))} ))}
</ul> </ul>
@@ -93,9 +92,9 @@ export default function Dashboard() {
) : ( ) : (
<ul> <ul>
{notifications.map(n => ( {notifications.map(n => (
<li key={n.id} className={n.is_read ? 'read' : 'unread'}> <li key={n.id} className={n.read ? 'read' : 'unread'}>
{n.message} {n.message}
{!n.is_read && ( {!n.read && (
<button className="btn-small" onClick={() => handleMarkRead(n.id)}>Mark read</button> <button className="btn-small" onClick={() => handleMarkRead(n.id)}>Mark read</button>
)} )}
</li> </li>

View File

@@ -1,15 +1,14 @@
import React from 'react'; import React from 'react';
import { render, screen, fireEvent, waitFor } from '@testing-library/react'; import { render, screen, fireEvent, waitFor } from '@testing-library/react';
import { vi, type Mock } from 'vitest';
import { MemoryRouter } from 'react-router-dom'; import { MemoryRouter } from 'react-router-dom';
import Profile from './Profile'; import Profile from './Profile';
import { api, Volunteer } from '../api'; import { api, Volunteer } from '../api';
import { AuthProvider } from '../auth'; import { AuthProvider } from '../auth';
vi.mock('../api', () => ({ jest.mock('../api', () => ({
api: { api: {
getVolunteer: vi.fn(), getVolunteer: jest.fn(),
updateVolunteer: vi.fn(), updateVolunteer: jest.fn(),
}, },
})); }));
@@ -22,8 +21,8 @@ function buildFakeJWT(payload: object): string {
return `${header}.${body}.fakesig`; return `${header}.${body}.fakesig`;
} }
const mockGetVolunteer = api.getVolunteer as Mock; const mockGetVolunteer = api.getVolunteer as jest.Mock;
const mockUpdateVolunteer = api.updateVolunteer as Mock; const mockUpdateVolunteer = api.updateVolunteer as jest.Mock;
const baseVolunteer: Volunteer = { const baseVolunteer: Volunteer = {
id: 5, id: 5,

View File

@@ -1,215 +0,0 @@
import React from 'react';
import { render, screen, fireEvent, waitFor } from '@testing-library/react';
import { vi, type Mock } from 'vitest';
import { MemoryRouter } from 'react-router-dom';
import Schedules from './Schedules';
import { api, ShiftInstance, ShiftTemplate } from '../api';
vi.mock('../api', async () => {
const actual = await vi.importActual<typeof import('../api')>('../api');
return {
...actual,
api: {
listShifts: vi.fn(),
listShiftTemplates: vi.fn(),
listVolunteers: vi.fn(),
listTimeOff: vi.fn(),
generateShifts: vi.fn(),
publishShifts: vi.fn(),
unpublishShifts: vi.fn(),
updateShift: vi.fn(),
confirmShift: vi.fn(),
createShiftTemplate: vi.fn(),
updateShiftTemplate: vi.fn(),
deleteShiftTemplate: vi.fn(),
},
};
});
vi.mock('../auth', () => ({
useAuth: vi.fn(),
}));
const { useAuth } = await import('../auth');
const mockDraftInstance: ShiftInstance = {
id: 1,
name: 'Morning Shift',
date: '2026-04-06',
start_time: '09:00:00',
end_time: '12:00:00',
min_capacity: 2,
max_capacity: 5,
status: 'draft',
year: 2026,
month: 4,
volunteers: [],
created_at: '2026-04-01T00:00:00Z',
updated_at: '2026-04-01T00:00:00Z',
};
const mockPublishedInstance: ShiftInstance = {
...mockDraftInstance,
id: 2,
status: 'published',
volunteers: [{ instance_id: 2, volunteer_id: 10, name: 'Alice', confirmed: false }],
};
const mockTemplate: ShiftTemplate = {
id: 1,
name: 'Morning Shift',
day_of_week: 1,
start_time: '09:00:00',
end_time: '12:00:00',
min_capacity: 2,
max_capacity: 5,
roles: [],
volunteer_ids: [],
created_at: '2026-04-01T00:00:00Z',
updated_at: '2026-04-01T00:00:00Z',
};
function renderAt(path: string) {
return render(
<MemoryRouter initialEntries={[path]}>
<Schedules />
</MemoryRouter>
);
}
describe('Schedules (volunteer view)', () => {
beforeEach(() => {
(useAuth as Mock).mockReturnValue({ role: 'volunteer', volunteerID: 10 });
(api.listShifts as Mock).mockResolvedValue([mockPublishedInstance]);
});
it('renders published shifts for a volunteer', async () => {
renderAt('/schedules');
await waitFor(() => {
expect(screen.getByText('Morning Shift')).toBeInTheDocument();
});
expect(screen.getByText('published')).toBeInTheDocument();
});
it('does not show admin controls', async () => {
renderAt('/schedules');
await waitFor(() => expect(screen.getByText('Morning Shift')).toBeInTheDocument());
expect(screen.queryByText('Generate')).not.toBeInTheDocument();
expect(screen.queryByText('Publish')).not.toBeInTheDocument();
expect(screen.queryByText('Manage Templates')).not.toBeInTheDocument();
});
});
describe('Schedules (admin shifts view)', () => {
beforeEach(() => {
(useAuth as Mock).mockReturnValue({ role: 'admin', volunteerID: 1 });
(api.listShifts as Mock).mockResolvedValue([mockDraftInstance]);
(api.listShiftTemplates as Mock).mockResolvedValue([mockTemplate]);
});
it('shows Generate and Publish buttons when drafts exist', async () => {
renderAt('/schedules');
await waitFor(() => expect(screen.getByText('Morning Shift')).toBeInTheDocument());
expect(screen.getByText('Generate')).toBeInTheDocument();
expect(screen.getByText('Publish')).toBeInTheDocument();
});
it('calls generateShifts on Generate click', async () => {
(api.generateShifts as Mock).mockResolvedValue([mockDraftInstance]);
renderAt('/schedules');
await waitFor(() => expect(screen.getByText('Generate')).toBeInTheDocument());
fireEvent.click(screen.getByText('Generate'));
expect(api.generateShifts).toHaveBeenCalled();
});
it('calls publishShifts on Publish click', async () => {
(api.publishShifts as Mock).mockResolvedValue({ year: 2026, month: 4 });
(api.listShifts as Mock)
.mockResolvedValueOnce([mockDraftInstance])
.mockResolvedValue([{ ...mockDraftInstance, status: 'published' }]);
renderAt('/schedules');
await waitFor(() => expect(screen.getByText('Publish')).toBeInTheDocument());
fireEvent.click(screen.getByText('Publish'));
expect(api.publishShifts).toHaveBeenCalled();
});
it('shows Unpublish button when all shifts are published', async () => {
(api.listShifts as Mock).mockResolvedValue([mockPublishedInstance]);
renderAt('/schedules');
await waitFor(() => expect(screen.getByText('Unpublish')).toBeInTheDocument());
});
it('shows Edit button on each shift row', async () => {
renderAt('/schedules');
await waitFor(() => expect(screen.getByText('Morning Shift')).toBeInTheDocument());
expect(screen.getByText('Edit')).toBeInTheDocument();
});
it('opens edit form with volunteer checkboxes when Edit is clicked', async () => {
(api.listVolunteers as Mock).mockResolvedValue([
{ id: 5, name: 'Alice', active: true, operational_roles: 'Dog Shelter Volunteer', is_trainee: false },
{ id: 6, name: 'Bob', active: true, operational_roles: 'Behaviour Team', is_trainee: false },
]);
(api.listTimeOff as Mock).mockResolvedValue([]);
renderAt('/schedules');
await waitFor(() => expect(screen.getByText('Edit')).toBeInTheDocument());
fireEvent.click(screen.getByText('Edit'));
await waitFor(() => expect(screen.getByText('Alice')).toBeInTheDocument());
expect(screen.getByText('Bob')).toBeInTheDocument();
expect(screen.getByText(/Edit Shift/)).toBeInTheDocument();
});
it('hides volunteers with approved time off on the shift date', async () => {
(api.listVolunteers as Mock).mockResolvedValue([
{ id: 5, name: 'Alice', active: true, operational_roles: 'Dog Shelter Volunteer', is_trainee: false },
{ id: 6, name: 'Bob', active: true, operational_roles: 'Behaviour Team', is_trainee: false },
]);
(api.listTimeOff as Mock).mockResolvedValue([
{ id: 1, volunteer_id: 6, starts_at: '2026-04-06T00:00:00Z', ends_at: '2026-04-07T00:00:00Z', status: 'approved' },
]);
renderAt('/schedules');
await waitFor(() => expect(screen.getByText('Edit')).toBeInTheDocument());
fireEvent.click(screen.getByText('Edit'));
await waitFor(() => expect(screen.getByText('Alice')).toBeInTheDocument());
// Bob should not appear as a selectable volunteer
expect(screen.queryByLabelText('Bob')).not.toBeInTheDocument();
// But should be listed as on time off
expect(screen.getByText(/On approved time off/)).toBeInTheDocument();
expect(screen.getByText(/Bob/)).toBeInTheDocument();
});
it('reads year and month from search params', async () => {
renderAt('/schedules?year=2025&month=12');
await waitFor(() => expect(api.listShifts).toHaveBeenCalledWith(2025, 12));
});
});
describe('Schedules (admin templates view)', () => {
beforeEach(() => {
(useAuth as Mock).mockReturnValue({ role: 'admin', volunteerID: 1 });
(api.listShiftTemplates as Mock).mockResolvedValue([mockTemplate]);
});
it('renders templates at /schedules/templates', async () => {
renderAt('/schedules/templates');
await waitFor(() => expect(screen.getByText('Shift Templates')).toBeInTheDocument());
expect(screen.getByText('Morning Shift')).toBeInTheDocument();
});
it('shows template form when New Template is clicked', async () => {
renderAt('/schedules/templates');
await waitFor(() => expect(screen.getByText('+ New Template')).toBeInTheDocument());
fireEvent.click(screen.getByText('+ New Template'));
expect(screen.getByText('New Template')).toBeInTheDocument();
});
it('deletes a template', async () => {
(api.deleteShiftTemplate as Mock).mockResolvedValue(undefined);
window.confirm = vi.fn().mockReturnValue(true);
renderAt('/schedules/templates');
await waitFor(() => expect(screen.getAllByText('Delete')[0]).toBeInTheDocument());
fireEvent.click(screen.getAllByText('Delete')[0]);
expect(api.deleteShiftTemplate).toHaveBeenCalledWith(1);
});
});

View File

@@ -1,636 +1,106 @@
import React, { useEffect, useState, FormEvent, useCallback } from 'react'; import React, { useEffect, useState, FormEvent } from 'react';
import { useLocation, useNavigate, useSearchParams } from 'react-router-dom'; import { api, Schedule } from '../api';
import {
api,
ShiftTemplate,
ShiftInstance,
Volunteer,
TimeOffRequest,
CreateShiftTemplateInput,
TemplateRole,
OPERATIONAL_ROLES,
} from '../api';
import { useAuth } from '../auth'; import { useAuth } from '../auth';
const DAY_NAMES = ['Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat'];
const MONTH_NAMES = [
'January', 'February', 'March', 'April', 'May', 'June',
'July', 'August', 'September', 'October', 'November', 'December',
];
function currentYearMonth() {
const now = new Date();
return { year: now.getFullYear(), month: now.getMonth() + 1 };
}
// ---------------------------------------------------------------------------
// Template form
// ---------------------------------------------------------------------------
function blankTemplate(): CreateShiftTemplateInput {
return {
name: '',
day_of_week: 1,
start_time: '09:00:00',
end_time: '17:00:00',
min_capacity: 1,
max_capacity: 5,
roles: [],
volunteer_ids: [],
};
}
interface TemplateFormProps {
initial?: Partial<CreateShiftTemplateInput>;
onSave: (data: CreateShiftTemplateInput) => Promise<void>;
onCancel: () => void;
title: string;
}
function TemplateForm({ initial, onSave, onCancel, title }: TemplateFormProps) {
const [form, setForm] = useState<CreateShiftTemplateInput>({ ...blankTemplate(), ...initial });
const [roleRow, setRoleRow] = useState<TemplateRole>({ role_name: '', count: 1 });
const [error, setError] = useState('');
const [saving, setSaving] = useState(false);
async function handleSubmit(e: FormEvent) {
e.preventDefault();
setError('');
setSaving(true);
try {
await onSave(form);
} catch (err: any) {
setError(err.message);
} finally {
setSaving(false);
}
}
function addRole() {
if (!roleRow.role_name) return;
setForm(f => ({ ...f, roles: [...(f.roles ?? []), { ...roleRow }] }));
setRoleRow({ role_name: '', count: 1 });
}
function removeRole(idx: number) {
setForm(f => ({ ...f, roles: (f.roles ?? []).filter((_, i) => i !== idx) }));
}
return (
<form className="card" onSubmit={handleSubmit}>
<h3>{title}</h3>
{error && <p className="error">{error}</p>}
<label>
Name
<input value={form.name} onChange={e => setForm(f => ({ ...f, name: e.target.value }))} required />
</label>
<label>
Day of Week
<select value={form.day_of_week} onChange={e => setForm(f => ({ ...f, day_of_week: Number(e.target.value) }))}>
{DAY_NAMES.map((d, i) => <option key={i} value={i}>{d}</option>)}
</select>
</label>
<label>
Start Time
<input type="time" value={form.start_time.slice(0, 5)}
onChange={e => setForm(f => ({ ...f, start_time: e.target.value + ':00' }))} required />
</label>
<label>
End Time
<input type="time" value={form.end_time.slice(0, 5)}
onChange={e => setForm(f => ({ ...f, end_time: e.target.value + ':00' }))} required />
</label>
<label>
Min Capacity
<input type="number" min={1} value={form.min_capacity}
onChange={e => setForm(f => ({ ...f, min_capacity: Number(e.target.value) }))} required />
</label>
<label>
Max Capacity
<input type="number" min={1} value={form.max_capacity}
onChange={e => setForm(f => ({ ...f, max_capacity: Number(e.target.value) }))} required />
</label>
<fieldset>
<legend>Role Requirements</legend>
{(form.roles ?? []).map((r, i) => (
<div key={i} style={{ display: 'flex', gap: '0.5rem', alignItems: 'center', marginBottom: '0.25rem' }}>
<span>{r.count}× {r.role_name}</span>
<button type="button" className="btn-danger btn-small" onClick={() => removeRole(i)}>Remove</button>
</div>
))}
<div style={{ display: 'flex', gap: '0.5rem', alignItems: 'flex-end' }}>
<label style={{ flex: 1 }}>
Role
<select value={roleRow.role_name} onChange={e => setRoleRow(r => ({ ...r, role_name: e.target.value }))}>
<option value="">Select role</option>
{OPERATIONAL_ROLES.map(r => <option key={r} value={r}>{r}</option>)}
</select>
</label>
<label>
Count
<input type="number" min={1} value={roleRow.count} style={{ width: '4rem' }}
onChange={e => setRoleRow(r => ({ ...r, count: Number(e.target.value) }))} />
</label>
<button type="button" onClick={addRole}>Add Role</button>
</div>
</fieldset>
<div style={{ display: 'flex', gap: '0.5rem', marginTop: '1rem' }}>
<button type="submit" disabled={saving}>{saving ? 'Saving…' : 'Save'}</button>
<button type="button" onClick={onCancel}>Cancel</button>
</div>
</form>
);
}
// ---------------------------------------------------------------------------
// Shift instance edit form
// ---------------------------------------------------------------------------
interface ShiftEditFormProps {
instance: ShiftInstance;
templateId: number | undefined;
onSave: (inst: ShiftInstance) => void;
onCancel: () => void;
}
function ShiftEditForm({ instance, templateId, onSave, onCancel }: ShiftEditFormProps) {
const [volunteers, setVolunteers] = useState<Volunteer[]>([]);
const [templateRoles, setTemplateRoles] = useState<TemplateRole[]>([]);
const [unavailableIds, setUnavailableIds] = useState<Set<number>>(new Set());
const [selectedIds, setSelectedIds] = useState<Set<number>>(
new Set(instance.volunteers.map(v => v.volunteer_id))
);
const [minCap, setMinCap] = useState(instance.min_capacity);
const [maxCap, setMaxCap] = useState(instance.max_capacity);
const [error, setError] = useState('');
const [saving, setSaving] = useState(false);
const [loading, setLoading] = useState(true);
useEffect(() => {
const loads: Promise<void>[] = [
api.listVolunteers().then((vols) => setVolunteers(vols as Volunteer[])),
api.listTimeOff().then((requests: TimeOffRequest[]) => {
const shiftDate = new Date(instance.date + 'T00:00:00');
const off = new Set<number>();
for (const r of requests) {
if (r.status !== 'approved') continue;
const start = new Date(r.starts_at);
const end = new Date(r.ends_at);
// Shift date falls within the approved time-off range
if (shiftDate >= new Date(start.toDateString()) && shiftDate <= new Date(end.toDateString())) {
off.add(r.volunteer_id);
}
}
setUnavailableIds(off);
}),
];
if (templateId) {
loads.push(
api.listShiftTemplates().then((tmpls) => {
const tmpl = tmpls.find(t => t.id === templateId);
if (tmpl) setTemplateRoles(tmpl.roles ?? []);
})
);
}
Promise.all(loads).finally(() => setLoading(false));
}, [templateId, instance.date]);
function toggleVolunteer(id: number) {
setSelectedIds(prev => {
const next = new Set(prev);
if (next.has(id)) next.delete(id);
else next.add(id);
return next;
});
}
async function handleSubmit(e: FormEvent) {
e.preventDefault();
setError('');
setSaving(true);
try {
const updated = await api.updateShift(instance.id, {
volunteer_ids: Array.from(selectedIds),
min_capacity: minCap,
max_capacity: maxCap,
});
onSave(updated);
} catch (err: any) {
setError(err.message);
} finally {
setSaving(false);
}
}
// Group active, available volunteers by their operational roles for display
const activeVolunteers = volunteers.filter(v => v.active && !unavailableIds.has(v.id));
const onTimeOff = volunteers.filter(v => v.active && unavailableIds.has(v.id));
// Build a map of role → volunteers who hold that role
const byRole = new Map<string, Volunteer[]>();
for (const v of activeVolunteers) {
const roles = v.operational_roles
? v.operational_roles.split(',').map(r => r.trim()).filter(Boolean)
: [];
if (roles.length === 0) {
const list = byRole.get('Unassigned') ?? [];
list.push(v);
byRole.set('Unassigned', list);
} else {
for (const r of roles) {
const list = byRole.get(r) ?? [];
list.push(v);
byRole.set(r, list);
}
}
}
// Order sections: template roles first, then any remaining
const roleOrder: string[] = [];
for (const tr of templateRoles) {
if (!roleOrder.includes(tr.role_name)) roleOrder.push(tr.role_name);
}
byRole.forEach((_, key) => {
if (!roleOrder.includes(key)) roleOrder.push(key);
});
if (loading) return <div className="card"><p>Loading volunteers</p></div>;
return (
<form className="card" onSubmit={handleSubmit}>
<h3>Edit Shift: {instance.name} {instance.date}</h3>
{error && <p className="error">{error}</p>}
{templateRoles.length > 0 && (
<p style={{ marginBottom: '0.5rem', color: '#666' }}>
<strong>Required:</strong>{' '}
{templateRoles.map(r => `${r.count}× ${r.role_name}`).join(', ')}
</p>
)}
<fieldset>
<legend>Volunteers ({selectedIds.size} selected)</legend>
{roleOrder.map(roleName => {
const vols = byRole.get(roleName);
if (!vols || vols.length === 0) return null;
const required = templateRoles.find(r => r.role_name === roleName);
const selectedInRole = vols.filter(v => selectedIds.has(v.id)).length;
return (
<div key={roleName} style={{ marginBottom: '0.75rem' }}>
<strong>
{roleName}
{required && (
<span style={{ fontWeight: 'normal', color: selectedInRole >= required.count ? '#2a7' : '#c55' }}>
{' '}({selectedInRole}/{required.count})
</span>
)}
</strong>
<div style={{ display: 'grid', gridTemplateColumns: 'repeat(auto-fill, minmax(200px, 1fr))', gap: '0.25rem', marginTop: '0.25rem' }}>
{vols.map(v => (
<label key={v.id} style={{ display: 'flex', alignItems: 'center', gap: '0.5rem', cursor: 'pointer' }}>
<input
type="checkbox"
checked={selectedIds.has(v.id)}
onChange={() => toggleVolunteer(v.id)}
/>
<span>{v.name}{v.is_trainee ? ' (trainee)' : ''}</span>
</label>
))}
</div>
</div>
);
})}
</fieldset>
{onTimeOff.length > 0 && (
<p style={{ marginTop: '0.5rem', color: '#999', fontSize: '0.9em' }}>
<strong>On approved time off:</strong>{' '}
{onTimeOff.map(v => v.name).join(', ')}
</p>
)}
<div style={{ display: 'flex', gap: '1rem', marginTop: '0.5rem' }}>
<label>
Min Capacity
<input type="number" min={1} value={minCap} style={{ width: '5rem' }}
onChange={e => setMinCap(Number(e.target.value))} />
</label>
<label>
Max Capacity
<input type="number" min={1} value={maxCap} style={{ width: '5rem' }}
onChange={e => setMaxCap(Number(e.target.value))} />
</label>
</div>
<div style={{ display: 'flex', gap: '0.5rem', marginTop: '1rem' }}>
<button type="submit" disabled={saving}>{saving ? 'Saving…' : 'Save'}</button>
<button type="button" onClick={onCancel}>Cancel</button>
</div>
</form>
);
}
// ---------------------------------------------------------------------------
// Main page
// ---------------------------------------------------------------------------
export default function Schedules() { export default function Schedules() {
const { role } = useAuth(); const { role } = useAuth();
const navigate = useNavigate(); const [schedules, setSchedules] = useState<Schedule[]>([]);
const location = useLocation();
const [searchParams] = useSearchParams();
// Derive view from URL path
const isTemplatesView = location.pathname === '/schedules/templates';
// Derive year/month from search params (shifts view only)
const init = currentYearMonth();
const year = Number(searchParams.get('year')) || init.year;
const month = Number(searchParams.get('month')) || init.month;
// Data
const [instances, setInstances] = useState<ShiftInstance[]>([]);
const [templates, setTemplates] = useState<ShiftTemplate[]>([]);
const [error, setError] = useState(''); const [error, setError] = useState('');
const [showForm, setShowForm] = useState(false);
// UI state const [form, setForm] = useState({ title: '', starts_at: '', ends_at: '', notes: '' });
const [showTemplateForm, setShowTemplateForm] = useState(false);
const [editingTemplate, setEditingTemplate] = useState<ShiftTemplate | null>(null);
const [editingInstance, setEditingInstance] = useState<ShiftInstance | null>(null);
// Navigation helpers
const goToShifts = useCallback((y: number, m: number) => {
navigate(`/schedules?year=${y}&month=${m}`);
}, [navigate]);
const goToTemplates = useCallback(() => {
navigate('/schedules/templates');
}, [navigate]);
useEffect(() => { useEffect(() => {
if (isTemplatesView) { api.listSchedules().then(setSchedules).catch(() => setError('Could not load schedules.'));
api.listShiftTemplates() }, []);
.then(setTemplates)
.catch(() => setError('Could not load templates.'));
} else {
api.listShifts(year, month)
.then(setInstances)
.catch(() => setError('Could not load shifts.'));
}
}, [isTemplatesView, year, month]);
function prevMonth() { async function handleCreate(e: FormEvent) {
const m = month === 1 ? 12 : month - 1; e.preventDefault();
const y = month === 1 ? year - 1 : year;
goToShifts(y, m);
}
function nextMonth() {
const m = month === 12 ? 1 : month + 1;
const y = month === 12 ? year + 1 : year;
goToShifts(y, m);
}
async function handleGenerate() {
setError(''); setError('');
try { try {
const newInstances = await api.generateShifts(year, month); const sc = await api.createSchedule(form);
setInstances(newInstances); setSchedules(prev => [...prev, sc]);
setForm({ title: '', starts_at: '', ends_at: '', notes: '' });
setShowForm(false);
} catch (err: any) { } catch (err: any) {
setError(err.message); setError(err.message);
} }
} }
async function handlePublish() { async function handleDelete(id: number) {
setError(''); if (!window.confirm('Delete this schedule?')) return;
try { try {
await api.publishShifts(year, month); await api.deleteSchedule(id);
const updated = await api.listShifts(year, month); setSchedules(prev => prev.filter(s => s.id !== id));
setInstances(updated);
} catch (err: any) { } catch (err: any) {
setError(err.message); setError(err.message);
} }
} }
async function handleUnpublish() {
if (!window.confirm(`Unpublish the ${MONTH_NAMES[month - 1]} ${year} schedule?`)) return;
setError('');
try {
await api.unpublishShifts(year, month);
const updated = await api.listShifts(year, month);
setInstances(updated);
} catch (err: any) {
setError(err.message);
}
}
async function handleConfirm(id: number) {
setError('');
try {
await api.confirmShift(id);
const updated = await api.listShifts(year, month);
setInstances(updated);
} catch (err: any) {
setError(err.message);
}
}
async function handleCreateTemplate(data: CreateShiftTemplateInput) {
const t = await api.createShiftTemplate(data);
setTemplates(prev => [...prev, t]);
setShowTemplateForm(false);
}
async function handleUpdateTemplate(data: CreateShiftTemplateInput) {
if (!editingTemplate) return;
const t = await api.updateShiftTemplate(editingTemplate.id, data);
setTemplates(prev => prev.map(x => (x.id === t.id ? t : x)));
setEditingTemplate(null);
}
async function handleDeleteTemplate(id: number) {
if (!window.confirm('Delete this template? Existing shifts will not be affected.')) return;
setError('');
try {
await api.deleteShiftTemplate(id);
setTemplates(prev => prev.filter(t => t.id !== id));
} catch (err: any) {
setError(err.message);
}
}
function handleInstanceSaved(updated: ShiftInstance) {
setInstances(prev => prev.map(i => (i.id === updated.id ? updated : i)));
setEditingInstance(null);
}
const allPublished = instances.length > 0 && instances.every(i => i.status === 'published');
const hasDraft = instances.some(i => i.status === 'draft');
return ( return (
<div className="page"> <div className="page">
<div className="page-header"> <div className="page-header">
<h2>Schedules</h2> <h2>Schedules</h2>
{role === 'admin' && ( {role === 'admin' && (
<div style={{ display: 'flex', gap: '0.5rem' }}> <button onClick={() => setShowForm(v => !v)}>
<button onClick={() => isTemplatesView ? goToShifts(year, month) : goToTemplates()}> {showForm ? 'Cancel' : 'Add Shift'}
{isTemplatesView ? 'View Shifts' : 'Manage Templates'}
</button> </button>
</div>
)} )}
</div> </div>
{error && <p className="error">{error}</p>} {error && <p className="error">{error}</p>}
{/* ---- Templates view ---- */} {showForm && (
{isTemplatesView && role === 'admin' && ( <form className="card" onSubmit={handleCreate}>
<> <h3>New Shift</h3>
<div className="page-header" style={{ marginBottom: '1rem' }}> <label>
<h3>Shift Templates</h3> Title
<button onClick={() => { setShowTemplateForm(true); setEditingTemplate(null); }}> <input value={form.title} onChange={e => setForm(f => ({ ...f, title: e.target.value }))} required />
+ New Template </label>
</button> <label>
</div> Starts At
<input type="datetime-local" value={form.starts_at} onChange={e => setForm(f => ({ ...f, starts_at: e.target.value }))} required />
{showTemplateForm && !editingTemplate && ( </label>
<TemplateForm <label>
title="New Template" Ends At
onSave={handleCreateTemplate} <input type="datetime-local" value={form.ends_at} onChange={e => setForm(f => ({ ...f, ends_at: e.target.value }))} required />
onCancel={() => setShowTemplateForm(false)} </label>
/> <label>
Notes
<textarea value={form.notes} onChange={e => setForm(f => ({ ...f, notes: e.target.value }))} />
</label>
<button type="submit">Create</button>
</form>
)} )}
{editingTemplate && ( {schedules.length === 0 ? (
<TemplateForm <p>No schedules found.</p>
title={`Edit: ${editingTemplate.name}`}
initial={editingTemplate}
onSave={handleUpdateTemplate}
onCancel={() => setEditingTemplate(null)}
/>
)}
{templates.length === 0 ? (
<p>No templates yet.</p>
) : ( ) : (
<table> <table>
<thead> <thead>
<tr> <tr>
<th>Name</th> <th>Title</th>
<th>Day</th> <th>Starts</th>
<th>Time</th> <th>Ends</th>
<th>Capacity</th> <th>Notes</th>
<th>Roles</th>
<th>Actions</th>
</tr>
</thead>
<tbody>
{templates.map(t => (
<tr key={t.id}>
<td>{t.name}</td>
<td>{DAY_NAMES[t.day_of_week]}</td>
<td>{t.start_time.slice(0, 5)}{t.end_time.slice(0, 5)}</td>
<td>{t.min_capacity}{t.max_capacity}</td>
<td>{(t.roles ?? []).map(r => `${r.count}× ${r.role_name}`).join(', ') || '—'}</td>
<td>
<button className="btn-small" onClick={() => { setEditingTemplate(t); setShowTemplateForm(false); }}>Edit</button>
{' '}
<button className="btn-danger btn-small" onClick={() => handleDeleteTemplate(t.id)}>Delete</button>
</td>
</tr>
))}
</tbody>
</table>
)}
</>
)}
{/* ---- Shifts view ---- */}
{!isTemplatesView && (
<>
{/* Month navigation */}
<div style={{ display: 'flex', alignItems: 'center', gap: '1rem', marginBottom: '1rem' }}>
<button onClick={prevMonth}></button>
<strong>{MONTH_NAMES[month - 1]} {year}</strong>
<button onClick={nextMonth}></button>
{role === 'admin' && (
<div style={{ display: 'flex', gap: '0.5rem', marginLeft: 'auto' }}>
<button onClick={handleGenerate}>Generate</button>
{hasDraft && <button onClick={handlePublish}>Publish</button>}
{allPublished && (
<button className="btn-danger" onClick={handleUnpublish}>Unpublish</button>
)}
</div>
)}
</div>
{/* Instance edit form */}
{editingInstance && (
<ShiftEditForm
instance={editingInstance}
templateId={editingInstance.template_id}
onSave={handleInstanceSaved}
onCancel={() => setEditingInstance(null)}
/>
)}
{instances.length === 0 ? (
<p>No shifts for {MONTH_NAMES[month - 1]} {year}.{role === 'admin' && ' Use Generate to create shifts from templates.'}</p>
) : (
<table>
<thead>
<tr>
<th>Date</th>
<th>Shift</th>
<th>Time</th>
<th>Status</th>
<th>Volunteers</th>
<th>Capacity</th>
{role === 'admin' && <th>Actions</th>} {role === 'admin' && <th>Actions</th>}
</tr> </tr>
</thead> </thead>
<tbody> <tbody>
{instances.map(inst => { {schedules.map(s => (
const confirmed = inst.volunteers.some(v => v.confirmed); <tr key={s.id}>
return ( <td>{s.title}</td>
<tr key={inst.id}> <td>{new Date(s.starts_at).toLocaleString()}</td>
<td>{inst.date}</td> <td>{new Date(s.ends_at).toLocaleString()}</td>
<td>{inst.name}</td> <td>{s.notes ?? '—'}</td>
<td>{inst.start_time.slice(0, 5)}{inst.end_time.slice(0, 5)}</td>
<td>
<span className={inst.status === 'published' ? 'badge-success' : 'badge-neutral'}>
{inst.status}
</span>
</td>
<td>
{inst.volunteers.length === 0 ? '—' : inst.volunteers.map(v => (
<span key={v.volunteer_id} title={v.confirmed ? 'Confirmed' : 'Unconfirmed'}>
{v.name}{v.confirmed ? ' ✓' : ' ⚠'}
{' '}
</span>
))}
</td>
<td>{inst.volunteers.length}/{inst.max_capacity}</td>
{role === 'admin' && ( {role === 'admin' && (
<td> <td>
<button className="btn-small" onClick={() => setEditingInstance(inst)}>Edit</button> <button className="btn-danger btn-small" onClick={() => handleDelete(s.id)}>Delete</button>
</td>
)}
{role !== 'admin' && inst.status === 'published' && !confirmed && (
<td>
<button className="btn-small" onClick={() => handleConfirm(inst.id)}>Confirm</button>
</td> </td>
)} )}
</tr> </tr>
); ))}
})}
</tbody> </tbody>
</table> </table>
)} )}
</>
)}
</div> </div>
); );
} }

View File

@@ -1,105 +0,0 @@
import React from 'react';
import { render, screen, fireEvent, waitFor } from '@testing-library/react';
import { vi, type Mock } from 'vitest';
import { MemoryRouter, Route, Routes } from 'react-router-dom';
import Setup from './Setup';
import { api } from '../api';
import { AuthProvider } from '../auth';
vi.mock('../api', () => ({
api: {
getSetupStatus: vi.fn(),
createSetupAdmin: vi.fn(),
},
}));
// Mock useSetup from App to provide setNeedsSetup
const mockSetNeedsSetup = vi.fn();
vi.mock('../App', () => ({
useSetup: () => ({ setNeedsSetup: mockSetNeedsSetup }),
}));
const mockCreateSetupAdmin = api.createSetupAdmin as Mock;
function renderSetup() {
return render(
<AuthProvider>
<MemoryRouter initialEntries={['/setup']}>
<Routes>
<Route path="/setup" element={<Setup />} />
<Route path="/" element={<div>Dashboard</div>} />
</Routes>
</MemoryRouter>
</AuthProvider>,
);
}
beforeEach(() => {
mockCreateSetupAdmin.mockReset();
mockSetNeedsSetup.mockReset();
});
test('renders all form fields', () => {
renderSetup();
expect(screen.getByLabelText(/name/i)).toBeInTheDocument();
expect(screen.getByLabelText(/email/i)).toBeInTheDocument();
expect(screen.getByLabelText(/^password$/i)).toBeInTheDocument();
expect(screen.getByLabelText(/confirm password/i)).toBeInTheDocument();
expect(screen.getByRole('button', { name: /create admin account/i })).toBeInTheDocument();
});
test('shows error when passwords do not match', async () => {
renderSetup();
fireEvent.change(screen.getByLabelText(/name/i), { target: { value: 'Admin' } });
fireEvent.change(screen.getByLabelText(/email/i), { target: { value: 'admin@example.com' } });
fireEvent.change(screen.getByLabelText(/^password$/i), { target: { value: 'password1' } });
fireEvent.change(screen.getByLabelText(/confirm password/i), { target: { value: 'password2' } });
fireEvent.click(screen.getByRole('button', { name: /create admin account/i }));
expect(await screen.findByText(/passwords do not match/i)).toBeInTheDocument();
});
test('shows error when password too short', async () => {
renderSetup();
fireEvent.change(screen.getByLabelText(/name/i), { target: { value: 'Admin' } });
fireEvent.change(screen.getByLabelText(/email/i), { target: { value: 'admin@example.com' } });
fireEvent.change(screen.getByLabelText(/^password$/i), { target: { value: 'short' } });
fireEvent.change(screen.getByLabelText(/confirm password/i), { target: { value: 'short' } });
fireEvent.click(screen.getByRole('button', { name: /create admin account/i }));
expect(await screen.findByText(/at least 8 characters/i)).toBeInTheDocument();
});
test('calls api.createSetupAdmin and navigates on success', async () => {
mockCreateSetupAdmin.mockResolvedValueOnce({ token: 'jwt-token' });
renderSetup();
fireEvent.change(screen.getByLabelText(/name/i), { target: { value: 'Admin' } });
fireEvent.change(screen.getByLabelText(/email/i), { target: { value: 'admin@example.com' } });
fireEvent.change(screen.getByLabelText(/^password$/i), { target: { value: 'goodpassword' } });
fireEvent.change(screen.getByLabelText(/confirm password/i), { target: { value: 'goodpassword' } });
fireEvent.click(screen.getByRole('button', { name: /create admin account/i }));
await waitFor(() => {
expect(mockCreateSetupAdmin).toHaveBeenCalledWith({
name: 'Admin',
email: 'admin@example.com',
password: 'goodpassword',
});
});
await waitFor(() => {
expect(mockSetNeedsSetup).toHaveBeenCalledWith(false);
});
expect(await screen.findByText(/dashboard/i)).toBeInTheDocument();
});
test('shows error when API returns failure', async () => {
mockCreateSetupAdmin.mockRejectedValueOnce(new Error('setup already completed'));
renderSetup();
fireEvent.change(screen.getByLabelText(/name/i), { target: { value: 'Admin' } });
fireEvent.change(screen.getByLabelText(/email/i), { target: { value: 'admin@example.com' } });
fireEvent.change(screen.getByLabelText(/^password$/i), { target: { value: 'goodpassword' } });
fireEvent.change(screen.getByLabelText(/confirm password/i), { target: { value: 'goodpassword' } });
fireEvent.click(screen.getByRole('button', { name: /create admin account/i }));
expect(await screen.findByText(/setup already completed/i)).toBeInTheDocument();
});

View File

@@ -1,77 +0,0 @@
import React, { useState, FormEvent } from 'react';
import { useNavigate } from 'react-router-dom';
import { api } from '../api';
import { useAuth } from '../auth';
import { useSetup } from '../App';
export default function Setup() {
const { login } = useAuth();
const { setNeedsSetup } = useSetup();
const navigate = useNavigate();
const [name, setName] = useState('');
const [email, setEmail] = useState('');
const [password, setPassword] = useState('');
const [confirm, setConfirm] = useState('');
const [error, setError] = useState('');
const [submitting, setSubmitting] = useState(false);
async function handleSubmit(e: FormEvent) {
e.preventDefault();
setError('');
if (!name || !email || !password) {
setError('All fields are required');
return;
}
if (password.length < 8) {
setError('Password must be at least 8 characters');
return;
}
if (password !== confirm) {
setError('Passwords do not match');
return;
}
setSubmitting(true);
try {
const { token } = await api.createSetupAdmin({ name, email, password });
login(token);
setNeedsSetup(false);
navigate('/');
} catch (err: any) {
setError(err.message);
} finally {
setSubmitting(false);
}
}
return (
<div className="auth-page">
<h1>Walkies</h1>
<h2>Initial Setup</h2>
<p>Create the first admin account to get started.</p>
<form onSubmit={handleSubmit}>
{error && <p className="error">{error}</p>}
<label>
Name
<input type="text" value={name} onChange={e => setName(e.target.value)} required />
</label>
<label>
Email
<input type="email" value={email} onChange={e => setEmail(e.target.value)} required />
</label>
<label>
Password
<input type="password" value={password} onChange={e => setPassword(e.target.value)} required />
</label>
<label>
Confirm Password
<input type="password" value={confirm} onChange={e => setConfirm(e.target.value)} required />
</label>
<button type="submit" disabled={submitting}>
{submitting ? 'Creating...' : 'Create Admin Account'}
</button>
</form>
</div>
);
}

View File

@@ -1,236 +0,0 @@
import React from 'react';
import { render, screen, fireEvent, waitFor } from '@testing-library/react';
import { vi, type Mock } from 'vitest';
import { MemoryRouter } from 'react-router-dom';
import TimeOff from './TimeOff';
import { api, TimeOffRequest, ApiError } from '../api';
import { AuthProvider } from '../auth';
vi.mock('../api', () => {
class MockApiError extends Error {
status: number;
data: any;
constructor(message: string, status: number, data: any) {
super(message);
this.status = status;
this.data = data;
}
}
return {
api: {
listTimeOff: vi.fn(),
createTimeOff: vi.fn(),
updateTimeOff: vi.fn(),
deleteTimeOff: vi.fn(),
reviewTimeOff: vi.fn(),
getRemovedShifts: vi.fn(),
listVolunteers: vi.fn(),
},
ApiError: MockApiError,
};
});
const mockListTimeOff = api.listTimeOff as Mock;
const mockCreateTimeOff = api.createTimeOff as Mock;
const mockDeleteTimeOff = api.deleteTimeOff as Mock;
const mockReviewTimeOff = api.reviewTimeOff as Mock;
const mockGetRemovedShifts = api.getRemovedShifts as Mock;
const mockListVolunteers = api.listVolunteers as Mock;
function buildFakeJWT(payload: object): string {
const header = btoa(JSON.stringify({ alg: 'HS256', typ: 'JWT' }));
const body = btoa(JSON.stringify(payload));
return `${header}.${body}.fakesig`;
}
const ADMIN_TOKEN = buildFakeJWT({ volunteer_id: 1, role: 'admin', exp: 9999999999 });
const VOL_TOKEN = buildFakeJWT({ volunteer_id: 10, role: 'volunteer', exp: 9999999999 });
const futureRequest: TimeOffRequest = {
id: 1,
volunteer_id: 10,
starts_at: '2026-06-01T00:00:00Z',
ends_at: '2026-06-03T00:00:00Z',
reason: 'vacation',
status: 'approved',
created_at: '2026-04-01T00:00:00Z',
updated_at: '2026-04-01T00:00:00Z',
};
const pastRequest: TimeOffRequest = {
id: 2,
volunteer_id: 10,
starts_at: '2020-01-01T00:00:00Z',
ends_at: '2020-01-03T00:00:00Z',
reason: 'sick',
status: 'approved',
created_at: '2020-01-01T00:00:00Z',
updated_at: '2020-01-01T00:00:00Z',
};
function renderAsVolunteer() {
localStorage.setItem('token', VOL_TOKEN);
return render(
<AuthProvider>
<MemoryRouter>
<TimeOff />
</MemoryRouter>
</AuthProvider>,
);
}
function renderAsAdmin() {
localStorage.setItem('token', ADMIN_TOKEN);
return render(
<AuthProvider>
<MemoryRouter>
<TimeOff />
</MemoryRouter>
</AuthProvider>,
);
}
beforeEach(() => {
vi.clearAllMocks();
localStorage.clear();
mockListVolunteers.mockResolvedValue([]);
});
describe('TimeOff page', () => {
it('renders empty state', async () => {
mockListTimeOff.mockResolvedValue([]);
renderAsVolunteer();
await waitFor(() => expect(screen.getByText('No time off requests.')).toBeInTheDocument());
});
it('renders request list for volunteer', async () => {
mockListTimeOff.mockResolvedValue([futureRequest]);
renderAsVolunteer();
await waitFor(() => expect(screen.getByText('vacation')).toBeInTheDocument());
expect(screen.getByText('approved')).toBeInTheDocument();
});
it('shows edit and delete buttons for own future time off', async () => {
mockListTimeOff.mockResolvedValue([futureRequest]);
renderAsVolunteer();
await waitFor(() => expect(screen.getByText('Edit')).toBeInTheDocument());
expect(screen.getByText('Delete')).toBeInTheDocument();
});
it('does not show edit/delete for past time off as volunteer', async () => {
mockListTimeOff.mockResolvedValue([pastRequest]);
renderAsVolunteer();
await waitFor(() => expect(screen.getByText('sick')).toBeInTheDocument());
expect(screen.queryByText('Edit')).not.toBeInTheDocument();
expect(screen.queryByText('Delete')).not.toBeInTheDocument();
});
it('shows create form when button clicked', async () => {
mockListTimeOff.mockResolvedValue([]);
renderAsVolunteer();
await waitFor(() => expect(screen.getByText('Request Time Off')).toBeInTheDocument());
fireEvent.click(screen.getByText('Request Time Off'));
expect(screen.getByText('New Request')).toBeInTheDocument();
});
it('creates time off request successfully', async () => {
mockListTimeOff.mockResolvedValue([]);
mockCreateTimeOff.mockResolvedValue(futureRequest);
renderAsVolunteer();
fireEvent.click(screen.getByText('Request Time Off'));
fireEvent.change(screen.getByLabelText('From'), { target: { value: '2026-06-01' } });
fireEvent.change(screen.getByLabelText('To'), { target: { value: '2026-06-03' } });
fireEvent.click(screen.getByText('Submit'));
await waitFor(() => expect(mockCreateTimeOff).toHaveBeenCalled());
});
it('shows conflict warning on 409 and allows confirmation', async () => {
mockListTimeOff.mockResolvedValue([]);
const { ApiError: MockApiError } = await vi.importMock<typeof import('../api')>('../api');
mockCreateTimeOff
.mockRejectedValueOnce(
new (MockApiError as any)('conflict', 409, {
message: 'Time off conflicts with assigned shifts.',
conflicts: [
{ instance_id: 100, name: 'Morning Walk', date: '2026-06-01', start_time: '08:00', end_time: '12:00' },
],
}),
)
.mockResolvedValueOnce(futureRequest);
renderAsVolunteer();
fireEvent.click(screen.getByText('Request Time Off'));
fireEvent.change(screen.getByLabelText('From'), { target: { value: '2026-06-01' } });
fireEvent.change(screen.getByLabelText('To'), { target: { value: '2026-06-03' } });
fireEvent.click(screen.getByText('Submit'));
await waitFor(() => expect(screen.getByText(/conflicts with 1 assigned shift/)).toBeInTheDocument());
expect(screen.getByText(/Morning Walk/)).toBeInTheDocument();
expect(screen.getByText('Confirm & Submit')).toBeInTheDocument();
fireEvent.click(screen.getByText('Confirm & Submit'));
await waitFor(() =>
expect(mockCreateTimeOff).toHaveBeenLastCalledWith(
expect.objectContaining({ confirm_conflicts: true }),
),
);
});
it('admin sees volunteer column and approve/reject buttons', async () => {
const pendingReq: TimeOffRequest = { ...futureRequest, status: 'pending', volunteer_id: 10 };
mockListTimeOff.mockResolvedValue([pendingReq]);
mockListVolunteers.mockResolvedValue([{ id: 10, name: 'Alice' }]);
renderAsAdmin();
await waitFor(() => expect(screen.getByText('Volunteer')).toBeInTheDocument());
expect(screen.getByText('Approve')).toBeInTheDocument();
expect(screen.getByText('Reject')).toBeInTheDocument();
});
it('admin can approve a request', async () => {
const pendingReq: TimeOffRequest = { ...futureRequest, status: 'pending' };
mockListTimeOff.mockResolvedValue([pendingReq]);
mockReviewTimeOff.mockResolvedValue({ ...pendingReq, status: 'approved' });
mockListVolunteers.mockResolvedValue([]);
renderAsAdmin();
await waitFor(() => expect(screen.getByText('Approve')).toBeInTheDocument());
fireEvent.click(screen.getByText('Approve'));
await waitFor(() => expect(mockReviewTimeOff).toHaveBeenCalledWith(1, 'approved'));
});
it('admin sees shift restoration preview when deleting', async () => {
mockListTimeOff.mockResolvedValue([futureRequest]);
mockGetRemovedShifts.mockResolvedValue([
{ instance_id: 100, name: 'Morning Walk', date: '2026-06-01', start_time: '08:00', end_time: '12:00' },
]);
mockDeleteTimeOff.mockResolvedValue({ deleted: true, restored_shifts: [] });
mockListVolunteers.mockResolvedValue([{ id: 10, name: 'Alice' }]);
renderAsAdmin();
await waitFor(() => expect(screen.getByText('Delete')).toBeInTheDocument());
fireEvent.click(screen.getByText('Delete'));
await waitFor(() =>
expect(screen.getByText('Delete Time Off — Shift Restoration Preview')).toBeInTheDocument(),
);
expect(screen.getByText(/Morning Walk/)).toBeInTheDocument();
});
it('admin sees volunteer picker in create form', async () => {
mockListTimeOff.mockResolvedValue([]);
mockListVolunteers.mockResolvedValue([
{ id: 10, name: 'Alice' },
{ id: 20, name: 'Bob' },
]);
renderAsAdmin();
await waitFor(() => expect(screen.getByText('Request Time Off')).toBeInTheDocument());
fireEvent.click(screen.getByText('Request Time Off'));
expect(screen.getByText('Volunteer')).toBeInTheDocument();
expect(screen.getByText('Alice')).toBeInTheDocument();
expect(screen.getByText('Bob')).toBeInTheDocument();
});
});

View File

@@ -1,96 +1,31 @@
import React, { useEffect, useState, FormEvent } from 'react'; import React, { useEffect, useState, FormEvent } from 'react';
import { api, ApiError, TimeOffRequest, ConflictingShift, Volunteer } from '../api'; import { api, TimeOffRequest } from '../api';
import { useAuth } from '../auth'; import { useAuth } from '../auth';
export default function TimeOff() { export default function TimeOff() {
const { role, volunteerID } = useAuth(); const { role } = useAuth();
const [requests, setRequests] = useState<TimeOffRequest[]>([]); const [requests, setRequests] = useState<TimeOffRequest[]>([]);
const [volunteers, setVolunteers] = useState<Volunteer[]>([]);
const [error, setError] = useState(''); const [error, setError] = useState('');
const [showForm, setShowForm] = useState(false); const [showForm, setShowForm] = useState(false);
const [form, setForm] = useState({ starts_at: '', ends_at: '', reason: '', volunteer_id: 0 }); const [form, setForm] = useState({ starts_at: '', ends_at: '', reason: '' });
const [editingId, setEditingId] = useState<number | null>(null);
const [conflicts, setConflicts] = useState<ConflictingShift[] | null>(null);
const [deletePreview, setDeletePreview] = useState<{ id: number; shifts: ConflictingShift[] } | null>(null);
useEffect(() => { useEffect(() => {
api.listTimeOff().then(setRequests).catch(() => setError('Could not load requests.')); api.listTimeOff().then(setRequests).catch(() => setError('Could not load requests.'));
if (role === 'admin') { }, []);
api.listVolunteers().then(vols => setVolunteers(vols as Volunteer[]));
}
}, [role]);
async function handleCreate(e: FormEvent) { async function handleCreate(e: FormEvent) {
e.preventDefault(); e.preventDefault();
setError(''); setError('');
try { try {
const payload: any = { starts_at: form.starts_at, ends_at: form.ends_at, reason: form.reason }; const req = await api.createTimeOff(form);
if (role === 'admin' && form.volunteer_id > 0) { setRequests(prev => [req, ...prev]);
payload.volunteer_id = form.volunteer_id; setForm({ starts_at: '', ends_at: '', reason: '' });
} setShowForm(false);
if (conflicts) {
payload.confirm_conflicts = true;
}
const result = await api.createTimeOff(payload);
setRequests(prev => [result as TimeOffRequest, ...prev]);
resetForm();
} catch (err: any) {
if (err instanceof ApiError && err.status === 409 && err.data?.conflicts) {
setConflicts(err.data.conflicts);
return;
}
setError(err.message);
}
}
async function handleUpdate(e: FormEvent) {
e.preventDefault();
if (!editingId) return;
setError('');
try {
const req = await api.updateTimeOff(editingId, {
starts_at: form.starts_at,
ends_at: form.ends_at,
reason: form.reason,
});
setRequests(prev => prev.map(r => r.id === editingId ? req : r));
resetForm();
} catch (err: any) { } catch (err: any) {
setError(err.message); setError(err.message);
} }
} }
async function handleDelete(id: number) {
setError('');
try {
const result = await api.deleteTimeOff(id);
setRequests(prev => prev.filter(r => r.id !== id));
setDeletePreview(null);
if (result.restored_shifts?.length > 0) {
setError(`Restored volunteer to ${result.restored_shifts.length} shift(s).`);
}
} catch (err: any) {
setError(err.message);
}
}
async function handleDeleteClick(id: number) {
if (role === 'admin') {
try {
const shifts = await api.getRemovedShifts(id);
if (shifts.length > 0) {
setDeletePreview({ id, shifts });
return;
}
} catch {
// If we can't fetch preview, proceed with confirm
}
}
if (window.confirm('Delete this time off request?')) {
handleDelete(id);
}
}
async function handleReview(id: number, status: 'approved' | 'rejected') { async function handleReview(id: number, status: 'approved' | 'rejected') {
try { try {
const req = await api.reviewTimeOff(id, status); const req = await api.reviewTimeOff(id, status);
@@ -100,150 +35,71 @@ export default function TimeOff() {
} }
} }
function startEdit(r: TimeOffRequest) {
setEditingId(r.id);
setForm({
starts_at: r.starts_at.split('T')[0],
ends_at: r.ends_at.split('T')[0],
reason: r.reason ?? '',
volunteer_id: 0,
});
setShowForm(true);
setConflicts(null);
}
function resetForm() {
setForm({ starts_at: '', ends_at: '', reason: '', volunteer_id: 0 });
setShowForm(false);
setEditingId(null);
setConflicts(null);
}
function canEditOrDelete(r: TimeOffRequest): boolean {
if (role === 'admin') return true;
if (r.volunteer_id !== volunteerID) return false;
return new Date(r.starts_at) > new Date();
}
const statusClass = (status: string) => { const statusClass = (status: string) => {
if (status === 'approved') return 'status-approved'; if (status === 'approved') return 'status-approved';
if (status === 'rejected') return 'status-rejected'; if (status === 'rejected') return 'status-rejected';
return 'status-pending'; return 'status-pending';
}; };
const volunteerName = (vid: number) => {
const v = volunteers.find(v => v.id === vid);
return v ? v.name : `#${vid}`;
};
return ( return (
<div className="page"> <div className="page">
<div className="page-header"> <div className="page-header">
<h2>Time Off Requests</h2> <h2>Time Off Requests</h2>
<button onClick={() => { if (showForm) resetForm(); else setShowForm(true); }}> <button onClick={() => setShowForm(v => !v)}>
{showForm ? 'Cancel' : 'Request Time Off'} {showForm ? 'Cancel' : 'Request Time Off'}
</button> </button>
</div> </div>
{error && <p className="error">{error}</p>} {error && <p className="error">{error}</p>}
{showForm && ( {showForm && (
<form className="card" onSubmit={editingId ? handleUpdate : handleCreate}> <form className="card" onSubmit={handleCreate}>
<h3>{editingId ? 'Edit Request' : 'New Request'}</h3> <h3>New Request</h3>
{role === 'admin' && !editingId && (
<label>
Volunteer
<select
value={form.volunteer_id}
onChange={e => setForm(f => ({ ...f, volunteer_id: Number(e.target.value) }))}
>
<option value={0}>Myself</option>
{volunteers.filter(v => v.id !== volunteerID).map(v => (
<option key={v.id} value={v.id}>{v.name}</option>
))}
</select>
</label>
)}
<label> <label>
From From
<input type="date" value={form.starts_at} onChange={e => { setForm(f => ({ ...f, starts_at: e.target.value })); setConflicts(null); }} required /> <input type="date" value={form.starts_at} onChange={e => setForm(f => ({ ...f, starts_at: e.target.value }))} required />
</label> </label>
<label> <label>
To To
<input type="date" value={form.ends_at} onChange={e => { setForm(f => ({ ...f, ends_at: e.target.value })); setConflicts(null); }} required /> <input type="date" value={form.ends_at} onChange={e => setForm(f => ({ ...f, ends_at: e.target.value }))} required />
</label> </label>
<label> <label>
Reason Reason
<textarea value={form.reason} onChange={e => setForm(f => ({ ...f, reason: e.target.value }))} /> <textarea value={form.reason} onChange={e => setForm(f => ({ ...f, reason: e.target.value }))} />
</label> </label>
<button type="submit">Submit</button>
{conflicts && (
<div className="card" style={{ background: '#fff3cd', border: '1px solid #ffc107', marginBottom: '1rem' }}>
<p><strong>Warning:</strong> This time off conflicts with {conflicts.length} assigned shift(s):</p>
<ul>
{conflicts.map(c => (
<li key={c.instance_id}>{c.name} on {c.date} ({c.start_time}{c.end_time})</li>
))}
</ul>
<p>You will be removed from these shifts. Continue?</p>
</div>
)}
<button type="submit">
{conflicts ? 'Confirm & Submit' : editingId ? 'Save Changes' : 'Submit'}
</button>
</form> </form>
)} )}
{deletePreview && (
<div className="card" style={{ background: '#d4edda', border: '1px solid #28a745', marginBottom: '1rem' }}>
<h3>Delete Time Off Shift Restoration Preview</h3>
<p>Deleting this time off will restore the volunteer to {deletePreview.shifts.length} shift(s):</p>
<ul>
{deletePreview.shifts.map(s => (
<li key={s.instance_id}>{s.name} on {s.date} ({s.start_time}{s.end_time})</li>
))}
</ul>
<button onClick={() => handleDelete(deletePreview.id)}>Confirm Delete &amp; Restore</button>
<button onClick={() => setDeletePreview(null)} style={{ marginLeft: '0.5rem' }}>Cancel</button>
</div>
)}
{requests.length === 0 ? ( {requests.length === 0 ? (
<p>No time off requests.</p> <p>No time off requests.</p>
) : ( ) : (
<table> <table>
<thead> <thead>
<tr> <tr>
{role === 'admin' && <th>Volunteer</th>}
<th>From</th> <th>From</th>
<th>To</th> <th>To</th>
<th>Reason</th> <th>Reason</th>
<th>Status</th> <th>Status</th>
<th>Actions</th> {role === 'admin' && <th>Actions</th>}
</tr> </tr>
</thead> </thead>
<tbody> <tbody>
{requests.map(r => ( {requests.map(r => (
<tr key={r.id}> <tr key={r.id}>
{role === 'admin' && <td>{volunteerName(r.volunteer_id)}</td>} <td>{new Date(r.starts_at).toLocaleDateString()}</td>
<td>{new Date(r.starts_at).toLocaleDateString(undefined, { year: 'numeric', month: 'long', day: 'numeric' })}</td> <td>{new Date(r.ends_at).toLocaleDateString()}</td>
<td>{new Date(r.ends_at).toLocaleDateString(undefined, { year: 'numeric', month: 'long', day: 'numeric' })}</td>
<td>{r.reason ?? '—'}</td> <td>{r.reason ?? '—'}</td>
<td><span className={statusClass(r.status)}>{r.status}</span></td> <td><span className={statusClass(r.status)}>{r.status}</span></td>
{role === 'admin' && (
<td> <td>
{role === 'admin' && r.status === 'pending' && ( {r.status === 'pending' && (
<> <>
<button className="btn-small" onClick={() => handleReview(r.id, 'approved')}>Approve</button> <button className="btn-small" onClick={() => handleReview(r.id, 'approved')}>Approve</button>
<button className="btn-small btn-danger" onClick={() => handleReview(r.id, 'rejected')}>Reject</button> <button className="btn-small btn-danger" onClick={() => handleReview(r.id, 'rejected')}>Reject</button>
</> </>
)} )}
{canEditOrDelete(r) && (
<>
<button className="btn-small" onClick={() => startEdit(r)}>Edit</button>
<button className="btn-small btn-danger" onClick={() => handleDeleteClick(r.id)}>Delete</button>
</>
)}
</td> </td>
)}
</tr> </tr>
))} ))}
</tbody> </tbody>

View File

@@ -1,25 +1,24 @@
import React from 'react'; import React from 'react';
import { render, screen, fireEvent, waitFor } from '@testing-library/react'; import { render, screen, fireEvent, waitFor } from '@testing-library/react';
import { vi, type Mock } from 'vitest';
import { MemoryRouter } from 'react-router-dom'; import { MemoryRouter } from 'react-router-dom';
import Volunteers from './Volunteers'; import Volunteers from './Volunteers';
import { api, AdminVolunteer } from '../api'; import { api, AdminVolunteer } from '../api';
import { AuthProvider } from '../auth'; import { AuthProvider } from '../auth';
vi.mock('../api', () => ({ jest.mock('../api', () => ({
api: { api: {
listVolunteers: vi.fn(), listVolunteers: jest.fn(),
createVolunteer: vi.fn(), createVolunteer: jest.fn(),
updateVolunteer: vi.fn(), updateVolunteer: jest.fn(),
resendInvite: vi.fn(), resendInvite: jest.fn(),
}, },
OPERATIONAL_ROLES: ['Behaviour Team', 'Dog Log Monitor', 'Dog Shelter Volunteer', 'Trainee', 'Floater'], OPERATIONAL_ROLES: ['Behaviour Team', 'Dog Log Monitor', 'Dog Shelter Volunteer', 'Trainee', 'Floater'],
})); }));
const mockListVolunteers = api.listVolunteers as Mock; const mockListVolunteers = api.listVolunteers as jest.Mock;
const mockCreateVolunteer = api.createVolunteer as Mock; const mockCreateVolunteer = api.createVolunteer as jest.Mock;
const mockUpdateVolunteer = api.updateVolunteer as Mock; const mockUpdateVolunteer = api.updateVolunteer as jest.Mock;
const mockResendInvite = api.resendInvite as Mock; const mockResendInvite = api.resendInvite as jest.Mock;
function buildFakeJWT(payload: object): string { function buildFakeJWT(payload: object): string {
const header = btoa(JSON.stringify({ alg: 'HS256', typ: 'JWT' })); const header = btoa(JSON.stringify({ alg: 'HS256', typ: 'JWT' }));

1
web/src/react-app-env.d.ts vendored Normal file
View File

@@ -0,0 +1 @@
/// <reference types="react-scripts" />

View File

@@ -0,0 +1,15 @@
import { ReportHandler } from 'web-vitals';
const reportWebVitals = (onPerfEntry?: ReportHandler) => {
if (onPerfEntry && onPerfEntry instanceof Function) {
import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => {
getCLS(onPerfEntry);
getFID(onPerfEntry);
getFCP(onPerfEntry);
getLCP(onPerfEntry);
getTTFB(onPerfEntry);
});
}
};
export default reportWebVitals;

View File

@@ -1,22 +1,9 @@
// jest-dom adds custom jest matchers for asserting on DOM nodes.
// allows you to do things like:
// expect(element).toHaveTextContent(/react/i)
// learn more: https://github.com/testing-library/jest-dom
import '@testing-library/jest-dom'; import '@testing-library/jest-dom';
// Node 22+ ships a native localStorage (getter on globalThis) that lacks // React Router v7 requires TextEncoder/TextDecoder which jsdom (CRA 5) does not provide.
// .clear()/.getItem()/etc. jsdom doesn't override it. Delete the native import { TextEncoder, TextDecoder } from 'util';
// property and replace it with a spec-compliant Storage implementation. Object.assign(global, { TextEncoder, TextDecoder });
const store = new Map<string, string>();
const storage: Storage = {
getItem: (key: string) => store.get(key) ?? null,
setItem: (key: string, value: string) => { store.set(key, String(value)); },
removeItem: (key: string) => { store.delete(key); },
clear: () => { store.clear(); },
key: (index: number) => [...store.keys()][index] ?? null,
get length() { return store.size; },
};
delete (globalThis as any).localStorage;
Object.defineProperty(globalThis, 'localStorage', {
value: storage,
writable: true,
configurable: true,
enumerable: true,
});

View File

@@ -1 +0,0 @@
/// <reference types="vite/client" />

View File

@@ -1,21 +0,0 @@
{
"compilerOptions": {
"target": "ES2020",
"lib": ["dom", "dom.iterable", "esnext"],
"allowJs": true,
"skipLibCheck": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"noFallthroughCasesInSwitch": true,
"module": "ESNext",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"noEmit": true,
"jsx": "react-jsx"
},
"include": ["src"],
"exclude": ["src/**/*.test.tsx", "src/**/*.test.ts", "src/setupTests.ts"]
}

View File

@@ -1 +0,0 @@
{"root":["./src/app.tsx","./src/api.ts","./src/auth.tsx","./src/main.tsx","./src/vite-env.d.ts","./src/pages/activate.tsx","./src/pages/dashboard.tsx","./src/pages/login.tsx","./src/pages/profile.tsx","./src/pages/schedules.tsx","./src/pages/setup.tsx","./src/pages/timeoff.tsx","./src/pages/volunteers.tsx"],"version":"6.0.2"}

View File

@@ -1,7 +1,11 @@
{ {
"compilerOptions": { "compilerOptions": {
"target": "ES2020", "target": "es5",
"lib": ["dom", "dom.iterable", "esnext"], "lib": [
"dom",
"dom.iterable",
"esnext"
],
"allowJs": true, "allowJs": true,
"skipLibCheck": true, "skipLibCheck": true,
"esModuleInterop": true, "esModuleInterop": true,
@@ -9,13 +13,14 @@
"strict": true, "strict": true,
"forceConsistentCasingInFileNames": true, "forceConsistentCasingInFileNames": true,
"noFallthroughCasesInSwitch": true, "noFallthroughCasesInSwitch": true,
"module": "ESNext", "module": "esnext",
"moduleResolution": "bundler", "moduleResolution": "node",
"resolveJsonModule": true, "resolveJsonModule": true,
"isolatedModules": true, "isolatedModules": true,
"noEmit": true, "noEmit": true,
"jsx": "react-jsx", "jsx": "react-jsx"
"types": ["vitest/globals"]
}, },
"include": ["src", "vite.config.ts"] "include": [
"src"
]
} }

View File

@@ -1 +0,0 @@
{"root":["./src/app.test.tsx","./src/app.tsx","./src/api.ts","./src/auth.tsx","./src/main.tsx","./src/setuptests.ts","./src/vite-env.d.ts","./src/pages/activate.test.tsx","./src/pages/activate.tsx","./src/pages/dashboard.tsx","./src/pages/login.tsx","./src/pages/profile.test.tsx","./src/pages/profile.tsx","./src/pages/schedules.test.tsx","./src/pages/schedules.tsx","./src/pages/setup.test.tsx","./src/pages/setup.tsx","./src/pages/timeoff.tsx","./src/pages/volunteers.test.tsx","./src/pages/volunteers.tsx","./vite.config.ts"],"errors":true,"version":"6.0.2"}

View File

@@ -1,23 +0,0 @@
/// <reference types="vitest/config" />
import { defineConfig } from 'vite';
import react from '@vitejs/plugin-react';
export default defineConfig({
plugins: [react()],
server: {
port: 3000,
proxy: {
'/api': 'http://localhost:8080',
},
},
build: {
outDir: 'dist',
},
test: {
globals: true,
environment: 'jsdom',
setupFiles: './src/setupTests.ts',
css: true,
unstubGlobals: true,
},
});