Files
unsupervised-scheduler/tests/Unit/Auth/InviteTest.php
T
thatguygriff f3f5c7801f
CI / No Debug Code (pull_request) Successful in 3s
CI / Tests (PHP 8.1) (pull_request) Successful in 43s
CI / Tests (PHP 8.3) (pull_request) Successful in 49s
CI / Tests (PHP 8.2) (pull_request) Successful in 59s
CI / Coding Standards (pull_request) Successful in 1m11s
CI / PHPStan (pull_request) Successful in 1m20s
CI / Build Plugin Zip (pull_request) Has been skipped
Security fixes: CSV injection, policy body output, invite hashing, slot datetimes
Four fixes from a security review pass:

- Neutralise CSV formula injection in the payments export: fields with a
  leading =, +, -, @, tab, or CR (e.g. a hostile student display name) are
  apostrophe-prefixed in PaymentReport::csvLine() so they open as text in
  Excel/Google Sheets. Fixes #39.
- Sanitise policy bodies with wp_kses_post at output in
  PolicyEndpoint::index() (the booking JS renders that HTML raw), so a
  future write path that forgets kses can never become stored XSS.
  Fixes #40.
- Store invite tokens hashed (SHA-256) at rest: a database leak can no
  longer redeem pending invites. The registration link is shown once, at
  creation; the pending list shows email/invited date; lookups hash the
  submitted token. Existing plaintext pending invites must be re-issued.
  Fixes #41.
- Validate availability slot datetimes on both creation paths (REST and
  admin form) via AvailabilitySlot::normalizeDateTime(): canonical and
  datetime-local forms normalise to Y-m-d H:i:s, garbage and end <= start
  are rejected (REST 400) instead of reaching the DATETIME column or
  throwing inside the weekly-series date arithmetic. Fixes #42.

composer test (204 tests, 594 assertions), PHPStan L6, and PHPCS all green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-06-10 16:36:26 -03:00

117 lines
4.0 KiB
PHP

<?php
declare(strict_types=1);
namespace Unsupervised\Schedular\Tests\Unit\Auth;
use Unsupervised\Schedular\Auth\Invite;
use Unsupervised\Schedular\Auth\RoleManager;
use Unsupervised\Schedular\Tests\Unit\TestCase;
class InviteTest extends TestCase
{
public function testDefaults(): void
{
$invite = new Invite('a@b.test', 'tok123');
self::assertSame('a@b.test', $invite->email);
self::assertSame('tok123', $invite->token);
self::assertSame(RoleManager::STUDENT, $invite->role);
self::assertSame(Invite::STATUS_PENDING, $invite->status);
self::assertTrue($invite->isPending());
self::assertNull($invite->invitedBy);
self::assertNull($invite->acceptedUserId);
self::assertNull($invite->id);
}
public function testFromRowMapsCorrectly(): void
{
$invite = Invite::fromRow((object) [
'id' => '5',
'email' => 'a@b.test',
'token' => 'tok123',
'role' => RoleManager::STUDENT,
'status' => Invite::STATUS_ACCEPTED,
'invited_by' => '2',
'accepted_user_id' => '9',
'accepted_at' => '2026-06-02 09:00:00',
]);
self::assertSame(5, $invite->id);
self::assertSame(2, $invite->invitedBy);
self::assertSame(9, $invite->acceptedUserId);
self::assertFalse($invite->isPending());
}
public function testFromRowHandlesNullableIds(): void
{
$invite = Invite::fromRow((object) [
'id' => '5',
'email' => 'a@b.test',
'token' => 'tok123',
'role' => RoleManager::STUDENT,
'status' => Invite::STATUS_PENDING,
'invited_by' => null,
'accepted_user_id' => null,
'accepted_at' => null,
]);
self::assertNull($invite->invitedBy);
self::assertNull($invite->acceptedUserId);
self::assertTrue($invite->isPending());
}
public function testIsExpiredWhenOlderThanExpiryWindow(): void
{
$created = gmdate('Y-m-d H:i:s', strtotime('2026-06-01 09:00:00'));
$now = '2026-06-20 09:00:00'; // 19 days later, beyond the 14-day window.
$invite = new Invite('a@b.test', 'tok', createdAt: $created);
self::assertTrue($invite->isExpired($now));
self::assertFalse($invite->isAcceptable($now));
}
public function testIsNotExpiredWithinExpiryWindow(): void
{
$invite = new Invite('a@b.test', 'tok', createdAt: '2026-06-01 09:00:00');
$now = '2026-06-10 09:00:00'; // 9 days later, inside the window.
self::assertFalse($invite->isExpired($now));
self::assertTrue($invite->isAcceptable($now));
}
public function testIsNotExpiredWhenCreatedAtUnknown(): void
{
$invite = new Invite('a@b.test', 'tok');
self::assertFalse($invite->isExpired('2030-01-01 00:00:00'));
self::assertTrue($invite->isAcceptable('2030-01-01 00:00:00'));
}
public function testAcceptedInviteIsNotAcceptableEvenWhenFresh(): void
{
$invite = new Invite('a@b.test', 'tok', status: Invite::STATUS_ACCEPTED, createdAt: '2026-06-01 09:00:00');
self::assertFalse($invite->isAcceptable('2026-06-02 09:00:00'));
}
public function testHashTokenIsDeterministicSha256(): void
{
$hash = Invite::hashToken('raw-token');
self::assertSame(hash('sha256', 'raw-token'), $hash);
self::assertSame($hash, Invite::hashToken('raw-token'));
self::assertNotSame($hash, Invite::hashToken('other-token'));
self::assertSame(64, strlen($hash));
}
public function testToArrayContainsExpectedKeys(): void
{
$arr = (new Invite('a@b.test', 'tok', id: 1))->toArray();
foreach (['id', 'email', 'token', 'role', 'status', 'invited_by', 'accepted_user_id', 'accepted_at'] as $key) {
self::assertArrayHasKey($key, $arr);
}
}
}