thatguygriffandClaude Opus 5
8c21a3fa9d
CI / Tests (PHP 8.1) (pull_request) Successful in 6m39s
CI / Tests (PHP 8.2) (pull_request) Successful in 57s
CI / Tests (PHP 8.3) (pull_request) Successful in 2m59s
CI / Tests (PHP 8.5) (pull_request) Successful in 3m31s
CI / No Debug Code (pull_request) Successful in 3s
CI / Coding Standards & Static Analysis (pull_request) Successful in 3m28s
CI / Build Plugin Zip (pull_request) Skipped
Two related gaps, closed together because the second is created by the first. A private lesson could only be booked by the student or their guardian, so a booking taken over the phone had no way in — where group classes have had "Add students directly" all along. "Book a lesson for a student" is now a panel on Scheduler and My Lessons: student, open time, lesson type, with weekly term reservations and a no-charge option for make-up lessons. The booking core is extracted to Booking\LessonBooker and shared with POST /bookings, so the two paths cannot drift on offering rules, slot claiming, or billing. That leaves a registration with no intake answers and no policy acceptances, because nobody was at a keyboard to give them — already true of every directly added group-class student. Ticking the boxes on a student's behalf would be an audit trail that says something untrue, so instead the answers are collected another way and recorded afterwards, from a lesson's or an enrolment's detail page. Every recording must say how it was collected, which is stamped on each row along with who typed it and shown in a new "How it was given" column: a policy ticked online and one transcribed from paper must never look alike. Only staff-made registrations qualify (us_lessons.booked_by, us_group_enrollments.enrolled_by) — one the student made already holds their own answers. Only what is still missing can be recorded, re-checked at write time, so a stale or double-posted form cannot duplicate or overwrite. No IP is stored for a transcription, and accepted_by stays the student while recorded_by names the staff member. Intake is now generic over Registration\IntakeSubject, which Lesson and Enrollment both implement; LessonDetail became Registration\IntakeAudit and is shared by both detail views rather than duplicated. Closes #182 Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01QfHt6CyJHz6KkA4RuaS7WK
71 lines
2.5 KiB
PHP
71 lines
2.5 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Tests\Unit\GroupClass;
|
|
|
|
use Unsupervised\Schedular\GroupClass\Enrollment;
|
|
use Unsupervised\Schedular\Registration\Answer;
|
|
use Unsupervised\Schedular\Tests\Unit\TestCase;
|
|
|
|
class EnrollmentTest extends TestCase
|
|
{
|
|
public function testDefaults(): void
|
|
{
|
|
$enrollment = new Enrollment(offeringId: 7, studentId: 5, instructorId: 3);
|
|
|
|
self::assertSame(Enrollment::STATUS_ACTIVE, $enrollment->status);
|
|
self::assertNull($enrollment->paymentId);
|
|
self::assertNull($enrollment->id);
|
|
}
|
|
|
|
public function testStatusConstants(): void
|
|
{
|
|
self::assertContains(Enrollment::STATUS_ACTIVE, Enrollment::VALID_STATUSES);
|
|
self::assertContains(Enrollment::STATUS_CANCELLED, Enrollment::VALID_STATUSES);
|
|
self::assertContains(Enrollment::STATUS_COMPLETED, Enrollment::VALID_STATUSES);
|
|
}
|
|
|
|
public function testFromRowMapsCorrectly(): void
|
|
{
|
|
$enrollment = Enrollment::fromRow((object) [
|
|
'id' => '12',
|
|
'offering_id' => '7',
|
|
'student_id' => '5',
|
|
'instructor_id' => '3',
|
|
'status' => Enrollment::STATUS_ACTIVE,
|
|
'payment_id' => null,
|
|
]);
|
|
|
|
self::assertSame(12, $enrollment->id);
|
|
self::assertSame(7, $enrollment->offeringId);
|
|
self::assertSame(5, $enrollment->studentId);
|
|
self::assertNull($enrollment->paymentId);
|
|
}
|
|
|
|
public function testToArrayContainsExpectedKeys(): void
|
|
{
|
|
$arr = (new Enrollment(7, 5, 3, id: 12))->toArray();
|
|
|
|
foreach (['id', 'offering_id', 'student_id', 'instructor_id', 'status', 'payment_id', 'enrolled_by'] as $key) {
|
|
self::assertArrayHasKey($key, $arr);
|
|
}
|
|
}
|
|
|
|
public function testAnEnrolmentIsItsOwnIntakeRegistration(): void
|
|
{
|
|
$enrollment = new Enrollment(7, 5, 3, id: 12);
|
|
|
|
self::assertSame(Answer::REG_ENROLLMENT, $enrollment->intakeRegistrationType());
|
|
// No series anchor to follow: a term of classes is one enrolment.
|
|
self::assertSame(12, $enrollment->intakeRegistrationId());
|
|
self::assertSame(7, $enrollment->intakeOfferingId());
|
|
self::assertSame(5, $enrollment->intakeStudentId());
|
|
}
|
|
|
|
public function testOnlyAStudioMadeEnrolmentIsStaffRegistered(): void
|
|
{
|
|
self::assertFalse((new Enrollment(7, 5, 3, id: 12))->isStaffRegistered());
|
|
self::assertTrue((new Enrollment(7, 5, 3, enrolledBy: 9, id: 12))->isStaffRegistered());
|
|
}
|
|
}
|