thatguygriff
1d6ac46ba3
CI / No Debug Code (pull_request) Successful in 3s
CI / Tests (PHP 8.2) (pull_request) Successful in 48s
CI / Tests (PHP 8.3) (pull_request) Successful in 52s
CI / Coding Standards (pull_request) Successful in 57s
CI / Tests (PHP 8.1) (pull_request) Successful in 1m1s
CI / PHPStan (pull_request) Successful in 1m11s
CI / Build Plugin Zip (pull_request) Has been skipped
- Bump phpstan/phpstan ^2.0 and szepeviktor/phpstan-wordpress ^2.0 - Move the analysis level into phpstan.neon (single source) and raise it to 10 - Add Val, a runtime coercion helper that narrows untyped WordPress boundary values (wpdb rows, REST params, superglobals, options) with explicit checks instead of blind casts, plus unit tests - Type value-object fromRow() params as stdClass (what wpdb returns) and map columns through Val so unexpected shapes degrade safely - Use %i identifier placeholders for table names in all wpdb::prepare() calls so every query string is a literal and identifiers are escaped by WordPress; raises the minimum WordPress version to 6.2 where %i was introduced - Guard wpdb::prepare() null result before wpdb::query() in updateTax() - Fix nullable get_permalink()/strtotime() handling, list types at REST and capability call sites, dead null-coalescing on checked superglobals, and narrow get_users() results before mapping - Register Val method names with the ValidatedSanitizedInput sniff so it validates the real sanitizer around each superglobal read - Update repository unit tests for the %i placeholder arguments Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
102 lines
3.1 KiB
PHP
102 lines
3.1 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Tests\Unit\Registration;
|
|
|
|
use Brain\Monkey\Functions;
|
|
use Mockery;
|
|
use Unsupervised\Schedular\Registration\Answer;
|
|
use Unsupervised\Schedular\Registration\AnswerRepository;
|
|
use Unsupervised\Schedular\Tests\Unit\TestCase;
|
|
|
|
class AnswerRepositoryTest extends TestCase
|
|
{
|
|
private \wpdb $db;
|
|
private AnswerRepository $repo;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
|
|
$this->db = Mockery::mock(\wpdb::class);
|
|
$this->db->prefix = 'wp_';
|
|
$this->repo = new AnswerRepository($this->db);
|
|
}
|
|
|
|
public function testInsertCallsWpdbInsertAndReturnsId(): void
|
|
{
|
|
Functions\expect('current_time')->with('mysql')->andReturn('2026-04-01 12:00:00');
|
|
|
|
$this->db->shouldReceive('insert')
|
|
->once()
|
|
->with(
|
|
'wp_us_question_answers',
|
|
Mockery::on(static function (array $data): bool {
|
|
return $data['question_id'] === 3
|
|
&& $data['registration_type'] === Answer::REG_LESSON
|
|
&& $data['registration_id'] === 12
|
|
&& $data['student_id'] === 5
|
|
&& $data['answer_value'] === 'Beginner';
|
|
}),
|
|
['%d', '%s', '%d', '%d', '%s', '%s']
|
|
);
|
|
|
|
$this->db->insert_id = 77;
|
|
|
|
$answer = new Answer(3, Answer::REG_LESSON, 12, 5, 'Beginner');
|
|
|
|
self::assertSame(77, $this->repo->insert($answer));
|
|
}
|
|
|
|
public function testInsertManyReturnsAllIds(): void
|
|
{
|
|
Functions\when('current_time')->justReturn('2026-04-01 12:00:00');
|
|
|
|
$ids = [101, 102];
|
|
$this->db->shouldReceive('insert')
|
|
->twice()
|
|
->andReturnUsing(function () use (&$ids): void {
|
|
$this->db->insert_id = array_shift($ids);
|
|
});
|
|
|
|
$answers = [
|
|
new Answer(3, Answer::REG_LESSON, 12, 5, 'A'),
|
|
new Answer(4, Answer::REG_LESSON, 12, 5, 'B'),
|
|
];
|
|
|
|
$result = $this->repo->insertMany($answers);
|
|
|
|
self::assertSame([101, 102], $result);
|
|
}
|
|
|
|
public function testFindByRegistrationPreparesQueryAndMaps(): void
|
|
{
|
|
$row = (object) [
|
|
'id' => '1',
|
|
'question_id' => '3',
|
|
'registration_type' => Answer::REG_LESSON,
|
|
'registration_id' => '12',
|
|
'student_id' => '5',
|
|
'answer_value' => 'Beginner',
|
|
];
|
|
|
|
$this->db->shouldReceive('prepare')
|
|
->once()
|
|
->with(
|
|
Mockery::pattern('/registration_type = %s AND registration_id = %d/'),
|
|
'wp_us_question_answers',
|
|
Answer::REG_LESSON,
|
|
12
|
|
)
|
|
->andReturn('SELECT ...');
|
|
|
|
$this->db->shouldReceive('get_results')->andReturn([$row]);
|
|
|
|
$answers = $this->repo->findByRegistration(Answer::REG_LESSON, 12);
|
|
|
|
self::assertCount(1, $answers);
|
|
self::assertInstanceOf(Answer::class, $answers[0]);
|
|
self::assertSame(3, $answers[0]->questionId);
|
|
}
|
|
}
|