thatguygriff
1d6ac46ba3
CI / No Debug Code (pull_request) Successful in 3s
CI / Tests (PHP 8.2) (pull_request) Successful in 48s
CI / Tests (PHP 8.3) (pull_request) Successful in 52s
CI / Coding Standards (pull_request) Successful in 57s
CI / Tests (PHP 8.1) (pull_request) Successful in 1m1s
CI / PHPStan (pull_request) Successful in 1m11s
CI / Build Plugin Zip (pull_request) Has been skipped
- Bump phpstan/phpstan ^2.0 and szepeviktor/phpstan-wordpress ^2.0 - Move the analysis level into phpstan.neon (single source) and raise it to 10 - Add Val, a runtime coercion helper that narrows untyped WordPress boundary values (wpdb rows, REST params, superglobals, options) with explicit checks instead of blind casts, plus unit tests - Type value-object fromRow() params as stdClass (what wpdb returns) and map columns through Val so unexpected shapes degrade safely - Use %i identifier placeholders for table names in all wpdb::prepare() calls so every query string is a literal and identifiers are escaped by WordPress; raises the minimum WordPress version to 6.2 where %i was introduced - Guard wpdb::prepare() null result before wpdb::query() in updateTax() - Fix nullable get_permalink()/strtotime() handling, list types at REST and capability call sites, dead null-coalescing on checked superglobals, and narrow get_users() results before mapping - Register Val method names with the ValidatedSanitizedInput sniff so it validates the real sanitizer around each superglobal read - Update repository unit tests for the %i placeholder arguments Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
94 lines
3.1 KiB
PHP
94 lines
3.1 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Tests\Unit\Policy;
|
|
|
|
use Brain\Monkey\Functions;
|
|
use Mockery;
|
|
use Unsupervised\Schedular\Policy\AcceptanceRepository;
|
|
use Unsupervised\Schedular\Policy\PolicyAcceptance;
|
|
use Unsupervised\Schedular\Tests\Unit\TestCase;
|
|
|
|
class AcceptanceRepositoryTest extends TestCase
|
|
{
|
|
private \wpdb $db;
|
|
private AcceptanceRepository $repo;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
|
|
$this->db = Mockery::mock(\wpdb::class);
|
|
$this->db->prefix = 'wp_';
|
|
$this->repo = new AcceptanceRepository($this->db);
|
|
}
|
|
|
|
public function testInsertReturnsId(): void
|
|
{
|
|
Functions\expect('current_time')->with('mysql')->andReturn('2026-06-02 09:00:00');
|
|
|
|
$this->db->shouldReceive('insert')
|
|
->once()
|
|
->with(
|
|
'wp_us_policy_acceptances',
|
|
Mockery::on(static function (array $d): bool {
|
|
return $d['policy_version_id'] === 9
|
|
&& $d['student_id'] === 5
|
|
&& $d['registration_type'] === PolicyAcceptance::REG_LESSON
|
|
&& $d['registration_id'] === 12
|
|
&& $d['ip_address'] === '203.0.113.7';
|
|
}),
|
|
['%d', '%d', '%s', '%d', '%s', '%s']
|
|
);
|
|
$this->db->insert_id = 1;
|
|
|
|
$acceptance = new PolicyAcceptance(9, 5, PolicyAcceptance::REG_LESSON, 12, '203.0.113.7');
|
|
|
|
self::assertSame(1, $this->repo->insert($acceptance));
|
|
}
|
|
|
|
public function testInsertManyReturnsAllIds(): void
|
|
{
|
|
Functions\when('current_time')->justReturn('2026-06-02 09:00:00');
|
|
|
|
$ids = [11, 12];
|
|
$this->db->shouldReceive('insert')
|
|
->twice()
|
|
->andReturnUsing(function () use (&$ids): void {
|
|
$this->db->insert_id = array_shift($ids);
|
|
});
|
|
|
|
$result = $this->repo->insertMany([
|
|
new PolicyAcceptance(9, 5, PolicyAcceptance::REG_LESSON, 12),
|
|
new PolicyAcceptance(10, 5, PolicyAcceptance::REG_LESSON, 12),
|
|
]);
|
|
|
|
self::assertSame([11, 12], $result);
|
|
}
|
|
|
|
public function testFindByRegistrationMapsRows(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')
|
|
->once()
|
|
->with(Mockery::pattern('/registration_type = %s AND registration_id = %d/'), 'wp_us_policy_acceptances', PolicyAcceptance::REG_LESSON, 12)
|
|
->andReturn('SELECT ...');
|
|
|
|
$this->db->shouldReceive('get_results')->andReturn([
|
|
(object) [
|
|
'id' => '1',
|
|
'policy_version_id' => '9',
|
|
'student_id' => '5',
|
|
'registration_type' => PolicyAcceptance::REG_LESSON,
|
|
'registration_id' => '12',
|
|
'accepted_at' => '2026-06-02 09:00:00',
|
|
'ip_address' => null,
|
|
],
|
|
]);
|
|
|
|
$rows = $this->repo->findByRegistration(PolicyAcceptance::REG_LESSON, 12);
|
|
|
|
self::assertCount(1, $rows);
|
|
self::assertInstanceOf(PolicyAcceptance::class, $rows[0]);
|
|
}
|
|
}
|