thatguygriffandClaude Fable 5
5888032ed7
CI / No Debug Code (pull_request) Successful in 2s
CI / Tests (PHP 8.2) (pull_request) Successful in 53s
CI / PHPStan (pull_request) Successful in 2m46s
CI / Tests (PHP 8.1) (pull_request) Successful in 42s
CI / Coding Standards (pull_request) Successful in 47s
CI / Tests (PHP 8.3) (pull_request) Successful in 2m35s
CI / Build Plugin Zip (pull_request) Has been skipped
Booking a slot with no priced offering created the lesson but no payment,
yet the front end still called POST /payments/intent, which 400ed with
"Could not start payment for this registration" — the student saw an error
while the backend held a claimed slot and a lesson stuck at pending.
- POST /bookings and POST /enrollments now return a `payment` summary
({id, method, status}) or null when nothing is owed; the JS only runs
the payment step when a payment exists.
- Bookings with nothing owed are confirmed at creation — there is no
payment step that would ever confirm them later.
- The booking page now shows the student's upcoming lessons (GET /bookings,
now scoped to upcoming non-cancelled lessons with slot start/end times)
with a pending-payment/confirmed status badge.
Fixes #53
Co-Authored-By: Claude Fable 5 <[email protected]>
90 lines
3.4 KiB
PHP
90 lines
3.4 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Tests\Unit\Payment;
|
|
|
|
use Unsupervised\Schedular\Payment\Payment;
|
|
use Unsupervised\Schedular\Tests\Unit\TestCase;
|
|
|
|
class PaymentTest extends TestCase
|
|
{
|
|
public function testDefaults(): void
|
|
{
|
|
$payment = new Payment(5, 3, Payment::REG_LESSON, 12, 35.00);
|
|
|
|
self::assertSame('CAD', $payment->currency);
|
|
self::assertSame(Payment::METHOD_ETRANSFER, $payment->method);
|
|
self::assertSame(Payment::STATUS_PENDING, $payment->status);
|
|
self::assertFalse($payment->isPaid());
|
|
self::assertNull($payment->id);
|
|
}
|
|
|
|
public function testConstants(): void
|
|
{
|
|
self::assertContains(Payment::METHOD_CARD, Payment::VALID_METHODS);
|
|
self::assertContains(Payment::METHOD_ETRANSFER, Payment::VALID_METHODS);
|
|
self::assertContains(Payment::METHOD_COMP, Payment::VALID_METHODS);
|
|
self::assertContains(Payment::STATUS_PAID, Payment::VALID_STATUSES);
|
|
}
|
|
|
|
public function testFromRowMapsCorrectly(): void
|
|
{
|
|
$payment = Payment::fromRow((object) [
|
|
'id' => '7',
|
|
'student_id' => '5',
|
|
'instructor_id' => '3',
|
|
'registration_type' => Payment::REG_ENROLLMENT,
|
|
'registration_id' => '12',
|
|
'amount' => '120.00',
|
|
'currency' => 'CAD',
|
|
'method' => Payment::METHOD_COMP,
|
|
'status' => Payment::STATUS_PAID,
|
|
'tax_rate' => '13.00',
|
|
'tax_amount' => '15.60',
|
|
'etransfer_email' => null,
|
|
'stripe_payment_intent_id' => null,
|
|
'receipt_number' => 'USC-7',
|
|
'receipt_sent_at' => null,
|
|
'paid_at' => '2026-06-08 10:00:00',
|
|
]);
|
|
|
|
self::assertSame(7, $payment->id);
|
|
self::assertSame(120.00, $payment->amount);
|
|
self::assertSame(13.00, $payment->taxRate);
|
|
self::assertSame(15.60, $payment->taxAmount);
|
|
self::assertSame(Payment::METHOD_COMP, $payment->method);
|
|
self::assertTrue($payment->isPaid());
|
|
self::assertSame('USC-7', $payment->receiptNumber);
|
|
}
|
|
|
|
public function testTotalAddsTaxToAmount(): void
|
|
{
|
|
$payment = new Payment(5, 3, Payment::REG_LESSON, 12, 100.00, taxRate: 13.0, taxAmount: 13.00);
|
|
|
|
self::assertSame(113.00, $payment->total());
|
|
}
|
|
|
|
public function testTotalEqualsAmountWhenUntaxed(): void
|
|
{
|
|
$payment = new Payment(5, 3, Payment::REG_LESSON, 12, 100.00);
|
|
|
|
self::assertSame(100.00, $payment->total());
|
|
}
|
|
|
|
public function testToSummaryArrayContainsOnlyClientFacingFields(): void
|
|
{
|
|
$summary = (new Payment(5, 3, Payment::REG_LESSON, 12, 35.00, id: 7))->toSummaryArray();
|
|
|
|
self::assertSame(['id' => 7, 'method' => Payment::METHOD_ETRANSFER, 'status' => Payment::STATUS_PENDING], $summary);
|
|
}
|
|
|
|
public function testToArrayContainsExpectedKeys(): void
|
|
{
|
|
$arr = (new Payment(5, 3, Payment::REG_LESSON, 12, 35.00, id: 7))->toArray();
|
|
|
|
foreach (['id', 'student_id', 'amount', 'tax_rate', 'tax_amount', 'total', 'currency', 'method', 'status', 'receipt_number'] as $key) {
|
|
self::assertArrayHasKey($key, $arr);
|
|
}
|
|
}
|
|
}
|