thatguygriffandClaude Opus 5
8c21a3fa9d
CI / Tests (PHP 8.1) (pull_request) Successful in 6m39s
CI / Tests (PHP 8.2) (pull_request) Successful in 57s
CI / Tests (PHP 8.3) (pull_request) Successful in 2m59s
CI / Tests (PHP 8.5) (pull_request) Successful in 3m31s
CI / No Debug Code (pull_request) Successful in 3s
CI / Coding Standards & Static Analysis (pull_request) Successful in 3m28s
CI / Build Plugin Zip (pull_request) Skipped
Two related gaps, closed together because the second is created by the first. A private lesson could only be booked by the student or their guardian, so a booking taken over the phone had no way in — where group classes have had "Add students directly" all along. "Book a lesson for a student" is now a panel on Scheduler and My Lessons: student, open time, lesson type, with weekly term reservations and a no-charge option for make-up lessons. The booking core is extracted to Booking\LessonBooker and shared with POST /bookings, so the two paths cannot drift on offering rules, slot claiming, or billing. That leaves a registration with no intake answers and no policy acceptances, because nobody was at a keyboard to give them — already true of every directly added group-class student. Ticking the boxes on a student's behalf would be an audit trail that says something untrue, so instead the answers are collected another way and recorded afterwards, from a lesson's or an enrolment's detail page. Every recording must say how it was collected, which is stamped on each row along with who typed it and shown in a new "How it was given" column: a policy ticked online and one transcribed from paper must never look alike. Only staff-made registrations qualify (us_lessons.booked_by, us_group_enrollments.enrolled_by) — one the student made already holds their own answers. Only what is still missing can be recorded, re-checked at write time, so a stale or double-posted form cannot duplicate or overwrite. No IP is stored for a transcription, and accepted_by stays the student while recorded_by names the staff member. Intake is now generic over Registration\IntakeSubject, which Lesson and Enrollment both implement; LessonDetail became Registration\IntakeAudit and is shared by both detail views rather than duplicated. Closes #182 Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01QfHt6CyJHz6KkA4RuaS7WK
73 lines
2.4 KiB
PHP
73 lines
2.4 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Registration;
|
|
|
|
use Unsupervised\Schedular\Val;
|
|
|
|
class Answer {
|
|
|
|
public const REG_LESSON = 'lesson';
|
|
public const REG_ENROLLMENT = 'enrollment';
|
|
public const REG_ACCOUNT = 'account';
|
|
|
|
/**
|
|
* Polymorphic registration targets an answer can attach to. `account` is used
|
|
* by studio-wide questions answered at signup (registration_id = the user ID).
|
|
*
|
|
* @var list<string>
|
|
*/
|
|
public const VALID_REGISTRATION_TYPES = [ self::REG_LESSON, self::REG_ENROLLMENT, self::REG_ACCOUNT ];
|
|
|
|
public function __construct(
|
|
public readonly int $questionId,
|
|
public readonly string $registrationType,
|
|
public readonly int $registrationId,
|
|
public readonly int $studentId,
|
|
public readonly ?string $answerValue = null,
|
|
/**
|
|
* How this answer reached the studio when it did not come from the booking
|
|
* form — see {@see IntakeProvenance}. Null is the ordinary case: the student
|
|
* typed it in themselves.
|
|
*/
|
|
public readonly ?string $collectedVia = null,
|
|
public readonly ?string $collectedNote = null,
|
|
/** The staff member who typed it in, when somebody did. */
|
|
public readonly int $recordedBy = 0,
|
|
public readonly ?int $id = null,
|
|
) {}
|
|
|
|
public static function fromRow( \stdClass $row ): self {
|
|
return new self(
|
|
questionId: Val::int( $row->question_id ),
|
|
registrationType: Val::string( $row->registration_type ),
|
|
registrationId: Val::int( $row->registration_id ),
|
|
studentId: Val::int( $row->student_id ),
|
|
answerValue: Val::stringOrNull( $row->answer_value ),
|
|
collectedVia: Val::stringOrNull( $row->collected_via ?? null ),
|
|
collectedNote: Val::stringOrNull( $row->collected_note ?? null ),
|
|
recordedBy: Val::int( $row->recorded_by ?? 0 ),
|
|
id: Val::int( $row->id ),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Returns a plain array representation of the answer.
|
|
*
|
|
* @return array<string, mixed>
|
|
*/
|
|
public function toArray(): array {
|
|
return [
|
|
'id' => $this->id,
|
|
'question_id' => $this->questionId,
|
|
'registration_type' => $this->registrationType,
|
|
'registration_id' => $this->registrationId,
|
|
'student_id' => $this->studentId,
|
|
'answer_value' => $this->answerValue,
|
|
'collected_via' => $this->collectedVia,
|
|
'collected_note' => $this->collectedNote,
|
|
'recorded_by' => $this->recordedBy,
|
|
];
|
|
}
|
|
}
|