CI / Tests (PHP 8.1) (pull_request) Successful in 6m39s
CI / Tests (PHP 8.2) (pull_request) Successful in 57s
CI / Tests (PHP 8.3) (pull_request) Successful in 2m59s
CI / Tests (PHP 8.5) (pull_request) Successful in 3m31s
CI / No Debug Code (pull_request) Successful in 3s
CI / Coding Standards & Static Analysis (pull_request) Successful in 3m28s
CI / Build Plugin Zip (pull_request) Skipped
Two related gaps, closed together because the second is created by the first. A private lesson could only be booked by the student or their guardian, so a booking taken over the phone had no way in — where group classes have had "Add students directly" all along. "Book a lesson for a student" is now a panel on Scheduler and My Lessons: student, open time, lesson type, with weekly term reservations and a no-charge option for make-up lessons. The booking core is extracted to Booking\LessonBooker and shared with POST /bookings, so the two paths cannot drift on offering rules, slot claiming, or billing. That leaves a registration with no intake answers and no policy acceptances, because nobody was at a keyboard to give them — already true of every directly added group-class student. Ticking the boxes on a student's behalf would be an audit trail that says something untrue, so instead the answers are collected another way and recorded afterwards, from a lesson's or an enrolment's detail page. Every recording must say how it was collected, which is stamped on each row along with who typed it and shown in a new "How it was given" column: a policy ticked online and one transcribed from paper must never look alike. Only staff-made registrations qualify (us_lessons.booked_by, us_group_enrollments.enrolled_by) — one the student made already holds their own answers. Only what is still missing can be recorded, re-checked at write time, so a stale or double-posted form cannot duplicate or overwrite. No IP is stored for a transcription, and accepted_by stays the student while recorded_by names the staff member. Intake is now generic over Registration\IntakeSubject, which Lesson and Enrollment both implement; LessonDetail became Registration\IntakeAudit and is shared by both detail views rather than duplicated. Closes #182 Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01QfHt6CyJHz6KkA4RuaS7WK
93 lines
2.7 KiB
PHP
93 lines
2.7 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Policy;
|
|
|
|
class AcceptanceRepository {
|
|
|
|
private string $table;
|
|
|
|
public function __construct( private \wpdb $db ) {
|
|
$this->table = $db->prefix . 'us_policy_acceptances';
|
|
}
|
|
|
|
public function insert( PolicyAcceptance $acceptance ): int {
|
|
$this->db->insert(
|
|
$this->table,
|
|
[
|
|
'policy_version_id' => $acceptance->policyVersionId,
|
|
'student_id' => $acceptance->studentId,
|
|
'accepted_by' => $acceptance->acceptorOrStudent(),
|
|
'registration_type' => $acceptance->registrationType,
|
|
'registration_id' => $acceptance->registrationId,
|
|
'ip_address' => $acceptance->ipAddress,
|
|
'collected_via' => $acceptance->collectedVia,
|
|
'collected_note' => $acceptance->collectedNote,
|
|
'recorded_by' => $acceptance->recordedBy,
|
|
'accepted_at' => current_time( 'mysql' ),
|
|
],
|
|
[ '%d', '%d', '%d', '%s', '%d', '%s', '%s', '%s', '%d', '%s' ]
|
|
);
|
|
|
|
return $this->db->insert_id;
|
|
}
|
|
|
|
/**
|
|
* Persist a batch of acceptances for a single registration.
|
|
*
|
|
* @param list<PolicyAcceptance> $acceptances
|
|
* @return list<int> Inserted acceptance IDs.
|
|
*/
|
|
public function insertMany( array $acceptances ): array {
|
|
return array_map( fn( PolicyAcceptance $a ): int => $this->insert( $a ), $acceptances );
|
|
}
|
|
|
|
/**
|
|
* Backfill `accepted_by` on acceptances recorded before guardian accounts
|
|
* existed, where the student always agreed for themselves. Run once from the
|
|
* installer so the acceptor is a real user id on every row.
|
|
*/
|
|
public function backfillAcceptedBy(): void {
|
|
$sql = $this->db->prepare( 'UPDATE %i SET accepted_by = student_id WHERE accepted_by = 0', $this->table );
|
|
|
|
if ( null !== $sql ) {
|
|
$this->db->query( $sql );
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Find all acceptances attached to a registration (lesson or enrolment).
|
|
*
|
|
* @return list<PolicyAcceptance>
|
|
*/
|
|
public function findByRegistration( string $registrationType, int $registrationId ): array {
|
|
$rows = $this->db->get_results(
|
|
$this->db->prepare(
|
|
'SELECT * FROM %i WHERE registration_type = %s AND registration_id = %d ORDER BY id ASC',
|
|
$this->table,
|
|
$registrationType,
|
|
$registrationId
|
|
)
|
|
);
|
|
|
|
return array_map( PolicyAcceptance::fromRow( ... ), $rows ?? [] );
|
|
}
|
|
|
|
/**
|
|
* Find every acceptance a student has recorded, newest first.
|
|
*
|
|
* @return list<PolicyAcceptance>
|
|
*/
|
|
public function findByStudent( int $studentId ): array {
|
|
$rows = $this->db->get_results(
|
|
$this->db->prepare(
|
|
'SELECT * FROM %i WHERE student_id = %d ORDER BY accepted_at DESC, id DESC',
|
|
$this->table,
|
|
$studentId
|
|
)
|
|
);
|
|
|
|
return array_map( PolicyAcceptance::fromRow( ... ), $rows ?? [] );
|
|
}
|
|
}
|