Files
unsupervised-scheduler/src/Policy/PolicyRepository.php
T
thatguygriffandClaude Fable 5 1d6ac46ba3
CI / No Debug Code (pull_request) Successful in 3s
CI / Tests (PHP 8.2) (pull_request) Successful in 48s
CI / Tests (PHP 8.3) (pull_request) Successful in 52s
CI / Coding Standards (pull_request) Successful in 57s
CI / Tests (PHP 8.1) (pull_request) Successful in 1m1s
CI / PHPStan (pull_request) Successful in 1m11s
CI / Build Plugin Zip (pull_request) Has been skipped
Upgrade PHPStan to 2.x and raise analysis level from 6 to 10
- Bump phpstan/phpstan ^2.0 and szepeviktor/phpstan-wordpress ^2.0
- Move the analysis level into phpstan.neon (single source) and raise it to 10
- Add Val, a runtime coercion helper that narrows untyped WordPress boundary
  values (wpdb rows, REST params, superglobals, options) with explicit checks
  instead of blind casts, plus unit tests
- Type value-object fromRow() params as stdClass (what wpdb returns) and map
  columns through Val so unexpected shapes degrade safely
- Use %i identifier placeholders for table names in all wpdb::prepare() calls
  so every query string is a literal and identifiers are escaped by WordPress;
  raises the minimum WordPress version to 6.2 where %i was introduced
- Guard wpdb::prepare() null result before wpdb::query() in updateTax()
- Fix nullable get_permalink()/strtotime() handling, list types at REST and
  capability call sites, dead null-coalescing on checked superglobals, and
  narrow get_users() results before mapping
- Register Val method names with the ValidatedSanitizedInput sniff so it
  validates the real sanitizer around each superglobal read
- Update repository unit tests for the %i placeholder arguments

Co-Authored-By: Claude Fable 5 <[email protected]>
2026-06-12 13:42:50 -03:00

90 lines
2.2 KiB
PHP

<?php
declare(strict_types=1);
namespace Unsupervised\Schedular\Policy;
class PolicyRepository {
private string $table;
public function __construct( private \wpdb $db ) {
$this->table = $db->prefix . 'us_policies';
}
public function insert( Policy $policy ): int {
$this->db->insert(
$this->table,
[
'title' => $policy->title,
'slug' => $policy->slug,
'current_version_id' => $policy->currentVersionId,
'acceptance_scope' => $policy->acceptanceScope,
'created_at' => current_time( 'mysql' ),
],
[ '%s', '%s', '%d', '%s', '%s' ]
);
return $this->db->insert_id;
}
/**
* Policies that must be accepted in the given gate — those scoped to it or to
* `both`. Pass `Policy::SCOPE_SIGNUP` or `Policy::SCOPE_BOOKING`.
*
* @return list<Policy>
*/
public function findForScope( string $scope ): array {
$rows = $this->db->get_results(
$this->db->prepare(
'SELECT * FROM %i WHERE acceptance_scope = %s OR acceptance_scope = %s ORDER BY title ASC',
$this->table,
$scope,
Policy::SCOPE_BOTH
)
);
return array_map( Policy::fromRow( ... ), $rows ?? [] );
}
public function updateCurrentVersion( int $policyId, int $versionId ): bool {
return false !== $this->db->update(
$this->table,
[ 'current_version_id' => $versionId ],
[ 'id' => $policyId ],
[ '%d' ],
[ '%d' ]
);
}
/**
* All policies, ordered by title.
*
* @return list<Policy>
*/
public function findAll(): array {
$rows = $this->db->get_results( "SELECT * FROM {$this->table} ORDER BY title ASC" );
return array_map( Policy::fromRow( ... ), $rows ?? [] );
}
public function findById( int $id ): ?Policy {
$row = $this->db->get_row(
$this->db->prepare( 'SELECT * FROM %i WHERE id = %d', $this->table, $id )
);
return $row ? Policy::fromRow( $row ) : null;
}
public function findBySlug( string $slug ): ?Policy {
$row = $this->db->get_row(
$this->db->prepare( 'SELECT * FROM %i WHERE slug = %s', $this->table, $slug )
);
return $row ? Policy::fromRow( $row ) : null;
}
public function delete( int $id ): bool {
return (bool) $this->db->delete( $this->table, [ 'id' => $id ], [ '%d' ] );
}
}