1d6ac46ba3
CI / No Debug Code (pull_request) Successful in 3s
CI / Tests (PHP 8.2) (pull_request) Successful in 48s
CI / Tests (PHP 8.3) (pull_request) Successful in 52s
CI / Coding Standards (pull_request) Successful in 57s
CI / Tests (PHP 8.1) (pull_request) Successful in 1m1s
CI / PHPStan (pull_request) Successful in 1m11s
CI / Build Plugin Zip (pull_request) Has been skipped
- Bump phpstan/phpstan ^2.0 and szepeviktor/phpstan-wordpress ^2.0 - Move the analysis level into phpstan.neon (single source) and raise it to 10 - Add Val, a runtime coercion helper that narrows untyped WordPress boundary values (wpdb rows, REST params, superglobals, options) with explicit checks instead of blind casts, plus unit tests - Type value-object fromRow() params as stdClass (what wpdb returns) and map columns through Val so unexpected shapes degrade safely - Use %i identifier placeholders for table names in all wpdb::prepare() calls so every query string is a literal and identifiers are escaped by WordPress; raises the minimum WordPress version to 6.2 where %i was introduced - Guard wpdb::prepare() null result before wpdb::query() in updateTax() - Fix nullable get_permalink()/strtotime() handling, list types at REST and capability call sites, dead null-coalescing on checked superglobals, and narrow get_users() results before mapping - Register Val method names with the ValidatedSanitizedInput sniff so it validates the real sanitizer around each superglobal read - Update repository unit tests for the %i placeholder arguments Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
153 lines
4.7 KiB
PHP
153 lines
4.7 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Tests\Unit\Registration;
|
|
|
|
use Brain\Monkey\Functions;
|
|
use Mockery;
|
|
use Unsupervised\Schedular\Registration\Question;
|
|
use Unsupervised\Schedular\Registration\QuestionRepository;
|
|
use Unsupervised\Schedular\Tests\Unit\TestCase;
|
|
|
|
class QuestionRepositoryTest extends TestCase
|
|
{
|
|
private \wpdb $db;
|
|
private QuestionRepository $repo;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
|
|
$this->db = Mockery::mock(\wpdb::class);
|
|
$this->db->prefix = 'wp_';
|
|
$this->repo = new QuestionRepository($this->db);
|
|
}
|
|
|
|
public function testInsertWithNullOptionsStoresNull(): void
|
|
{
|
|
Functions\expect('current_time')->with('mysql')->andReturn('2026-04-01 12:00:00');
|
|
|
|
$this->db->shouldReceive('insert')
|
|
->once()
|
|
->with(
|
|
'wp_us_questions',
|
|
Mockery::on(static function (array $data): bool {
|
|
return $data['offering_id'] === 7
|
|
&& $data['label'] === 'Your level?'
|
|
&& $data['field_type'] === Question::FIELD_TEXT
|
|
&& $data['options'] === null
|
|
&& $data['is_required'] === 0
|
|
&& $data['created_at'] === '2026-04-01 12:00:00';
|
|
}),
|
|
Mockery::type('array')
|
|
);
|
|
|
|
$this->db->insert_id = 21;
|
|
|
|
$question = new Question(7, 'Your level?');
|
|
|
|
self::assertSame(21, $this->repo->insert($question));
|
|
}
|
|
|
|
public function testInsertEncodesOptionsAsJson(): void
|
|
{
|
|
Functions\expect('current_time')->andReturn('2026-04-01 12:00:00');
|
|
Functions\expect('wp_json_encode')
|
|
->once()
|
|
->with(['Beginner', 'Advanced'])
|
|
->andReturn('["Beginner","Advanced"]');
|
|
|
|
$this->db->shouldReceive('insert')
|
|
->once()
|
|
->with(
|
|
'wp_us_questions',
|
|
Mockery::on(static fn (array $data): bool => $data['options'] === '["Beginner","Advanced"]'),
|
|
Mockery::type('array')
|
|
);
|
|
|
|
$this->db->insert_id = 22;
|
|
|
|
$question = new Question(
|
|
offeringId: 7,
|
|
label: 'Pick a level',
|
|
fieldType: Question::FIELD_SELECT,
|
|
options: ['Beginner', 'Advanced'],
|
|
);
|
|
|
|
self::assertSame(22, $this->repo->insert($question));
|
|
}
|
|
|
|
public function testUpdateReturnsTrueOnSuccess(): void
|
|
{
|
|
$this->db->shouldReceive('update')
|
|
->once()
|
|
->with(
|
|
'wp_us_questions',
|
|
Mockery::on(static fn (array $data): bool => $data['label'] === 'Renamed' && $data['is_required'] === 1),
|
|
['id' => 5],
|
|
Mockery::type('array'),
|
|
['%d']
|
|
)
|
|
->andReturn(1);
|
|
|
|
$question = new Question(7, 'Renamed', isRequired: true, id: 5);
|
|
|
|
self::assertTrue($this->repo->update(5, $question));
|
|
}
|
|
|
|
public function testFindByOfferingActiveOnlyPreparesQuery(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')
|
|
->once()
|
|
->with(
|
|
Mockery::pattern('/offering_id = %d AND is_active = %d/'),
|
|
Mockery::on(static fn (array $p): bool => $p === ['wp_us_questions', 7, 1])
|
|
)
|
|
->andReturn('SELECT ...');
|
|
|
|
$this->db->shouldReceive('get_results')->andReturn([]);
|
|
|
|
self::assertSame([], $this->repo->findByOffering(7, activeOnly: true));
|
|
}
|
|
|
|
public function testFindByOfferingReturnsQuestions(): void
|
|
{
|
|
$row = (object) [
|
|
'id' => '3',
|
|
'offering_id' => '7',
|
|
'label' => 'Q',
|
|
'field_type' => Question::FIELD_TEXT,
|
|
'options' => null,
|
|
'is_required' => '0',
|
|
'sort_order' => '0',
|
|
'is_active' => '1',
|
|
];
|
|
|
|
$this->db->shouldReceive('prepare')->andReturn('SELECT ...');
|
|
$this->db->shouldReceive('get_results')->andReturn([$row]);
|
|
|
|
$questions = $this->repo->findByOffering(7);
|
|
|
|
self::assertCount(1, $questions);
|
|
self::assertInstanceOf(Question::class, $questions[0]);
|
|
}
|
|
|
|
public function testFindByIdReturnsNullWhenNotFound(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')->andReturn('SELECT ...');
|
|
$this->db->shouldReceive('get_row')->andReturn(null);
|
|
|
|
self::assertNull($this->repo->findById(99));
|
|
}
|
|
|
|
public function testDeleteCallsWpdbDelete(): void
|
|
{
|
|
$this->db->shouldReceive('delete')
|
|
->once()
|
|
->with('wp_us_questions', ['id' => 4], ['%d'])
|
|
->andReturn(1);
|
|
|
|
self::assertTrue($this->repo->delete(4));
|
|
}
|
|
}
|