1d6ac46ba3
CI / No Debug Code (pull_request) Successful in 3s
CI / Tests (PHP 8.2) (pull_request) Successful in 48s
CI / Tests (PHP 8.3) (pull_request) Successful in 52s
CI / Coding Standards (pull_request) Successful in 57s
CI / Tests (PHP 8.1) (pull_request) Successful in 1m1s
CI / PHPStan (pull_request) Successful in 1m11s
CI / Build Plugin Zip (pull_request) Has been skipped
- Bump phpstan/phpstan ^2.0 and szepeviktor/phpstan-wordpress ^2.0 - Move the analysis level into phpstan.neon (single source) and raise it to 10 - Add Val, a runtime coercion helper that narrows untyped WordPress boundary values (wpdb rows, REST params, superglobals, options) with explicit checks instead of blind casts, plus unit tests - Type value-object fromRow() params as stdClass (what wpdb returns) and map columns through Val so unexpected shapes degrade safely - Use %i identifier placeholders for table names in all wpdb::prepare() calls so every query string is a literal and identifiers are escaped by WordPress; raises the minimum WordPress version to 6.2 where %i was introduced - Guard wpdb::prepare() null result before wpdb::query() in updateTax() - Fix nullable get_permalink()/strtotime() handling, list types at REST and capability call sites, dead null-coalescing on checked superglobals, and narrow get_users() results before mapping - Register Val method names with the ValidatedSanitizedInput sniff so it validates the real sanitizer around each superglobal read - Update repository unit tests for the %i placeholder arguments Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
118 lines
3.9 KiB
PHP
118 lines
3.9 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
namespace Unsupervised\Schedular\Tests\Unit\Policy;
|
|
|
|
use Brain\Monkey\Functions;
|
|
use Mockery;
|
|
use Unsupervised\Schedular\Policy\Policy;
|
|
use Unsupervised\Schedular\Policy\PolicyRepository;
|
|
use Unsupervised\Schedular\Tests\Unit\TestCase;
|
|
|
|
class PolicyRepositoryTest extends TestCase
|
|
{
|
|
private \wpdb $db;
|
|
private PolicyRepository $repo;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
|
|
$this->db = Mockery::mock(\wpdb::class);
|
|
$this->db->prefix = 'wp_';
|
|
$this->repo = new PolicyRepository($this->db);
|
|
}
|
|
|
|
public function testInsertReturnsId(): void
|
|
{
|
|
Functions\expect('current_time')->with('mysql')->andReturn('2026-06-01 12:00:00');
|
|
|
|
$this->db->shouldReceive('insert')
|
|
->once()
|
|
->with(
|
|
'wp_us_policies',
|
|
Mockery::on(static fn (array $d): bool => $d['title'] === 'Cancellation' && $d['slug'] === 'cancellation' && $d['current_version_id'] === null && $d['acceptance_scope'] === Policy::SCOPE_BOOKING),
|
|
['%s', '%s', '%d', '%s', '%s']
|
|
);
|
|
$this->db->insert_id = 7;
|
|
|
|
self::assertSame(7, $this->repo->insert(new Policy('Cancellation', 'cancellation')));
|
|
}
|
|
|
|
public function testFindForScopeMatchesScopeOrBoth(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')
|
|
->once()
|
|
->with(
|
|
Mockery::pattern('/acceptance_scope = %s OR acceptance_scope = %s/'),
|
|
'wp_us_policies',
|
|
Policy::SCOPE_SIGNUP,
|
|
Policy::SCOPE_BOTH
|
|
)
|
|
->andReturn('SELECT ...');
|
|
|
|
$this->db->shouldReceive('get_results')->andReturn([
|
|
(object) ['id' => '1', 'title' => 'Terms', 'slug' => 'terms', 'current_version_id' => '5', 'acceptance_scope' => Policy::SCOPE_SIGNUP],
|
|
]);
|
|
|
|
$found = $this->repo->findForScope(Policy::SCOPE_SIGNUP);
|
|
|
|
self::assertCount(1, $found);
|
|
self::assertSame(Policy::SCOPE_SIGNUP, $found[0]->acceptanceScope);
|
|
}
|
|
|
|
public function testUpdateCurrentVersion(): void
|
|
{
|
|
$this->db->shouldReceive('update')
|
|
->once()
|
|
->with('wp_us_policies', ['current_version_id' => 9], ['id' => 7], ['%d'], ['%d'])
|
|
->andReturn(1);
|
|
|
|
self::assertTrue($this->repo->updateCurrentVersion(7, 9));
|
|
}
|
|
|
|
public function testFindBySlugReturnsPolicy(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')->andReturn('SELECT ...');
|
|
$this->db->shouldReceive('get_row')->andReturn((object) [
|
|
'id' => '7',
|
|
'title' => 'Cancellation',
|
|
'slug' => 'cancellation',
|
|
'current_version_id' => null,
|
|
'acceptance_scope' => Policy::SCOPE_BOOKING,
|
|
]);
|
|
|
|
$policy = $this->repo->findBySlug('cancellation');
|
|
|
|
self::assertInstanceOf(Policy::class, $policy);
|
|
self::assertSame('cancellation', $policy->slug);
|
|
}
|
|
|
|
public function testFindBySlugReturnsNullWhenMissing(): void
|
|
{
|
|
$this->db->shouldReceive('prepare')->andReturn('SELECT ...');
|
|
$this->db->shouldReceive('get_row')->andReturn(null);
|
|
|
|
self::assertNull($this->repo->findBySlug('nope'));
|
|
}
|
|
|
|
public function testFindAllMapsRows(): void
|
|
{
|
|
$this->db->shouldReceive('get_results')->andReturn([
|
|
(object) ['id' => '1', 'title' => 'A', 'slug' => 'a', 'current_version_id' => null, 'acceptance_scope' => Policy::SCOPE_BOOKING],
|
|
]);
|
|
|
|
$all = $this->repo->findAll();
|
|
|
|
self::assertCount(1, $all);
|
|
self::assertInstanceOf(Policy::class, $all[0]);
|
|
}
|
|
|
|
public function testDeleteCallsWpdb(): void
|
|
{
|
|
$this->db->shouldReceive('delete')->once()->with('wp_us_policies', ['id' => 3], ['%d'])->andReturn(1);
|
|
|
|
self::assertTrue($this->repo->delete(3));
|
|
}
|
|
}
|