Files
unsupervised-scheduler/src/Policy/PolicyVersionRepository.php
T
thatguygriffandClaude Fable 5 1d6ac46ba3
CI / No Debug Code (pull_request) Successful in 3s
CI / Tests (PHP 8.2) (pull_request) Successful in 48s
CI / Tests (PHP 8.3) (pull_request) Successful in 52s
CI / Coding Standards (pull_request) Successful in 57s
CI / Tests (PHP 8.1) (pull_request) Successful in 1m1s
CI / PHPStan (pull_request) Successful in 1m11s
CI / Build Plugin Zip (pull_request) Has been skipped
Upgrade PHPStan to 2.x and raise analysis level from 6 to 10
- Bump phpstan/phpstan ^2.0 and szepeviktor/phpstan-wordpress ^2.0
- Move the analysis level into phpstan.neon (single source) and raise it to 10
- Add Val, a runtime coercion helper that narrows untyped WordPress boundary
  values (wpdb rows, REST params, superglobals, options) with explicit checks
  instead of blind casts, plus unit tests
- Type value-object fromRow() params as stdClass (what wpdb returns) and map
  columns through Val so unexpected shapes degrade safely
- Use %i identifier placeholders for table names in all wpdb::prepare() calls
  so every query string is a literal and identifiers are escaped by WordPress;
  raises the minimum WordPress version to 6.2 where %i was introduced
- Guard wpdb::prepare() null result before wpdb::query() in updateTax()
- Fix nullable get_permalink()/strtotime() handling, list types at REST and
  capability call sites, dead null-coalescing on checked superglobals, and
  narrow get_users() results before mapping
- Register Val method names with the ValidatedSanitizedInput sniff so it
  validates the real sanitizer around each superglobal read
- Update repository unit tests for the %i placeholder arguments

Co-Authored-By: Claude Fable 5 <[email protected]>
2026-06-12 13:42:50 -03:00

90 lines
2.1 KiB
PHP

<?php
declare(strict_types=1);
namespace Unsupervised\Schedular\Policy;
class PolicyVersionRepository {
private string $table;
public function __construct( private \wpdb $db ) {
$this->table = $db->prefix . 'us_policy_versions';
}
public function insert( PolicyVersion $version ): int {
$this->db->insert(
$this->table,
[
'policy_id' => $version->policyId,
'version_number' => $version->versionNumber,
'body' => $version->body,
'status' => $version->status,
'published_at' => $version->publishedAt,
'created_at' => current_time( 'mysql' ),
],
[ '%d', '%d', '%s', '%s', '%s', '%s' ]
);
return $this->db->insert_id;
}
public function updateBody( int $id, ?string $body ): bool {
return false !== $this->db->update(
$this->table,
[ 'body' => $body ],
[ 'id' => $id ],
[ '%s' ],
[ '%d' ]
);
}
public function updateStatus( int $id, string $status, ?string $publishedAt = null ): bool {
return false !== $this->db->update(
$this->table,
[
'status' => $status,
'published_at' => $publishedAt,
],
[ 'id' => $id ],
[ '%s', '%s' ],
[ '%d' ]
);
}
/**
* All versions of a policy, newest version number first.
*
* @return list<PolicyVersion>
*/
public function findByPolicy( int $policyId ): array {
$rows = $this->db->get_results(
$this->db->prepare(
'SELECT * FROM %i WHERE policy_id = %d ORDER BY version_number DESC',
$this->table,
$policyId
)
);
return array_map( PolicyVersion::fromRow( ... ), $rows ?? [] );
}
public function findById( int $id ): ?PolicyVersion {
$row = $this->db->get_row(
$this->db->prepare( 'SELECT * FROM %i WHERE id = %d', $this->table, $id )
);
return $row ? PolicyVersion::fromRow( $row ) : null;
}
/**
* Highest version_number assigned for a policy (0 when none exist yet).
*/
public function maxVersionNumber( int $policyId ): int {
$max = $this->db->get_var(
$this->db->prepare( 'SELECT MAX(version_number) FROM %i WHERE policy_id = %d', $this->table, $policyId )
);
return null === $max ? 0 : (int) $max;
}
}