Studio-defined account-registration questions #91

2026-07-23T13:45:48Z

thatguygriff commented

2026-07-23 13:45:48 +00:00

Closes #90

What this does

Studio admins can define account-registration questions that every new student answers as a required second step during signup (after name/password), and each student's answers appear under a new Registration Information section in the admin.

Approach

Extends the existing Registration domain rather than building a parallel system — the answer side was already polymorphic and account-aware.

Schema (Schema.php): us_questions.offering_id is now nullable and a new scope column (offering | account) distinguishes the two. Account answers reuse us_question_answers with the new Answer::REG_ACCOUNT type (registration_id = user ID). Plugin version bumped 1.0.0 → 1.1.0 so dbDelta runs the migration.
Authoring: reuses Offerings → Questions with an "Account signup (all registrations)" scope, visible to studio admins only.
Signup step 2: RegistrationPage + register-page.php + new assets/js/register.js split the form into two panels behind a "Next" button (progressive enhancement — works without JS). Required answers are validated before the user is created; applies to all paths (invite, group link, self-approval).
Admin review: StudentHistory::registrationInfo() lists each account question with the student's answer ("—" when unanswered); account answers are excluded from the existing "Intake answers" table to avoid duplication.
REST stays offering-scope only (account questions are managed through the server-rendered admin page).

Notes

Field types reuse the existing set (text / paragraph / dropdown / checkbox) with a per-question required toggle.
A question added after a student registered shows "—" for that student (they are not re-prompted).

Tests

composer test — 421 tests, 1246 assertions, all passing
composer lint — PHPStan level 10, no errors
composer cs — PHPCS clean
no-debug check — clean

Closes #90 ## What this does Studio admins can define **account-registration questions** that every new student answers as a required **second step** during signup (after name/password), and each student's answers appear under a new **Registration Information** section in the admin. ## Approach Extends the existing `Registration` domain rather than building a parallel system — the answer side was already polymorphic and `account`-aware. - **Schema** (`Schema.php`): `us_questions.offering_id` is now nullable and a new `scope` column (`offering` | `account`) distinguishes the two. Account answers reuse `us_question_answers` with the new `Answer::REG_ACCOUNT` type (`registration_id` = user ID). **Plugin version bumped 1.0.0 → 1.1.0** so `dbDelta` runs the migration. - **Authoring**: reuses **Offerings → Questions** with an "Account signup (all registrations)" scope, visible to studio admins only. - **Signup step 2**: `RegistrationPage` + `register-page.php` + new `assets/js/register.js` split the form into two panels behind a "Next" button (progressive enhancement — works without JS). Required answers are validated **before** the user is created; applies to all paths (invite, group link, self-approval). - **Admin review**: `StudentHistory::registrationInfo()` lists each account question with the student's answer ("—" when unanswered); account answers are excluded from the existing "Intake answers" table to avoid duplication. - REST stays offering-scope only (account questions are managed through the server-rendered admin page). ## Notes - Field types reuse the existing set (text / paragraph / dropdown / checkbox) with a per-question required toggle. - A question added after a student registered shows "—" for that student (they are not re-prompted). ## Tests - `composer test` — 421 tests, 1246 assertions, all passing - `composer lint` — PHPStan level 10, no errors - `composer cs` — PHPCS clean - no-debug check — clean

thatguygriff added 1 commit 2026-07-23 13:45:48 +00:00

Add studio-defined account-registration questions

CI / Tests (PHP 8.2) (pull_request) Successful in 44s

Details

CI / Tests (PHP 8.1) (pull_request) Successful in 45s

Details

CI / No Debug Code (pull_request) Successful in 2s

Details

CI / Coding Standards (pull_request) Successful in 2m46s

Details

CI / PHPStan (pull_request) Successful in 2m58s

Details

CI / Tests (PHP 8.3) (pull_request) Successful in 2m41s

Details

CI / Build Plugin Zip (pull_request) Skipped

Details

49c59a950c

Studio admins can now define registration questions that every new student
answers as a required second step during signup, with each student's answers
shown under a "Registration Information" section in the admin.

Extends the existing Registration domain: us_questions gains a scope column
(offering | account) and a nullable offering_id, and account answers reuse
us_question_answers with registration_type = 'account'. Authoring reuses the
Offerings -> Questions page via an "Account signup" scope (studio-admin only).
The registration form becomes two steps (progressive enhancement via
assets/js/register.js; works without JS); required answers are validated before
the account is created and apply to all signup paths (invite, group link,
self-approval). StudentHistory::registrationInfo() powers the admin section.

Bumps the plugin version to 1.1.0 so dbDelta runs the schema migration.

Closes #90

Co-Authored-By: Claude Opus 4.8 <[email protected]>

thatguygriff merged commit 8d6615da67 into main

2026-07-23 13:50:35 +00:00

thatguygriff deleted branch feature/account-registration-questions

2026-07-23 13:50:35 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Unsupervised/unsupervised-scheduler#91