Students can book generic slots for free — booking must require an offering #55

New Issue

2026-07-06T01:08:51Z

thatguygriff commented

2026-07-06 01:08:51 +00:00

Problem

The booking flow never asks the student to choose an offering. The front end (assets/js/booking.js) only reads slot.offering_id, and POST /bookings accepts offering_id defaulting to 0.

For any availability slot created without a tied offering ("Offering: none" in the availability form), this means:

the booking is created with no offering at all
no payment is created and the lesson is confirmed immediately, for free
no intake questions are asked

This contradicts docs/features/lesson-booking.md ("Student picks an offering… and a slot") and docs/features/availability-management.md (slot duration "is matched against the offering a student picks" — never enforced).

Fix

Server (Booking\BookingEndpoint):

Reject bookings with no resolvable offering (400 offering_required).
For student-chosen offerings on generic slots, require an active private_lesson offering owned by the slot's instructor whose duration_minutes matches the slot.
Slot-tied offerings remain authoritative (existing anti-tamper behaviour).

Front end (assets/js/booking.js):

Registration form gets a Lesson type field:
- Slot tied to an offering → shown locked with title/duration/price so the student sees exactly what they are booking.
- Generic slot → required picker of the instructor's active private-lesson offerings that fit the slot length; intake questions load for the selected offering.
Generic slot with no fitting offering → "cannot be booked online" message.

## Problem The booking flow never asks the student to choose an offering. The front end (`assets/js/booking.js`) only reads `slot.offering_id`, and `POST /bookings` accepts `offering_id` defaulting to `0`. For any availability slot created **without** a tied offering ("Offering: none" in the availability form), this means: - the booking is created with **no offering** at all - **no payment** is created and the lesson is **confirmed immediately, for free** - **no intake questions** are asked This contradicts `docs/features/lesson-booking.md` ("Student picks an offering… and a slot") and `docs/features/availability-management.md` (slot duration "is matched against the offering a student picks" — never enforced). ## Fix **Server (`Booking\BookingEndpoint`):** - Reject bookings with no resolvable offering (`400 offering_required`). - For student-chosen offerings on generic slots, require an **active** `private_lesson` offering owned by the slot's instructor whose `duration_minutes` matches the slot. - Slot-tied offerings remain authoritative (existing anti-tamper behaviour). **Front end (`assets/js/booking.js`):** - Registration form gets a **Lesson type** field: - Slot tied to an offering → shown **locked** with title/duration/price so the student sees exactly what they are booking. - Generic slot → **required picker** of the instructor's active private-lesson offerings that fit the slot length; intake questions load for the selected offering. - Generic slot with no fitting offering → "cannot be booked online" message.

thatguygriff referenced this issue from a commit

2026-07-06 01:09:55 +00:00

Require an offering on every lesson booking, with a student-facing picker

thatguygriff referenced a pull request that will close this issue

2026-07-06 01:10:13 +00:00

Require an offering on every lesson booking, with a student-facing picker #56

thatguygriff closed this issue

2026-07-06 01:14:18 +00:00

Sign in to join this conversation.