Fix main: two signup fixtures use a now-rejected password #157

2026-07-30T01:41:13Z

thatguygriff commented

2026-07-30 01:41:13 +00:00

main is currently red — this is the fix. Four tests fail on main right now; they pass again with this.

What happened

My fault, and worth recording because it is the classic version of this mistake.

#154 (required name and birth year) added two guardian-signup tests using 'password123' as their fixture password.
#155 (password validation) added PasswordPolicy, which rejects password123 by name as a well-known leaked password.

Each branch was green. Neither contained the other's change: I cut #155's branch from main before #154 merged, and then rebased #155 onto a main that had moved — but a rebase only replays my commits, it does not re-run the other branch's tests against mine. The two landed in sequence and the combination had never been executed anywhere.

The fix

Both tests now use thistle-marrow-42, the policy-clearing fixture the other fifteen fixtures in the file already use. The deliberate 'password123' in the rejected-passwords data provider stays — that one is the whole point of the test.

Verification

composer test 807 passing (4 failing before), composer lint, composer cs clean.

Worth doing separately

The fixture password is a bare literal repeated ~16 times in RegistrationPageTest. A private const VALID_PASSWORD would say "a password that clears the policy" out loud and give the next policy change one place to break instead of sixteen. I left it out to keep this diff to the two lines that unbreak the build — happy to follow up.

**`main` is currently red — this is the fix.** Four tests fail on `main` right now; they pass again with this. ## What happened My fault, and worth recording because it is the classic version of this mistake. - **#154** (required name and birth year) added two guardian-signup tests using `'password123'` as their fixture password. - **#155** (password validation) added `PasswordPolicy`, which rejects `password123` by name as a well-known leaked password. Each branch was green. Neither contained the other's change: I cut #155's branch from `main` **before** #154 merged, and then rebased #155 onto a `main` that had moved — but a rebase only replays my commits, it does not re-run the other branch's tests against mine. The two landed in sequence and the combination had never been executed anywhere. ## The fix Both tests now use `thistle-marrow-42`, the policy-clearing fixture the other fifteen fixtures in the file already use. The deliberate `'password123'` in the rejected-passwords data provider stays — that one is the whole point of the test. ## Verification `composer test` 807 passing (4 failing before), `composer lint`, `composer cs` clean. ## Worth doing separately The fixture password is a bare literal repeated ~16 times in `RegistrationPageTest`. A `private const VALID_PASSWORD` would say "a password that clears the policy" out loud and give the next policy change one place to break instead of sixteen. I left it out to keep this diff to the two lines that unbreak the build — happy to follow up.

thatguygriff added 1 commit 2026-07-30 01:41:14 +00:00

Fix main: two signup fixtures use a now-rejected password

CI / Tests (PHP 8.2) (pull_request) Successful in 52s

Details

CI / No Debug Code (pull_request) Successful in 2s

Details

CI / PHPStan (pull_request) Successful in 2m46s

Details

CI / Tests (PHP 8.1) (pull_request) Successful in 54s

Details

CI / Coding Standards (pull_request) Successful in 3m6s

Details

CI / Tests (PHP 8.3) (pull_request) Successful in 2m49s

Details

CI / Build Plugin Zip (pull_request) Skipped

Details

04cba9702c

#154 and #155 each passed on their own branch and broke on landing
together. #154 added two guardian-signup tests using 'password123' as
their fixture; #155 then added PasswordPolicy, which rejects exactly
that. Neither branch ever saw the other's change, because #155 was cut
from main before #154 merged.

Both tests now use the same policy-clearing fixture as the rest of the
file. The deliberate 'password123' in the rejected-passwords provider
stays — that one is the point.

Co-Authored-By: Claude Opus 5 <[email protected]>

thatguygriff merged commit 7875cb1bf7 into main

2026-07-30 01:41:29 +00:00

thatguygriff deleted branch fix/green-main

2026-07-30 01:41:29 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Unsupervised/unsupervised-scheduler#157