Unsupervised/unsupervised-scheduler
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix all PHPCS coding standards violations
All checks were successful
CI / Coding Standards (push) Successful in 44s
Details
CI / PHPStan (push) Successful in 49s
Details
CI / Tests (PHP 8.1) (push) Successful in 54s
Details
CI / Tests (PHP 8.2) (push) Successful in 51s
Details
CI / Tests (PHP 8.3) (push) Successful in 39s
Details
CI / No Debug Code (push) Successful in 3s
Details

Browse Source 
- Add phpcs.xml.dist: excludes PSR-4 file naming, camelCase naming,
  short array syntax, and redundant per-method/property docblocks
- Fix wp_unslash() on all $_POST reads (LoginPage, AvailabilityController)
- Add phpcs:ignore for password field (must not be sanitized)
- Fix Yoda conditions throughout (AvailabilityRepository, AvailabilityEndpoint,
  BookingEndpoint, AvailabilityController)
- Fix inline comments to end with full stops (AdminMenu)
- Replace short ternary ?: with explicit full ternary (BookingEndpoint)
- Rename $namespace param to $route_namespace (reserved keyword warning)
- Add short descriptions to doc blocks that had tag-only blocks
- Add nonce suppression comment in handleFormAction (nonce verified by caller)
- Update composer.json and CI to use phpcs.xml.dist

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
James Griffin-Allwood
2026-03-30 16:20:49 -03:00
parent e24c3ce850
commit ed49924f95
24 changed files with 857 additions and 715 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
src/Roles/RoleManager.php
View File

@@ -3,44 +3,42 @@ declare(strict_types=1);
namespace Unsupervised\Schedular\Roles;
class RoleManager
{
public const INSTRUCTOR = 'us_instructor';
public const STUDENT = 'us_student';
class RoleManager {
public const CAP_MANAGE_AVAILABILITY = 'manage_availability';
public const CAP_VIEW_LESSONS = 'view_own_lessons';
public const CAP_BOOK_LESSON = 'book_lesson';
public const INSTRUCTOR = 'us_instructor';
public const STUDENT = 'us_student';
public function register(): void
{
add_action('init', [$this, 'createRoles']);
}
public const CAP_MANAGE_AVAILABILITY = 'manage_availability';
public const CAP_VIEW_LESSONS = 'view_own_lessons';
public const CAP_BOOK_LESSON = 'book_lesson';
public function createRoles(): void
{
if (get_role(self::INSTRUCTOR) === null) {
add_role(
self::INSTRUCTOR,
__('Instructor', 'unsupervised-schedular'),
[
'read' => true,
self::CAP_MANAGE_AVAILABILITY => true,
self::CAP_VIEW_LESSONS => true,
]
);
}
public function register(): void {
add_action( 'init', [ $this, 'createRoles' ] );
}
if (get_role(self::STUDENT) === null) {
add_role(
self::STUDENT,
__('Student', 'unsupervised-schedular'),
[
'read' => true,
self::CAP_BOOK_LESSON => true,
self::CAP_VIEW_LESSONS => true,
]
);
}
}
public function createRoles(): void {
if ( get_role( self::INSTRUCTOR ) === null ) {
add_role(
self::INSTRUCTOR,
__( 'Instructor', 'unsupervised-schedular' ),
[
'read' => true,
self::CAP_MANAGE_AVAILABILITY => true,
self::CAP_VIEW_LESSONS => true,
]
);
}
if ( get_role( self::STUDENT ) === null ) {
add_role(
self::STUDENT,
__( 'Student', 'unsupervised-schedular' ),
[
'read' => true,
self::CAP_BOOK_LESSON => true,
self::CAP_VIEW_LESSONS => true,
]
);
}
}
}