Unsupervised/unsupervised-scheduler
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix all PHPCS coding standards violations
All checks were successful
CI / Coding Standards (push) Successful in 44s
Details
CI / PHPStan (push) Successful in 49s
Details
CI / Tests (PHP 8.1) (push) Successful in 54s
Details
CI / Tests (PHP 8.2) (push) Successful in 51s
Details
CI / Tests (PHP 8.3) (push) Successful in 39s
Details
CI / No Debug Code (push) Successful in 3s
Details

Browse Source 
- Add phpcs.xml.dist: excludes PSR-4 file naming, camelCase naming,
  short array syntax, and redundant per-method/property docblocks
- Fix wp_unslash() on all $_POST reads (LoginPage, AvailabilityController)
- Add phpcs:ignore for password field (must not be sanitized)
- Fix Yoda conditions throughout (AvailabilityRepository, AvailabilityEndpoint,
  BookingEndpoint, AvailabilityController)
- Fix inline comments to end with full stops (AdminMenu)
- Replace short ternary ?: with explicit full ternary (BookingEndpoint)
- Rename $namespace param to $route_namespace (reserved keyword warning)
- Add short descriptions to doc blocks that had tag-only blocks
- Add nonce suppression comment in handleFormAction (nonce verified by caller)
- Update composer.json and CI to use phpcs.xml.dist

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
James Griffin-Allwood
2026-03-30 16:20:49 -03:00
parent e24c3ce850
commit ed49924f95
24 changed files with 857 additions and 715 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/Api/RestRegistrar.php
View File

@@ -6,27 +6,24 @@ namespace Unsupervised\Schedular\Api;
use Unsupervised\Schedular\Data\AvailabilityRepository;
use Unsupervised\Schedular\Data\BookingRepository;
class RestRegistrar
{
public const NAMESPACE = 'us-scheduler/v1';
class RestRegistrar {
private AvailabilityEndpoint $availabilityEndpoint;
private BookingEndpoint $bookingEndpoint;
public const NAMESPACE = 'us-scheduler/v1';
public function __construct(AvailabilityRepository $availability, BookingRepository $bookings)
{
$this->availabilityEndpoint = new AvailabilityEndpoint($availability);
$this->bookingEndpoint = new BookingEndpoint($availability, $bookings);
}
private AvailabilityEndpoint $availabilityEndpoint;
private BookingEndpoint $bookingEndpoint;
public function register(): void
{
add_action('rest_api_init', [$this, 'registerRoutes']);
}
public function __construct( AvailabilityRepository $availability, BookingRepository $bookings ) {
$this->availabilityEndpoint = new AvailabilityEndpoint( $availability );
$this->bookingEndpoint = new BookingEndpoint( $availability, $bookings );
}
public function registerRoutes(): void
{
$this->availabilityEndpoint->registerRoutes(self::NAMESPACE);
$this->bookingEndpoint->registerRoutes(self::NAMESPACE);
}
public function register(): void {
add_action( 'rest_api_init', [ $this, 'registerRoutes' ] );
}
public function registerRoutes(): void {
$this->availabilityEndpoint->registerRoutes( self::NAMESPACE );
$this->bookingEndpoint->registerRoutes( self::NAMESPACE );
}
}