Bulk delete availability slots from the admin list view

The list view of Current Slots gets a checkbox per unbooked slot, a select-all header checkbox, and a Delete selected button submitting a new bulk_delete form action. Each id is ownership-checked through the same path as single delete; the repository's is_booked guard refuses booked slots as a second layer. Row checkboxes attach to the bulk form via the HTML form attribute because the table already contains the per-row delete forms and forms cannot nest. Closes #57 Co-Authored-By: Claude Fable 5 <[email protected]>
2026-07-05 22:25:35 -03:00
parent aaa24e524f
commit c743ed5459
4 changed files with 175 additions and 6 deletions
@@ -0,0 +1,125 @@
+<?php
+declare(strict_types=1);
+
+namespace Unsupervised\Schedular\Tests\Unit\Availability;
+
+use Brain\Monkey\Functions;
+use Mockery;
+use Unsupervised\Schedular\Availability\AvailabilityController;
+use Unsupervised\Schedular\Availability\AvailabilityRepository;
+use Unsupervised\Schedular\Availability\AvailabilitySlot;
+use Unsupervised\Schedular\Offering\OfferingRepository;
+use Unsupervised\Schedular\Tests\Unit\TestCase;
+
+class AvailabilityControllerTest extends TestCase
+{
+    private AvailabilityRepository&Mockery\MockInterface $repository;
+    private OfferingRepository&Mockery\MockInterface $offerings;
+    private AvailabilityController $controller;
+
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        $this->repository = Mockery::mock(AvailabilityRepository::class);
+        $this->offerings  = Mockery::mock(OfferingRepository::class);
+        $this->controller = new AvailabilityController($this->repository, $this->offerings);
+
+        $_POST = [];
+        $_GET  = [];
+
+        Functions\when('current_user_can')->justReturn(true);
+        Functions\when('get_current_user_id')->justReturn(3);
+        Functions\when('check_admin_referer')->justReturn(true);
+        Functions\when('wp_unslash')->returnArg();
+        Functions\when('sanitize_text_field')->returnArg();
+        Functions\when('sanitize_key')->alias(
+            static fn ($key) => strtolower((string) preg_replace('/[^a-zA-Z0-9_\-]/', '', (string) $key))
+        );
+        Functions\when('absint')->alias(static fn ($value) => abs((int) $value));
+        Functions\when('get_option')->justReturn(1);
+        Functions\when('current_time')->justReturn('2026-07-06');
+        Functions\when('admin_url')->justReturn('admin.php?page=us-availability');
+        Functions\when('add_query_arg')->justReturn('admin.php?page=us-availability&usc_view=week');
+        Functions\when('wp_nonce_field')->justReturn('');
+        Functions\when('submit_button')->justReturn('');
+        Functions\when('mysql2date')->alias(
+            static fn (string $format, string $date) => date($format, (int) strtotime($date))
+        );
+
+        $this->offerings->shouldReceive('findAll')->andReturn([]);
+    }
+
+    public function testBulkDeleteRemovesOnlyOwnedExistingSlots(): void
+    {
+        $_POST = [
+            'usc_action' => 'bulk_delete',
+            'slot_ids'   => ['5', 'junk', '7', '9'],
+        ];
+
+        $owned = new AvailabilitySlot(instructorId: 3, startDt: '2026-07-08 09:00:00', endDt: '2026-07-08 10:00:00', id: 5);
+        $other = new AvailabilitySlot(instructorId: 4, startDt: '2026-07-08 09:00:00', endDt: '2026-07-08 10:00:00', id: 7);
+
+        $this->repository->shouldReceive('findById')->once()->with(5)->andReturn($owned);
+        $this->repository->shouldReceive('findById')->once()->with(7)->andReturn($other);
+        $this->repository->shouldReceive('findById')->once()->with(9)->andReturn(null);
+        $this->repository->shouldReceive('delete')->once()->with(5)->andReturn(true);
+        $this->repository->shouldReceive('findByInstructor')->once()->with(3)->andReturn([]);
+
+        $this->render();
+    }
+
+    public function testBulkDeleteIgnoresNonArrayInput(): void
+    {
+        $_POST = [
+            'usc_action' => 'bulk_delete',
+            'slot_ids'   => '5',
+        ];
+
+        $this->repository->shouldNotReceive('findById');
+        $this->repository->shouldNotReceive('delete');
+        $this->repository->shouldReceive('findByInstructor')->once()->with(3)->andReturn([]);
+
+        $this->render();
+    }
+
+    public function testSingleDeleteChecksOwnership(): void
+    {
+        $_POST = [
+            'usc_action' => 'delete',
+            'slot_id'    => '7',
+        ];
+
+        $other = new AvailabilitySlot(instructorId: 4, startDt: '2026-07-08 09:00:00', endDt: '2026-07-08 10:00:00', id: 7);
+
+        $this->repository->shouldReceive('findById')->once()->with(7)->andReturn($other);
+        $this->repository->shouldNotReceive('delete');
+        $this->repository->shouldReceive('findByInstructor')->once()->with(3)->andReturn([]);
+
+        $this->render();
+    }
+
+    public function testListViewRendersBulkCheckboxesOnlyForUnbookedSlots(): void
+    {
+        $unbooked = new AvailabilitySlot(instructorId: 3, startDt: '2026-07-08 09:00:00', endDt: '2026-07-08 10:00:00', id: 5);
+        $booked   = new AvailabilitySlot(instructorId: 3, startDt: '2026-07-08 10:00:00', endDt: '2026-07-08 11:00:00', isBooked: true, id: 6);
+
+        $this->repository->shouldReceive('findByInstructor')->once()->with(3)->andReturn([$unbooked, $booked]);
+
+        $html = $this->render();
+
+        self::assertStringContainsString('id="usc-bulk-delete-form"', $html);
+        self::assertStringContainsString('value="bulk_delete"', $html);
+        self::assertStringContainsString('Delete selected', $html);
+        self::assertStringContainsString('name="slot_ids[]" form="usc-bulk-delete-form" value="5"', $html);
+        self::assertStringNotContainsString('name="slot_ids[]" form="usc-bulk-delete-form" value="6"', $html);
+    }
+
+    private function render(): string
+    {
+        ob_start();
+        $this->controller->renderPage();
+
+        return (string) ob_get_clean();
+    }
+}