Add link-target and auto-redirect options to booking/login blocks

The booking block gains a loginPageId attribute choosing which page its logged-out "log in to book a lesson" link points to (default remains the WordPress login screen), and the student-login block gains a bookingPageId attribute controlling the logged-in "View available lessons" link and the post-login redirect target (default remains the current page). Both blocks also gain an autoRedirect toggle, off by default, that sends the visitor straight to the target page; block rendering starts after output, so the redirect runs on template_redirect by parsing the queried page's content for the block, with a self-target guard against redirect loops. The link targets are also available to the shortcodes as login_page_id/booking_page_id. Also fixes a pre-existing fatal: WordPress passes an empty string (not an array) to shortcode callbacks when a shortcode is used without attributes, so bare [us_booking] etc. threw a TypeError against the strictly-typed render(array $atts) methods. ShortcodeRegistrar now wraps each callback to normalize non-array attribute values. Closes #51 Co-Authored-By: Claude Fable 5 <[email protected]>
2026-07-05 16:16:52 -03:00
parent 43497503b9
commit 9d89bc6d0e
13 changed files with 848 additions and 53 deletions
@@ -19,6 +19,30 @@ output is identical either way. Pasting a shortcode into the block editor
 auto-converts it to the matching block via a `transforms.from` shortcode
 transform.

+## Block options
+
+Two blocks have sidebar (inspector) options controlling where their
+logged-in/logged-out link sends the visitor:
+
+| Block | Attribute | Default | Effect |
+|---|---|---|---|
+| `us-scheduler/booking` | `loginPageId` (number) | `0` | Page the "log in to book a lesson" link points to for logged-out visitors. `0` = the WordPress login screen (with a redirect back to the current page). |
+| `us-scheduler/booking` | `autoRedirect` (boolean) | `false` | Send logged-out visitors straight to the login page instead of showing the link. |
+| `us-scheduler/student-login` | `bookingPageId` (number) | `0` | Page the "View available lessons" link points to for logged-in visitors, and the post-login redirect target. `0` = the current page. |
+| `us-scheduler/student-login` | `autoRedirect` (boolean) | `false` | Send logged-in visitors straight to the booking page instead of showing the link. Does nothing until a booking page is chosen. |
+
+The page selects list all published pages; if a chosen page is later deleted,
+the blocks fall back to their defaults. The link targets are also available
+to the shortcodes as `[us_booking login_page_id="…"]` and
+`[us_student_login booking_page_id="…"]`; auto-redirect is block-only.
+
+Auto-redirect cannot happen during block rendering (output has already
+started, so a `Location` header cannot be sent). Instead
+`BlockRegistrar::maybeAutoRedirect()` runs on `template_redirect`, parses the
+queried singular post's content for the block (including inside nested
+blocks), and redirects when the block opts in. A block whose target is its
+own page is ignored to avoid a redirect loop.
+
 ## How it works

 - **`BlockRegistrar`** (`src/BlockRegistrar.php`) hooks `init` and registers
@@ -60,7 +84,11 @@ published page shows instead. The note class only appears in editor previews.
 ## Tests

 - `tests/Unit/BlockRegistrarTest.php` — hook registration, block/asset
-  registration, front-end delegation to the page objects, preview-mode
-  routing.
+  registration, attribute schemas, front-end delegation to the page objects,
+  preview-mode routing, auto-redirect behaviour.
+- `tests/Unit/Booking/BookingPageTest.php` — logged-out login-link targets
+  and fallbacks.
+- `tests/Unit/Auth/LoginPageTest.php` — logged-in booking-link targets and
+  fallbacks.
 - `tests/Unit/BlockPreviewTest.php` — preview markup mirrors the live CSS
  classes/ids and includes the editor note.