Show instructor real name or nickname in group-class views, not the login

Add Auth\UserName::format(), which prefers a user's first + last name, then their nickname, avoiding display_name (which can be the login/username). Route the instructor name through it in both the front-end offerings response (instructor_name) and the back-end group-class summary and details views. Tests: composer test (513), composer lint, composer cs all pass. Co-Authored-By: Claude Opus 4.8 <[email protected]>
2026-07-23 17:50:34 -03:00
parent b066bef353
commit 87cfe921a9
8 changed files with 136 additions and 20 deletions
@@ -4,6 +4,7 @@ declare(strict_types=1);
 namespace Unsupervised\Schedular\Offering;

 use Unsupervised\Schedular\Auth\RoleManager;
+use Unsupervised\Schedular\Auth\UserName;
 use Unsupervised\Schedular\GroupClass\GroupAccessRepository;
 use Unsupervised\Schedular\Val;

@@ -84,8 +85,9 @@ class OfferingEndpoint {
 	}

 	/**
-	 * A public-facing offering array with the assigned instructor's display name
-	 * added (empty when the instructor account no longer exists).
+	 * A public-facing offering array with the assigned instructor's name added —
+	 * their real name or nickname, never the login (empty when the instructor
+	 * account no longer exists). See {@see UserName::format()}.
 	 *
 	 * @return array<string, mixed>
 	 */
@@ -93,7 +95,7 @@ class OfferingEndpoint {
 		$out  = $offering->toArray( includeEtransferEmail: false );
 		$user = get_userdata( $offering->instructorId );

-		$out['instructor_name'] = $user instanceof \WP_User ? $user->display_name : '';
+		$out['instructor_name'] = UserName::format( $user instanceof \WP_User ? $user : null );

 		return $out;
 	}