Unsupervised/unsupervised-scheduler
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 12 Wiki Activity

Show instructor real name or nickname in group-class views, not the login
CI / Tests (PHP 8.2) (pull_request) Successful in 46s
Details
CI / Tests (PHP 8.1) (pull_request) Successful in 46s
Details
CI / No Debug Code (pull_request) Successful in 2s
Details
CI / PHPStan (pull_request) Successful in 2m47s
Details
CI / Coding Standards (pull_request) Successful in 2m51s
Details
CI / Tests (PHP 8.3) (pull_request) Successful in 2m41s
Details
CI / Build Plugin Zip (pull_request) Skipped
Details

Browse Source 
Add Auth\UserName::format(), which prefers a user's first + last name, then
their nickname, avoiding display_name (which can be the login/username).
Route the instructor name through it in both the front-end offerings response
(instructor_name) and the back-end group-class summary and details views.

Tests: composer test (513), composer lint, composer cs all pass.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
This commit is contained in:
thatguygriff
2026-07-23 17:50:34 -03:00
co-authored by Claude Opus 4.8
parent b066bef353
commit 87cfe921a9
8 changed files with 136 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/GroupClass/GroupClassController.php
+14 -6
View File
@@ -8,6 +8,7 @@ use Unsupervised\Schedular\Auth\InviteRepository;
use Unsupervised\Schedular\Auth\RegistrationController;
use Unsupervised\Schedular\Auth\RegistrationMailer;
use Unsupervised\Schedular\Auth\RoleManager;
use Unsupervised\Schedular\Auth\UserName;
use Unsupervised\Schedular\Offering\Offering;
use Unsupervised\Schedular\Offering\OfferingRepository;
use Unsupervised\Schedular\Payment\Payment;
@@ -73,12 +74,10 @@ class GroupClassController {
$rows = array_map(
function ( Offering $offering ): array {
$instructor = get_userdata( $offering->instructorId );
return [
'id' => $offering->id,
'title' => $offering->title,
'instructor' => $instructor ? $instructor->display_name : (string) $offering->instructorId,
'instructor' => $this->instructorName( $offering ),
'when' => $this->whenLabel( $offering ),
'capacity' => $offering->capacity,
'enrolled' => $this->enrollments->countActiveForOffering( (int) $offering->id ),
@@ -196,10 +195,8 @@ class GroupClassController {
];
}
$instructor = get_userdata( $offering->instructorId );
return $this->classSummary( $offering, $enrollments ) + [
'instructor' => $instructor ? $instructor->display_name : (string) $offering->instructorId,
'instructor' => $this->instructorName( $offering ),
'price' => $offering->price,
'currency' => $offering->currency,
'duration' => $offering->durationMinutes,
@@ -211,6 +208,17 @@ class GroupClassController {
];
}
/**
* The teaching instructor's display name — their real name or nickname, never
* the login. Falls back to the numeric id when the account is gone. See
* {@see UserName::format()}.
*/
private function instructorName( Offering $offering ): string {
$user = get_userdata( $offering->instructorId );
return UserName::format( $user instanceof \WP_User ? $user : null, $offering->instructorId );
}
/**
* Human-readable "when" label for a class: the class date (or weekly date
* range) and, when set, the start time. Empty when the class has no date.