Show instructor real name or nickname in group-class views, not the login

Add Auth\UserName::format(), which prefers a user's first + last name, then their nickname, avoiding display_name (which can be the login/username). Route the instructor name through it in both the front-end offerings response (instructor_name) and the back-end group-class summary and details views. Tests: composer test (513), composer lint, composer cs all pass. Co-Authored-By: Claude Opus 4.8 <[email protected]>
2026-07-23 17:50:34 -03:00
parent b066bef353
commit 87cfe921a9
8 changed files with 136 additions and 20 deletions
@@ -22,8 +22,10 @@ A group class offering carries `term_start`/`term_end` plus a `class_time` and a
 owning `instructor_id` (see `offerings.md`): one-off classes end the day they
 start; weekly classes run a set number of sessions, all at `class_time`. The class
 card on the enrolment page shows **when** the class meets (the date or date range
-plus the start time) and **who** teaches it (the assigned instructor's display
-name, surfaced as `instructor_name` on the `GET /offerings` response).
+plus the start time) and **who** teaches it (the assigned instructor's name,
+surfaced as `instructor_name` on the `GET /offerings` response). Instructor names
+in the group-class views (front and back end) use the instructor's real name
+(first + last) or nickname, never their login — see `Auth\UserName::format()`.

 Assigning an instructor to a scheduled class removes that instructor's open
 booking slots at the class time and flags any already-booked lesson that clashes;