Lock the registration email to the invite only when the invite is redeemable

The register form keyed the read-only, prefilled email off any invite row matching the token. A stale token (expired / accepted / revoked) with open registration on therefore showed the stale invite's address read-only while the submit handler took the open branch and required a posted email the locked field never submits, dead-ending the form. The lock now applies exactly when the invite is acceptable; otherwise the editable field renders. Closes #78 Co-Authored-By: Claude Fable 5 <[email protected]>
2026-07-22 10:24:44 -03:00
parent 05d1728248
commit 681fc5ae07
4 changed files with 54 additions and 5 deletions
@@ -45,6 +45,12 @@ class RegistrationPage {
 		$invite = '' !== $token ? $this->invites->findByToken( Invite::hashToken( $token ) ) : null;
 		$open   = $this->settings->openRegistrationEnabled();

+		// Only a redeemable invite fixes the form's email to the invited address.
+		// A stale token (expired / accepted / revoked) with open registration on
+		// must fall back to the normal editable email field, not show — and then
+		// fail to submit — the stale invite's address.
+		$inviteValid = null !== $invite && $invite->isAcceptable( current_time( 'mysql' ) );
+
 		$error       = '';
 		$successType = '';

@@ -65,7 +71,7 @@ class RegistrationPage {
 		$loginUrl = $this->loginUrl( Val::int( $atts['loginPageId'] ?? $atts['login_page_id'] ?? 0 ) );

 		$policyForms = $this->signupPolicies();
-		$canRegister = $open || ( null !== $invite && $invite->isAcceptable( current_time( 'mysql' ) ) );
+		$canRegister = $open || $inviteValid;

 		ob_start();
 		include USC_PLUGIN_DIR . 'templates/frontend/register-page.php';