Skip payment step for unpriced bookings, confirm them immediately, show students their lessons

Booking a slot with no priced offering created the lesson but no payment, yet the front end still called POST /payments/intent, which 400ed with "Could not start payment for this registration" — the student saw an error while the backend held a claimed slot and a lesson stuck at pending. - POST /bookings and POST /enrollments now return a `payment` summary ({id, method, status}) or null when nothing is owed; the JS only runs the payment step when a payment exists. - Bookings with nothing owed are confirmed at creation — there is no payment step that would ever confirm them later. - The booking page now shows the student's upcoming lessons (GET /bookings, now scoped to upcoming non-cancelled lessons with slot start/end times) with a pending-payment/confirmed status badge. Fixes #53 Co-Authored-By: Claude Fable 5 <[email protected]>
2026-07-05 17:02:38 -03:00
parent 93dccd6352
commit 5888032ed7
15 changed files with 433 additions and 25 deletions
@@ -110,14 +110,17 @@ class EnrollmentEndpoint {

 		$this->gate->record( PolicyAcceptance::REG_ENROLLMENT, $id, $studentId, $offeringId, $answers, $acceptedVersionIds, $this->clientIp() );

+		$payment = null;
 		if ( $offering->price > 0.0 ) {
-			$this->payments->createForRegistration( Payment::REG_ENROLLMENT, $id, $studentId, $offering->instructorId, $offering->price, $offering->currency, $offering->etransferEmail );
+			$payment = $this->payments->createForRegistration( Payment::REG_ENROLLMENT, $id, $studentId, $offering->instructorId, $offering->price, $offering->currency, $offering->etransferEmail );
 		}

+		// `payment: null` tells the front end to skip the payment step entirely.
 		return new \WP_REST_Response(
 			[
-				'id'     => $id,
-				'status' => Enrollment::STATUS_ACTIVE,
+				'id'      => $id,
+				'status'  => Enrollment::STATUS_ACTIVE,
+				'payment' => $payment?->toSummaryArray(),
 			],
 			201
 		);