Upgrade PHPStan to 2.x and raise analysis level from 6 to 10

- Bump phpstan/phpstan ^2.0 and szepeviktor/phpstan-wordpress ^2.0
- Move the analysis level into phpstan.neon (single source) and raise it to 10
- Add Val, a runtime coercion helper that narrows untyped WordPress boundary
  values (wpdb rows, REST params, superglobals, options) with explicit checks
  instead of blind casts, plus unit tests
- Type value-object fromRow() params as stdClass (what wpdb returns) and map
  columns through Val so unexpected shapes degrade safely
- Use %i identifier placeholders for table names in all wpdb::prepare() calls
  so every query string is a literal and identifiers are escaped by WordPress;
  raises the minimum WordPress version to 6.2 where %i was introduced
- Guard wpdb::prepare() null result before wpdb::query() in updateTax()
- Fix nullable get_permalink()/strtotime() handling, list types at REST and
  capability call sites, dead null-coalescing on checked superglobals, and
  narrow get_users() results before mapping
- Register Val method names with the ValidatedSanitizedInput sniff so it
  validates the real sanitizer around each superglobal read
- Update repository unit tests for the %i placeholder arguments

Co-Authored-By: Claude Fable 5 <[email protected]>

src/Registration/Answer.php

@@ -3,6 +3,8 @@ declare(strict_types=1);
 
 namespace Unsupervised\Schedular\Registration;
 
+use Unsupervised\Schedular\Val;
+
 class Answer {
 
 	public const REG_LESSON     = 'lesson';
@@ -24,14 +26,14 @@ class Answer {
 		public readonly ?int $id = null,
 	) {}
 
-	public static function fromRow( object $row ): self {
+	public static function fromRow( \stdClass $row ): self {
 		return new self(
-			questionId:       (int) $row->question_id,
-			registrationType: $row->registration_type,
-			registrationId:   (int) $row->registration_id,
-			studentId:        (int) $row->student_id,
-			answerValue:      $row->answer_value,
-			id:               (int) $row->id,
+			questionId:       Val::int( $row->question_id ),
+			registrationType: Val::string( $row->registration_type ),
+			registrationId:   Val::int( $row->registration_id ),
+			studentId:        Val::int( $row->student_id ),
+			answerValue:      Val::stringOrNull( $row->answer_value ),
+			id:               Val::int( $row->id ),
 		);
 	}
 

src/Registration/AnswerRepository.php

@@ -46,7 +46,8 @@ class AnswerRepository {
 	public function findByRegistration( string $registrationType, int $registrationId ): array {
 		$rows = $this->db->get_results(
 			$this->db->prepare(
-				"SELECT * FROM {$this->table} WHERE registration_type = %s AND registration_id = %d ORDER BY id ASC",
+				'SELECT * FROM %i WHERE registration_type = %s AND registration_id = %d ORDER BY id ASC',
+				$this->table,
 				$registrationType,
 				$registrationId
 			)

src/Registration/Question.php

@@ -3,6 +3,8 @@ declare(strict_types=1);
 
 namespace Unsupervised\Schedular\Registration;
 
+use Unsupervised\Schedular\Val;
+
 class Question {
 
 	public const FIELD_TEXT     = 'text';
@@ -38,22 +40,24 @@ class Question {
 		public readonly ?int $id = null,
 	) {}
 
-	public static function fromRow( object $row ): self {
+	public static function fromRow( \stdClass $row ): self {
 		$options = null;
 		if ( null !== $row->options && '' !== $row->options ) {
-			$decoded = json_decode( (string) $row->options, true );
-			$options = is_array( $decoded ) ? array_values( array_map( 'strval', $decoded ) ) : null;
+			$decoded = json_decode( Val::string( $row->options ), true );
+			$options = is_array( $decoded )
+				? array_values( array_map( static fn( mixed $v ): string => Val::string( $v ), $decoded ) )
+				: null;
 		}
 
 		return new self(
-			offeringId: (int) $row->offering_id,
-			label:      $row->label,
-			fieldType:  $row->field_type,
+			offeringId: Val::int( $row->offering_id ),
+			label:      Val::string( $row->label ),
+			fieldType:  Val::string( $row->field_type ),
 			options:    $options,
-			isRequired: (bool) $row->is_required,
-			sortOrder:  (int) $row->sort_order,
-			isActive:   (bool) $row->is_active,
-			id:         (int) $row->id,
+			isRequired: Val::bool( $row->is_required ),
+			sortOrder:  Val::int( $row->sort_order ),
+			isActive:   Val::bool( $row->is_active ),
+			id:         Val::int( $row->id ),
 		);
 	}
 

src/Registration/QuestionController.php

@@ -6,6 +6,7 @@ namespace Unsupervised\Schedular\Registration;
 use Unsupervised\Schedular\Auth\RoleManager;
 use Unsupervised\Schedular\Offering\Offering;
 use Unsupervised\Schedular\Offering\OfferingRepository;
+use Unsupervised\Schedular\Val;
 
 class QuestionController {
 
@@ -23,7 +24,7 @@ class QuestionController {
 		$manageAll = current_user_can( RoleManager::CAP_MANAGE_INSTRUCTORS );
 
 		// phpcs:ignore WordPress.Security.NonceVerification.Recommended -- read-only offering selector.
-		$offeringId       = absint( $_GET['offering_id'] ?? 0 );
+		$offeringId       = absint( Val::int( $_GET['offering_id'] ?? 0 ) );
 		$offeringList     = $manageAll ? $this->offerings->findAll() : $this->offerings->findAll( $userId );
 		$selectedOffering = $offeringId > 0 ? $this->offerings->findById( $offeringId ) : null;
 
@@ -46,14 +47,14 @@ class QuestionController {
 	private function handleFormAction( Offering $offering ): void {
 		// Nonce is verified by the caller (renderPage) before this method runs.
 		// phpcs:disable WordPress.Security.NonceVerification.Missing
-		$action = sanitize_key( wp_unslash( $_POST['usc_action'] ?? '' ) );
+		$action = sanitize_key( Val::string( wp_unslash( $_POST['usc_action'] ?? '' ) ) );
 
 		if ( 'add' === $action ) {
 			$this->addQuestion( (int) $offering->id );
 		}
 
 		if ( 'delete' === $action ) {
-			$questionId = absint( $_POST['question_id'] ?? 0 );
+			$questionId = absint( Val::int( $_POST['question_id'] ?? 0 ) );
 			if ( $questionId > 0 ) {
 				$question = $this->questions->findById( $questionId );
 				if ( $question && $question->offeringId === (int) $offering->id ) {
@@ -66,8 +67,8 @@ class QuestionController {
 
 	private function addQuestion( int $offeringId ): void {
 		// phpcs:disable WordPress.Security.NonceVerification.Missing
-		$label     = sanitize_text_field( wp_unslash( $_POST['label'] ?? '' ) );
-		$fieldType = sanitize_key( wp_unslash( $_POST['field_type'] ?? Question::FIELD_TEXT ) );
+		$label     = sanitize_text_field( Val::string( wp_unslash( $_POST['label'] ?? '' ) ) );
+		$fieldType = sanitize_key( Val::string( wp_unslash( $_POST['field_type'] ?? Question::FIELD_TEXT ) ) );
 
 		if ( '' === $label || ! in_array( $fieldType, Question::VALID_FIELD_TYPES, true ) ) {
 			return;
@@ -78,9 +79,9 @@ class QuestionController {
 				offeringId: $offeringId,
 				label:      $label,
 				fieldType:  $fieldType,
-				options:    $this->parseOptions( sanitize_textarea_field( wp_unslash( $_POST['options'] ?? '' ) ) ),
+				options:    $this->parseOptions( sanitize_textarea_field( Val::string( wp_unslash( $_POST['options'] ?? '' ) ) ) ),
 				isRequired: isset( $_POST['is_required'] ),
-				sortOrder:  absint( $_POST['sort_order'] ?? 0 ),
+				sortOrder:  absint( Val::int( $_POST['sort_order'] ?? 0 ) ),
 			)
 		);
 		// phpcs:enable WordPress.Security.NonceVerification.Missing

src/Registration/QuestionEndpoint.php

@@ -5,6 +5,7 @@ namespace Unsupervised\Schedular\Registration;
 
 use Unsupervised\Schedular\Auth\RoleManager;
 use Unsupervised\Schedular\Offering\OfferingRepository;
+use Unsupervised\Schedular\Val;
 
 class QuestionEndpoint {
 
@@ -13,6 +14,11 @@ class QuestionEndpoint {
 		private OfferingRepository $offerings,
 	) {}
 
+	/**
+	 * Registers this endpoint's REST routes.
+	 *
+	 * @param non-falsy-string $route_namespace REST namespace the routes are registered under (e.g. `us-scheduler/v1`).
+	 */
 	public function registerRoutes( string $route_namespace ): void {
 		register_rest_route(
 			$route_namespace,
@@ -57,24 +63,24 @@ class QuestionEndpoint {
 	}
 
 	public function index( \WP_REST_Request $request ): \WP_REST_Response {
-		$questions = $this->questions->findByOffering( absint( $request->get_param( 'id' ) ), activeOnly: true );
+		$questions = $this->questions->findByOffering( absint( Val::int( $request->get_param( 'id' ) ) ), activeOnly: true );
 
 		return new \WP_REST_Response( array_map( fn( Question $q ) => $q->toArray(), $questions ), 200 );
 	}
 
 	public function create( \WP_REST_Request $request ): \WP_REST_Response|\WP_Error {
-		$offeringId = absint( $request->get_param( 'offering_id' ) );
+		$offeringId = absint( Val::int( $request->get_param( 'offering_id' ) ) );
 		$ownerCheck = $this->requireOfferingOwner( $offeringId );
 		if ( $ownerCheck instanceof \WP_Error ) {
 			return $ownerCheck;
 		}
 
-		$label = sanitize_text_field( (string) $request->get_param( 'label' ) );
+		$label = sanitize_text_field( Val::string( $request->get_param( 'label' ) ) );
 		if ( '' === $label ) {
 			return $this->invalid( __( 'A question label is required.', 'unsupervised-schedular' ) );
 		}
 
-		$fieldType = (string) ( $request->get_param( 'field_type' ) ?? Question::FIELD_TEXT );
+		$fieldType = Val::string( $request->get_param( 'field_type' ) ?? Question::FIELD_TEXT );
 		if ( ! in_array( $fieldType, Question::VALID_FIELD_TYPES, true ) ) {
 			return $this->invalid( __( 'Invalid field type.', 'unsupervised-schedular' ) );
 		}
@@ -85,7 +91,7 @@ class QuestionEndpoint {
 			fieldType:  $fieldType,
 			options:    $this->sanitizeOptions( $request->get_param( 'options' ) ),
 			isRequired: (bool) $request->get_param( 'is_required' ),
-			sortOrder:  (int) $request->get_param( 'sort_order' ),
+			sortOrder:  Val::int( $request->get_param( 'sort_order' ) ),
 			isActive:   null === $request->get_param( 'is_active' ) ? true : (bool) $request->get_param( 'is_active' ),
 		);
 
@@ -95,7 +101,7 @@ class QuestionEndpoint {
 	}
 
 	public function update( \WP_REST_Request $request ): \WP_REST_Response|\WP_Error {
-		$id       = absint( $request->get_param( 'id' ) );
+		$id       = absint( Val::int( $request->get_param( 'id' ) ) );
 		$existing = $this->questions->findById( $id );
 
 		if ( null === $existing ) {
@@ -107,18 +113,18 @@ class QuestionEndpoint {
 			return $ownerCheck;
 		}
 
-		$fieldType = $request->has_param( 'field_type' ) ? (string) $request->get_param( 'field_type' ) : $existing->fieldType;
+		$fieldType = $request->has_param( 'field_type' ) ? Val::string( $request->get_param( 'field_type' ) ) : $existing->fieldType;
 		if ( ! in_array( $fieldType, Question::VALID_FIELD_TYPES, true ) ) {
 			return $this->invalid( __( 'Invalid field type.', 'unsupervised-schedular' ) );
 		}
 
 		$question = new Question(
 			offeringId: $existing->offeringId,
-			label:      $request->has_param( 'label' ) ? sanitize_text_field( (string) $request->get_param( 'label' ) ) : $existing->label,
+			label:      $request->has_param( 'label' ) ? sanitize_text_field( Val::string( $request->get_param( 'label' ) ) ) : $existing->label,
 			fieldType:  $fieldType,
 			options:    $request->has_param( 'options' ) ? $this->sanitizeOptions( $request->get_param( 'options' ) ) : $existing->options,
 			isRequired: $request->has_param( 'is_required' ) ? (bool) $request->get_param( 'is_required' ) : $existing->isRequired,
-			sortOrder:  $request->has_param( 'sort_order' ) ? (int) $request->get_param( 'sort_order' ) : $existing->sortOrder,
+			sortOrder:  $request->has_param( 'sort_order' ) ? Val::int( $request->get_param( 'sort_order' ) ) : $existing->sortOrder,
 			isActive:   $request->has_param( 'is_active' ) ? (bool) $request->get_param( 'is_active' ) : $existing->isActive,
 			id:         $id,
 		);
@@ -129,7 +135,7 @@ class QuestionEndpoint {
 	}
 
 	public function delete( \WP_REST_Request $request ): \WP_REST_Response|\WP_Error {
-		$id       = absint( $request->get_param( 'id' ) );
+		$id       = absint( Val::int( $request->get_param( 'id' ) ) );
 		$existing = $this->questions->findById( $id );
 
 		if ( null === $existing ) {
@@ -192,7 +198,7 @@ class QuestionEndpoint {
 		$options = array_values(
 			array_filter(
 				array_map(
-					static fn( $option ): string => sanitize_text_field( (string) $option ),
+					static fn( mixed $option ): string => sanitize_text_field( Val::string( $option ) ),
 					$value
 				)
 			)

src/Registration/QuestionRepository.php

@@ -54,8 +54,8 @@ class QuestionRepository {
 	 * @return list<Question>
 	 */
 	public function findByOffering( int $offeringId, bool $activeOnly = false ): array {
-		$sql    = "SELECT * FROM {$this->table} WHERE offering_id = %d";
-		$params = [ $offeringId ];
+		$sql    = 'SELECT * FROM %i WHERE offering_id = %d';
+		$params = [ $this->table, $offeringId ];
 
 		if ( $activeOnly ) {
 			$sql     .= ' AND is_active = %d';
@@ -71,7 +71,7 @@ class QuestionRepository {
 
 	public function findById( int $id ): ?Question {
 		$row = $this->db->get_row(
-			$this->db->prepare( "SELECT * FROM {$this->table} WHERE id = %d", $id )
+			$this->db->prepare( 'SELECT * FROM %i WHERE id = %d', $this->table, $id )
 		);
 
 		return $row ? Question::fromRow( $row ) : null;