Upgrade PHPStan to 2.x and raise analysis level from 6 to 10
CI / No Debug Code (pull_request) Successful in 3s
CI / Tests (PHP 8.2) (pull_request) Successful in 48s
CI / Tests (PHP 8.3) (pull_request) Successful in 52s
CI / Coding Standards (pull_request) Successful in 57s
CI / Tests (PHP 8.1) (pull_request) Successful in 1m1s
CI / PHPStan (pull_request) Successful in 1m11s
CI / Build Plugin Zip (pull_request) Has been skipped
CI / No Debug Code (pull_request) Successful in 3s
CI / Tests (PHP 8.2) (pull_request) Successful in 48s
CI / Tests (PHP 8.3) (pull_request) Successful in 52s
CI / Coding Standards (pull_request) Successful in 57s
CI / Tests (PHP 8.1) (pull_request) Successful in 1m1s
CI / PHPStan (pull_request) Successful in 1m11s
CI / Build Plugin Zip (pull_request) Has been skipped
- Bump phpstan/phpstan ^2.0 and szepeviktor/phpstan-wordpress ^2.0 - Move the analysis level into phpstan.neon (single source) and raise it to 10 - Add Val, a runtime coercion helper that narrows untyped WordPress boundary values (wpdb rows, REST params, superglobals, options) with explicit checks instead of blind casts, plus unit tests - Type value-object fromRow() params as stdClass (what wpdb returns) and map columns through Val so unexpected shapes degrade safely - Use %i identifier placeholders for table names in all wpdb::prepare() calls so every query string is a literal and identifiers are escaped by WordPress; raises the minimum WordPress version to 6.2 where %i was introduced - Guard wpdb::prepare() null result before wpdb::query() in updateTax() - Fix nullable get_permalink()/strtotime() handling, list types at REST and capability call sites, dead null-coalescing on checked superglobals, and narrow get_users() results before mapping - Register Val method names with the ValidatedSanitizedInput sniff so it validates the real sanitizer around each superglobal read - Update repository unit tests for the %i placeholder arguments Co-Authored-By: Claude Fable 5 <[email protected]>
This commit is contained in:
+19
-17
@@ -3,6 +3,8 @@ declare(strict_types=1);
|
||||
|
||||
namespace Unsupervised\Schedular\Offering;
|
||||
|
||||
use Unsupervised\Schedular\Val;
|
||||
|
||||
class Offering {
|
||||
|
||||
public const KIND_PRIVATE_LESSON = 'private_lesson';
|
||||
@@ -44,24 +46,24 @@ class Offering {
|
||||
public readonly ?int $id = null,
|
||||
) {}
|
||||
|
||||
public static function fromRow( object $row ): self {
|
||||
public static function fromRow( \stdClass $row ): self {
|
||||
return new self(
|
||||
instructorId: (int) $row->instructor_id,
|
||||
kind: $row->kind,
|
||||
title: $row->title,
|
||||
price: (float) $row->price,
|
||||
currency: $row->currency,
|
||||
billingMode: $row->billing_mode,
|
||||
description: $row->description,
|
||||
durationMinutes: null !== $row->duration_minutes ? (int) $row->duration_minutes : null,
|
||||
allowWeekly: (bool) $row->allow_weekly,
|
||||
capacity: null !== $row->capacity ? (int) $row->capacity : null,
|
||||
termStart: $row->term_start,
|
||||
termEnd: $row->term_end,
|
||||
scheduleNote: $row->schedule_note,
|
||||
etransferEmail: $row->etransfer_email,
|
||||
isActive: (bool) $row->is_active,
|
||||
id: (int) $row->id,
|
||||
instructorId: Val::int( $row->instructor_id ),
|
||||
kind: Val::string( $row->kind ),
|
||||
title: Val::string( $row->title ),
|
||||
price: Val::float( $row->price ),
|
||||
currency: Val::string( $row->currency ),
|
||||
billingMode: Val::string( $row->billing_mode ),
|
||||
description: Val::stringOrNull( $row->description ),
|
||||
durationMinutes: Val::intOrNull( $row->duration_minutes ),
|
||||
allowWeekly: Val::bool( $row->allow_weekly ),
|
||||
capacity: Val::intOrNull( $row->capacity ),
|
||||
termStart: Val::stringOrNull( $row->term_start ),
|
||||
termEnd: Val::stringOrNull( $row->term_end ),
|
||||
scheduleNote: Val::stringOrNull( $row->schedule_note ),
|
||||
etransferEmail: Val::stringOrNull( $row->etransfer_email ),
|
||||
isActive: Val::bool( $row->is_active ),
|
||||
id: Val::int( $row->id ),
|
||||
);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user