Upgrade PHPStan to 2.x and raise analysis level from 6 to 10

- Bump phpstan/phpstan ^2.0 and szepeviktor/phpstan-wordpress ^2.0
- Move the analysis level into phpstan.neon (single source) and raise it to 10
- Add Val, a runtime coercion helper that narrows untyped WordPress boundary
  values (wpdb rows, REST params, superglobals, options) with explicit checks
  instead of blind casts, plus unit tests
- Type value-object fromRow() params as stdClass (what wpdb returns) and map
  columns through Val so unexpected shapes degrade safely
- Use %i identifier placeholders for table names in all wpdb::prepare() calls
  so every query string is a literal and identifiers are escaped by WordPress;
  raises the minimum WordPress version to 6.2 where %i was introduced
- Guard wpdb::prepare() null result before wpdb::query() in updateTax()
- Fix nullable get_permalink()/strtotime() handling, list types at REST and
  capability call sites, dead null-coalescing on checked superglobals, and
  narrow get_users() results before mapping
- Register Val method names with the ValidatedSanitizedInput sniff so it
  validates the real sanitizer around each superglobal read
- Update repository unit tests for the %i placeholder arguments

Co-Authored-By: Claude Fable 5 <[email protected]>

src/Offering/Offering.php

@@ -3,6 +3,8 @@ declare(strict_types=1);
 
 namespace Unsupervised\Schedular\Offering;
 
+use Unsupervised\Schedular\Val;
+
 class Offering {
 
 	public const KIND_PRIVATE_LESSON = 'private_lesson';
@@ -44,24 +46,24 @@ class Offering {
 		public readonly ?int $id = null,
 	) {}
 
-	public static function fromRow( object $row ): self {
+	public static function fromRow( \stdClass $row ): self {
 		return new self(
-			instructorId:    (int) $row->instructor_id,
-			kind:            $row->kind,
-			title:           $row->title,
-			price:           (float) $row->price,
-			currency:        $row->currency,
-			billingMode:     $row->billing_mode,
-			description:     $row->description,
-			durationMinutes: null !== $row->duration_minutes ? (int) $row->duration_minutes : null,
-			allowWeekly:     (bool) $row->allow_weekly,
-			capacity:        null !== $row->capacity ? (int) $row->capacity : null,
-			termStart:       $row->term_start,
-			termEnd:         $row->term_end,
-			scheduleNote:    $row->schedule_note,
-			etransferEmail:  $row->etransfer_email,
-			isActive:        (bool) $row->is_active,
-			id:              (int) $row->id,
+			instructorId:    Val::int( $row->instructor_id ),
+			kind:            Val::string( $row->kind ),
+			title:           Val::string( $row->title ),
+			price:           Val::float( $row->price ),
+			currency:        Val::string( $row->currency ),
+			billingMode:     Val::string( $row->billing_mode ),
+			description:     Val::stringOrNull( $row->description ),
+			durationMinutes: Val::intOrNull( $row->duration_minutes ),
+			allowWeekly:     Val::bool( $row->allow_weekly ),
+			capacity:        Val::intOrNull( $row->capacity ),
+			termStart:       Val::stringOrNull( $row->term_start ),
+			termEnd:         Val::stringOrNull( $row->term_end ),
+			scheduleNote:    Val::stringOrNull( $row->schedule_note ),
+			etransferEmail:  Val::stringOrNull( $row->etransfer_email ),
+			isActive:        Val::bool( $row->is_active ),
+			id:              Val::int( $row->id ),
 		);
 	}
 

src/Offering/OfferingController.php

@@ -4,6 +4,7 @@ declare(strict_types=1);
 namespace Unsupervised\Schedular\Offering;
 
 use Unsupervised\Schedular\Auth\RoleManager;
+use Unsupervised\Schedular\Val;
 
 class OfferingController {
 
@@ -31,14 +32,14 @@ class OfferingController {
 	private function handleFormAction( int $instructorId, bool $manageAll ): void {
 		// Nonce is verified by the caller (renderPage) before this method runs.
 		// phpcs:disable WordPress.Security.NonceVerification.Missing
-		$action = sanitize_key( wp_unslash( $_POST['usc_action'] ?? '' ) );
+		$action = sanitize_key( Val::string( wp_unslash( $_POST['usc_action'] ?? '' ) ) );
 
 		if ( 'add' === $action ) {
 			$this->addOffering( $instructorId );
 		}
 
 		if ( 'delete' === $action ) {
-			$offeringId = absint( $_POST['offering_id'] ?? 0 );
+			$offeringId = absint( Val::int( $_POST['offering_id'] ?? 0 ) );
 			if ( $offeringId > 0 ) {
 				$offering = $this->repository->findById( $offeringId );
 				if ( $offering && ( $manageAll || $offering->instructorId === $instructorId ) ) {
@@ -51,33 +52,33 @@ class OfferingController {
 
 	private function addOffering( int $instructorId ): void {
 		// phpcs:disable WordPress.Security.NonceVerification.Missing
-		$title = sanitize_text_field( wp_unslash( $_POST['title'] ?? '' ) );
-		$kind  = sanitize_key( wp_unslash( $_POST['kind'] ?? '' ) );
+		$title = sanitize_text_field( Val::string( wp_unslash( $_POST['title'] ?? '' ) ) );
+		$kind  = sanitize_key( Val::string( wp_unslash( $_POST['kind'] ?? '' ) ) );
 
 		if ( '' === $title || ! in_array( $kind, Offering::VALID_KINDS, true ) ) {
 			return;
 		}
 
-		$billingMode = sanitize_key( wp_unslash( $_POST['billing_mode'] ?? Offering::BILLING_ONE_TIME ) );
+		$billingMode = sanitize_key( Val::string( wp_unslash( $_POST['billing_mode'] ?? Offering::BILLING_ONE_TIME ) ) );
 		if ( ! in_array( $billingMode, Offering::VALID_BILLING_MODES, true ) ) {
 			$billingMode = Offering::BILLING_ONE_TIME;
 		}
 
-		$duration = absint( $_POST['duration_minutes'] ?? 0 );
-		$capacity = absint( $_POST['capacity'] ?? 0 );
+		$duration = absint( Val::int( $_POST['duration_minutes'] ?? 0 ) );
+		$capacity = absint( Val::int( $_POST['capacity'] ?? 0 ) );
 
 		$this->repository->insert(
 			new Offering(
 				instructorId:    $instructorId,
 				kind:            $kind,
 				title:           $title,
-				price:           max( 0.0, (float) sanitize_text_field( wp_unslash( $_POST['price'] ?? '0' ) ) ),
+				price:           max( 0.0, (float) sanitize_text_field( Val::string( wp_unslash( $_POST['price'] ?? '0' ) ) ) ),
 				billingMode:     $billingMode,
 				durationMinutes: $duration > 0 ? $duration : null,
 				allowWeekly:     isset( $_POST['allow_weekly'] ),
 				capacity:        $capacity > 0 ? $capacity : null,
-				scheduleNote:    $this->nullableText( sanitize_text_field( wp_unslash( $_POST['schedule_note'] ?? '' ) ) ),
-				etransferEmail:  $this->nullableText( sanitize_email( wp_unslash( $_POST['etransfer_email'] ?? '' ) ) ),
+				scheduleNote:    $this->nullableText( sanitize_text_field( Val::string( wp_unslash( $_POST['schedule_note'] ?? '' ) ) ) ),
+				etransferEmail:  $this->nullableText( sanitize_email( Val::string( wp_unslash( $_POST['etransfer_email'] ?? '' ) ) ) ),
 			)
 		);
 		// phpcs:enable WordPress.Security.NonceVerification.Missing

src/Offering/OfferingEndpoint.php

@@ -4,11 +4,17 @@ declare(strict_types=1);
 namespace Unsupervised\Schedular\Offering;
 
 use Unsupervised\Schedular\Auth\RoleManager;
+use Unsupervised\Schedular\Val;
 
 class OfferingEndpoint {
 
 	public function __construct( private OfferingRepository $repository ) {}
 
+	/**
+	 * Registers this endpoint's REST routes.
+	 *
+	 * @param non-falsy-string $route_namespace REST namespace the routes are registered under (e.g. `us-scheduler/v1`).
+	 */
 	public function registerRoutes( string $route_namespace ): void {
 		register_rest_route(
 			$route_namespace,
@@ -57,8 +63,8 @@ class OfferingEndpoint {
 
 	public function index( \WP_REST_Request $request ): \WP_REST_Response {
 		$offerings = $this->repository->findAll(
-			(int) $request->get_param( 'instructor_id' ),
-			(string) $request->get_param( 'kind' ),
+			Val::int( $request->get_param( 'instructor_id' ) ),
+			Val::string( $request->get_param( 'kind' ) ),
 			activeOnly: true,
 		);
 
@@ -67,17 +73,17 @@ class OfferingEndpoint {
 	}
 
 	public function create( \WP_REST_Request $request ): \WP_REST_Response|\WP_Error {
-		$title = sanitize_text_field( (string) $request->get_param( 'title' ) );
+		$title = sanitize_text_field( Val::string( $request->get_param( 'title' ) ) );
 		if ( '' === $title ) {
 			return $this->invalid( __( 'A title is required.', 'unsupervised-schedular' ) );
 		}
 
-		$kind = (string) $request->get_param( 'kind' );
+		$kind = Val::string( $request->get_param( 'kind' ) );
 		if ( ! in_array( $kind, Offering::VALID_KINDS, true ) ) {
 			return $this->invalid( __( 'Invalid offering kind.', 'unsupervised-schedular' ) );
 		}
 
-		$billingMode = (string) ( $request->get_param( 'billing_mode' ) ?? Offering::BILLING_ONE_TIME );
+		$billingMode = Val::string( $request->get_param( 'billing_mode' ) ?? Offering::BILLING_ONE_TIME );
 		if ( ! in_array( $billingMode, Offering::VALID_BILLING_MODES, true ) ) {
 			return $this->invalid( __( 'Invalid billing mode.', 'unsupervised-schedular' ) );
 		}
@@ -87,7 +93,7 @@ class OfferingEndpoint {
 			kind:            $kind,
 			title:           $title,
 			price:           $this->price( $request->get_param( 'price' ) ),
-			currency:        sanitize_text_field( (string) ( $request->get_param( 'currency' ) ?? 'CAD' ) ),
+			currency:        sanitize_text_field( Val::string( $request->get_param( 'currency' ) ?? 'CAD' ) ),
 			billingMode:     $billingMode,
 			description:     $this->nullableText( $request->get_param( 'description' ) ),
 			durationMinutes: $this->nullableInt( $request->get_param( 'duration_minutes' ) ),
@@ -106,7 +112,7 @@ class OfferingEndpoint {
 	}
 
 	public function update( \WP_REST_Request $request ): \WP_REST_Response|\WP_Error {
-		$id       = absint( $request->get_param( 'id' ) );
+		$id       = absint( Val::int( $request->get_param( 'id' ) ) );
 		$existing = $this->repository->findById( $id );
 
 		if ( null === $existing ) {
@@ -117,12 +123,12 @@ class OfferingEndpoint {
 			return new \WP_Error( 'forbidden', __( 'You cannot edit this offering.', 'unsupervised-schedular' ), [ 'status' => 403 ] );
 		}
 
-		$kind = $request->has_param( 'kind' ) ? (string) $request->get_param( 'kind' ) : $existing->kind;
+		$kind = $request->has_param( 'kind' ) ? Val::string( $request->get_param( 'kind' ) ) : $existing->kind;
 		if ( ! in_array( $kind, Offering::VALID_KINDS, true ) ) {
 			return $this->invalid( __( 'Invalid offering kind.', 'unsupervised-schedular' ) );
 		}
 
-		$billingMode = $request->has_param( 'billing_mode' ) ? (string) $request->get_param( 'billing_mode' ) : $existing->billingMode;
+		$billingMode = $request->has_param( 'billing_mode' ) ? Val::string( $request->get_param( 'billing_mode' ) ) : $existing->billingMode;
 		if ( ! in_array( $billingMode, Offering::VALID_BILLING_MODES, true ) ) {
 			return $this->invalid( __( 'Invalid billing mode.', 'unsupervised-schedular' ) );
 		}
@@ -130,9 +136,9 @@ class OfferingEndpoint {
 		$offering = new Offering(
 			instructorId:    $existing->instructorId,
 			kind:            $kind,
-			title:           $request->has_param( 'title' ) ? sanitize_text_field( (string) $request->get_param( 'title' ) ) : $existing->title,
+			title:           $request->has_param( 'title' ) ? sanitize_text_field( Val::string( $request->get_param( 'title' ) ) ) : $existing->title,
 			price:           $request->has_param( 'price' ) ? $this->price( $request->get_param( 'price' ) ) : $existing->price,
-			currency:        $request->has_param( 'currency' ) ? sanitize_text_field( (string) $request->get_param( 'currency' ) ) : $existing->currency,
+			currency:        $request->has_param( 'currency' ) ? sanitize_text_field( Val::string( $request->get_param( 'currency' ) ) ) : $existing->currency,
 			billingMode:     $billingMode,
 			description:     $request->has_param( 'description' ) ? $this->nullableText( $request->get_param( 'description' ) ) : $existing->description,
 			durationMinutes: $request->has_param( 'duration_minutes' ) ? $this->nullableInt( $request->get_param( 'duration_minutes' ) ) : $existing->durationMinutes,
@@ -152,7 +158,7 @@ class OfferingEndpoint {
 	}
 
 	public function delete( \WP_REST_Request $request ): \WP_REST_Response|\WP_Error {
-		$id       = absint( $request->get_param( 'id' ) );
+		$id       = absint( Val::int( $request->get_param( 'id' ) ) );
 		$existing = $this->repository->findById( $id );
 
 		if ( null === $existing ) {
@@ -195,17 +201,17 @@ class OfferingEndpoint {
 	}
 
 	private function price( mixed $value ): float {
-		return max( 0.0, (float) $value );
+		return max( 0.0, Val::float( $value ) );
 	}
 
 	private function nullableEmail( mixed $value ): ?string {
-		$email = sanitize_email( (string) $value );
+		$email = sanitize_email( Val::string( $value ) );
 
 		return '' !== $email ? $email : null;
 	}
 
 	private function nullableInt( mixed $value ): ?int {
-		return ( null === $value || '' === $value ) ? null : (int) $value;
+		return ( null === $value || '' === $value ) ? null : Val::int( $value );
 	}
 
 	private function nullableText( mixed $value ): ?string {
@@ -213,6 +219,6 @@ class OfferingEndpoint {
 			return null;
 		}
 
-		return sanitize_text_field( (string) $value );
+		return sanitize_text_field( Val::string( $value ) );
 	}
 }

src/Offering/OfferingRepository.php

@@ -90,18 +90,18 @@ class OfferingRepository {
 		}
 
 		$whereClause = implode( ' AND ', $where );
-		$sql         = "SELECT * FROM {$this->table} WHERE {$whereClause} ORDER BY title ASC";
+		$sql         = "SELECT * FROM %i WHERE {$whereClause} ORDER BY title ASC";
 
-		$rows = $params
-			? $this->db->get_results( $this->db->prepare( $sql, $params ) )
-			: $this->db->get_results( $sql );
+		$rows = $this->db->get_results(
+			$this->db->prepare( $sql, array_merge( [ $this->table ], $params ) )
+		);
 
 		return array_map( Offering::fromRow( ... ), $rows ?? [] );
 	}
 
 	public function findById( int $id ): ?Offering {
 		$row = $this->db->get_row(
-			$this->db->prepare( "SELECT * FROM {$this->table} WHERE id = %d", $id )
+			$this->db->prepare( 'SELECT * FROM %i WHERE id = %d', $this->table, $id )
 		);
 
 		return $row ? Offering::fromRow( $row ) : null;