Unsupervised/unsupervised-scheduler
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 12 Wiki Activity

Accept whole days only for the studio cancellation cutoff
CI / Tests (PHP 8.2) (pull_request) Successful in 38s
Details
CI / Tests (PHP 8.1) (pull_request) Successful in 49s
Details
CI / No Debug Code (pull_request) Successful in 2s
Details
CI / PHPStan (pull_request) Successful in 2m54s
Details
CI / Coding Standards (pull_request) Successful in 3m2s
Details
CI / Tests (PHP 8.3) (pull_request) Successful in 2m40s
Details
CI / Build Plugin Zip (pull_request) Skipped
Details

Browse Source 
The Studio Settings cutoff field now takes an integer number of days (step 1,
coerced with Val::int) instead of allowing half-day fractions, and displays the
stored hours rounded to whole days.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
This commit is contained in:
thatguygriff
2026-07-23 12:10:55 -03:00
co-authored by Claude Opus 4.8
parent 8b90b8d78d
commit 169f7b6a13
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Payment/StudioSettings.php
+6 -6
View File
@@ -134,8 +134,8 @@ class StudioSettings {
$hstRate = $this->hstRate();
$stripeConfigured = $this->isStripeConfigured();
$openRegistration = $this->openRegistrationEnabled();
// Stored in hours, surfaced to the admin in days.
$cancellationCutoffDays = $this->cancellationCutoffHours() / 24;
// Stored in hours, surfaced to the admin in whole days.
$cancellationCutoffDays = (int) round( $this->cancellationCutoffHours() / 24 );
include USC_PLUGIN_DIR . 'templates/admin/settings.php';
}
@@ -162,10 +162,10 @@ class StudioSettings {
$hstRate = isset( $_POST['hst_rate'] ) ? Val::float( $_POST['hst_rate'] ) : 0.0;
update_option( self::OPT_HST_RATE, max( 0.0, $hstRate ) );
// The cutoff is entered in days but stored in hours.
// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- Val::float() coerces to float; slashes cannot survive numeric coercion.
$cutoffDays = isset( $_POST['cancellation_cutoff_days'] ) ? max( 0.0, Val::float( $_POST['cancellation_cutoff_days'] ) ) : 0.0;
update_option( self::OPT_CANCELLATION_CUTOFF_HOURS, (int) round( $cutoffDays * 24 ) );
// The cutoff is entered in whole days but stored in hours.
// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- Val::int() coerces to int; slashes cannot survive numeric coercion.
$cutoffDays = isset( $_POST['cancellation_cutoff_days'] ) ? max( 0, Val::int( $_POST['cancellation_cutoff_days'] ) ) : 0;
update_option( self::OPT_CANCELLATION_CUTOFF_HOURS, $cutoffDays * 24 );
$this->applyRegistrationMode( isset( $_POST['open_registration'] ) );
// phpcs:enable WordPress.Security.NonceVerification.Missing
templates/admin/settings.php
+2 -2
View File
@@ -16,7 +16,7 @@ if (! defined('ABSPATH')) {
* @var float $hstRate
* @var bool $stripeConfigured
* @var bool $openRegistration
* @var float $cancellationCutoffDays
* @var int $cancellationCutoffDays
*/
?>
<div class="wrap">
@@ -96,7 +96,7 @@ if (! defined('ABSPATH')) {
<tr>
<th><label for="cancellation_cutoff_days"><?php esc_html_e('Cancellation cutoff (days)', 'unsupervised-schedular'); ?></label></th>
<td>
<input type="number" name="cancellation_cutoff_days" id="cancellation_cutoff_days" class="small-text" min="0" step="0.5" value="<?php echo esc_attr(rtrim(rtrim(number_format($cancellationCutoffDays, 2, '.', ''), '0'), '.')); ?>">
<input type="number" name="cancellation_cutoff_days" id="cancellation_cutoff_days" class="small-text" min="0" step="1" value="<?php echo esc_attr((string) $cancellationCutoffDays); ?>">
<p class="description"><?php esc_html_e('How far ahead of a lesson a student may still cancel it. Within this window only an instructor can cancel. 0 lets students cancel any time. An offering can override this with its own value.', 'unsupervised-schedular'); ?></p>
</td>
</tr>