Unsupervised/unsupervised-scheduler
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 12 Wiki Activity

Fix main: two signup fixtures use a now-rejected password
CI / Tests (PHP 8.2) (pull_request) Successful in 52s
Details
CI / No Debug Code (pull_request) Successful in 2s
Details
CI / PHPStan (pull_request) Successful in 2m46s
Details
CI / Tests (PHP 8.1) (pull_request) Successful in 54s
Details
CI / Coding Standards (pull_request) Successful in 3m6s
Details
CI / Tests (PHP 8.3) (pull_request) Successful in 2m49s
Details
CI / Build Plugin Zip (pull_request) Skipped
Details

Browse Source 
#154 and #155 each passed on their own branch and broke on landing
together. #154 added two guardian-signup tests using 'password123' as
their fixture; #155 then added PasswordPolicy, which rejects exactly
that. Neither branch ever saw the other's change, because #155 was cut
from main before #154 merged.

Both tests now use the same policy-clearing fixture as the rest of the
file. The deliberate 'password123' in the rejected-passwords provider
stays — that one is the point.

Co-Authored-By: Claude Opus 5 <[email protected]>
This commit is contained in:
thatguygriff
2026-07-29 22:40:51 -03:00
co-authored by Claude Opus 5
parent d554e35d80
commit 04cba9702c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Auth/RegistrationPageTest.php
+2 -2
View File
@@ -738,7 +738,7 @@ class RegistrationPageTest extends TestCase
public function testGuardianSignupRejectsAHalfFilledChildRatherThanDroppingIt(): void public function testGuardianSignupRejectsAHalfFilledChildRatherThanDroppingIt(): void
{ {
$_POST = [ $_POST = [
'password' => 'password123', 'password' => 'thistle-marrow-42',
'display_name' => 'Grace', 'display_name' => 'Grace',
'us_is_guardian' => '1', 'us_is_guardian' => '1',
'children' => [ 'children' => [
@@ -764,7 +764,7 @@ class RegistrationPageTest extends TestCase
public function testGuardianSignupRejectsAChildWithoutAUsableBirthYear(string $submitted): void public function testGuardianSignupRejectsAChildWithoutAUsableBirthYear(string $submitted): void
{ {
$_POST = [ $_POST = [
'password' => 'password123', 'password' => 'thistle-marrow-42',
'display_name' => 'Grace', 'display_name' => 'Grace',
'us_is_guardian' => '1', 'us_is_guardian' => '1',
'children' => [['name' => 'Ada', 'birth_year' => $submitted, 'answers' => []]], 'children' => [['name' => 'Ada', 'birth_year' => $submitted, 'answers' => []]],