thatguygriffandClaude Opus 5
abf8ec317c
CI / Typecheck, test, build (pull_request) Successful in 28s
The StopTheMadness rules are indiscriminate, which is the point, but they catch the link on the way back out as well: in the browser they are installed in, "Open on <platform>" redirects straight back here. The one button meant to reach the app is the one that cannot. Handing the address to a different browser is the way past it, and the only way to do that from a page is that browser's own URL scheme. `/` gets a picker for which one; the choice lives in that browser's localStorage, because which browsers are installed is a fact about the device and the phone's answer is not the Mac's. The scheme table is its own module so a test can pin it -- every browser spells it differently, and Edge differs between macOS and iOS. Firefox has no scheme on macOS, so it is only offered on iOS, and an unknown or schemeless choice keeps the plain link rather than producing a dead one. The markup still carries the plain https address and the script swaps it afterwards, so nothing changes without JavaScript. Once a browser is chosen the button says which, since a scheme for a browser that is not installed opens nothing and the tap would otherwise be silent. Closes #7 Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01KF5YF3iZVKbezwALap8LYd
48 lines
2.4 KiB
TypeScript
48 lines
2.4 KiB
TypeScript
import assert from 'node:assert/strict';
|
|
import { test } from 'node:test';
|
|
import { browsersFor, detectOs, openUrlFor } from '../public/browsers.js';
|
|
|
|
const URL = 'https://www.instagram.com/p/ABC/?a=1&b=2';
|
|
|
|
test('each browser gets the scheme it actually answers to', () => {
|
|
assert.equal(openUrlFor(URL, 'chrome', 'macos'), 'googlechromes://www.instagram.com/p/ABC/?a=1&b=2');
|
|
assert.equal(openUrlFor(URL, 'chrome', 'ios'), 'googlechromes://www.instagram.com/p/ABC/?a=1&b=2');
|
|
assert.equal(openUrlFor('http://example.com/a', 'chrome', 'ios'), 'googlechrome://example.com/a');
|
|
|
|
// Edge folds the scheme into its own on iOS and prefixes it on macOS.
|
|
assert.equal(openUrlFor(URL, 'edge', 'macos'), `microsoft-edge:${URL}`);
|
|
assert.equal(openUrlFor(URL, 'edge', 'ios'), 'microsoft-edge-https://www.instagram.com/p/ABC/?a=1&b=2');
|
|
|
|
// The parameter form has to be encoded, or the original query string ends
|
|
// up read as the opener's own.
|
|
assert.equal(openUrlFor(URL, 'orion', 'macos'),
|
|
`orion://open-url?url=${encodeURIComponent(URL)}`);
|
|
assert.equal(openUrlFor(URL, 'firefox', 'ios'),
|
|
`firefox://open-url?url=${encodeURIComponent(URL)}`);
|
|
});
|
|
|
|
test('a browser with no scheme on this system keeps the plain link', () => {
|
|
// Firefox on macOS has none, and a dead scheme opens nothing at all --
|
|
// worse than opening in the wrong browser.
|
|
assert.equal(openUrlFor(URL, 'firefox', 'macos'), URL);
|
|
assert.equal(openUrlFor(URL, 'default', 'ios'), URL);
|
|
assert.equal(openUrlFor(URL, 'nonesuch', 'ios'), URL);
|
|
});
|
|
|
|
test('only ordinary web links are rewritten', () => {
|
|
assert.equal(openUrlFor('mailto:[email protected]', 'chrome', 'ios'), 'mailto:[email protected]');
|
|
assert.equal(openUrlFor('/reddit/r/a/comments/b', 'chrome', 'ios'), '/reddit/r/a/comments/b');
|
|
});
|
|
|
|
test('only the browsers reachable on that system are offered', () => {
|
|
assert.deepEqual(browsersFor('macos').map((b) => b.id), ['default', 'chrome', 'edge', 'orion']);
|
|
assert.deepEqual(browsersFor('ios').map((b) => b.id), ['default', 'chrome', 'edge', 'firefox', 'orion']);
|
|
});
|
|
|
|
test('an iPad is told from a Mac by its touch points, not its platform string', () => {
|
|
assert.equal(detectOs({ platform: 'iPhone', maxTouchPoints: 5 }), 'ios');
|
|
assert.equal(detectOs({ platform: 'MacIntel', maxTouchPoints: 5 }), 'ios');
|
|
assert.equal(detectOs({ platform: 'MacIntel', maxTouchPoints: 0 }), 'macos');
|
|
assert.equal(detectOs({}), 'macos');
|
|
});
|