Giphy Support on Reddit #10

New Issue

2026-08-30T18:15:18Z

thatguygriff commented

2026-08-30 18:15:18 +00:00

Reddit comments that include a giphy gif embed as a markdown link, but not a proper href.

![gif](giphy|zUW23b6FmzB5e)

Reddit comments that include a giphy gif embed as a markdown link, but not a proper href. `![gif](giphy|zUW23b6FmzB5e)`

thatguygriff commented

2026-08-31 02:38:31 +00:00

Fixed on giphy-tokens-and-video-posters.

A giphy token now resolves without media_metadata to look it up in — Reddit ships plenty of comments carrying one and no metadata at all, including the zUW23b6FmzB5e in this issue, and with nothing to look it up in the token itself was what the comment showed. Giphy is the one of the three token kinds whose id means something off Reddit, so that one falls back to i.giphy.com/media/<id>/giphy.gif. Emote and upload ids still resolve only through the metadata.

The video sizing was two things. The renderer put only aspect-ratio on the <video>, and a video with no data has a natural size of 300x150 that WebKit sizes from in preference to the ratio — so a portrait video kept a squat landscape box until playback supplied real dimensions. Chromium stretch-fits and gets it right, which is why it only showed on Safari. A video's size before its data arrives is its poster's, so one with no poster now gets an empty SVG of the right shape as a stand-in.

And Reddit's videos with sound had no poster to be sized by at all: fromRedditVideo attached the still from preview.images to the MP4 branch only, so every post with sound showed an empty box where a silent one showed a frame. It goes on both forms now.

Checked against https://www.reddit.com/r/LoveTrash/comments/1vxkehp/growing_your_account — 31 comment gifs, none broken, and the video's own still in place and correctly sized in WebKit.

Fixed on `giphy-tokens-and-video-posters`. A giphy token now resolves without `media_metadata` to look it up in — Reddit ships plenty of comments carrying one and no metadata at all, including the `zUW23b6FmzB5e` in this issue, and with nothing to look it up in the token itself was what the comment showed. Giphy is the one of the three token kinds whose id means something off Reddit, so that one falls back to `i.giphy.com/media/<id>/giphy.gif`. Emote and upload ids still resolve only through the metadata. The video sizing was two things. The renderer put only `aspect-ratio` on the `<video>`, and a video with no data has a natural size of 300x150 that WebKit sizes from in preference to the ratio — so a portrait video kept a squat landscape box until playback supplied real dimensions. Chromium stretch-fits and gets it right, which is why it only showed on Safari. A video's size before its data arrives is its poster's, so one with no poster now gets an empty SVG of the right shape as a stand-in. And Reddit's videos with sound had no poster to be sized by at all: `fromRedditVideo` attached the still from `preview.images` to the MP4 branch only, so every post with sound showed an empty box where a silent one showed a frame. It goes on both forms now. Checked against https://www.reddit.com/r/LoveTrash/comments/1vxkehp/growing_your_account — 31 comment gifs, none broken, and the video's own still in place and correctly sized in WebKit.

thatguygriff closed this issue

2026-08-31 02:38:32 +00:00

thatguygriff reopened this issue

2026-08-31 02:39:57 +00:00

thatguygriff referenced this issue from a commit

2026-08-31 02:40:00 +00:00

Resolve a giphy token with no metadata to look it up in

thatguygriff referenced a pull request that will close this issue

2026-08-31 02:40:20 +00:00

Render giphy tokens, and give a video its shape before it plays #11

thatguygriff closed this issue

2026-08-31 02:41:08 +00:00