Let the "Open on" button choose a browser
CI / Typecheck, test, build (pull_request) Successful in 28s
CI / Typecheck, test, build (pull_request) Successful in 28s
The StopTheMadness rules are indiscriminate, which is the point, but they catch the link on the way back out as well: in the browser they are installed in, "Open on <platform>" redirects straight back here. The one button meant to reach the app is the one that cannot. Handing the address to a different browser is the way past it, and the only way to do that from a page is that browser's own URL scheme. `/` gets a picker for which one; the choice lives in that browser's localStorage, because which browsers are installed is a fact about the device and the phone's answer is not the Mac's. The scheme table is its own module so a test can pin it -- every browser spells it differently, and Edge differs between macOS and iOS. Firefox has no scheme on macOS, so it is only offered on iOS, and an unknown or schemeless choice keeps the plain link rather than producing a dead one. The markup still carries the plain https address and the script swaps it afterwards, so nothing changes without JavaScript. Once a browser is chosen the button says which, since a scheme for a browser that is not installed opens nothing and the tap would otherwise be silent. Closes #7 Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01KF5YF3iZVKbezwALap8LYd
This commit is contained in:
@@ -17,6 +17,10 @@
|
||||
// Source imports carry the real `.ts` specifier so `node --experimental-
|
||||
// strip-types` can run the tree directly for dev, tests and the resolve
|
||||
// CLI. tsc rewrites them to `.js` on the way into dist.
|
||||
// The client-side scheme table is plain JS, because the browser loads it
|
||||
// as-is out of `public`. Its types are inferred so the test can check it.
|
||||
"allowJs": true,
|
||||
|
||||
"allowImportingTsExtensions": true,
|
||||
"rewriteRelativeImportExtensions": true,
|
||||
|
||||
|
||||
Reference in New Issue
Block a user