mirror of
https://github.com/juherr/kill-the-news.git
synced 2026-06-20 22:03:48 +00:00
Julien Herr
ad196f1761
Address five modeling tensions in one pass: - Encapsulation: the Feed aggregate no longer exposes raw config/metadata (a shallow Readonly still leaked mutable arrays). It now offers intention-revealing accessors that return copies, plus toConfigSnapshot/toMetadataSnapshot for the repository and summary() for the global registry. - feeds:list consistency: FeedRepository.save/saveConfig upsert the registry entry from feed.summary(), so services no longer mirror title/description/ expiry by hand (the old add/updateInList footgun is gone). - domain/feed.ts: drop the dead applySenderPolicy, internalise resolveExpiresAt and trimToByteBudget into the aggregate; feed.ts keeps only the shared isExpired predicate used by the read-model routes. - Single edit path: remove editDetails; edit(patch, deps) is the sole config mutation, with a systematic expired guard. Renaming an expired feed now 403s. - FeedId flows through the application and infrastructure signatures; fromTrusted/parse happen once at the edge, .value only at the serialisation boundaries (urls, feed-generator, feed-keys, logs, JSON). 347 tests green, tsc clean, Worker bundle builds. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
15 lines
486 B
TypeScript
15 lines
486 B
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { isExpired } from "./feed";
|
|
|
|
describe("isExpired", () => {
|
|
it("is false when no expiry is set", () => {
|
|
expect(isExpired({ expires_at: undefined }, 1000)).toBe(false);
|
|
});
|
|
|
|
it("is true at or past the expiry instant", () => {
|
|
expect(isExpired({ expires_at: 1000 }, 1000)).toBe(true);
|
|
expect(isExpired({ expires_at: 1000 }, 1001)).toBe(true);
|
|
expect(isExpired({ expires_at: 1000 }, 999)).toBe(false);
|
|
});
|
|
});
|