mirror of
https://github.com/juherr/kill-the-news.git
synced 2026-06-20 22:03:48 +00:00
refactor: introduce domain events for feed side effects (Track E — point 5)
Light "collect + dispatch" variant: the Feed aggregate records FeedEvents (FeedCreated, EmailIngested) on the mutations that have consequences, exposed via pullEvents(). A new application dispatcher (feed-events.applyFeedEvents) maps those events to their side effects — counters (awaited) plus WebSub pings and favicon fetches handed to a BackgroundScheduler. This removes the inline, scattered side effects from the ingest hot path (email-processor) and from createFeedRecord; the aggregate is now the source of truth for "what happened". Side effects with no aggregate mutation (rejected email, feed deletion bypassing the aggregate, bulk admin ops, the cron, unsubscribes-sent) stay imperative by design — there is no aggregate event for them to ride on. BackgroundScheduler type moved to infrastructure/worker.ts (shared). CLAUDE.md updated. 355 tests pass (+4 event tests); tsc --noEmit clean. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -2,6 +2,7 @@ import { FeedConfig, FeedMetadata, EmailMetadata } from "../types";
|
||||
import { FeedId } from "./value-objects/feed-id";
|
||||
import { SenderPolicy, SenderDecision } from "./value-objects/sender-policy";
|
||||
import { Clock, systemClock } from "./clock";
|
||||
import { FeedEvent } from "./events";
|
||||
import { resolveExpiresAt, isExpired, trimToByteBudget } from "./feed";
|
||||
|
||||
export interface CreateFeedInput {
|
||||
@@ -65,6 +66,8 @@ export interface IngestOptions {
|
||||
* concurrent writers (see email-processor.ts).
|
||||
*/
|
||||
export class Feed {
|
||||
private readonly _events: FeedEvent[] = [];
|
||||
|
||||
private constructor(
|
||||
readonly id: FeedId,
|
||||
private _config: FeedConfig,
|
||||
@@ -91,7 +94,9 @@ export class Feed {
|
||||
updated_at: now,
|
||||
...(expiresAt !== undefined ? { expires_at: expiresAt } : {}),
|
||||
};
|
||||
return new Feed(id, config, { emails: [] }, clock);
|
||||
const feed = new Feed(id, config, { emails: [] }, clock);
|
||||
feed._events.push({ type: "FeedCreated" });
|
||||
return feed;
|
||||
}
|
||||
|
||||
/** Rebuild an aggregate from persisted state. */
|
||||
@@ -112,6 +117,16 @@ export class Feed {
|
||||
return this._metadata;
|
||||
}
|
||||
|
||||
/**
|
||||
* Drain the domain events recorded since the last pull. The application layer
|
||||
* calls this after persisting and feeds them to a dispatcher that runs the
|
||||
* side effects (counters, WebSub, favicon). Clearing on read keeps a long-lived
|
||||
* aggregate from re-emitting.
|
||||
*/
|
||||
pullEvents(): FeedEvent[] {
|
||||
return this._events.splice(0, this._events.length);
|
||||
}
|
||||
|
||||
isExpired(now: number = this.clock.now()): boolean {
|
||||
return isExpired(this._config, now);
|
||||
}
|
||||
@@ -145,6 +160,7 @@ export class Feed {
|
||||
};
|
||||
}
|
||||
|
||||
this._events.push({ type: "EmailIngested", iconDomain: opts.iconDomain });
|
||||
return trimToByteBudget(this._metadata, opts.maxBytes);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user