mirror of
https://github.com/juherr/kill-the-news.git
synced 2026-06-20 22:03:48 +00:00
refactor: tighten DDD boundaries on the Feed aggregate
Address five modeling tensions in one pass: - Encapsulation: the Feed aggregate no longer exposes raw config/metadata (a shallow Readonly still leaked mutable arrays). It now offers intention-revealing accessors that return copies, plus toConfigSnapshot/toMetadataSnapshot for the repository and summary() for the global registry. - feeds:list consistency: FeedRepository.save/saveConfig upsert the registry entry from feed.summary(), so services no longer mirror title/description/ expiry by hand (the old add/updateInList footgun is gone). - domain/feed.ts: drop the dead applySenderPolicy, internalise resolveExpiresAt and trimToByteBudget into the aggregate; feed.ts keeps only the shared isExpired predicate used by the read-model routes. - Single edit path: remove editDetails; edit(patch, deps) is the sole config mutation, with a systematic expired guard. Renaming an expired feed now 403s. - FeedId flows through the application and infrastructure signatures; fromTrusted/parse happen once at the edge, .value only at the serialisation boundaries (urls, feed-generator, feed-keys, logs, JSON). 347 tests green, tsc clean, Worker bundle builds. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
+6
-1
@@ -15,6 +15,7 @@ import { Env } from "./types";
|
||||
import { logger } from "./infrastructure/logger";
|
||||
import { FeedRepository } from "./infrastructure/feed-repository";
|
||||
import { purgeExpiredFeeds } from "./application/feed-cleanup";
|
||||
import { FeedId } from "./domain/value-objects/feed-id";
|
||||
import {
|
||||
bumpCounters,
|
||||
scanR2Usage,
|
||||
@@ -206,7 +207,11 @@ export default {
|
||||
.map((f) => f.id);
|
||||
|
||||
for (const feedId of expiredIds) {
|
||||
await purgeExpiredFeeds(env.EMAIL_STORAGE, feedId, attachmentBucket);
|
||||
await purgeExpiredFeeds(
|
||||
env.EMAIL_STORAGE,
|
||||
FeedId.fromTrusted(feedId),
|
||||
attachmentBucket,
|
||||
);
|
||||
}
|
||||
if (expiredIds.length > 0) {
|
||||
await repo.removeFromListBulk(expiredIds);
|
||||
|
||||
Reference in New Issue
Block a user