GitHub/kill-the-news
1
0
Fork 0
mirror of https://github.com/juherr/kill-the-news.git synced 2026-06-21 06:13:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(domain): split Icon/WebSub/Counters out of FeedRepository

Browse Source 
FeedRepository no longer owns favicons, WebSub subscriber lists or the
monitoring counters singleton. Each concern gets its own repository
(IconRepository, WebSubSubscriptionRepository, CountersRepository),
sharing the key schema via feed-keys. KV key strings are unchanged;
counters increment policy stays in utils/stats.ts.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Julien Herr
2026-05-24 00:27:33 +02:00
parent b347f2f625
commit a31ff42f59
13 changed files with 204 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/domain/feed-repository.test.ts
+1 -44
View File
@@ -1,13 +1,7 @@
import { describe, it, expect } from "vitest";
import { createMockEnv } from "../test/setup";
import { FeedRepository } from "./feed-repository";
import type {
Env,
FeedConfig,
FeedMetadata,
EmailData,
WebSubSubscription,
} from "../types";
import type { Env, FeedConfig, FeedMetadata, EmailData } from "../types";
const mockEnv = () => createMockEnv() as unknown as Env;
@@ -31,7 +25,6 @@ describe("FeedRepository key schema", () => {
it("builds the canonical KV keys via the public API", () => {
const repo = new FeedRepository(mockEnv().EMAIL_STORAGE);
expect(repo.feedKeyPrefix("a.b.42")).toBe("feed:a.b.42:");
expect(repo.iconKey("example.com")).toBe("icon:example.com");
expect(repo.newEmailKey("a.b.42")).toMatch(/^feed:a\.b\.42:\d+$/);
});
@@ -133,39 +126,3 @@ describe("FeedRepository feed list", () => {
expect((await repo.listFeeds()).map((f) => f.id)).toEqual(["c.d.99"]);
});
});
describe("FeedRepository counters, icons, websub", () => {
it("round-trips raw counters", async () => {
const repo = new FeedRepository(mockEnv().EMAIL_STORAGE);
expect(await repo.getCountersRaw()).toBeNull();
await repo.putCounters({
feeds_created: 1,
feeds_deleted: 0,
emails_received: 2,
emails_rejected: 0,
unsubscribes_sent: 0,
});
expect(await repo.getCountersRaw()).toMatchObject({ emails_received: 2 });
});
it("stores and reads favicons as text or json", async () => {
const repo = new FeedRepository(mockEnv().EMAIL_STORAGE);
expect(await repo.getIconText("example.com")).toBeNull();
await repo.putIcon("example.com", JSON.stringify({ data: null }), 60);
expect(await repo.getIconText("example.com")).toBe('{"data":null}');
expect(await repo.getIconJson<{ data: null }>("example.com")).toEqual({
data: null,
});
});
it("round-trips websub subscriptions and counts them", async () => {
const repo = new FeedRepository(mockEnv().EMAIL_STORAGE);
expect(await repo.getSubscriptions("a.b.42")).toEqual([]);
const subs: WebSubSubscription[] = [
{ callbackUrl: "https://r.example/cb", expiresAt: 9999 },
];
await repo.saveSubscriptions("a.b.42", subs);
expect(await repo.getSubscriptions("a.b.42")).toEqual(subs);
expect(await repo.countSubscriptionKeys()).toBe(1);
});
});