mirror of
https://github.com/juherr/kill-the-news.git
synced 2026-06-20 22:03:48 +00:00
feat: decouple read FeedId from inbound MailboxId
Separate the two feed identities so the public read URL never reveals the inbound address and vice-versa: - FeedId becomes an opaque high-entropy token (read id + KV key); MailboxId (noun.noun.NN) owns the inbound address and the untrusted-input boundary via MailboxId.parse. They map only through the inbound:<mailbox> secondary index, resolved solely at reception. - inbound index lifecycle is owned by FeedRepository: written by save/saveConfig, dropped by removeFromList(Bulk) — symmetric, never mirrored by hand (removes the manual delete in feed-service + the cron loop, and a silent empty-catch). - Feed.mailboxId exposes a MailboxId VO (symmetry with Feed.id); the mailbox@domain shape lives on MailboxId.emailAddress(domain). - Distinguish mailbox_unknown (no feed claims the address) from feed_not_found (dangling index) for observability; both forwardable, both 404. - Drop the redundant EmailParser.extractMailbox pass-through so MailboxId.parse is the single parse boundary. Docs (README/INSTALL/CLAUDE.md/landing) and tests updated; 439 tests green, tsc clean, build dry-run OK. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,6 @@
|
||||
import { beforeAll, afterAll, afterEach } from "vitest";
|
||||
import { setupServer } from "msw/node";
|
||||
import { feedKeys } from "../domain/feed-keys";
|
||||
|
||||
// Minimal Node.js built-ins used only in this test setup file.
|
||||
// Declared locally to avoid pulling in the full @types/node package,
|
||||
@@ -263,3 +264,16 @@ export const createMockEnv = (options: { withR2?: boolean } = {}) => ({
|
||||
? { ATTACHMENT_BUCKET: new MockR2() as unknown as R2Bucket }
|
||||
: {}),
|
||||
});
|
||||
|
||||
/**
|
||||
* Seed the `inbound:<mailbox> → <feedId>` index that email reception resolves
|
||||
* through. Defaults the feed id to the mailbox (the common unit-test shape where
|
||||
* a feed is keyed by the same string as its inbound address).
|
||||
*/
|
||||
export async function seedInboundIndex(
|
||||
env: { EMAIL_STORAGE: { put: (k: string, v: string) => Promise<unknown> } },
|
||||
mailboxId: string,
|
||||
feedId: string = mailboxId,
|
||||
): Promise<void> {
|
||||
await env.EMAIL_STORAGE.put(feedKeys.inbound(mailboxId), feedId);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user